[O] [PATCH] tiny fixes in ox-ascii.el [was: Re: Bug: Footnotes break iCalendar export]

2013-04-21 Thread Richard Lawrence

Here is a patch for a couple of tiny issues I encountered in ox-ascii.el
while debugging ox-icalendar.el.  Explanation:

1) There is no function called `org-ascii-footnote-definition' (though
it looks like maybe there once was?), so I changed a reference to it to
`ignore' to be more explicit.

I'm not sure if this is the right thing to do -- maybe the point was to
let the user define such a function if she wishes?  That however would
be inconsistent with the comment that such definitions are ignored (see
below).

2) A tiny change to the comment explaining why there is no such
function: footnote definitions are ignored because they are compiled by
`org-ascii-inner-template', not `org-ascii-template'.

Best,
Richard

diff --git a/lisp/ox-ascii.el b/lisp/ox-ascii.el
index 2191539..4543c34 100644
--- a/lisp/ox-ascii.el
+++ b/lisp/ox-ascii.el
@@ -68,7 +68,7 @@
 (export-block . org-ascii-export-block)
 (export-snippet . org-ascii-export-snippet)
 (fixed-width . org-ascii-fixed-width)
-(footnote-definition . org-ascii-footnote-definition)
+(footnote-definition . ignore)
 (footnote-reference . org-ascii-footnote-reference)
 (headline . org-ascii-headline)
 (horizontal-rule . org-ascii-horizontal-rule)
@@ -1147,7 +1147,7 @@ CONTENTS is nil.  INFO is a plist holding contextual information.
  Footnote Definition
 
 ;; Footnote Definitions are ignored.  They are compiled at the end of
-;; the document, by `org-ascii-template'.
+;; the document, by `org-ascii-inner-template'.
 
 
  Footnote Reference


Re: [O] [PATCH] tiny fixes in ox-ascii.el [was: Re: Bug: Footnotes break iCalendar export]

2013-04-21 Thread Nicolas Goaziou
Richard Lawrence richard.lawre...@berkeley.edu writes:

 Here is a patch for a couple of tiny issues I encountered in ox-ascii.el
 while debugging ox-icalendar.el.  Explanation:

I applied the changes. Thank you.


Regards,

-- 
Nicolas Goaziou