Re: [O] [PATCH 00/10] Takjuggler exporter improvements

2012-08-09 Thread Christian Egli
Hi Yann

Yann Hodique yann.hodi...@gmail.com writes:

 Here are a couple of patches for org-taskjuggler.el

 My main goals with these were to:

  - be able to leverage SCHEDULE/DEADLINE information, so as to be able
to leverage org timelines in complement to the reports

  - be able to #+BIND some of the exporter variables (such as the
preamble)

  - be able to define reports in the org file itself, without having to
mess with a custom variable

 Any feedback is highly welcome.

I have looked at your patches. I have not had time to try them but
reading the diffs it looks excellent. They implement some features which
make the exporter much more flexible.

I have one comment to patch make project umbrella task optional which
I'll adress separately.

Thanks
Christian

-- 
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland




Re: [O] [PATCH 00/10] Takjuggler exporter improvements

2012-08-06 Thread Bastien
CC'ing Christian again with a working email address this time.

Bastien b...@gnu.org writes:

 thanks for this.  I've quickly check by just reading the patches,
 and this looks good.  I copy Christian, hoping he will have time
 to double-check.

-- 
 Bastien



[O] [PATCH 00/10] Takjuggler exporter improvements

2012-08-05 Thread Yann Hodique
Here are a couple of patches for org-taskjuggler.el

My main goals with these were to:

 - be able to leverage SCHEDULE/DEADLINE information, so as to be able
   to leverage org timelines in complement to the reports

 - be able to #+BIND some of the exporter variables (such as the
   preamble)

 - be able to define reports in the org file itself, without having to
   mess with a custom variable

Any feedback is highly welcome.

Thanks,
Yann.


Yann Hodique (10):
  org-taskjuggler: make task and resource properties customizable
  org-taskjuggler: properly install local variables at export time
  org-taskjuggler: make use of org properties
  org-taskjuggler: task with end-only is also a milestone (deadline)
  org-taskjuggler: introduce a global header, for early macros
  org-taskjuggler: use project end date, if specified
  org-taskjuggler: make project umbrella task optional
  org-taskjuggler: disambiguate headline, as it's also a valid
taskjuggler property
  org-taskjuggler: allow reports definition from within the org file
  org-taskjuggler: update doc to reflect latest changes

 doc/org.texi|  48 ++--
 lisp/org-taskjuggler.el | 145 +++-
 2 files changed, 149 insertions(+), 44 deletions(-)

-- 
1.7.11.3




Re: [O] [PATCH 00/10] Takjuggler exporter improvements

2012-08-05 Thread Bastien
Hi Yann,

Yann Hodique yann.hodi...@gmail.com writes:

 Here are a couple of patches for org-taskjuggler.el

thanks for this.  I've quickly check by just reading the patches,
and this looks good.  I copy Christian, hoping he will have time
to double-check.

Did you sign the FSF papers?  

If you didn't, please fill in this form and send it to ass...@fsf.org:

http://orgmode.org/w/?p=org-mode.git;a=blob_plain;f=request-assign-future.txt;hb=HEAD

Also, please reread http://orgmode.org/worg/org-contribute.html#sec-5 
to format the commit messages more appropriately.

Thanks,

-- 
 Bastien



Re: [O] [PATCH 00/10] Takjuggler exporter improvements

2012-08-05 Thread Yann Hodique
 Bastien == Bastien  b...@gnu.org writes:

 Hi Yann,
 Yann Hodique yann.hodi...@gmail.com writes:

 Here are a couple of patches for org-taskjuggler.el

 thanks for this.  I've quickly check by just reading the patches,
 and this looks good.  I copy Christian, hoping he will have time
 to double-check.

 Did you sign the FSF papers?  

Hi Bastien,

Thanks for the quick feedback.

I did sign FSF papers a few years ago, but not sure Emacs was explicitly
in the scope. Anyway, I just sent another form to be sure.

 Also, please reread http://orgmode.org/worg/org-contribute.html#sec-5 
 to format the commit messages more appropriately.

Ok. I'll wait a bit for potential feedback from Christian and rework
the messages.

Thanks,

Yann.

-- 
The surest way to keep a secret is to make
people believe they already know the answer.

  -- Ancient Fremen Wisdom