Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Michael, I fixed this again in maint, please let me know if it's now okay for you. Thanks, -- Bastien
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Bastien On Thu, Mar 20, 2014 at 3:15 PM, Bastien b...@gnu.org wrote: I fixed this again in maint, please let me know if it's now okay for you. Thanks, Yes, also release_8.2.5h-809-g61d still solves my use case with literal links in a table, thank you. I tested only GNU Emacs and can not tell for XEmacs. Michael
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Michael, Michael Brand michael.ch.br...@gmail.com writes: On Sat, Mar 1, 2014 at 12:13 PM, Bastien b...@gnu.org wrote: I see. The following patch fixes it but it's just a quick try, I need to review possible side-effects more carefully. In the meantime, if you can confirm it works for you, that'd help. The patch works, thank you. I'll continue to use it. I've now applied this patch, thanks for testing it so far. -- Bastien
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Michael, Michael Brand michael.ch.br...@gmail.com writes: is a regression for Shift-enter on 1 in the table below when hyperlinks are configured to be literal: | [[http://www.orgmode.org]] | 1 | | | [[http://www.orgmode.org]] | | | | [[http://www.orgmode.org]] | | | You mean when `bracket' is not part of `org-activate-links'? I can reproduce the problem... but it goes away when I instrument `org-move-to-column' for debugging. I'll have to digg deeper -- if you have more information on your side, please share. Thanks, -- Bastien
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Bastien On Sat, Mar 1, 2014 at 10:02 AM, Bastien b...@gnu.org wrote: Michael Brand michael.ch.br...@gmail.com writes: is a regression for Shift-enter on 1 in the table below when hyperlinks are configured to be literal: | [[http://www.orgmode.org]] | 1 | | | [[http://www.orgmode.org]] | | | | [[http://www.orgmode.org]] | | | You mean when `bracket' is not part of `org-activate-links'? I don't know if and how the variable org-activate-links is related. I used the function org-toggle-link-display or the menu to get the state with the variable org-descriptive-links being nil which is for display the full links literally. Michael
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Michael, Michael Brand michael.ch.br...@gmail.com writes: I don't know if and how the variable org-activate-links is related. I used the function org-toggle-link-display or the menu to get the state with the variable org-descriptive-links being nil which is for display the full links literally. I see. The following patch fixes it but it's just a quick try, I need to review possible side-effects more carefully. In the meantime, if you can confirm it works for you, that'd help. Thanks, diff --git a/lisp/org-compat.el b/lisp/org-compat.el index 1553e4f..9837e13 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -344,9 +344,12 @@ Works on both Emacs and XEmacs. (indent-line-to column))) (defun org-move-to-column (column optional force buffer ignore-invisible) - (let ((buffer-invisibility-spec ignore-invisible)) + (let ((buffer-invisibility-spec + (and ignore-invisible + (member '(org-link) buffer-invisibility-spec (if (featurep 'xemacs) - (org-xemacs-without-invisibility (move-to-column column force buffer)) + (org-xemacs-without-invisibility + (move-to-column column force buffer)) (move-to-column column force (defun org-get-x-clipboard-compat (value) -- Bastien
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Bastien On Sat, Mar 1, 2014 at 12:13 PM, Bastien b...@gnu.org wrote: I see. The following patch fixes it but it's just a quick try, I need to review possible side-effects more carefully. In the meantime, if you can confirm it works for you, that'd help. The patch works, thank you. I'll continue to use it. Michael
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Bastien On Thu, Feb 6, 2014 at 9:59 AM, Bastien b...@gnu.org wrote: Jason Lewis ja...@dickson.st writes: when using the Shift-enter feature in a table to copy values down, it fails to place the cursor where you expect it to if the previous column has a fixed width and the contents of the cell is truncated. Fixed in maint, thanks for reporting this! The related commit commit 323c7b3de2211a7d61bf0c71c6f5923b1ea62297 Author: Bastien Guerry b...@altern.org Date: Thu Feb 6 09:58:17 2014 +0100 org-table.el: Fix bugs about cursor repositioning * org-table.el (org-table-copy-down) (org-table-find-dataline, org-table-move-row) (org-table-insert-hline, org-table-kill-row): Use `org-move-to-column' with the IGNORE-INVISIBLE arg set to `t', so that abbreviated rows don't interfer with setting the cursor back at the correct position. Thanks to Jason Lewis for reporting one of these bugs. is a regression for Shift-enter on 1 in the table below when hyperlinks are configured to be literal: | [[http://www.orgmode.org]] | 1 | | | [[http://www.orgmode.org]] | | | | [[http://www.orgmode.org]] | | | Michael
Re: [O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi Jason, Jason Lewis ja...@dickson.st writes: when using the Shift-enter feature in a table to copy values down, it fails to place the cursor where you expect it to if the previous column has a fixed width and the contents of the cell is truncated. Fixed in maint, thanks for reporting this! -- Bastien
[O] Bug: shift-enter in org tables leaves cursor in wrong position [8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/)]
Hi, when using the Shift-enter feature in a table to copy values down, it fails to place the cursor where you expect it to if the previous column has a fixed width and the contents of the cell is truncated. Steps to reproduce: enter the following org table: | | 7 | | |---+-+---| | 4 | podsdfsfsadastatoes | 1 | | 5 | podsdfsfsadastatoes | 2 | | 6 | | | press C-c C-c to ensure the second column is showing abbreviated. place cursor on the number 1, Shift-enter copies values to the next line but leaves the cursor in the wrong position, at the end of the string in the row that starts with 5 if you remove the 7 and repeat the experiment, the cursor moves down the third column as you expect it to. I expect it should work the same whether or not the previous column has truncated contents. Emacs : GNU Emacs 24.3.50.2 (i686-pc-cygwin) of 2014-01-15 on jade Package: Org-mode version 8.2.5h (8.2.5h-6-g8e1386-elpa @ /cygdrive/c/Users/jason/.emacs.d/elpa/org-20140203/) current state: == (setq org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe) org-latex-format-headline-function 'org-latex-format-headline-default-function org-html-format-inlinetask-function 'ignore outline-minor-mode-hook '(mediawiki-outline-magic-keys) org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-refile-targets '((nil :maxlevel . 9) (org-agenda-files :maxlevel . 9)) org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-hide-inline-tasks org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-agenda-before-write-hook '(org-agenda-add-entry-text) org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook) org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default org-babel-pre-tangle-hook '(save-buffer) org-occur-hook '(org-first-headline-recenter) org-html-format-headline-function 'ignore org-metaup-hook '(org-babel-load-in-session-maybe) org-confirm-elisp-link-function 'yes-or-no-p org-default-notes-file ~/Dropbox/org/todo.org org-latex-format-drawer-function '(lambda (name contents) contents) org-blank-before-new-entry nil org-clock-out-hook '(org-clock-remove-empty-clock-drawer) org-mode-hook '(#[nil \300\301\302\303\304$\207 [org-add-hook change-major-mode-hook org-show-block-all append local] 5] #[nil \300\301\302\303\304$\207 [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes (lambda nil (flyspell-mode -1))) org-ascii-format-drawer-function '(lambda (name contents width) contents) org-directory ~/Dropbox/org org-from-is-user-regexp \\jason\\ org-html-format-drawer-function '(lambda (name contents) contents) org-metadown-hook '(org-babel-pop-to-session-maybe) org-agenda-files '(~/Dropbox/org/todo.org ~/Dropbox/org ~/Dropbox/org/todo.org) org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-after-todo-state-change-hook '(org-clock-out-if-current) org-latex-format-inlinetask-function 'ignore org-M-RET-may-split-line '((default)) org-confirm-shell-link-function 'yes-or-no-p ) signature.asc Description: OpenPGP digital signature
