[O] Build error in git HEAD with org-bibtex.el

2011-04-28 Thread Christian Egli
Hi all

When doing a `make update` I get the following compile error:

~/src/org-mode $ make update
git pull
Already up-to-date.
/usr/bin/make clean
make[1]: Entering directory `/home/eglic/src/org-mode'
[snip]
emacs -batch -q -no-site-file -eval (setq load-path (cons (expand-file-name 
\./lisp/\) (cons \/usr/local/share/emacs/site-lisp\ load-path))) -f 
batch-byte-compile lisp/org-bibtex.el

In toplevel form:
lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get' will not 
work - use `labels' instead
make[1]: *** [lisp/org-bibtex.elc] Error 1
make[1]: Leaving directory `/home/eglic/src/org-mode'
make: *** [update] Error 2

This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.22.0) of 
2011-03-04 on yellow, modified by Debian

Thanks
Christian
-- 
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland




Re: [O] Build error in git HEAD with org-bibtex.el

2011-04-28 Thread Matt Lundin
Christian Egli christian.e...@sbs.ch writes:

 Hi all

 When doing a `make update` I get the following compile error:

 ~/src/org-mode $ make update
 git pull
 Already up-to-date.
 /usr/bin/make clean
 make[1]: Entering directory `/home/eglic/src/org-mode'
 [snip]
 emacs -batch -q -no-site-file -eval (setq load-path (cons
 (expand-file-name \./lisp/\) (cons
 \/usr/local/share/emacs/site-lisp\ load-path))) -f
 batch-byte-compile lisp/org-bibtex.el

 In toplevel form:
 lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get'
 will not work - use `labels' instead
 make[1]: *** [lisp/org-bibtex.elc] Error 1
 make[1]: Leaving directory `/home/eglic/src/org-mode'
 make: *** [update] Error 2

 This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version
 2.22.0) of 2011-03-04 on yellow, modified by Debian


And with bleeding edge emacs (compiled from the repos yesterday), I'm
getting an additional error:

In toplevel form:
org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix
org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get' will not work 
- use `labels' instead
make: *** [lisp/org-bibtex.elc] Error 1

Note: the description variable error has nothing to do with the recent
changes to org-bibtex.

Best,
Matt



Re: [O] Build error in git HEAD with org-bibtex.el

2011-04-28 Thread Eric Schulte
Hi Christian,

Thanks for sharing this.  I've just pushed up a fix for the problem you
mentioned below.  That will teach me to push a big change without
consulting the compiler first.

Best -- Eric

Christian Egli christian.e...@sbs.ch writes:

 Hi all

 When doing a `make update` I get the following compile error:

 ~/src/org-mode $ make update
 git pull
 Already up-to-date.
 /usr/bin/make clean
 make[1]: Entering directory `/home/eglic/src/org-mode'
 [snip]
 emacs -batch -q -no-site-file -eval (setq load-path (cons (expand-file-name 
 \./lisp/\) (cons \/usr/local/share/emacs/site-lisp\ load-path))) -f 
 batch-byte-compile lisp/org-bibtex.el

 In toplevel form:
 lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get' will 
 not work - use `labels' instead
 make[1]: *** [lisp/org-bibtex.elc] Error 1
 make[1]: Leaving directory `/home/eglic/src/org-mode'
 make: *** [update] Error 2

 This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.22.0) of 
 2011-03-04 on yellow, modified by Debian

 Thanks
 Christian

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/



Re: [O] Build error in git HEAD with org-bibtex.el

2011-04-28 Thread Eric Schulte
Matt Lundin m...@imapmail.org writes:

 Christian Egli christian.e...@sbs.ch writes:

 Hi all

 When doing a `make update` I get the following compile error:

 ~/src/org-mode $ make update
 git pull
 Already up-to-date.
 /usr/bin/make clean
 make[1]: Entering directory `/home/eglic/src/org-mode'
 [snip]
 emacs -batch -q -no-site-file -eval (setq load-path (cons
 (expand-file-name \./lisp/\) (cons
 \/usr/local/share/emacs/site-lisp\ load-path))) -f
 batch-byte-compile lisp/org-bibtex.el

 In toplevel form:
 lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get'
 will not work - use `labels' instead
 make[1]: *** [lisp/org-bibtex.elc] Error 1
 make[1]: Leaving directory `/home/eglic/src/org-mode'
 make: *** [update] Error 2

 This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version
 2.22.0) of 2011-03-04 on yellow, modified by Debian


 And with bleeding edge emacs (compiled from the repos yesterday), I'm
 getting an additional error:

 In toplevel form:
 org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix
 org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get' will not 
 work - use `labels' instead
 make: *** [lisp/org-bibtex.elc] Error 1

 Note: the description variable error has nothing to do with the recent
 changes to org-bibtex.


Hi Matt,

Yes, the org-mode source is littered with such un-prefixed dynamic
variables, and I'm not sure how this will be addressed.  Personally I
would prefer an option to tell the compiler not to complain, as adding
org- to all of these variable names could make the source harder to
read.  But, that said, I suppose there is a danger of conflict in common
variable names between packages...

Thanks -- Eric


 Best,
 Matt



-- 
Eric Schulte
http://cs.unm.edu/~eschulte/



Re: [O] Build error in git HEAD with org-bibtex.el

2011-04-28 Thread Matt Lundin
Eric Schulte schulte.e...@gmail.com writes:

 Matt Lundin m...@imapmail.org writes:


[...]

 And with bleeding edge emacs (compiled from the repos yesterday), I'm
 getting an additional error:

 In toplevel form:
 org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix
 org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get'
 will not work - use `labels' instead
 make: *** [lisp/org-bibtex.elc] Error 1

 Note: the description variable error has nothing to do with the recent
 changes to org-bibtex.

 Yes, the org-mode source is littered with such un-prefixed dynamic
 variables, and I'm not sure how this will be addressed.  Personally I
 would prefer an option to tell the compiler not to complain, as adding
 org- to all of these variable names could make the source harder to
 read.  But, that said, I suppose there is a danger of conflict in common
 variable names between packages...

Thanks for explaining this. I believe I misspoke when I said it was an
error. I now see it is only a warning.

Best,
Matt