Re: [O] Use (org-entry-properties) in a mode derived from org-mode

2011-09-01 Thread Stefan Reichör
Hello again!

 Hi!

 I'd like to derive a mode from org-mode.

 I do something like this:

 (define-derived-mode derived-org-mode org-mode dorg derived org-mode
   (message derived-org-mode activated)
   )

 When I activate the derived-org-mode, M-: (org-entry-properties) does no 
 longer work.

 Using org-mode it works.

 When I use derived-mode-p in org-mode-p everything works:


 (defsubst org-mode-p ()
   Check if the current buffer is in Org-mode or a derived mode.
   ;;(eq major-mode 'org-mode))
   (if (derived-mode-p 'org-mode) t nil))


 I think changing org-mode-p should be the correct change to make
 deriving from org-mode work.

 Perhaps a (if (symbolp 'derived-mode-p) ...) is necessary to avoid
 compatibility problems.

 What do the org developers think of this improvement?



In function org-edit-src-code there is already support for derived modes from 
org-mode:
,
|   (let ((mark (and (org-region-active-p) (mark)))
|   (case-fold-search t)
|   (info (org-edit-src-find-region-and-lang))
|   (full-info (org-babel-get-src-block-info))
|   (org-mode-p (or (org-mode-p) (derived-mode-p 'org-mode)))
`

(defun org-mode-or-derived-mode-p ()
  Check if the current buffer is in Org-mode or a derived mode.
  (if (derived-mode-p 'org-mode) t nil))

Using org-mode-or-derived-mode-p would change the function like this:
,
| In function org-edit-src-code
|   (let ((mark (and (org-region-active-p) (mark)))
|   (case-fold-search t)
|   (info (org-edit-src-find-region-and-lang))
|   (full-info (org-babel-get-src-block-info))
|   (org-mode-p (org-mode-or-derived-mode-p))
`

org-mode-p could be replaced step by step with org-mode-or-derived-mode-p to 
enhance the support for org-mode derived modes.

I need org-mode-or-derived-mode-p instead of org-mode-p in org-entry-properties.

It would be great if org-mode-or-derived-mode-p could be added!

Thanks,
  Stefan.




[O] Use (org-entry-properties) in a mode derived from org-mode

2011-08-31 Thread Stefan Reichör
Hi!

I'd like to derive a mode from org-mode.

I do something like this:

(define-derived-mode derived-org-mode org-mode dorg derived org-mode
  (message derived-org-mode activated)
  )

When I activate the derived-org-mode, M-: (org-entry-properties) does no longer 
work.

Using org-mode it works.

When I use derived-mode-p in org-mode-p everything works:


(defsubst org-mode-p ()
  Check if the current buffer is in Org-mode or a derived mode.
  ;;(eq major-mode 'org-mode))
  (if (derived-mode-p 'org-mode) t nil))


I think changing org-mode-p should be the correct change to make
deriving from org-mode work.

Perhaps a (if (symbolp 'derived-mode-p) ...) is necessary to avoid
compatibility problems.

What do the org developers think of this improvement?


Stefan.