[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message
Nicolas Richard theonewiththeevill...@yahoo.fr writes: David Griffiths dogriffi...@gmail.com writes: Debugger entered--Lisp error: (error `recenter'ing a window that does not display current-buffer.) recenter((4)) org-overview() So that's a duplicate of #17724. It is fixed in org-mode (upstream) master branch. The easy fix is to use emacs-24 branch :) (otherwise just remove that call to recenter in org-overview). PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. -- Bastien
[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message
Bastien b...@altern.org writes: PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. For me, fixing also org-fix-ellipsis-at-bol made all tests run as expected. -- Nico.
[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message
Nicolas Richard theonewiththeevill...@yahoo.fr writes: Bastien b...@altern.org writes: PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. For me, fixing also org-fix-ellipsis-at-bol made all tests run as expected. What do you mean by fixing? Removing it entirely? -- Bastien
[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message
From: Bastien b...@altern.org Date: Wed, 11 Jun 2014 17:50:02 +0200 Cc: 17...@debbugs.gnu.org, David Griffiths dogriffi...@gmail.com PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. Say thanks to Stefan for flagging all those bugs ;-)
[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message
Say thanks to Stefan for flagging all those bugs ;-) Now that I think about it, I should make `car' signal an error every 100th call, as well. Would flag many bugs (with some false positives, of course, but what's a few false positives among friends?)! Stefan
[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message
From: Stefan Monnier monn...@iro.umontreal.ca Cc: Bastien b...@altern.org, theonewiththeevill...@yahoo.fr, 17...@debbugs.gnu.org, dogriffi...@gmail.com Date: Wed, 11 Jun 2014 14:15:08 -0400 Say thanks to Stefan for flagging all those bugs ;-) Now that I think about it, I should make `car' signal an error every 100th call, as well. Would flag many bugs (with some false positives, of course, but what's a few false positives among friends?)! Not just 'car', 'cdr' as well, I'd say.
[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message
Bastien b...@altern.org writes: Nicolas Richard theonewiththeevill...@yahoo.fr writes: Bastien b...@altern.org writes: PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. For me, fixing also org-fix-ellipsis-at-bol made all tests run as expected. What do you mean by fixing? Removing it entirely? Yes, I admit, I did : (defsubst org-fix-ellipsis-at-bol () nil) But I must have done something wrong or misread the results because now I see some other failures. Moreover, the backtrace that I get from make test seems incomplete and it's not obvious to me where the recenter call is made. OTOH I hope that wrapping every call to recenter in a (when (eq (current-buffer) (window-buffer)) (recenter ...)) would fix the tests, no ? -- Nico.
