[O] org-babel-gnuplot-quote-tsv-field does not work properly (quotes); org-plot-quote-tsv-field does though

2014-01-05 Thread Miguel Ruiz
Hi,

I cannot get temp data file from org-babel-gnuplot with quoted row labels. I 
have tried org-plot/gnuplot and it provides a correct temp data file but it 
freezes so it is no useful by now.

My test table:

| Sede  | Max cites | H-index |
|---+---+-|
| Chile |    257.72 |   21.39 |
| Leeds |    165.77 |   19.68 |
| Sao Paolo | 71.00 |   11.50 | ; without quotes (in temp data file), 
gnuplot sees 4 columns
| Stockholm |    134.19 |   14.33 |
| Morelia   |    257.56 |   17.67 |


I would appreciate any hint.

TIA,
Miguel Ruiz.

CYGWIN_NT-6.1-WOW64 usuario-PC 1.7.27(0.271/5/3) 2013-12-09 11:57 i686 Cygwin
GNU Emacs (emacs-w32) 24.3.1 (i686-pc-cygwin) of 2013-08-14 on moufang
Org-mode version 8.2.5a (release_8.2.5a @ /home/usuario/org-mode/maint/lisp/)

Re: [O] org-babel-gnuplot-quote-tsv-field does not work properly (quotes); org-plot-quote-tsv-field does though

2014-01-05 Thread Miguel Ruiz
Is it *this* enough:

diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
index cc9186b..426077b 100644
--- a/lisp/ob-gnuplot.el
+++ b/lisp/ob-gnuplot.el
@@ -253,7 +253,7 @@ then create one.  Return the initialized session.  The 
current
    (org-babel-gnuplot-quote-timestamp-field s)
   (if (zerop (length s))
  (or *org-babel-gnuplot-missing* s)
-   (if (string-match [ \] ?)
+   (if (string-match [ \] s)
    (concat \ (mapconcat 'identity (split-string s \) \\)
    \)
  s)


It works for me.




El Domingo 5 de enero de 2014 9:50, Miguel Ruiz rbeni...@yahoo.es escribió:
 
Hi,

I cannot get temp data file from org-babel-gnuplot with quoted row labels. I 
have tried org-plot/gnuplot and it provides a correct temp data file but it 
freezes so it is no useful by now.

My test table:

| Sede  | Max cites | H-index |
|---+---+-|
| Chile |    257.72 |   21.39 |
| Leeds |    165.77 |   19.68 |
| Sao Paolo | 71.00 |   11.50 | ; without quotes (in temp data file), 
gnuplot sees 4 columns
| Stockholm |    134.19 |   14.33 |
| Morelia   |    257.56 |   17.67 |


I would appreciate any
 hint.

TIA,
Miguel Ruiz.

CYGWIN_NT-6.1-WOW64 usuario-PC 1.7.27(0.271/5/3) 2013-12-09 11:57 i686 Cygwin
GNU Emacs (emacs-w32) 24.3.1 (i686-pc-cygwin) of 2013-08-14 on moufang
Org-mode version 8.2.5a (release_8.2.5a @ /home/usuario/org-mode/maint/lisp/)

Re: [O] org-babel-gnuplot-quote-tsv-field does not work properly (quotes); org-plot-quote-tsv-field does though

2014-01-05 Thread Bastien
Hi Miguel,

Miguel Ruiz rbeni...@yahoo.es writes:

 Is it *this* enough:

 diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
 index cc9186b..426077b 100644
 --- a/lisp/ob-gnuplot.el
 +++ b/lisp/ob-gnuplot.el

Thanks for the fix -- could you format it with git format-patch
and add a proper ChangeLog?

See http://orgmode.org/worg/org-contribute.html#sec-4-2 for
details on how to submit a patch.  Please add TINYCHANGE at
the end of your commit message if you didn't sign the FSF
papers.

Thanks!

-- 
 Bastien



Re: [O] org-babel-gnuplot-quote-tsv-field does not work properly (quotes); org-plot-quote-tsv-field does though

2014-01-05 Thread Miguel Ruiz
Thank you, Bastien. I'd prefer some of you writes the changelog entry; the 
patch is attached.





El Domingo 5 de enero de 2014 12:51, Bastien b...@gnu.org escribió:
 
Hi Miguel,

Miguel Ruiz rbeni...@yahoo.es writes:

 Is it *this* enough:

 diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
 index cc9186b..426077b 100644
 --- a/lisp/ob-gnuplot.el
 +++ b/lisp/ob-gnuplot.el

Thanks for the fix -- could you format it with git format-patch
and add a proper ChangeLog?

See http://orgmode.org/worg/org-contribute.html#sec-4-2 for
details on how to submit a patch.  Please add TINYCHANGE at
the end of your commit message if you didn't sign the FSF
papers.

Thanks!

-- 
Bastien

0001-Fix-typo-that-stopped-necessary-quoted-strings-in-gn.patch
Description: Binary data


Re: [O] org-babel-gnuplot-quote-tsv-field does not work properly (quotes); org-plot-quote-tsv-field does though

2014-01-05 Thread Bastien
Miguel Ruiz rbeni...@yahoo.es writes:

 Thank you, Bastien. I'd prefer some of you writes the changelog
 entry; the patch is attached.

Applied, thanks.

-- 
 Bastien