Re: [O] patch for ob-sql.el: improve MySQL header formatting, and add db spec header vars
Gary Oberbrunner ga...@oberbrunner.com writes: Here's a better version of this patch, which also adds support for :colnames, which I needed. And it adds some doc about what header args are used. * add a header-row delimiter to the tables returned from mysql * adds new sql-specific header args for the database connection, and implements them for mysql * adds support for :colnames (mysql only) * (minor) adds an edebug spec to org-babel-result-cond to allow edebugging through it Hi Gary, Thanks for sharing this patch. It looks like a solid improvement of Org's SQL support, and I'd like to apply it, however I need to ask for two things first. Most importantly, given the size of the patch you'll have to complete the Emacs copyright assignment process, see [1]. Less importantly, if you could re-generate the patch using git format-patch, it will be much easier to apply. Thanks! On Fri, Feb 1, 2013 at 10:18 AM, Gary Oberbrunner ga...@oberbrunner.comwrote: Let me know if this would be better as a pull request. This patch does three things: * add a header-row delimiter to the tables returned from mysql * adds new sql-specific header args for the database connection, and implements them for mysql * (minor) adds an edebug spec to org-babel-result-cond to allow edebugging through it -- Gary Footnotes: [1] http://orgmode.org/worg/org-contribute.html -- Eric Schulte http://cs.unm.edu/~eschulte
[O] patch for ob-sql.el: improve MySQL header formatting, and add db spec header vars
Let me know if this would be better as a pull request. This patch does three things: * add a header-row delimiter to the tables returned from mysql * adds new sql-specific header args for the database connection, and implements them for mysql * (minor) adds an edebug spec to org-babel-result-cond to allow edebugging through it -- Gary org-mode-sql.patch Description: Binary data
Re: [O] patch for ob-sql.el: improve MySQL header formatting, and add db spec header vars
Here's a better version of this patch, which also adds support for :colnames, which I needed. And it adds some doc about what header args are used. * add a header-row delimiter to the tables returned from mysql * adds new sql-specific header args for the database connection, and implements them for mysql * adds support for :colnames (mysql only) * (minor) adds an edebug spec to org-babel-result-cond to allow edebugging through it On Fri, Feb 1, 2013 at 10:18 AM, Gary Oberbrunner ga...@oberbrunner.comwrote: Let me know if this would be better as a pull request. This patch does three things: * add a header-row delimiter to the tables returned from mysql * adds new sql-specific header args for the database connection, and implements them for mysql * (minor) adds an edebug spec to org-babel-result-cond to allow edebugging through it -- Gary -- Gary org-mode-sql-2.patch Description: Binary data
