Re: [Orgmode] [BUG] org splitting window weird layout

2011-02-12 Thread Bastien
Hi Leo,

Leo sdl@gmail.com writes:

 Function org-fast-tag-selection may create a three-window layout like
 this: http://imagebin.org/127056.

Perhaps due to my delay in replying, the image disappeared.

Do you still have this problem?  If so, can you be so kind as to report
the picture?

Thanks!

-- 
 Bastien

___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


Re: [Orgmode] [BUG] org splitting window weird layout

2011-02-12 Thread Leo
On 2011-02-12 22:41 +0800, Bastien wrote:
 Leo sdl@gmail.com writes:

 Function org-fast-tag-selection may create a three-window layout like
 this: http://imagebin.org/127056.

 Perhaps due to my delay in replying, the image disappeared.

 Do you still have this problem?  If so, can you be so kind as to report
 the picture?

 Thanks!

Carsten has applied the patch.

Leo

-- 
Oracle is the new evil

___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


Re: [Orgmode] [BUG] org splitting window weird layout

2011-02-12 Thread Bastien
Leo sdl@gmail.com writes:

 Carsten has applied the patch.

Thanks for confirming.

-- 
 Bastien

___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


[Orgmode] [BUG] org splitting window weird layout

2010-12-09 Thread Leo
Hello all,

Function org-fast-tag-selection may create a three-window layout like
this: http://imagebin.org/127056.

This is due to org-switch-to-buffer-other-window subject to
split-window-sensibly and thus

  (org-switch-to-buffer-other-window  *Org tags*)

is not guaranteed to switch to the window created by
(split-window-vertically).

I have temporarily fixed the problem with the patch attached
(http://imagebin.org/127057). I think a proper fix may have to be in
org-switch-to-buffer-other-window, i.e. add an extra argument to
indicate preferring horizontal or vertical split and let bound
split-width-threshold or split-height-threshold accordingly, and fix the
places where it is used.

diff -c /usr/local/unix/site-lisp/orgmode/org.el\~ 
/usr/local/unix/site-lisp/orgmode/org.el

--- /usr/local/unix/site-lisp/orgmode/org.el~   Mon Dec  6 18:24:00 2010

   
+++ /usr/local/unix/site-lisp/orgmode/org.elThu Dec  9 10:30:09 2010

   
@@ -13026,7 +13026,7 @@
   (setq exit-after-next (not exit-after-next)))

   
(setq expert nil)   

   
(delete-other-windows)  

   
-   (split-window-vertically)   

   
+   (set-window-buffer (split-window-vertically)  *Org tags*) 

   
(org-switch-to-buffer-other-window  *Org tags*)   

   
(org-fit-window-to-buffer)))

   
 ((or (= c ?\C-g)   

   


   
Diff finished.  Thu Dec  9 10:30:48 2010
  

HTH,
Leo


___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode