Re: [Orgmode] [PATCH] ASCII export: Fixed a bug.
Hi Bastien, I just noticed that the call to 'car' is missing: -- lisp/org-ascii.el -- index 3cc95e6..dd6f69b 100644 @@ -656 +656 @@ publishing directory. -(last org-export-ascii-underline))) +(car (last org-export-ascii-underline Best regards, Valentin On Tue, Feb 15, 2011 at 7:58 AM, Valentin Wüstholz wuesth...@gmail.com wrote: On Tue, Feb 15, 2011 at 5:31 AM, Bastien bastien.gue...@wikimedia.fr wrote: Hi Valentin, Valentin Wüstholz wuesth...@gmail.com writes: thanks. Is there a reason for keeping the 'reverse' operation? The documentation for org-export-ascii-underline states that the characters are ordered by level (1, 2, ...). Why should they be accessed in reverse order then? The docstring didn't match the default value for the defcustom: now it does. I also simplified `org-ascii-level-start' so that it use the right level char. Sounds good! Thanks, Valentin ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] [PATCH] ASCII export: Fixed a bug.
Hi Valentin, Valentin Wüstholz wuesth...@gmail.com writes: I just noticed that the call to 'car' is missing: -- lisp/org-ascii.el -- index 3cc95e6..dd6f69b 100644 @@ -656 +656 @@ publishing directory. - (last org-export-ascii-underline))) + (car (last org-export-ascii-underline Argh, right, fixed again. Thanks! -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] [PATCH] ASCII export: Fixed a bug.
Hi Valentin, Valentin Wüstholz wuesth...@gmail.com writes: thanks. Is there a reason for keeping the 'reverse' operation? The documentation for org-export-ascii-underline states that the characters are ordered by level (1, 2, ...). Why should they be accessed in reverse order then? The docstring didn't match the default value for the defcustom: now it does. I also simplified `org-ascii-level-start' so that it use the right level char. Thanks for insisting on this, -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] [PATCH] ASCII export: Fixed a bug.
On Tue, Feb 15, 2011 at 5:31 AM, Bastien bastien.gue...@wikimedia.fr wrote: Hi Valentin, Valentin Wüstholz wuesth...@gmail.com writes: thanks. Is there a reason for keeping the 'reverse' operation? The documentation for org-export-ascii-underline states that the characters are ordered by level (1, 2, ...). Why should they be accessed in reverse order then? The docstring didn't match the default value for the defcustom: now it does. I also simplified `org-ascii-level-start' so that it use the right level char. Sounds good! Thanks, Valentin ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] [PATCH] ASCII export: Fixed a bug.
Hi, I have attached a small patch for a bug that I reported a while ago. See http://thread.gmane.org/gmane.emacs.orgmode/36097. Best regards, Valentin org-ascii.el.diff Description: Binary data ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] [PATCH] ASCII export: Fixed a bug.
Hi Basten, thanks. Is there a reason for keeping the 'reverse' operation? The documentation for org-export-ascii-underline states that the characters are ordered by level (1, 2, ...). Why should they be accessed in reverse order then? Best regards, Valentin On Sun, Feb 13, 2011 at 12:44 PM, Bastien bastien.gue...@wikimedia.fr wrote: Hi Valentin, Valentin Wüstholz wuesth...@gmail.com writes: I have attached a small patch for a bug that I reported a while ago. See http://thread.gmane.org/gmane.emacs.orgmode/36097. Thanks for this patch. I've just applied a simplified version of it, which takes care of the bug. Best, -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
