Re: [Orgmode] [PATCH] agenda startup: log-mode should be customizable as well

2009-05-14 Thread Carsten Dominik

Applied, thanks.

- Carsten

On May 14, 2009, at 5:57 AM, Benjamin Andresen wrote:


Hey there,

I was curious as to why a value such log-mode wasn't customizable
to be run on start-up as follow-mode and clock-report-mode are.

If Carsten thinks this is a good idea, I've attached a patch that may
shave of 5 seconds of him adding it. It applies cleanly to current git
HEAD.

br,
benny

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7622f6a..e52fdbc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -628,6 +628,7 @@ Needs to be set before org.el is loaded.
  :group 'org-agenda-startup
  :type 'boolean)

+
(defvar org-agenda-include-inactive-timestamps nil
  Non-nil means, include inactive time stamps in agenda and  
timeline.)


@@ -789,6 +790,12 @@ agenda display.
  :group 'org-agenda-daily/weekly
  :type 'boolean)

+(defcustom org-agenda-start-with-log-mode nil
+  The initial value of log-mode in a newly created agenda window.
+  :group 'org-agenda-startup
+  :group 'org-agenda-daily/weekly
+  :type 'boolean)
+
(defcustom org-agenda-start-with-clockreport-mode nil
  The initial value of clockreport-mode in a newly created agenda  
window.

  :group 'org-agenda-startup
@@ -1252,7 +1259,7 @@ The following commands are available:
  (unless org-agenda-keep-modes
(setq org-agenda-follow-mode org-agenda-start-with-follow-mode
  org-agenda-clockreport-mode org-agenda-start-with-clockreport-mode
- org-agenda-show-log nil))
+ org-agenda-show-log org-agenda-start-with-log-mode))
  (easy-menu-change
   '(Agenda) Agenda Files
   (append
___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


[Orgmode] [PATCH] agenda startup: log-mode should be customizable as well

2009-05-13 Thread Benjamin Andresen
Hey there,

I was curious as to why a value such log-mode wasn't customizable
to be run on start-up as follow-mode and clock-report-mode are.

If Carsten thinks this is a good idea, I've attached a patch that may
shave of 5 seconds of him adding it. It applies cleanly to current git
HEAD.

br,
benny

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7622f6a..e52fdbc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -628,6 +628,7 @@ Needs to be set before org.el is loaded.
   :group 'org-agenda-startup
   :type 'boolean)
 
+
 (defvar org-agenda-include-inactive-timestamps nil
   Non-nil means, include inactive time stamps in agenda and timeline.)
 
@@ -789,6 +790,12 @@ agenda display.
   :group 'org-agenda-daily/weekly
   :type 'boolean)
 
+(defcustom org-agenda-start-with-log-mode nil
+  The initial value of log-mode in a newly created agenda window.
+  :group 'org-agenda-startup
+  :group 'org-agenda-daily/weekly
+  :type 'boolean)
+
 (defcustom org-agenda-start-with-clockreport-mode nil
   The initial value of clockreport-mode in a newly created agenda window.
   :group 'org-agenda-startup
@@ -1252,7 +1259,7 @@ The following commands are available:
   (unless org-agenda-keep-modes
 (setq org-agenda-follow-mode org-agenda-start-with-follow-mode
  org-agenda-clockreport-mode org-agenda-start-with-clockreport-mode
- org-agenda-show-log nil))
+ org-agenda-show-log org-agenda-start-with-log-mode))
   (easy-menu-change
'(Agenda) Agenda Files
(append
___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode