Re: REJECT patches (was: Re: [Orgmode] [PATCH] org-agenda: allow to negate skip conditions )
On Dec 15, 2010, at 11:55 AM, Giovanni Ridolfi wrote: Please, reject the following patches: Done. - Carsten Julien Danjou writes: On Tue, Dec 14 2010, Julien Danjou wrote: * org-agenda.el (org-agenda-skip-if): Allow to negate conditions. This was not meant to be sent as it is. Forget it. 1. see above http://patchwork.newartisans.com/patch/482/ 2. my "stupid patch" to add (debug) calls to org-capture.el to help in fixing the :PROPERTIES: bug[1] http://patchwork.newartisans.com/patch/477/ cheers, Giovanni [1] http://lists.gnu.org/archive/html/emacs-orgmode/2010-12/msg00690.html by the way, perhaps the bug will be fixed if the path[2] by Julien is applied. [2] http://patchwork.newartisans.com/patch/478/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
REJECT patches (was: Re: [Orgmode] [PATCH] org-agenda: allow to negate skip conditions )
Please, reject the following patches: Julien Danjou writes: > On Tue, Dec 14 2010, Julien Danjou wrote: > >> * org-agenda.el (org-agenda-skip-if): Allow to negate conditions. > > This was not meant to be sent as it is. Forget it. 1. see above http://patchwork.newartisans.com/patch/482/ 2. my "stupid patch" to add (debug) calls to org-capture.el to help in fixing the :PROPERTIES: bug[1] http://patchwork.newartisans.com/patch/477/ cheers, Giovanni [1] http://lists.gnu.org/archive/html/emacs-orgmode/2010-12/msg00690.html by the way, perhaps the bug will be fixed if the path[2] by Julien is applied. [2] http://patchwork.newartisans.com/patch/478/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] [PATCH] org-agenda: allow to negate skip conditions
On Tue, Dec 14 2010, Julien Danjou wrote: > * org-agenda.el (org-agenda-skip-if): Allow to negate conditions. This was not meant to be sent as it is. Forget it. -- Julien Danjou ❱ http://julien.danjou.info pgpO9W4PRwX9A.pgp Description: PGP signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] [PATCH] org-agenda: allow to negate skip conditions
* org-agenda.el (org-agenda-skip-if): Allow to negate conditions. Signed-off-by: Julien Danjou --- lisp/org-agenda.el | 33 + 1 files changed, 21 insertions(+), 12 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index f476449..537a421 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4076,7 +4076,12 @@ See `org-agenda-skip-if' for details." See `org-agenda-skip-if' for details." (org-agenda-skip-if t conditions)) -(defun org-agenda-skip-if (subtree conditions) +(defun org-agenda-skip-if-not (subtree conditions) + "Skip entry if none of CONDITIONS is false. +See `org-agenda-skip-if' for details." + (org-agenda-skip-if subtree conditions t)) + +(defun org-agenda-skip-if (subtree conditions &optional not) "Checks current entity for CONDITIONS. If SUBTREE is non-nil, the entire subtree is checked. Otherwise, only the entry, i.e. the text before the next heading is checked. @@ -4112,17 +4117,21 @@ Instead of a list a keyword class may be given would skip entries that haven't been marked with any of \"DONE\" keywords. Possible classes are: `todo', `done', `any'. -If any of these conditions is met, this function returns the end point of -the entity, causing the search to continue from there. This is a function -that can be put into `org-agenda-skip-function' for the duration of a command." - (let (beg end m) -(org-back-to-heading t) -(setq beg (point) - end (if subtree - (progn (org-end-of-subtree t) (point)) - (progn (outline-next-heading) (1- (point) -(goto-char beg) -(and +If any of these conditions is met, this function returns the end +point of the entity, causing the search to continue from there. + +If NOT is set to t, then this function returns the end point of +the entity only if none of the condition is met, causing the +search to continue from there. + +This is a function that can be put into +`org-agenda-skip-function' for the duration of a command." + (org-back-to-heading t) + (let ((beg (point)) + (end (if subtree +(save-excursion (org-end-of-subtree t)) + (save-excursion (outline-next-heading) (1- (point)) +((if not 'or 'and) (or (and (memq 'scheduled conditions) (re-search-forward org-scheduled-time-regexp end t)) -- 1.7.2.3 ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
