[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Matt Lundin m...@imapmail.org writes: Bastien Guerry b...@altern.org writes: Patch 543 (http://patchwork.newartisans.com/patch/543/) is now Accepted. * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a possible default span if it is set. This patch breaks custom commands --- i.e., if one binds org-agenda-span in a custom command, it seems to be overridden by the span of whatever agenda command one last called (i.e., org-agenda-current-span). Steps to replicate: 1. (setq org-agenda-span 'day) 2. M-x org-agenda-list 3. Check the value of org-agenda-current-span = day 4. Call the following custom command: (setq org-agenda-custom-commands '((c Calendar agenda ((org-agenda-span 'week) (org-agenda-start-on-weekday 0) (org-agenda-time-grid nil) (org-agenda-entry-types '(:timestamp :sexp)) (org-agenda-prefix-format %-12:t ) (org-deadline-warning-days 0) (org-agenda-include-all-todo nil) (org-agenda-repeating-timestamp-show-all t) This results in only a day view because org-agenda-current-span is still 'day. Has there been any progress on this issue? I am finding that the local span bindings in the custom command above still do not have any effect. My default agenda span is a day. If I call the custom command above, it displays only one day, despite the local setting. Best, Matt ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Matt Lundin m...@imapmail.org writes: Has there been any progress on this issue? I am finding that the local span bindings in the custom command above still do not have any effect. My default agenda span is a day. If I call the custom command above, it displays only one day, despite the local setting. I think I know what's happening. The custom agenda commands had been working properly until this commit on Feb 18, which brought back the behavior described above: c6dbde1babaa0b2efa278d75a6ec82f91ef59d5e Thanks, Matt ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Matt, Matt Lundin m...@imapmail.org writes: Matt Lundin m...@imapmail.org writes: Has there been any progress on this issue? I am finding that the local span bindings in the custom command above still do not have any effect. My default agenda span is a day. If I call the custom command above, it displays only one day, despite the local setting. I think I know what's happening. The custom agenda commands had been working properly until this commit on Feb 18, which brought back the behavior described above: c6dbde1babaa0b2efa278d75a6ec82f91ef59d5e This commit should have fixed the issue - not brought it back :/ I'm not able to reproduce your problem with emacs -q and the minimal configuration you proposed. Can I ask you to check again? Thanks, -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Matt, Bastien b...@altern.org writes: I'm not able to reproduce your problem with emacs -q and the minimal configuration you proposed. Can I ask you to check again? Forget my message - I *can* reproduce your issue, I will investigate this tomorrow. Thanks for your patience, -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Carsten, Carsten Dominik carsten.domi...@gmail.com writes: wow, you found your way through the agenda code maze. Yeah, the trip in the code was really a-mazing :) Looks good to me! Thanks for getting this fixed, so that Juliens cleaner implementation can stay the basis for time span setting. This basis is quite an improvement, so it deserved the time spent to fix this bug (and to learn the code)... -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Carsten and all, Carsten Dominik carsten.domi...@gmail.com writes: For what it is worth, and for the record, I still do not believe that this is the correct solution to the problem. I've finally push a fix for this problem. The issue appeared when trying to redo a block agenda command, where previous restrictions were not taking into account. I tested the fix on various agenda custom views, with the tests provided by Michael (thanks!) and it looks fine. Please report any problem, this issue is pretty essential. Special thanks to Matt and Michael for their reports! -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Bastien bastien.gue...@wikimedia.fr writes: Hi Carsten and all, Carsten Dominik carsten.domi...@gmail.com writes: For what it is worth, and for the record, I still do not believe that this is the correct solution to the problem. I've finally push a fix for this problem. The issue appeared when trying to redo a block agenda command, where previous restrictions were not taking into account. I tested the fix on various agenda custom views, with the tests provided by Michael (thanks!) and it looks fine. Please report any problem, this issue is pretty essential. Special thanks to Matt and Michael for their reports! I confirm that it's working as expected. ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Bastien, On Feb 18, 2011, at 3:19 PM, Bastien wrote: Hi Carsten and all, Carsten Dominik carsten.domi...@gmail.com writes: For what it is worth, and for the record, I still do not believe that this is the correct solution to the problem. I've finally push a fix for this problem. The issue appeared when trying to redo a block agenda command, where previous restrictions were not taking into account. I tested the fix on various agenda custom views, with the tests provided by Michael (thanks!) and it looks fine. wow, you found your way through the agenda code maze. Looks good to me! Thanks for getting this fixed, so that Juliens cleaner implementation can stay the basis for time span setting. - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Bastien, hi Julien, For what it is worth, and for the record, I still do not believe that this is the correct solution to the problem. I believe it causes the issue reported in http://thread.gmane.org/gmane.emacs.orgmode/37673 But unfortunately I have not had time to study the issue in more detail. I hope to do this before the next release. Kind regards. - Carsten On Feb 10, 2011, at 3:35 PM, Bastien wrote: Julien Danjou jul...@danjou.info writes: But maybe you can just delocalize that one variable instead, using kill-local-variable? It's a possibility, but I think it's more logical to reset every local variable. I just pushed a (temporary) fix, following Carsten's suggestion of using kill-local-variable. I tested this with emacs -q and things work back as usual. Matt and Michael, please report any problem. Michael, thanks for the detailed step-by-step way of reproducing the problem with a bare emacs! Quite useful. Julien: I've pushed this (temporary) fix so that you don't feel too much pressure about finding a more general solution. Thanks! -- Bastien - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Carsten, Carsten Dominik carsten.domi...@gmail.com writes: For what it is worth, and for the record, I still do not believe that this is the correct solution to the problem. I believe it causes the issue reported in http://thread.gmane.org/gmane.emacs.orgmode/37673 But unfortunately I have not had time to study the issue in more detail. I hope to do this before the next release. thanks for the heads up -- this is on top of my priority list, hopefully I'll fix this soon. Best, -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
On Feb 9, 2011, at 5:37 PM, Bastien wrote: Julien Danjou jul...@danjou.info writes: On Sat, Feb 05 2011, Matt Lundin wrote: This results in only a day view because org-agenda-current-span is still 'day. Here's a proposal fix. I applied it to early, I made the error of not testing it with a bare emacs -q. The fix is not okay. Let's find a better solution. I am not sure if I know exactly what the remaining problem is. Could someone summarize this - I'd be happy to take a look and see if I can fix it. - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
On Thu, Feb 10 2011, Carsten Dominik wrote: I am not sure if I know exactly what the remaining problem is. Could someone summarize this - I'd be happy to take a look and see if I can fix it. The problem is that org-agenda-list, when called use as span either: (or span org-agenda-current-span org-agenda-span) Or, when defining a custom agenda view, and calling it, the Agenda buffer is reused. Therefore, if your agenda view locally bind org-agenda-span to 'day, whereas org-agenda-current-span was previously set to 'week, it does not work. This is why I've added a kill-local-variable in custom agenda view, which seems quite a good thing. Bastien says it does not work with emacs -q, but I don't why unfortunately. Bastien? -- Julien Danjou ❱ http://julien.danjou.info pgpnQaxzd7YaH.pgp Description: PGP signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Carsten On Thu, Feb 10, 2011 at 10:20, Carsten Dominik carsten.domi...@gmail.com wrote: I am not sure if I know exactly what the remaining problem is. Could someone summarize this - I'd be happy to take a look and see if I can fix it. Not the summary you asked for but a related issue, could you please also consider the following? * test case: `d g' in custom agenda view 1) emacs -q --eval (progn \ (global-set-key (kbd \C-c a\) 'org-agenda) \ (setq org-agenda-custom-commands \ '((\x\ \test\ ((agenda)) 2) C-c a a d g: `g' stays in view day like expected 3) C-c a x d g: `g' changes back to view week but I expect it to stay in view day like above This is described as issue part 1) in this post/thread http://thread.gmane.org/gmane.emacs.orgmode/35403/focus=36776 and like described there was introduced with the commit http://orgmode.org/w/org-mode.git/commitdiff/0d0edd6d21ade8e8617c51e3594ea4e87040e05f * test case: `w f d g' in custom agenda view 1) emacs -q --eval (progn \ (global-set-key (kbd \C-c a\) 'org-agenda) \ (setq org-agenda-custom-commands \ '((\x\ \test\ ((agenda)) 2) C-c a a f d g: `g' stays on the day of the next week like expected 3) C-c a x f d g: `g' does not stay on the day of the next week but is expected to do like above This is described as issue part 2) also in this post/thread http://thread.gmane.org/gmane.emacs.orgmode/35403/focus=36776 (unlike the above this is not related with the commit mentioned above) Michael ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
On Feb 10, 2011, at 11:51 AM, Julien Danjou wrote: On Thu, Feb 10 2011, Carsten Dominik wrote: I am not sure if I know exactly what the remaining problem is. Could someone summarize this - I'd be happy to take a look and see if I can fix it. The problem is that org-agenda-list, when called use as span either: (or span org-agenda-current-span org-agenda-span) Or, when defining a custom agenda view, and calling it, the Agenda buffer is reused. Therefore, if your agenda view locally bind org-agenda-span to 'day, whereas org-agenda-current-span was previously set to 'week, it does not work. This is why I've added a kill-local-variable in custom agenda view, which seems quite a good thing. Bastien says it does not work with emacs -q, but I don't why unfortunately. Bastien? No, I believe you did kill-all-local-variables, which is a very bad idea. Org uses local variables to remember settings when refreshing. And apparently this call was executed in an innocent org buffer, reverting its major mode to fundamental mode. :) But maybe you can just delocalize that one variable instead, using kill-local-variable? - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Michael, thanks. - Carsten On Feb 10, 2011, at 12:18 PM, Michael Brand wrote: Hi Carsten On Thu, Feb 10, 2011 at 10:20, Carsten Dominik carsten.domi...@gmail.com wrote: I am not sure if I know exactly what the remaining problem is. Could someone summarize this - I'd be happy to take a look and see if I can fix it. Not the summary you asked for but a related issue, could you please also consider the following? * test case: `d g' in custom agenda view 1) emacs -q --eval (progn \ (global-set-key (kbd \C-c a\) 'org-agenda) \ (setq org-agenda-custom-commands \ '((\x\ \test\ ((agenda)) 2) C-c a a d g: `g' stays in view day like expected 3) C-c a x d g: `g' changes back to view week but I expect it to stay in view day like above This is described as issue part 1) in this post/thread http://thread.gmane.org/gmane.emacs.orgmode/35403/focus=36776 and like described there was introduced with the commit http://orgmode.org/w/org-mode.git/commitdiff/0d0edd6d21ade8e8617c51e3594ea4e87040e05f * test case: `w f d g' in custom agenda view 1) emacs -q --eval (progn \ (global-set-key (kbd \C-c a\) 'org-agenda) \ (setq org-agenda-custom-commands \ '((\x\ \test\ ((agenda)) 2) C-c a a f d g: `g' stays on the day of the next week like expected 3) C-c a x f d g: `g' does not stay on the day of the next week but is expected to do like above This is described as issue part 2) also in this post/thread http://thread.gmane.org/gmane.emacs.orgmode/35403/focus=36776 (unlike the above this is not related with the commit mentioned above) Michael - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
On Thu, Feb 10 2011, Carsten Dominik wrote: No, I believe you did kill-all-local-variables, which is a very bad idea. Org uses local variables to remember settings when refreshing. And apparently this call was executed in an innocent org buffer, reverting its major mode to fundamental mode. :) That explains everything! My bad! But maybe you can just delocalize that one variable instead, using kill-local-variable? It's a possibility, but I think it's more logical to reset every local variable. I think this call should be used in the appropriate buffer, the agenda one, then. I'll try to send a patch later, but if you have time please do so. :) -- Julien Danjou ❱ http://julien.danjou.info pgpADO4tI50lk.pgp Description: PGP signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Julien Danjou jul...@danjou.info writes: But maybe you can just delocalize that one variable instead, using kill-local-variable? It's a possibility, but I think it's more logical to reset every local variable. I just pushed a (temporary) fix, following Carsten's suggestion of using kill-local-variable. I tested this with emacs -q and things work back as usual. Matt and Michael, please report any problem. Michael, thanks for the detailed step-by-step way of reproducing the problem with a bare emacs! Quite useful. Julien: I've pushed this (temporary) fix so that you don't feel too much pressure about finding a more general solution. Thanks! -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Hi Bastien On Thu, Feb 10, 2011 at 15:35, Bastien bastien.gue...@wikimedia.fr wrote: Matt and Michael, please report any problem. The two test cases `d g' and `w f d g' in custom agenda view that I described above do still not work like I expect. Michael, thanks for the detailed step-by-step way of reproducing the problem with a bare emacs! Quite useful. I have put my reply to this into a new thread called automatic regression test (again): http://thread.gmane.org/gmane.emacs.orgmode/37402 Michael ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Julien Danjou jul...@danjou.info writes: On Sat, Feb 05 2011, Matt Lundin wrote: This results in only a day view because org-agenda-current-span is still 'day. Here's a proposal fix. I applied it to early, I made the error of not testing it with a bare emacs -q. The fix is not okay. Let's find a better solution. Thanks, -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Accepted] [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Patch 587 (http://patchwork.newartisans.com/patch/587/) is now Accepted. Maintainer comment: none This relates to the following submission: http://mid.gmane.org/%3C87sjvzaezr.fsf%40keller.adm.naquadah.org%3E Here is the original message containing the patch: Content-Type: text/plain; charset=utf-8 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Date: Mon, 07 Feb 2011 16:39:17 - From: Julien Danjou jul...@danjou.info X-Patchwork-Id: 587 Message-Id: 87sjvzaezr@keller.adm.naquadah.org To: Matt Lundin m...@imapmail.org Cc: Bastien Guerry b...@altern.org, emacs-orgmode@gnu.org On Sat, Feb 05 2011, Matt Lundin wrote: This results in only a day view because org-agenda-current-span is still 'day. Here's a proposal fix. I could have setq org-agenda-current-span to nil as a work around, but it seems more logical to just kill all the local variables. That is, a custom agenda view would not keep any of the local variable of the previous agenda, which seems logical to me. From b48fc7c395dffea60df20c23b26e362ac0354b01 Mon Sep 17 00:00:00 2001 From: Julien Danjou jul...@danjou.info Date: Mon, 7 Feb 2011 12:36:42 +0100 Subject: [PATCH] org-agenda: kill local variables in agenda view * org-agenda.el (org-agenda): Kill all local variables. This assures we are not keeping buffer variable from an old agenda view when switching to a new custom agenda. Signed-off-by: Julien Danjou jul...@danjou.info --- lisp/org-agenda.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index d146f83..9a3d953 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -2161,6 +2161,8 @@ Pressing `' twice means to restrict to the current subtree or region (put 'org-agenda-redo-command 'org-lprops nil) ;; Remember where this call originated (setq org-agenda-last-dispatch-buffer (current-buffer)) + ;; Remove all local variables + (kill-all-local-variables) (unless keys (setq ans (org-agenda-get-restriction-and-command prefix-descriptions) keys (car ans) -- 1.7.2.3 ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
On Sat, Feb 05 2011, Matt Lundin wrote: This results in only a day view because org-agenda-current-span is still 'day. Here's a proposal fix. I could have setq org-agenda-current-span to nil as a work around, but it seems more logical to just kill all the local variables. That is, a custom agenda view would not keep any of the local variable of the previous agenda, which seems logical to me. From b48fc7c395dffea60df20c23b26e362ac0354b01 Mon Sep 17 00:00:00 2001 From: Julien Danjou jul...@danjou.info Date: Mon, 7 Feb 2011 12:36:42 +0100 Subject: [PATCH] org-agenda: kill local variables in agenda view * org-agenda.el (org-agenda): Kill all local variables. This assures we are not keeping buffer variable from an old agenda view when switching to a new custom agenda. Signed-off-by: Julien Danjou jul...@danjou.info --- lisp/org-agenda.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index d146f83..9a3d953 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -2161,6 +2161,8 @@ Pressing `' twice means to restrict to the current subtree or region (put 'org-agenda-redo-command 'org-lprops nil) ;; Remember where this call originated (setq org-agenda-last-dispatch-buffer (current-buffer)) + ;; Remove all local variables + (kill-all-local-variables) (unless keys (setq ans (org-agenda-get-restriction-and-command prefix-descriptions) keys (car ans) -- 1.7.2.3 -- Julien Danjou ❱ http://julien.danjou.info pgp5f0MLiuj3S.pgp Description: PGP signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
On Sat, Feb 05 2011, Matt Lundin wrote: This patch breaks custom commands --- i.e., if one binds org-agenda-span in a custom command, it seems to be overridden by the span of whatever agenda command one last called (i.e., org-agenda-current-span). Steps to replicate: 1. (setq org-agenda-span 'day) 2. M-x org-agenda-list 3. Check the value of org-agenda-current-span = day 4. Call the following custom command: (setq org-agenda-custom-commands '((c Calendar agenda ((org-agenda-span 'week) (org-agenda-start-on-weekday 0) (org-agenda-time-grid nil) (org-agenda-entry-types '(:timestamp :sexp)) (org-agenda-prefix-format %-12:t ) (org-deadline-warning-days 0) (org-agenda-include-all-todo nil) (org-agenda-repeating-timestamp-show-all t) This results in only a day view because org-agenda-current-span is still 'day. Yes, this has already been reported, I just did not had the time to find a proper fix. -- Julien Danjou ❱ http://julien.danjou.info pgppDM5P7afRW.pgp Description: PGP signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Bastien Guerry b...@altern.org writes: Patch 543 (http://patchwork.newartisans.com/patch/543/) is now Accepted. * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a possible default span if it is set. Signed-off-by: Julien Danjou jul...@danjou.info --- lisp/org-agenda.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 0cd620c..0d695b5 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'. (setq org-agenda-last-arguments (list include-all start-day span)) (org-compile-prefix-format 'agenda) (org-set-sorting-strategy 'agenda) - (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays org-agenda-span))) + (let* ((span (org-agenda-ndays-to-span (or span + org-agenda-current-span + org-agenda-ndays + org-agenda-span))) (today (org-today)) (sd (or start-day today)) (ndays (org-agenda-span-to-ndays span sd)) -- This patch breaks custom commands --- i.e., if one binds org-agenda-span in a custom command, it seems to be overridden by the span of whatever agenda command one last called (i.e., org-agenda-current-span). Steps to replicate: 1. (setq org-agenda-span 'day) 2. M-x org-agenda-list 3. Check the value of org-agenda-current-span = day 4. Call the following custom command: (setq org-agenda-custom-commands '((c Calendar agenda ((org-agenda-span 'week) (org-agenda-start-on-weekday 0) (org-agenda-time-grid nil) (org-agenda-entry-types '(:timestamp :sexp)) (org-agenda-prefix-format %-12:t ) (org-deadline-warning-days 0) (org-agenda-include-all-todo nil) (org-agenda-repeating-timestamp-show-all t) This results in only a day view because org-agenda-current-span is still 'day. Best, Matt ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
