Re: [Orgmode] org-capture: org-capture-place-item needs search bounds
s...@blarg.net writes: In org-capture-place-item, excerpted here... [...] the function needs to bound re-search-forward by END, and it needs to bound re-search-backward by BEG. As it stands right now, if the target location doesn't contain an item already, the function will happily pick the nearest list in a preceeding or following entry. If this is still an issue, can you provide a patch for this? It will help me understand what is really at stake. Thanks! -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] org-capture: org-capture-place-item needs search bounds
Bastien bastien.gue...@wikimedia.fr writes: If this is still an issue, can you provide a patch for this? It will help me understand what is really at stake. Forget about this, I've seen this has been fixed long ago. Sorry for the noise, -- Bastien ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] org-capture: org-capture-place-item needs search bounds
Carsten Dominik writes: Yes. Thank you for your report and correct analysis. This fix was already in the current development version, I guess you are using 7.01h or something similar? If you prefer to use released versions, expect this change in 7.02. I saw the problem in plain 7.01 and verified that it still existed in 7.01h. But my location at the time didn't allow git:// access, and the last time I had looked at the website I didn't notice the browsable git repo. I'll keep that in mind for next time. Thanks, Derek -- Derek Upham s...@blarg.net ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] org-capture: org-capture-place-item needs search bounds
In org-capture-place-item, excerpted here... (defun org-capture-place-item () Place the template as a new plain list item. (let* ((txt (org-capture-get :template)) (target-entry-p (org-capture-get :target-entry-p)) (ind 0) beg end) (cond ((org-capture-get :exact-position) (goto-char (org-capture-get :exact-position))) ((not target-entry-p) ;; Insert as top-level entry, either at beginning or at end of file (setq beg (point-min) end (point-max))) (t (setq beg (1+ (point-at-eol)) end (save-excursion (outline-next-heading) (point) (if (org-capture-get :prepend) (progn (goto-char beg) (if (re-search-forward (concat ^ (org-item-re)) nil t) (progn (goto-char (match-beginning 0)) (setq ind (org-get-indentation))) (goto-char end) (setq ind 0))) (goto-char end) (if (re-search-backward (concat ^ (org-item-re)) nil t) (progn (setq ind (org-get-indentation)) (org-end-of-item)) (setq ind 0))) [...] the function needs to bound re-search-forward by END, and it needs to bound re-search-backward by BEG. As it stands right now, if the target location doesn't contain an item already, the function will happily pick the nearest list in a preceeding or following entry. Derek -- Derek Upham s...@blarg.net ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
