Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]
Alan Ristow writes: > Finally, as a newbie here myself, I have a naïve question of my own: > Provided the patch proves successful, how/when is it applied to the > official org repo? Is it up to Ihor (or somebody else) to make a pull > request, for example? An email with [PATCH] in header is the pull request for Org :) You can see a list of patches, confirmed bugs, and help requests in https://updates.orgmode.org/ The emails replying to the patch email are the comments to the pull request. The merge is up to Org maintainers. They patches are reviewed and merged as the maintainers get some free time to do it. Best, Ihor
Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]
On Tue, 13 Jul 2021 at 21:06, Alan Ristow wrote: > > Also, thanks to Ihor and Bhavin for your work on this. Prior to applying > the patch, I was noticing new bizarre behavior relating to recurring > tasks. I haven't been running the patched org very long yet, but so far, > so good. Thank you for confirming that it is working correctly for you. > Finally, as a newbie here myself, I have a naïve question of my own: > Provided the patch proves successful, how/when is it applied to the > official org repo? Is it up to Ihor (or somebody else) to make a pull > request, for example? >From my very little experience here, the patch will get reviewed by someone, and one of the maintainers (one with committer access) will merge/apply it in a few days. It might take more time as well. https://orgmode.org/worg/org-contribute.html#what-can-I-expect -- Bhavin Gandhi (bhavin192) | https://geeksocket.in
Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]
On 7/13/21 4:55 AM, Carlo Tambuatco wrote: Newbie question: what command do I use to apply the patch…? I can tell you what worked for me. I think you probably need to have cloned org using git for it to work, but I am far from being a git wiz so there could be a workaround I don't know about in the case that you have it installed by a more conventional method. First, I saved the patch file to the same directory where I have org cloned (for me, that is ~/.emacs.d/straight/repos/org). Then I opened a terminal and ran: git apply --check 0001-Fix-duplicate-logbook-entry-for-repeated-tasks.patch to do a dry run and make sure I had saved the patch file in the right place that "git apply" would run correctly. It returned nothing, which is good, so then I ran: git apply --check 0001-Fix-duplicate-logbook-entry-for-repeated-tasks.patch to apply the patch. Since I'm using straight.el as my package manager, I then opened Emacs and ran "M-x straight-rebuild-all". Also, thanks to Ihor and Bhavin for your work on this. Prior to applying the patch, I was noticing new bizarre behavior relating to recurring tasks. I haven't been running the patched org very long yet, but so far, so good. Finally, as a newbie here myself, I have a naïve question of my own: Provided the patch proves successful, how/when is it applied to the official org repo? Is it up to Ihor (or somebody else) to make a pull request, for example? Best regards, Alan
Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]
Newbie question: what command do I use to apply the patch…? > On Jul 12, 2021, at 1:50 PM, Bhavin Gandhi wrote: > > On Sun, 11 Jul 2021 at 06:59, Ihor Radchenko wrote: >> You are right. I believe that I fixed the breakage in the attached >> patch. Also, I noticed that c67037 did not fix the original bug when >> state change requests interactive note. > > Thanks! I tested your latest patch, and it is fixing both the original > issues which `c67037' solved as well as this one. > > I was trying to understand your change. So, when we call > `org-agenda-todo', it calls `org-todo' which adds the > post-command-hook. This hook is supposed to run when `org-agenda-todo' > finishes, but instead of that we call it directly. This makes sure that > the change is recorded in `buffer-undo-list'. > > Sorry if that's too much to ask, but why don't we need something similar > when org-log-note-how is 'note? Can you please help me understand that? > I tried reading org-add-log-note and org-store-log-note, but I think I'm > missing something basic here. > > Also, should this line from org.el (org-store-log-note) be removed? > > ;; Don't add undo information when called from `org-agenda-todo'. >
