Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank

[Ihor Radchenko]

Ihor Radchenko  writes:

>> The patch is against main only because it overlaps a region where bugfix
>> and main diverged.  I am willing to provide a similar patch against 
>> main.
>
> I do not think that we in a hurry to put this onto bugfix.
> Bugfix is just for trivial and critical fixes.
> https://orgmode.org/worg/org-maintenance.html#release-types
>
> Writing the whole extra alternative patch is probably too much to bother.

Since no concerns have been raised, I just applied the patch onto main.
Applied.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e58bbded5

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank

[Ihor Radchenko]

gerard.vermeu...@posteo.net writes:

>> I'd appreciate if other ob-lisp users could test the patch with both 
>> SLY
>> and SLIME.
>> 
>> I have no comments on the Elisp part of the patch.
>
> I have a few additional remarks:
>
> The patch is against main only because it overlaps a region where bugfix
> and main diverged.  I am willing to provide a similar patch against 
> main.

I do not think that we in a hurry to put this onto bugfix.
Bugfix is just for trivial and critical fixes.
https://orgmode.org/worg/org-maintenance.html#release-types

Writing the whole extra alternative patch is probably too much to bother.

> I hope that my mail reaches David (CC-ed d...@gnu.org  taken from the
> file header), but my previous message bounced (non-existent address).

I am CCing his alternative (AFAIK) email.
David, if you are still interested to deal with ob-lisp, we can update
the email.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank

[gerard . vermeulen]

On 29.03.2023 11:42, Ihor Radchenko wrote:

gerard.vermeu...@posteo.net writes:


The Emacs integrated development environments Slime and Sly
communicate by means of similar RPC protocols with different server
programs: Swank in case of Slime and Slynk in case of Sly.  However,
the code in org-babel-execute:lisp always expects to talk with Swank
because of the hard-coded call to swank:eval-and-grab-output.

After starting a Sly REPL, calls to swank:eval-and-grab-output do not
talk with the Slynk server started by the Sly REPL.

The attached patch "soft-codes" eval-and-grab-output to become
swank:eval-and-grab-output when using Slime and
slynk:eval-and-grab-output when using Sly.


I do not use ob-lisp, but this patch looks reasonable.

I'd appreciate if other ob-lisp users could test the patch with both 
SLY

and SLIME.

I have no comments on the Elisp part of the patch.


I have a few additional remarks:

The patch is against main only because it overlaps a region where bugfix
and main diverged.  I am willing to provide a similar patch against 
main.


I have installed Slime and Sly with the same user-emacs-directory using
package-install.  Normally, both autoload when doing M-x sly, but Sly
prompts you whether you want to disable Slime.  I choose "yes" to test
Sly.  I package-delete Sly when I want to test Slime.

See https://github.com/joaotavora/sly/blob/master/CONTRIBUTING.md
describes in detail how Sly uses the RPC protocol.

I hope that my mail reaches David (CC-ed d...@gnu.org  taken from the
file header), but my previous message bounced (non-existent address).

Best regards -- Gerard

Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank

[Ihor Radchenko]

gerard.vermeu...@posteo.net writes:

> The Emacs integrated development environments Slime and Sly
> communicate by means of similar RPC protocols with different server
> programs: Swank in case of Slime and Slynk in case of Sly.  However,
> the code in org-babel-execute:lisp always expects to talk with Swank
> because of the hard-coded call to swank:eval-and-grab-output.
>
> After starting a Sly REPL, calls to swank:eval-and-grab-output do not
> talk with the Slynk server started by the Sly REPL.
>
> The attached patch "soft-codes" eval-and-grab-output to become
> swank:eval-and-grab-output when using Slime and
> slynk:eval-and-grab-output when using Sly.

I do not use ob-lisp, but this patch looks reasonable.

I'd appreciate if other ob-lisp users could test the patch with both SLY
and SLIME.

I have no comments on the Elisp part of the patch.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

[PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank

[gerard . vermeulen]

Hello,

The Emacs integrated development environments Slime and Sly
communicate by means of similar RPC protocols with different server
programs: Swank in case of Slime and Slynk in case of Sly.  However,
the code in org-babel-execute:lisp always expects to talk with Swank
because of the hard-coded call to swank:eval-and-grab-output.

After starting a Sly REPL, calls to swank:eval-and-grab-output do not
talk with the Slynk server started by the Sly REPL.

The attached patch "soft-codes" eval-and-grab-output to become
swank:eval-and-grab-output when using Slime and
slynk:eval-and-grab-output when using Sly.

For more info: steps to test the patch are:
1. Open a Sly REPL with M-x sly
2. Look in the *sly-events for * ( is sbcl in my case) for
   slynk: prefixes
3. Type C-c C-c on the test block below
4. Look for an addition in *sly-events for * looking like
   (slynk:eval-and-grab-output "(let ((...)) (+ 1 1)\n)")

#+name: test-ob-lisp-with-sly
#+begin_src lisp -n :output results
(+ 1 1)
#+end_src

#+RESULTS: test-ob-lisp-with-sly
: 2

Best regards -- Gerard


0001-lisp-ob-lisp-fix-org-babel-execute-lisp-for-use-with.patch
Description: Binary data