Re: [PATCH] Silence a warning in org-table.el

[Bastien Guerry]

Ihor Radchenko  writes:

> It just _seems_ trivial. This innocently-looking patch will break tests.
>
> Duplicate of https://list.orgmode.org/orgmode/875y2oxfd8@red-bean.com/T/#u
> Canceled.

Doh!  And I already reverted this myself!  I'm getting old.

Thanks.

-- 
 Bastien Guerry

Re: [PATCH] Silence a warning in org-table.el

[Ihor Radchenko]

Bastien  writes:

> This seems trivial, if nobody bites I'll apply this tomorrow.

It just _seems_ trivial. This innocently-looking patch will break tests.

Duplicate of https://list.orgmode.org/orgmode/875y2oxfd8@red-bean.com/T/#u
Canceled.

And yes, it is annoying. Just not very clear how to address correctly.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

[PATCH] Silence a warning in org-table.el

[Bastien]

The attached patch silences a warning.

This seems trivial, if nobody bites I'll apply this tomorrow.

Thanks!

-- 
 Bastien
diff --git a/lisp/org-table.el b/lisp/org-table.el
index 0c2dc27ed..3d40a02a1 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -2887,7 +2887,7 @@ list, `literal' is for the format specifier L."
   (if lispp
 	  (if (eq lispp 'literal)
 	  elements
-	(if (and (eq elements "") (not keep-empty))
+	(if (and (string= elements "") (not keep-empty))
 ;; FIXME: This branch of `if' is never used because
 ;; strings are never `eq' here.  But changing to
 ;; `equal' breaks tests.