Re: [PATCH] org-element--current-element: Fix #+BEGIN$ parsed as special block

2022-05-14 Thread Ihor Radchenko
Nicolas Goaziou  writes:

> Hello,
>
> Ihor Radchenko  writes:
>
>> Nicolas,
>> Let me know if I miss something about special block parsing.
>
> LGTM! Thanks.

Applied onto main as e5e7ae36c.

I changed the patch as org-element-dynamic-block-open-re is matching
from bol.

Also, I fixed one broken test that assumed
#+BEGIN:
Paragraph
to be a full paragraph, not a sequence of keyword + paragraph.

Best,
Ihor



Re: [PATCH] org-element--current-element: Fix #+BEGIN$ parsed as special block

2021-12-26 Thread Nicolas Goaziou
Hello,

Ihor Radchenko  writes:

> Nicolas,
> Let me know if I miss something about special block parsing.

LGTM! Thanks.

Regards,
-- 
Nicolas Goaziou



[PATCH] org-element--current-element: Fix #+BEGIN$ parsed as special block

2021-12-26 Thread Ihor Radchenko
Robert Nikander  writes:

> Hitting TAB on the BEGIN line does nothing. But if I add a blank line before 
> it, then hitting TAB hides and shows the block. Is that a bug? Or am I doing 
> it wrong? Seems like it should work without the blank line.
>
> * Test
> Some text
>
> #+BEGIN 
> Hide this
> #+END
>
> M-x org-version => 9.5.1.

This last case is actually a bug. As Tomas pointed, Org blocks have
slightly different syntax: either #+begin_something or #+begin:
typeofblock. The fact that you can fold the #+BEGIN..#+END in your
second case should not happen.

The fix is attached.

Nicolas,
Let me know if I miss something about special block parsing.

Best,
Ihor

>From 289afdb9672eadaea119ebb2b0deecff4db3aa89 Mon Sep 17 00:00:00 2001
Message-Id: <289afdb9672eadaea119ebb2b0deecff4db3aa89.1640530104.git.yanta...@gmail.com>
From: Ihor Radchenko 
Date: Sun, 26 Dec 2021 22:45:36 +0800
Subject: [PATCH] org-element--current-element: Fix #+BEGIN$ parsed as special
 block

* lisp/org-element.el (org-element--current-element): Use
`org-element-dynamic-block-open-re' to match blocks.

Reported in https://list.orgmode.org/ycay4s3iadegs...@tuxteam.de/T/#t
---
 lisp/org-element.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-element.el b/lisp/org-element.el
index eac39d429..ce251da38 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -4266,7 +4266,7 @@ (defun org-element--current-element (limit  granularity mode structure
 	((looking-at "CALL:")
 		 (beginning-of-line)
 		 (org-element-babel-call-parser limit affiliated))
-	((looking-at "BEGIN:? ")
+	((looking-at org-element-dynamic-block-open-re)
 		 (beginning-of-line)
 		 (org-element-dynamic-block-parser limit affiliated))
 	((looking-at "\\S-+:")
-- 
2.32.0