Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match
On 2021-05-01, 18:06 +0200, Bastien wrote: > I let you and Nicolas move forward on separators guessing, because so > far I'm not really convinved Org should try to be too clever here. Yes! Nicolas has also convinced me on that front. There was some misunderstanding on my side as I was considering Elisp (my first Lisp) to be a general purpose language and Org tables it's CSV library. Even though due to the very nature of Lisp most of this possible but Org is not a right place for this. -- Utkarsh Singh http://utkarshsingh.xyz
Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match
Hi Utkarsh, Utkarsh Singh writes: > Actually, I proposed a revised patch in the following tread (which also > include more patches building up on this patch): > https://orgmode.org/list/87zgxpwqa7@gmail.com/T/#m38de818718a71f670fbc21b7abb8c789ef485181 thanks for the heads up. I thought applying this first patch would help clarify the discussion on this other thread, as the problem is different. I let you and Nicolas move forward on separators guessing, because so far I'm not really convinved Org should try to be too clever here. Thanks, -- Bastien
Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match
Hi Bastien, On 2021-05-01, 10:51 +0200, Bastien wrote: > Hi Utkarsh, > > Utkarsh Singh writes: > >> Can we give small flexibility in choosing the filename interactively for >> `org-table-import'? Currently org-table-import will just throw an error >> when file name doesn't have .txt, .csv or .tsv as extension. > > Applied in master as commit 7c99d1555, thanks. > > Please see the commit changelog for future patches: > https://code.orgmode.org/bzg/org-mode/commit/7c99d1555 > > Also https://orgmode.org/worg/org-contribute.html#commit-messages give > more detailed directions. Actually, I proposed a revised patch in the following tread (which also include more patches building up on this patch): https://orgmode.org/list/87zgxpwqa7@gmail.com/T/#m38de818718a71f670fbc21b7abb8c789ef485181 Btw, thank you for this and I will try to keep original tread updated from next time. -- Utkarsh Singh http://utkarshsingh.xyz
Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match
Hi Utkarsh, Utkarsh Singh writes: > Can we give small flexibility in choosing the filename interactively for > `org-table-import'? Currently org-table-import will just throw an error > when file name doesn't have .txt, .csv or .tsv as extension. Applied in master as commit 7c99d1555, thanks. Please see the commit changelog for future patches: https://code.orgmode.org/bzg/org-mode/commit/7c99d1555 Also https://orgmode.org/worg/org-contribute.html#commit-messages give more detailed directions. Thanks, -- Bastien
[PATCH] org-table-import: Give option to import interactively even if filename doesn't match
Hi, Can we give small flexibility in choosing the filename interactively for `org-table-import'? Currently org-table-import will just throw an error when file name doesn't have .txt, .csv or .tsv as extension. This patch tries to add a simple yes-and-no to let user choose if they want to continue importing or not. diff --git a/lisp/org/org-table.el b/lisp/org/org-table.el index 0e93fb271f..ab66859d6a 100644 --- a/lisp/org/org-table.el +++ b/lisp/org/org-table.el @@ -938,7 +938,8 @@ org-table-import - regexp When a regular expression, use it to match the separator." (interactive "f\nP") (when (and (called-interactively-p 'any) -(not (string-match-p (rx "." (or "txt" "tsv" "csv") eos) file))) +(not (string-match-p (rx "." (or "txt" "tsv" "csv") eos) file)) + (not (yes-or-no-p "File doesn't have .txt, .tsv or .csv as extension. Do you still want to continue? "))) (user-error "Cannot import such file")) (unless (bolp) (insert "\n")) (let ((beg (point)) -- Utkarsh Singh http://utkarshsingh.xyz
