Re: [O] [PATCH] Fix `org-capture-templates' type declaration

[Nicolas Goaziou]

Hello,

Grégoire Jadi  writes:

> The attached patch fix the type declaration of org-capture-templates by
> allowing the user to use file, variable, function and sexp as target's
> file to match the documentation

Thank you.

> - (file :tag "  File"))
> + (choice :tag "  File"
> + file variable function sexp))

Shouldn't there be an entry for each type instead of stuffing everything
within "File" descriptor ?


Regards,

-- 
Nicolas Goaziou

Re: [O] [PATCH] Fix `org-capture-templates' type declaration

[Grégoire Jadi]

Nicolas Goaziou writes:

> Hello,

Hi,

Thanks for the reply.

> Grégoire Jadi  writes:
>
>> The attached patch fix the type declaration of org-capture-templates by
>> allowing the user to use file, variable, function and sexp as target's
>> file to match the documentation
>
> Thank you.
>
>> -(file :tag "  File"))
>> +(choice :tag "  File"
>> +file variable function sexp))
>
> Shouldn't there be an entry for each type instead of stuffing everything
> within "File" descriptor ?

With my patch, the customization interface looks like this
- for a file :
Target location: Value Menu File:
  File: Value Menu File: ~/org/notes.org

- for a variable :
Target location: Value Menu File:
  File: Value Menu Variable: nil

- for a function :
Target location: Value Menu File:
  File: Value Menu Function: ignore

- for an Emacs Lisp form :
Target location: Value Menu File:
  File: Value Menu Lisp expression: nil

What kind of rendering do you think would be better/clearer?

Best,
> Regards,

-- 
Grégoire Jadi


signature.asc
Description: PGP signature

Re: [O] [PATCH] Fix `org-capture-templates' type declaration

[Grégoire Jadi]

Nicolas Goaziou writes:

> Grégoire Jadi  writes:
>
>> With my patch, the customization interface looks like this
>> - for a file :
>> Target location: Value Menu File:
>>   File: Value Menu File: ~/org/notes.org
>>
>> - for a variable :
>> Target location: Value Menu File:
>>   File: Value Menu Variable: nil
>>
>> - for a function :
>> Target location: Value Menu File:
>>   File: Value Menu Function: ignore
>>
>> - for an Emacs Lisp form :
>> Target location: Value Menu File:
>>   File: Value Menu Lisp expression: nil
>>
>> What kind of rendering do you think would be better/clearer?
>
> :tag " File" is misleading. Perhaps " File, variable, function or
> S-expression" would be clearer, if a bit longish.

That's too long IMHO.

> Not sure how to make this beast clearer anyway.

Me neither.

If anyone has an opinion on this, s/he is welcome!

This patch can wait a little until we find a satisfactory solution.
AFAIK noone has reported this bug :)


Best,

-- 
Grégoire Jadi


signature.asc
Description: PGP signature

Re: [O] [PATCH] Fix `org-capture-templates' type declaration

[Nicolas Goaziou]

Grégoire Jadi  writes:

> With my patch, the customization interface looks like this
> - for a file :
> Target location: Value Menu File:
>   File: Value Menu File: ~/org/notes.org
>
> - for a variable :
> Target location: Value Menu File:
>   File: Value Menu Variable: nil
>
> - for a function :
> Target location: Value Menu File:
>   File: Value Menu Function: ignore
>
> - for an Emacs Lisp form :
> Target location: Value Menu File:
>   File: Value Menu Lisp expression: nil
>
> What kind of rendering do you think would be better/clearer?

:tag " File" is misleading. Perhaps " File, variable, function or
S-expression" would be clearer, if a bit longish.

Not sure how to make this beast clearer anyway.


Regards,