Re: [O] [PATCH] Make `org-contacts-message-complete-function' work with byte compilation
Daimrod writes: @All: Can I use (require 'cl) and ignore the warning or is there better solution? You could if this would never go into mainline, where it is not allowed due to the namespace pollution that cl causes. You could use cl-lib instead, but then this would be an Emacs-24 only solution. In general, the stanza ((eval-when-compile (require 'cl)) only works as intended when you are only using cl macros, but you seem to use defuns. You could check how hard it is to replace these with plain elisp, aside from syntactical inconveniences this is usually not a big problem. Regards, Achim. -- +[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]+ SD adaptation for Waldorf Blofeld V1.15B11: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
Re: [O] [PATCH] Make `org-contacts-message-complete-function' work with byte compilation
Achim Gratz strom...@nexgo.de writes: Daimrod writes: @All: Can I use (require 'cl) and ignore the warning or is there better solution? You could if this would never go into mainline, where it is not allowed due to the namespace pollution that cl causes. You could use cl-lib instead, but then this would be an Emacs-24 only solution. In general, the stanza ((eval-when-compile (require 'cl)) only works as intended when you are only using cl macros, but you seem to use defuns. You could check how hard it is to replace these with plain elisp, aside from syntactical inconveniences this is usually not a big problem. I've done this, thanks for the advice. Regards, Achim. -- Daimrod/Greg pgp6UPcFcxhRs.pgp Description: PGP signature
Re: [O] [PATCH] Make `org-contacts-message-complete-function' work with byte compilation
Daimrod wrote: Achim Gratz strom...@nexgo.de writes: Daimrod writes: @All: Can I use (require 'cl) and ignore the warning or is there better solution? You could if this would never go into mainline, where it is not allowed due to the namespace pollution that cl causes. You could use cl-lib instead, but then this would be an Emacs-24 only solution. In general, the stanza ((eval-when-compile (require 'cl)) only works as intended when you are only using cl macros, but you seem to use defuns. You could check how hard it is to replace these with plain elisp, aside from syntactical inconveniences this is usually not a big problem. I've done this, thanks for the advice. I've just given the latest git HEAD version a spin and it seems to work as expected. Thanks for taking an interesting and fixing this so promptly. ;) Regards, Frank
Re: [O] [PATCH] Make `org-contacts-message-complete-function' work with byte compilation
Daimrod daim...@gmail.com writes: I've done this, thanks for the advice. Thanks for fixing this! And to Achim for the useful directions. -- Bastien
Re: [O] [PATCH] Make `org-contacts-message-complete-function' work with byte compilation
Frank Terbeck f...@bewatermyfriend.org writes: Hi Frank, Thank you for the report; however, I'm unsure about the right solution. There is a problem with the current (eval-when-compile ...) but there are still warnings when I compile it (with emacs -batch -f batch-byte-compile). In org-contacts-db-need-update-p: org-contacts.el:169:14:Warning: function `some' from cl package called at runtime In org-contacts-filter: org-contacts.el:211:37:Warning: function `some' from cl package called at runtime In org-contacts-test-completion-prefix: org-contacts.el:373:12:Warning: function `find-if' from cl package called at runtime In org-contacts-complete-name: org-contacts.el:445:71:Warning: function `remove-duplicates' from cl package called at runtime Those warnings disapear if I simply (require 'cl) at toplevel but it triggers this warning: org-contacts.el:40:1:Warning: cl package required at runtime @All: Can I use (require 'cl) and ignore the warning or is there better solution? -- Daimrod/Greg pgp2M1C9H7f_a.pgp Description: PGP signature
