Re: [O] [PATCH] org-edit-special too much space if starting with empty block
On Fri, Nov 30, 2012 at 9:23 PM, Nicolas Goaziou n.goaz...@gmail.com wrote: I've pushed your changes. Thank you. Btw, have you signed the FSF papers for larger patches? Thanks Nicolas. I have signed assignment papers for Emacs. -- Le
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Le Wang l26w...@gmail.com writes: Thanks Nicolas. I have signed assignment papers for Emacs. Great. I have added you to the list of contributors, in Worg. Regards, -- Nicolas Goaziou
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Nicolas Goaziou n.goaz...@gmail.com writes: Le Wang l26w...@gmail.com writes: Thanks Nicolas. I have signed assignment papers for Emacs. Great. I have added you to the list of contributors, in Worg. Note: I did not received confirmation from the FSF yet. Le, did you receive it? To be on the safe side, I try to add people on this list only with the FSF copyright clerk confirm the author status. Just double-checking. -- Bastien
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
On Thu, Dec 13, 2012 at 11:15 PM, Bastien b...@altern.org wrote: Nicolas Goaziou n.goaz...@gmail.com writes: Le Wang l26w...@gmail.com writes: Thanks Nicolas. I have signed assignment papers for Emacs. Great. I have added you to the list of contributors, in Worg. Note: I did not received confirmation from the FSF yet. Le, did you receive it? To be on the safe side, I try to add people on this list only with the FSF copyright clerk confirm the author status. Just double-checking. I'm not sure how to check, but I signed it and sent it back a while ago and got a confirmation e-mail from Donald on Aug 9. AFAIK everything is sorted. -- Le
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Le Wang l26w...@gmail.com writes: I'm not sure how to check, but I signed it and sent it back a while ago and got a confirmation e-mail from Donald on Aug 9. AFAIK everything is sorted. Okay, thanks for confirming! -- Bastien
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Le Wang writes: I'm not sure how to check, but I signed it and sent it back a while ago and got a confirmation e-mail from Donald on Aug 9. AFAIK everything is sorted. Did you just get a confirmation of receipt or a confirmation of the papers having been signed and accepted? If the latter, that email should have had a scan of those papers added as a PDF attachment. Regards, Achim. -- +[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]+ SD adaptations for KORG EX-800 and Poly-800MkII V0.9: http://Synth.Stromeko.net/Downloads.html#KorgSDada
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
On Fri, Dec 14, 2012 at 2:09 AM, Achim Gratz strom...@nexgo.de wrote: Le Wang writes: I'm not sure how to check, but I signed it and sent it back a while ago and got a confirmation e-mail from Donald on Aug 9. AFAIK everything is sorted. Did you just get a confirmation of receipt or a confirmation of the papers having been signed and accepted? If the latter, that email should have had a scan of those papers added as a PDF attachment. I have a signed and accepted PDF. Do you want me to do something with it? -- Le
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Le Wang l26w...@gmail.com writes: I have a signed and accepted PDF. Do you want me to do something with it? Nope, it is fine. Thanks Le! -- Bastien
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Le Wang l26w...@gmail.com writes: Has anyone had a chance to check this out? Others have run into this problem. I've pushed your changes. Thank you. Btw, have you signed the FSF papers for larger patches? Regards, -- Nicolas Goaziou
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Has anyone had a chance to check this out? Others have run into this problem. On Sun, Nov 18, 2012 at 1:49 PM, Le Wang l26w...@gmail.com wrote: On Fri, Nov 9, 2012 at 8:23 AM, Nicolas Goaziou n.goaz...@gmail.com wrote: Thank you for your patch. Would you mind adding comments in the function in order to explain the need for two pass. Also, you may want to reverse the if test in order to get rid of the progn. I've refactored and added comments. Finally, could you provide the patch as git format-patch and add a changelog entry to it? The patch is now in the requested format. If the commit message and inlined comments still aren't enough to explain the changes, please let me know. Thanks! -- Le -- Le
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
On Fri, Nov 9, 2012 at 8:23 AM, Nicolas Goaziou n.goaz...@gmail.com wrote: Thank you for your patch. Would you mind adding comments in the function in order to explain the need for two pass. Also, you may want to reverse the if test in order to get rid of the progn. I've refactored and added comments. Finally, could you provide the patch as git format-patch and add a changelog entry to it? The patch is now in the requested format. If the commit message and inlined comments still aren't enough to explain the changes, please let me know. Thanks! -- Le org-src.el.patch Description: Binary data
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Can someone take a look at these test cases and if this patch or some other fixes is appropriate? I use org-mode to take lots of notes of source code and this is annoying. On Mon, Nov 5, 2012 at 10:31 PM, Le Wang l26w...@gmail.com wrote: Some tests: Case 1: Start with emacs -Q I insert #+begin_src javascript #+end_src with point before #+end_src, I press C-c ' to start editing the source I enter foobar into the source buffer and immediately exit with C-c ' Case 2: restart with #+begin_src javascript #+end_src I've included a patch that fixes both issues. -- Le -- Le
Re: [O] [PATCH] org-edit-special too much space if starting with empty block
Hello, Le Wang l26w...@gmail.com writes: Some tests: Case 1: Start with emacs -Q I insert #+begin_src javascript #+end_src with point before #+end_src, I press C-c ' to start editing the source I enter foobar into the source buffer and immediately exit with C-c ' Case 2: restart with #+begin_src javascript #+end_src I've included a patch that fixes both issues. Thank you for your patch. Would you mind adding comments in the function in order to explain the need for two pass. Also, you may want to reverse the if test in order to get rid of the progn. Finally, could you provide the patch as git format-patch and add a changelog entry to it? Regards, -- Nicolas Goaziou
