Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[David Talmage]

On Sun, Nov 20, 2016 at 3:38 AM, Nicolas Goaziou 
wrote:

> Hello,
>
> "Charles C. Berry"  writes:
>
> > OTOH, (expand-file-name "test.txt") resolves double-slashes and seems
> > like the right idiom in any case.
>
> Fixed. Thank you.
>

It worked for me, too!  Thank you all!

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[Nicolas Goaziou]

Hello,

"Charles C. Berry"  writes:

> OTOH, (expand-file-name "test.txt") resolves double-slashes and seems
> like the right idiom in any case.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[Charles C. Berry]

On Sat, 19 Nov 2016, John Kitchin wrote:


I have also seen this error on my mac. I guess it is from the trailing
slash as you suggest:


echo $TMPDIR

/var/folders/5q/lllv2yf95hg_n6h6kjttbmdwgn/T/




So,

: testdir=${TMPDIR%/}/tmp-orgtest

in mk/default.mk would handle this on my mac, but I do not know if 
this is fully portable.


OTOH, (expand-file-name "test.txt") resolves double-slashes and seems like 
the right idiom in any case.


Chuck

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[John Kitchin]

I have also seen this error on my mac. I guess it is from the trailing
slash as you suggest:

> echo $TMPDIR
/var/folders/5q/lllv2yf95hg_n6h6kjttbmdwgn/T/


Achim Gratz writes:

> Charles C. Berry writes:
>> Doing this with `make test', I see that default-directory is let bound to
>>
>> "/var/folders/kb/2hchpbyj7lb6z76l0q73w_fhgn/T//tmp-orgtest/"
>>
>> and (concat default-directory "test.txt") will retain the double slash.
>
> Not to sound facetious, but it seems that the make variable testdir gets
> set to a path that has a trailing slash.  Fix that and the problem
> should go away (most likely TMPDIR has a trailing slash).  Check with
>
> : make config
>
> or even
>
> : make config-all
>
> that the variable is set correctly.
>
> Regards,
> Achim.


-- 
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[Achim Gratz]

Charles C. Berry writes:
> Doing this with `make test', I see that default-directory is let bound to
>
> "/var/folders/kb/2hchpbyj7lb6z76l0q73w_fhgn/T//tmp-orgtest/"
>
> and (concat default-directory "test.txt") will retain the double slash.

Not to sound facetious, but it seems that the make variable testdir gets
set to a path that has a trailing slash.  Fix that and the problem
should go away (most likely TMPDIR has a trailing slash).  Check with

: make config

or even

: make config-all

that the variable is set correctly.

Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[Charles C. Berry]

On Fri, 18 Nov 2016, Nicolas Goaziou wrote:


Hello,

"Charles C. Berry"  writes:


On Fri, 18 Nov 2016, Nicolas Goaziou wrote:


Hello,

David Talmage  writes:


I built org 9.0 on my Mac today.  'make test' reported one failed test.  I
don't know if it is important or not.  Please advise me.

'make test' said:

1 unexpected results:
   FAILED  test-ob/indented-cached-org-bracket-link




[snip]




Another option is to modify the test so it prints some useful debugging
information before failing (e.g., contents of default-directory and
return value of (org-babel-execute-src-block)).



Doing this with `make test', I see that default-directory is let bound to

"/var/folders/kb/2hchpbyj7lb6z76l0q73w_fhgn/T//tmp-orgtest/"

and (concat default-directory "test.txt") will retain the double slash.

The return value from the second (org-babel-execute-src-block) has only a 
single slash between 'T' and 'tmp'. Hence the failure.


When run interactively, there is no double slash and the test succeeds.

Using

: (expand-file-name "test.txt")

in place of

: (concat default-directory "test.txt)

cleans out the double slash and succeeds either with `make test' or 
interactively.


So, maybe make that change?

Chuck

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[Nicolas Goaziou]

Hello,

"Charles C. Berry"  writes:

> On Fri, 18 Nov 2016, Nicolas Goaziou wrote:
>
>> Hello,
>>
>> David Talmage  writes:
>>
>>> I built org 9.0 on my Mac today.  'make test' reported one failed test.  I
>>> don't know if it is important or not.  Please advise me.
>>>
>>> 'make test' said:
>>>
>>> 1 unexpected results:
>>>FAILED  test-ob/indented-cached-org-bracket-link
>>
>> Our build bot doesn't report this error and I cannot reproduce it
>> either. None of us is using a Mac, though.
>>
>
> I have a Mac and I *can* reproduce this running `make test'. But
> following the README for interactive testing, the test succeeds:
>
> Selector: test-ob/indented-cached-org-bracket-link
> Passed:  1
> Failed:  0
> Skipped: 0
> Total:   1/1
>
> I do not know what further steps to take to debug this.

You can mimic the test:
- create a new file in `temporary-file-directory'.
- insert 

  * Test
#+BEGIN_SRC emacs-lisp :file test.txt :cache yes
  (message "test")
#+END_SRC"

- Put point on "BEGIN"

- Call (org-babel-execute-src-block) and compare return value with
  (concat default-directory "test.text")


Another option is to modify the test so it prints some useful debugging
information before failing (e.g., contents of default-directory and
return value of (org-babel-execute-src-block)).


Regards,

-- 
Nicolas Goaziou

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[Charles C. Berry]

On Fri, 18 Nov 2016, Nicolas Goaziou wrote:


Hello,

David Talmage  writes:


I built org 9.0 on my Mac today.  'make test' reported one failed test.  I
don't know if it is important or not.  Please advise me.

'make test' said:

1 unexpected results:
   FAILED  test-ob/indented-cached-org-bracket-link


Our build bot doesn't report this error and I cannot reproduce it
either. None of us is using a Mac, though.



I have a Mac and I *can* reproduce this running `make test'. But following 
the README for interactive testing, the test succeeds:


Selector: test-ob/indented-cached-org-bracket-link
Passed:  1
Failed:  0
Skipped: 0
Total:   1/1

I do not know what further steps to take to debug this.

??

Chuck

Re: [O] Release 9.0 test failed: test-ob/indented-cached-org-bracket-link

[Nicolas Goaziou]

Hello,

David Talmage  writes:

> I built org 9.0 on my Mac today.  'make test' reported one failed test.  I
> don't know if it is important or not.  Please advise me.
>
> 'make test' said:
>
> 1 unexpected results:
>FAILED  test-ob/indented-cached-org-bracket-link

Our build bot doesn't report this error and I cannot reproduce it
either. None of us is using a Mac, though.


> Test test-ob/indented-cached-org-bracket-link condition:
> (ert-test-failed
>  ((should
>(let
>   (...)
> (org-test-with-temp-text "
> * Test
>   #+BEGIN_SRC emacs-lisp :file test.txt :cache yes
> (message \"test\")
>   #+END_SRC" ... ...)))
>   :form
>   (let
>  ((default-directory temporary-file-directory))
> (org-test-with-temp-text "
> * Test
>   #+BEGIN_SRC emacs-lisp :file test.txt :cache yes
> (message \"test\")
>   #+END_SRC"
>  (org-babel-execute-src-block)
>  (string= ... ...)))
>   :value nil))
>FAILED  166/670  test-ob/indented-cached-org-bracket-link

Unfortunately, the backtrace is missing important information. It might
be enlightening to know why (string= ... ...) returns nil, i.e., what
strings are compared.

Regards,

-- 
Nicolas Goaziou