Re: [PATCH] Fix some emacs-30 byte-compile warnings

[Ihor Radchenko]

Ihor Radchenko  writes:

> It is clearly a bug of some kind - the code is not doing what it
> intended originally. But we need to understand org-table.el better to
> fix this...

Upon further review, I dropped that branch of if completely.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=bd5665e01

No more warnings on main.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] Fix some emacs-30 byte-compile warnings

[Robert Pluim]

> On Fri, 17 Feb 2023 14:08:04 +, Ihor Radchenko  
> said:

Ihor> Robert Pluim  writes:
Ihor> 3 unexpected results:
Ihor> FAILED  test-org-table/copy-field
Ihor> FAILED  test-org-table/references/mode-string-N
Ihor> FAILED  test-org-table/references/mode-string-none
>> 
>> Hmm, at least the first one is because the code in the 't' branch of
>> (if (and (eq elements "") (not keep-empty))
>> 
>> in org-table-make-reference now runs, and it results in
>> 
>> (eval '(identity))'
>> 
>> Of course fixing that causes other problems 

Ihor> Meanwhile, I fixed all the other warnings.
Ihor> 
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eea8da0315b4d9c43272f4ee87d752e651f1a0c0
Ihor> Now, only this org-table problem remains.

Ihor> It is clearly a bug of some kind - the code is not doing what it
Ihor> intended originally. But we need to understand org-table.el better to
Ihor> fix this...

Iʼve not had time to look at it further (probably my subconscious not
wanting to deal with org-table.el :-))

Robert
-- 

Re: [PATCH] Fix some emacs-30 byte-compile warnings

[Ihor Radchenko]

Robert Pluim  writes:

> Ihor> 3 unexpected results:
> Ihor>FAILED  test-org-table/copy-field
> Ihor>FAILED  test-org-table/references/mode-string-N
> Ihor>FAILED  test-org-table/references/mode-string-none
>
> Hmm, at least the first one is because the code in the 't' branch of
>   (if (and (eq elements "") (not keep-empty))
>
> in org-table-make-reference now runs, and it results in
>
> (eval '(identity))'
>
> Of course fixing that causes other problems 

Meanwhile, I fixed all the other warnings.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eea8da0315b4d9c43272f4ee87d752e651f1a0c0
Now, only this org-table problem remains.

It is clearly a bug of some kind - the code is not doing what it
intended originally. But we need to understand org-table.el better to
fix this...

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] Fix some emacs-30 byte-compile warnings

[Robert Pluim]

> On Mon, 23 Jan 2023 14:04:42 +, Ihor Radchenko  
> said:

Ihor> Robert Pluim  writes:
>> The emacs 30 byte-compiler warns about uses of `eq'
>> and similar with constant strings which might have unintended
>> semantics. Patch is against emacs master.

Ihor> Thanks, but it will break some tests:

Ihor> 3 unexpected results:
Ihor>FAILED  test-org-table/copy-field
Ihor>FAILED  test-org-table/references/mode-string-N
Ihor>FAILED  test-org-table/references/mode-string-none

Hmm, at least the first one is because the code in the 't' branch of
(if (and (eq elements "") (not keep-empty))

in org-table-make-reference now runs, and it results in

(eval '(identity))'

Of course fixing that causes other problems 

Iʼll get back to this maybe tomorrow.

Robert
-- 

Re: [PATCH] Fix some emacs-30 byte-compile warnings

[Ihor Radchenko]

Robert Pluim  writes:

> The emacs 30 byte-compiler warns about uses of `eq'
> and similar with constant strings which might have unintended
> semantics. Patch is against emacs master.

Thanks, but it will break some tests:

3 unexpected results:
   FAILED  test-org-table/copy-field
   FAILED  test-org-table/references/mode-string-N
   FAILED  test-org-table/references/mode-string-none

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at