Re: [PATCH] org-manual.org: update and add info for arbitrary :float values

2022-02-15 Thread Nicolas Goaziou
Hello,

Juan Manuel Macías  writes:

> Ah, sorry, I hadn't noticed that :-). The thing is that I have in my
> ~/.emacs `sentence-end-double-space' set to nil.

Yes, .dir-locals.el files contains (sentence-end-double-space . t).
Somehow, you are not evaluating it.

>> However, isn't it a bug? Shouldn't t value default to "figure"
>> environment, if only for the sake of backward compatibility?
>
> I think you're right. t value should be figure and table, I agree. Would
> it be appropriate to add these two lines:
>
> In org-latex--inline-image:
>
> ((string= float "t") 'figure)
>
> And in org-latex--decorate-table
>
> ((string= float "t") "table")

I think so.

Regards,
-- 
Nicolas Goaziou



Re: [PATCH] org-manual.org: update and add info for arbitrary :float values

2022-02-13 Thread Juan Manuel Macías
Hi Nicolas,

Nicolas Goaziou writes:

> Thanks. Note you need to add two spaces between sentences.

Ah, sorry, I hadn't noticed that :-). The thing is that I have in my
~/.emacs `sentence-end-double-space' set to nil.

> However, isn't it a bug? Shouldn't t value default to "figure"
> environment, if only for the sake of backward compatibility?

I think you're right. t value should be figure and table, I agree. Would
it be appropriate to add these two lines:

In org-latex--inline-image:

((string= float "t") 'figure)

And in org-latex--decorate-table

((string= float "t") "table")

?

Best regards,

Juan Manuel 



Re: [PATCH] org-manual.org: update and add info for arbitrary :float values

2022-02-13 Thread Nicolas Goaziou
Hello,

Juan Manuel Macías  writes:

> Hi all,
>
> From the commit:
>
> e0bc2b37f :: lisp/ox-latex.el: Allow arbitrary float environments
>
> The `t' option for `:float' in tables and images is no longer valid.
> That is, something like
>
> #+ATTR_LaTeX: :float t
> [[file:foo.jpg]]
>
> would create in LaTeX export:
>
> \begin{t}
> \centering
> \includegraphics[width=.9\linewidth]{foo.jpg}
> \end{t}
>
> I am attaching a patch to update those changes to the Manual.

Thanks. Note you need to add two spaces between sentences.

However, isn't it a bug? Shouldn't t value default to "figure"
environment, if only for the sake of backward compatibility?

Regards,
-- 
Nicolas Goaziou