Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

[Ihor Radchenko]

Dmitry Logvinenko  writes:

> Thank you for your comments, fixed.

Thanks!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5b3a1a634

I also added you to the contributor list.
https://git.sr.ht/~bzg/worg/commit/d9174193

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

[Dmitry Logvinenko]

Thank you for your comments, fixed.


0001-lisp-org-habit.el-Inherit-habit-style-property.patch
Description: Binary data

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

[Ihor Radchenko]

Dmitry Logvinenko  writes:

> Subject: [PATCH] lisp/org-habit.el: Inherit habit style property
>
> * lisp/org-habit.el (org-is-habit-p):  Use `org-entry-get' with
> 'selective option to optionally find habit subheadings.
> * etc/ORG-NEWS: Describe a breaking change.

Thanks for the patch!
May I know if you have FSF copyright assignment?
If not, you need to add TINYCHANGE cookie to the commit message.
See https://orgmode.org/worg/org-contribute.html#first-patch

> --- a/etc/ORG-NEWS
> +++ b/etc/ORG-NEWS
> @@ -478,6 +478,18 @@ After:
>  : ("simple" "list")
>  #+end_src
>  
> +
> +*** =org-habit.el= now optionally inherits ~:STYLE: habit~ properties
> +
> +Currently, the ~STYLE~ property of habits is not inherited when searching
> +for entries.
> +
> +This change allows the property to be inherited optionally by customizing
> +the ~org-use-property-inheritance~ variable.
> +
> +This change aims to provide more flexibility in managing habits, allowing
> +users to dedicate separate subtrees or files to habits without manually
> +setting the ~STYLE~ property for each sub-task.

Please add this under Org 9.7. It is for main branch - next release.
Also, please mention that the change is breaking when
`org-use-property-inheritance' is set to t. This is important
information - we need to explain how the change can break existing configs.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

[Dmitry Logvinenko]

--
Dmitry Logvinenko // dmlogv


0001-lisp-org-habit.el-Inherit-habit-style-property.patch
Description: Binary data

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

[Ihor Radchenko]

Ihor Radchenko  writes:

> I am generally in favour of allowing STYLE to be inherited, but it is
> technically a breaking change, as I described.
>
> Let's see if anyone voices against this change.

No objections have been raised.

Dmitry, could you please create a proper patch, adding etc/ORG-NEWS
entry that describes the change (under " ... breaking changes" section),
and a proper commit message? See
https://orgmode.org/worg/org-contribute.html#first-patch

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at