Re: org-ctags-find-tag should not prompt inside org-open-at-point

2023-10-05 Thread Ihor Radchenko
Joseph Turner  writes:

>> We generally agree that (require 'org-ctags) should ideally not have
>> side effects, but do not want to introduce too breaking changes either.
>
> Does this mean that org-ctag's disruptive behavior will be fixed?

Yeah. But it is quite far down in my todo-list now (because not easy).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: org-ctags-find-tag should not prompt inside org-open-at-point

2023-09-28 Thread Joseph Turner


Rudolf Adamkovič  writes:

> Joseph Turner  writes:
>
>> (setopt org-ctags-open-link-functions nil)
>
> Oh, thank you!  This regularly drives me crazy.

You're welcome!

> I added the following to my Emacs/Org configuration:
>
> #+BEGIN_SRC emacs-lisp :results none
> (eval-after-load 'org-ctags
>   (setq org-ctags-open-link-functions nil))
> #+END_SRC

Yes, eval-after-load makes sense.

Joseph



Re: org-ctags-find-tag should not prompt inside org-open-at-point

2023-09-28 Thread Rudolf Adamkovič
Joseph Turner  writes:

> (setopt org-ctags-open-link-functions nil)

Oh, thank you!  This regularly drives me crazy.

I added the following to my Emacs/Org configuration:

#+BEGIN_SRC emacs-lisp :results none
(eval-after-load 'org-ctags
  (setq org-ctags-open-link-functions nil))
#+END_SRC

Rudy
-- 
"I love deadlines.  I love the whooshing noise they make as they go by."
-- Douglas Adams, The Salmon of Doubt, 2002

Rudolf Adamkovič  [he/him]
Studenohorská 25
84103 Bratislava
Slovakia



Re: org-ctags-find-tag should not prompt inside org-open-at-point

2023-09-26 Thread Joseph Turner


Ihor Radchenko  writes:

> Joseph Turner  writes:
>
>> When org-ctags-find-tag is a member of org-open-link-functions, fuzzy
>> links and custom-id links are broken. Instead of following those links,
>> Emacs prompts for a filename with "Visit tags table (default TAGS)".
>
> This is expected. As per org-ctags documentation:
>
> ;; By default, with org-ctags loaded, org will first try and visit the tag
> ;; with the same name as the link; then, if unsuccessful, ask the user if
> ;; he/she wants to rebuild the 'TAGS' database and try again; then ask if
> ;; the user wishes to append 'tag' as a new toplevel heading at the end of
> ;; the buffer; and finally, defer to org's default behavior which is to
> ;; search the entire text of the current buffer for 'tag'.
> ;;
> ;; This behavior can be modified by changing the value of
> ;; ORG-CTAGS-OPEN-LINK-FUNCTIONS.
>
>> I'm sure how org-ctags is getting required in my Emacs, but I think
>> (require 'org-ctags) probably shouldn't call org-ctags-enable.
>
> Check out
> https://list.orgmode.org/orgmode/87o7omg4ie@alphaville.usersys.redhat.com/

Thank you!! I'm glad to see such care taken in considering this issue!

> We generally agree that (require 'org-ctags) should ideally not have
> side effects, but do not want to introduce too breaking changes either.

Does this mean that org-ctag's disruptive behavior will be fixed?

Thanks!!

Joseph



Re: org-ctags-find-tag should not prompt inside org-open-at-point

2023-09-26 Thread Ihor Radchenko
Joseph Turner  writes:

> When org-ctags-find-tag is a member of org-open-link-functions, fuzzy
> links and custom-id links are broken. Instead of following those links,
> Emacs prompts for a filename with "Visit tags table (default TAGS)".

This is expected. As per org-ctags documentation:

;; By default, with org-ctags loaded, org will first try and visit the tag
;; with the same name as the link; then, if unsuccessful, ask the user if
;; he/she wants to rebuild the 'TAGS' database and try again; then ask if
;; the user wishes to append 'tag' as a new toplevel heading at the end of
;; the buffer; and finally, defer to org's default behavior which is to
;; search the entire text of the current buffer for 'tag'.
;;
;; This behavior can be modified by changing the value of
;; ORG-CTAGS-OPEN-LINK-FUNCTIONS.

> I'm sure how org-ctags is getting required in my Emacs, but I think
> (require 'org-ctags) probably shouldn't call org-ctags-enable.

Check out
https://list.orgmode.org/orgmode/87o7omg4ie@alphaville.usersys.redhat.com/

We generally agree that (require 'org-ctags) should ideally not have
side effects, but do not want to introduce too breaking changes either.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at