bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil

2022-05-10 Thread Kaushal Modi
done 55342

On Tue, May 10, 2022 at 1:06 AM Lars Ingebrigtsen  wrote:
>
> Ihor Radchenko  writes:
>
> > The code above always skips a bibtex entry starting at bob.
> > Hence, the provided example bibliography is parsed as empty, which is
> > not expected by Org.
>
> This should now be fixed on the trunk.

Thanks! I confirm the fix.





bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil

2022-05-10 Thread Eli Zaretskii
> From: Ihor Radchenko 
> Cc: Kaushal Modi ,  55...@debbugs.gnu.org
> Date: Tue, 10 May 2022 12:52:52 +0800
> 
> Eli Zaretskii  writes:
> 
> >> From: Kaushal Modi 
> >> Date: Mon, 9 May 2022 17:41:32 -0400
> >> 
> >> Exporting an Org file with citations on Emacs 29 now throws the error
> >> "Wrong value for ENTRY-OR-KEY: nil". This error can be reproduced with
> >> the Org version shipped with Emacs on the master branch.
> >
> > Shouldn't this be reported to Org developers first?
> 
> It has been.
> However, part of the problem lies in the bibtex-map-entries:
> 
>   ;; If we have invalid entries, ensure that we have forward
>   ;; progress so that we don't infloop.
>   (if (= (point) prev)
>   (forward-line 1)
> 
> The code above always skips a bibtex entry starting at bob.
> Hence, the provided example bibliography is parsed as empty, which is
> not expected by Org.

Thanks.  It would be nice to have that information included in the
original report.





bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil

2022-05-09 Thread Lars Ingebrigtsen
Ihor Radchenko  writes:

> The code above always skips a bibtex entry starting at bob.
> Hence, the provided example bibliography is parsed as empty, which is
> not expected by Org.

This should now be fixed on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil

2022-05-09 Thread Ihor Radchenko
Eli Zaretskii  writes:

>> From: Kaushal Modi 
>> Date: Mon, 9 May 2022 17:41:32 -0400
>> 
>> Exporting an Org file with citations on Emacs 29 now throws the error
>> "Wrong value for ENTRY-OR-KEY: nil". This error can be reproduced with
>> the Org version shipped with Emacs on the master branch.
>
> Shouldn't this be reported to Org developers first?

It has been.
However, part of the problem lies in the bibtex-map-entries:

  ;; If we have invalid entries, ensure that we have forward
  ;; progress so that we don't infloop.
  (if (= (point) prev)
  (forward-line 1)

The code above always skips a bibtex entry starting at bob.
Hence, the provided example bibliography is parsed as empty, which is
not expected by Org.

While handling empty bibfiles should be fixed on Org side, the current
behaviour of bibtex-map-entries should indeed be fixed on Emacs side.

Best,
Ihor





bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil

2022-05-09 Thread Eli Zaretskii
> From: Kaushal Modi 
> Date: Mon, 9 May 2022 17:41:32 -0400
> 
> Exporting an Org file with citations on Emacs 29 now throws the error
> "Wrong value for ENTRY-OR-KEY: nil". This error can be reproduced with
> the Org version shipped with Emacs on the master branch.

Shouldn't this be reported to Org developers first?

Thanks.