Re: cgit and merge commit

2023-01-24 Thread Ihor Radchenko
Max Nikulin  writes:

>> Should we then report a bug to cgit mailing list?
>
> I do not have particular opinion. I rarely use web UI for git and mostly 
> for blame. I prefer to do it with local clone. I have never read cgit 
> docs. Perhaps it may be more apparent that it is a merge commit.
>
> Anyway at first I would ask the savannah team. E.g. vanilla debbugs 
> instance is significantly more convenient than the GNU ones and the 
> changes in the latter are intentional. Mhonarc (list archive) at 
> lists.debian.org has better configuration than at lists.gnu.org as well. 
> So there might be specific of particular instance.

I asked savannah people, and they pointed out that the commits where, in
fact, listed in the logs. Just at their original creating dates - much
earlier than the merge commit date and further down into the logs.

So, it was mostly my oversight from the very beginning - nothing was
lost during the merge process.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



cgit and merge commit

2023-01-14 Thread Max Nikulin

On 14/01/2023 17:35, Ihor Radchenko wrote:

Max Nikulin writes:


So Matt did not squashed commits before committing to the main branch
and detailed commit messages are preserved. That is why I do not
consider cgit render as a strong enough reason for reverting.


Should we then report a bug to cgit mailing list?


I do not have particular opinion. I rarely use web UI for git and mostly 
for blame. I prefer to do it with local clone. I have never read cgit 
docs. Perhaps it may be more apparent that it is a merge commit.


Anyway at first I would ask the savannah team. E.g. vanilla debbugs 
instance is significantly more convenient than the GNU ones and the 
changes in the latter are intentional. Mhonarc (list archive) at 
lists.debian.org has better configuration than at lists.gnu.org as well. 
So there might be specific of particular instance.


After all, it may be convenient to review cumulative changes. When I 
worked with gerrit (a web application for code review) sometimes it was 
inconvenient that it was impossible to see diff for whole commit series.