Re: Graphics files in archives cannot be toggled to display image or code
Thanks. ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 04.04.2006 um 15:53 schrieb Richard Stallman: I am starting and I am observing with some files, when I toggle from the initial image to the code view and then back to image, only code is shown, and it's only a part of the code that is displayed. This failure has gone after applying your last patch! -- Greetings Pete “One cannot live by television, video games, top ten CDs, and dumb movies alone” (Amiri Baraka 1999) ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 04.04.2006 um 15:53 schrieb Richard Stallman: Does this handle tar mode as well as arc mode? After a configure and 'make bootstrap' it still works! In a TAR file and in a ZIP archive. -- Greetings Pete ~ o ~_\\_/\ ~ O O ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 04.04.2006 um 15:53 schrieb Richard Stallman: Does this handle tar mode as well as arc mode? *** image-mode.el 11 Feb 2006 11:43:50 -0500 1.10 --- image-mode.el 03 Apr 2006 23:35:43 -0400 *** *** 139,145 ;; was inserted (let* ((image (if (and (buffer-file-name) !(not (buffer-modified-p))) (progn (clear-image-cache) (create-image (buffer-file-name))) (create-image --- 139,149 ;; was inserted (let* ((image (if (and (buffer-file-name) !(not (buffer-modified-p)) !(not (and (boundp 'archive-superior-buffer) ! archive-superior-buffer)) !(not (and (boundp 'tar-superior-buffer) ! tar-superior-buffer))) (progn (clear-image-cache) (create-image (buffer-file-name))) (create-image This patch indeed makes it right! But before I worked on a problem with Carbon Emacs and received from Takashi Hiromatsu the recommendation to use -DUSE_ATSUI in CFLAGS. So I configured again and just invoked 'make -k' because no Elisp code was updated. And this version of the X11 client GNU Emacs does not fail any more. I'll configure again without -DUSE_ATSUI and do a 'make bootstrap' -- which takes more than hour! I removed some days ago image-mode.elc when I found that image-mode is loaded when needed, not part of the dumped Emacs. Byte-recompile- directory never compiled any Elisp file. Is that correct? -- Greetings Pete Globalisation -- socialism from above. ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
I am starting and I am observing with some files, when I toggle from the initial image to the code view and then back to image, only code is shown, and it's only a part of the code that is displayed. Please examine what the buffer contents are that cause this result. ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Does this handle tar mode as well as arc mode? *** image-mode.el 11 Feb 2006 11:43:50 -0500 1.10 --- image-mode.el 03 Apr 2006 23:35:43 -0400 *** *** 139,145 ;; was inserted (let* ((image (if (and (buffer-file-name) !(not (buffer-modified-p))) (progn (clear-image-cache) (create-image (buffer-file-name))) (create-image --- 139,149 ;; was inserted (let* ((image (if (and (buffer-file-name) !(not (buffer-modified-p)) !(not (and (boundp 'archive-superior-buffer) ! archive-superior-buffer)) !(not (and (boundp 'tar-superior-buffer) ! tar-superior-buffer))) (progn (clear-image-cache) (create-image (buffer-file-name))) (create-image ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 01.04.2006 um 15:45 schrieb Richard Stallman: Can you debug why it fails? It ought to work. It works with ZIP archives that open in archive-mode. TAR files open in tar-mode. In image-mode.el we have now: 140 (let* ((image 141 (if (and (buffer-file-name) 142(not (buffer-modified-p)) 143(not (and (boundp 'archive-superior-buffer) 144 archive-superior-buffer))) 145 (progn (clear-image-cache) 146 (create-image (buffer-file-name))) 147 (create-image 148 (string-make-unibyte 149 (buffer-substring-no-properties (point-min) (point-max))) 150 nil t))) Archive-superior-buffer is set by ZIP archives, so they are treated differently here with clear-image-cache and clear-image. Or TAR files are treated that way -- I don't understand the code, but here's the difference that might explain why image-mode works for ZIP archives and not for TAR files. Well, that's actually your patch ... One thing this patch achieves is that *Messages* does not contain any more Cannot find image file `/Users/pete/Quellen/Emacs_CVS/ graphics_test_tar/images.tar!image.xbm' [2 times] Cannot find image file `/Users/pete/Quellen/Emacs_CVS/ graphics_test_tar/images.tar!image.xpm' [2 times] -- Greetings Pete Increase the size of your bike by at least *five* inches ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 01.04.2006 um 15:45 schrieb Richard Stallman:
Can you debug why it fails?
It ought to work.
I am starting and I am observing with some files, when I toggle from
the initial image to the code view and then back to image, only code
is shown, and it's only a part of the code that is displayed. It
happens with JPG, PGM, PPM, TIFF. With XPM the columns are "encoded"
as lines, and I mean encoded:
/* XPM */
static char *image[] = {
/* width height num_colors chars_per_pixel */
"8880 2562",
/* colors */
".. c #040909",
".# c #748774",
".a c #bcc6a0",
".b c #414629",
".c c #ac946c",
".d c #dce6bc",
becomes
"aV#.#.bj.i#.an.p.B#Pabbj#.#.aLbj.E.E#2an#f.I#Uan#XacacaLbR#HaV.E#MbIa1
aW.jbX#Na5#wb.#w#1.za5#K.Haoapap..bY#x#x#l#F#R#F.#bk.j#o#N.H#F#R.N.E.EaG
bVa.#N.w.H.Ha.#5#5.VaV#HaVaVaVaVaV",
"#.a3#.abbnaMb0.i.BaM.i.i.BbMaM.iaMb2.L#U#AaE#2#0bR#HaLaV#H#.#H.Ba.#o#o
bua5a5bhb3a5#lao.HbJ#D.w.Ta5aAbmaA#laAapaN.Ybnbhbt#Nbub3#QbY#5.W#B#X#0.B
bW.4#Qat#Q#Q#Qb3ao.Tac#HaV#HaVaVaV",
"aVaVaLanbW.Cbe#Fbyby#F.zbV.C.C.C#M#M#Mbe#faE.E.6aLaVaVaV#HaL.
6.i#Q.G#ibq#i#ibq#i..#i.Gbz.H#D#w.Hbm#x.T.Vby#lbYbq.Ybn#l.G#lbh.l.G#x.z#
2#Xa7.Q.E#R#l#Q..#ibq..#i#Qaj#0aVaVaV#HaVaV",
--
Greetings
Pete
There's no sense in being precise when you don't
even know what you're talking about.
-- John von Neumann
___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 02.04.2006 um 22:38 schrieb Richard Stallman: (By the way, what is a "quadratic frame"?) Four lines that build a square. This had always the same size, independent from the graphics size. -- Greetings Pete "Let's face it; we don't want a free market economy either." James Farley, president, Coca-Cola Export Corp., 1959 ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
(Isn't it time to add some JPEG2000 support with the help of libjasper?) If it is simple, we could add it now if someone sends a patch. Otherwise it might be better to wait for after the release. ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Before your eMail arrived I wondered whether my yesterday 'make -k' really made a new image-mode.elc file, so I invoked 'make clean ; The recommended way is to use M-x byte-recompile-directory on the `lisp' directory. In the tar file, x-symbol-4.51-src.tar.gz, the XBM and XPM images in x- symbol/etc only show up as quadratic frames. Can you debug why it fails on those files? That surprises me, because this change ought to handle all cases. (By the way, what is a "quadratic frame"?) ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 01.04.2006 um 15:45 schrieb Richard Stallman: No, it does not: I still see only empty frames (in bold magenta for xbm in tar, in black for tiff or gif in zip) and the JPEG file does not switch to the frame, i.e. I see only file's code from the start. (No more tries.) Can you debug why it fails? It ought to work. Before your eMail arrived I wondered whether my yesterday 'make -k' really made a new image-mode.elc file, so I invoked 'make clean ; make -k' -- and it *partially* really works: in the ZIP file I can see GIF, JPEG, and TIFF images and toggle between this and the code view more than once and I either see the image or its code. In the tar file, x-symbol-4.51-src.tar.gz, the XBM and XPM images in x- symbol/etc only show up as quadratic frames. In a different tar file, digit-src-2_12.tar.gz, I could view GIF, PNG, and JPEG files. I could toggle to the code view. The next toggle made a frame appear. More toggles with C-c C-c only switched between the frame and the code view. Next week I could start to understand image-mode.el and make a plan. Actually, I have no other idea than to create a tar file with image files of all types and then create from this also differently compressed versions ... and of course some other types of archives (p7zip seems to support a few different formats like arc, arj, lha ...) (Isn't it time to add some JPEG2000 support with the help of libjasper?) -- Greetings <] Pete o__o |__o recumbo ___o/I -\<, |o \ -\),-% ergo sum! ___/\ /\___./ \___...O/ O.`-O-'-()--o_ ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
No, it does not: I still see only empty frames (in bold magenta for xbm in tar, in black for tiff or gif in zip) and the JPEG file does not switch to the frame, i.e. I see only file's code from the start. (No more tries.) Can you debug why it fails? It ought to work. ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Am 31.03.2006 um 05:10 schrieb Richard Stallman: Does this patch fix the problem? No, it does not: I still see only empty frames (in bold magenta for xbm in tar, in black for tiff or gif in zip) and the JPEG file does not switch to the frame, i.e. I see only file's code from the start. (No more tries.) I launched GNU Emacs as src/emacs -Q. -- Greetings Pete Behold the warranty ... the bold print giveth and the fine print taketh away. ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Graphics files in archives cannot be toggled to display image or code
Does this patch fix the problem? *** image-mode.el 11 Feb 2006 11:43:50 -0500 1.10 --- image-mode.el 30 Mar 2006 11:37:37 -0500 *** *** 139,145 ;; was inserted (let* ((image (if (and (buffer-file-name) !(not (buffer-modified-p))) (progn (clear-image-cache) (create-image (buffer-file-name))) (create-image --- 139,147 ;; was inserted (let* ((image (if (and (buffer-file-name) !(not (buffer-modified-p)) !(not (and (boundp 'archive-superior-buffer) ! archive-superior-buffer))) (progn (clear-image-cache) (create-image (buffer-file-name))) (create-image ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Graphics files in archives cannot be toggled to display image or code
Hello! In dired-mode a graphics file can be viewed. Instantly one either sees the code or the image, C-c C-c toggles the view between code and image, as often as one wants without failures. PNG, TIFF, GIF, XPM, XBM files from a (compressed) tape archive (tar file) when toggled from code view to image view show only a frame of the image's dimensions, but not the image inside it. The code view is OK. Viewing GIF and TIFF files in a ZIP archive I only get the frame (although it instantly should display the image), viewing a JPG file I instantly get the code presented. Pressing C-c C-c I see in mini- buffer: "Repeat this command to go back to displaying the file as text" without any change. Again the code view is OK. Looking into the *Messages* buffer I see: Cannot find image file `/Volumes/Halde/_neu/x-symbol-4.51-src.tar.gz! x-symbol/etc/RIP.xbm' [2 times] Cannot find image file `/Volumes/Halde/_neu/ texshopsource.zip:texshopsource/DrawerToggleToolbarImage.tiff' [2 times] This also happens so in GNU Emacs 23.0.0. Launching both with -Q makes no difference. In GNU Emacs 22.0.50.1 (powerpc-apple-darwin8.5.0, X toolkit, Xaw3d scroll bars) of 2006-03-26 on localhost X server distributor `The XFree86 Project, Inc', version 11.0.4040 configured using `configure '--without-sound' '--without-pop' '--with- xpm' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' '--enable- locallisppath=/Library/Application Support/Emacs/calendar22:/Library/ Application Support/Emacs/preview:/Library/Application Support/Emacs/ auctex/images:/Library/Application Support/Emacs/auctex:/Library/ Application Support/Emacs' 'CFLAGS=-ggdb -O2 -pipe -faltivec - maltivec -mabi=altivec -mcpu=7450 -no-cpp-precomp -fomit-frame- pointer -foptimize-register-move -fcprop-registers -frename-registers -freorder-blocks -fpeephole -mpowerpc-gfxopt -mpowerpc-gpopt' 'CPPFLAGS=-I/usr/local/include -I/sw/include/libpng12 -I/sw/lib/pango- ft219/include -I/sw/include/pango-1.0 -I/sw/lib/freetype219/include - I/sw/include' 'LDFLAGS=-dead_strip -L/usr/X11R6/lib -L/usr/local/lib - L/sw/lib/ncurses -L/sw/lib/freetype219/lib -L/sw/lib/pango-ft219/lib - L/sw/lib'' Important settings: value of $LC_ALL: de_DE.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: de_DE.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8 default-enable-multibyte-characters: t Major mode: Image Minor modes in effect: desktop-save-mode: t display-time-mode: t show-paren-mode: t tooltip-mode: t auto-compression-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t view-mode: t -- Mit friedvollen Grüßen Pete "Specifications are for the weak and timid!" ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
