Re: [PATCH] Fix connection problems for XEmacs/MULE.

2000-05-22 Thread Kai Großjohann

"Daniel Pittman" [EMAIL PROTECTED] writes:

 Hrm. In that case, since it seems to be biting me, I might put in some
 effort to learning how MULE works and implementing it properly for RCP.
 Assuming you don't object, of course.

I would be very happy if you were to help with that.  Thanks!

kai
-- 
Beware of flying birch trees.




[PATCH] Fix connection problems for XEmacs/MULE.

2000-05-21 Thread Daniel Pittman

The attached patch makes the connection setup work for me under
XEmacs/MULE. Simply put, I presume that the system I am talking to is
going to have dos-style line enders, and set the coding system for
reading to match that.

This shouldn't hurt anything under non-MULE code, being as it binds a
variable for the duration of the 'start-process' call.

Still, I don't want to commit this without knowing that it at least
works for a few people, and I really /don't/ understand how the MULE
integration has been done in rcp.

Given a little time I will probably get off my backside and try to
understand it, then make sure that it gets to be working quite right
under XEmacs.  Er, hang on... I will have to get /on/ my backside and...
;)

Anyway, comments?
Daniel



Index: rcp.el
===
RCS file: /services/emacs-rcp/cvsroot/rcp/lisp/rcp.el,v
retrieving revision 1.342
diff -u -u -p -r1.342 rcp.el
--- rcp.el	2000/05/21 00:03:25	1.342
+++ rcp.el	2000/05/21 10:59:41
@@ -2992,6 +2992,7 @@ must specify the right method in the fil
 (rcp-pre-connection multi-method method user host)
 (rcp-message 7 "Opening connection for %s@%s using %s..." user host method)
 (let* ((default-directory (rcp-temporary-file-directory))
+	   (coding-system-for-read 'undecided-dos)
(p (apply #'start-process
  (rcp-buffer-name multi-method method user host)
  (rcp-get-buffer multi-method method user host)



-- 
The problem with defending the purity of the English language is that English
is about as pure as a cribhouse whore. We don't just borrow words; on
occasion, English has pursued other languages down alleyways to beat them
unconscious and rifle their pockets for new vocabulary.
-- James D. Nicoll



Re: [PATCH] Fix connection problems for XEmacs/MULE.

2000-05-21 Thread Daniel Pittman

On Sun, 21 May 2000, Kai Großjohann [EMAIL PROTECTED]
wrote:

 Daniel Pittman [EMAIL PROTECTED] writes:
 
 Still, I don't want to commit this without knowing that it at least
 works for a few people, and I really /don't/ understand how the MULE
 integration has been done in rcp.
 
 Well, that makes two of us...

Hrm. In that case, since it seems to be biting me, I might put in some
effort to learning how MULE works and implementing it properly for RCP.
Assuming you don't object, of course.

 MULE comes into play in different places, but for the shell buffer,
 I'm basically hoping that the MULE machinery does everything right
 automatically.  

Seems not to, at least for me. It keeps deciding on 'undecided-mac' as
the coding system, which is just wrong.

[...]

 [looks into the code]
 
 Oops!  Where did that `echo foo ; echo bar' go?  Surely searching for
 ^M characters won't work unless there's at least one line ending in
 the buffer.
 
 Will try to change this now -- can you test it to see if it works,
 Daniel?

Er, no. Still fails, in the same way as previously. Darn.

Daniel

-- 
He who cannot change the very fabric of his thought will never be able to
change reality, and will never, therefore, make any progress.
-- Anwaar Sadat