Re: [Engine-devel] Vm nic active boolean should be converted to status/state=active
Hi, I believe we should save the REST API behavior and keep using status object instead of activetrue/active for vm nics. We should use: status stateactivestate /status Active is a binary state, why would we need a multi-state representation for it? Many rest frameworks works around that status object in order to verify element state and we shouldn't change that behavior. This is true also for hotplug disk Avi Tal Red Hat tlv ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Vm nic active boolean should be converted to status/state=active
Avi Tal Red Hat tlv - Original Message - From: Mike Kolesnik mkole...@redhat.com To: Avi Tal a...@redhat.com Cc: engine-devel@ovirt.org Sent: Thursday, June 14, 2012 10:34:32 AM Subject: Re: [Engine-devel] Vm nic active boolean should be converted to status/state=active Hi, I believe we should save the REST API behavior and keep using status object instead of activetrue/active for vm nics. We should use: status stateactivestate /status Active is a binary state, why would we need a multi-state representation for it? The way i see it (as a REST API user) active/deactive are states just like up/down. If i would like to verify the nic active state i would go to the nic state just as simple as it sound. I can't see any good reason way defining it different then host state or DataCenter state or even storage state. Many rest frameworks works around that status object in order to verify element state and we shouldn't change that behavior. This is true also for hotplug disk Avi Tal Red Hat tlv ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Forking unit tests
- Original Message - From: Roy Golan rgo...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, June 13, 2012 4:14:06 PM Subject: Re: [Engine-devel] Forking unit tests On 06/13/2012 03:41 PM, Laszlo Hornyak wrote: We can just move the surefire config to a higher level in the pom hierarchy, but that makes the tests slower globaly. It is more work, but we could help Allon to rewrite the Powermock tests :-) And then the surefire settings could be removed and the tests will run quick again. great job. I think that any further effort we want to put in refactoring the tests must be in abstracting the code *first* i.e creating facade + interfaces + getters instead of static calling classes (Backend, Config, DbFacade ...) . that way we can avoid a lot of mocking code (mkublin we can remove a lot of code here!) +gazilion. - Original Message - From: Yair Zaslavskyyzasl...@redhat.com To: Mike Kolesnikmkole...@redhat.com Cc: engine-develengine-devel@ovirt.org Sent: Wednesday, June 13, 2012 1:44:39 PM Subject: Re: [Engine-devel] Forking unit tests On 06/13/2012 01:28 PM, Mike Kolesnik wrote: Hi guys, If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others. Over the past month or so I've been working on removing PowerMock from as many places as possible (many thanks to mkolesni and lhornyak!), and we've got to the stage that forking is only needed in to subprojects - bll and resttypes. +1 - great job! +1 Would it be possible to have this as a parameter (defaul true) that can be overridden, such as -Dengine.forkTests=false ?+ +1 - good idea. The forking was defined explicitly in those two projects, so if you want to speed up your tests, just take the latest version of settings.xml from http://ovirt.org/wiki/Building_oVirt_engine#Maven_personal_settings. -Allon ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] oVirt UI: Legacy UserPortal removed
Hi, A visualization of how that counts (from sonar) https://twitter.com/kozka/status/213229060103483392/photo/1 Laszlo - Original Message - From: Vojtech Szocs vsz...@redhat.com To: engine-devel@ovirt.org Sent: Thursday, June 14, 2012 12:55:18 PM Subject: [Engine-devel] oVirt UI: Legacy UserPortal removed Hi everyone, please note that the original (SmartGWT-based) UserPortal application has been removed from oVirt repository, as part of patch [http://gerrit.ovirt.org/5317]. This has no impact on the current UserPortal application, which is part of the standard oVirt Maven build. Please let me know if you have any questions. Thanks, Vojtech ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] oVirt UI: Legacy UserPortal removed
awesome! - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Vojtech Szocs vsz...@redhat.com, engine-devel@ovirt.org Sent: Thursday, June 14, 2012 2:29:40 PM Subject: Re: [Engine-devel] oVirt UI: Legacy UserPortal removed Hi, A visualization of how that counts (from sonar) https://twitter.com/kozka/status/213229060103483392/photo/1 Laszlo - Original Message - From: Vojtech Szocs vsz...@redhat.com To: engine-devel@ovirt.org Sent: Thursday, June 14, 2012 12:55:18 PM Subject: [Engine-devel] oVirt UI: Legacy UserPortal removed Hi everyone, please note that the original (SmartGWT-based) UserPortal application has been removed from oVirt repository, as part of patch [http://gerrit.ovirt.org/5317]. This has no impact on the current UserPortal application, which is part of the standard oVirt Maven build. Please let me know if you have any questions. Thanks, Vojtech ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] What BlockMigrationOnSwapUsagePercentage
Hi guys I got the following error message when I tried to run a VM: VM's swap percentage is above the threshold. (check your configuration parameters for Host Swap Percentage). After increasing the parameter BlockMigrationOnSwapUsagePercentage, the problem disappeared. But I don't understand the logic here: IsVMSwapValueLegal return ((swap_total - swap_free - mem_available) * 100 / physical_mem_mb) = Config .Integer GetValue(ConfigValues.BlockMigrationOnSwapUsagePercentage); So anyone can help me explain it? Thanks a lot! Mark. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] What BlockMigrationOnSwapUsagePercentage
On 06/14/2012 04:59 PM, Mark Wu wrote: Hi guys I got the following error message when I tried to run a VM: VM's swap percentage is above the threshold. (check your configuration parameters for Host Swap Percentage). After increasing the parameter BlockMigrationOnSwapUsagePercentage, the problem disappeared. But I don't understand the logic here: IsVMSwapValueLegal return ((swap_total - swap_free - mem_available) * 100 / analyzing this... how much memory swap has minus how much is still available gives the amount of swap used then subtract the amount of RAM available - since it won't require swap for that amount of RAM. that's gives how much swap is used (taking into consideration available RAM) as a percentage from physical memory yes, could be written in a more readable way. physical_mem_mb) = Config .Integer GetValue(ConfigValues.BlockMigrationOnSwapUsagePercentage); So anyone can help me explain it? Thanks a lot! Mark. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] reasonable, the actual size are unchanged during create virtual Disk,
1. add a 110GB disk and the format of disk is Preallocated. during the status is locked, the actual size are unchanged, always is 1 GB. but the the free space is decreasing, at the same time. IMO, the total actual size should be equal to what the free space decreased. and I check the web browser display refresh rate is 5 seconds. 2.another one. Is bootable and Is bootable are check box in the pop-up dialogue of Add virtual Disk but error when select both. Error: Cannot add Virtual Machine Disk. Low disk space on relevant Storage Domain. is this reasonable? ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] oVirt UI: Legacy UserPortal removed
AWESOME !!! +0, -76860 - Original Message - From: Allon Mureinik amure...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel@ovirt.org Sent: Thursday, June 14, 2012 4:28:05 PM Subject: Re: [Engine-devel] oVirt UI: Legacy UserPortal removed awesome! - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Vojtech Szocs vsz...@redhat.com, engine-devel@ovirt.org Sent: Thursday, June 14, 2012 2:29:40 PM Subject: Re: [Engine-devel] oVirt UI: Legacy UserPortal removed Hi, A visualization of how that counts (from sonar) https://twitter.com/kozka/status/213229060103483392/photo/1 Laszlo - Original Message - From: Vojtech Szocs vsz...@redhat.com To: engine-devel@ovirt.org Sent: Thursday, June 14, 2012 12:55:18 PM Subject: [Engine-devel] oVirt UI: Legacy UserPortal removed Hi everyone, please note that the original (SmartGWT-based) UserPortal application has been removed from oVirt repository, as part of patch [http://gerrit.ovirt.org/5317]. This has no impact on the current UserPortal application, which is part of the standard oVirt Maven build. Please let me know if you have any questions. Thanks, Vojtech ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
