Re: [Engine-devel] Proposal to make REST API more webapp-friendly
Thanks Antoni, the article essentially documents the (complete) lack of confidentiality protection for the transmitted credentials in Basic Auth protocol. Base64 encoding is neither encryption nor hashing so it's pretty much the same as plaintext. To be fair, with HTTPS, the confidentiality issue of Basic Auth protocol is mitigated. This means Basic Auth should only be used with HTTPS. At the end of the article, the author proposes exactly what I wrote some time ago: "collect auth information, hash (sign) it with a private key, and send everything to server". (In the article, it's mentioned as "HMAC-SHA" technique.) Vojtech - Original Message - From: "Antoni Segura Puimedon" To: "engine-devel" Sent: Wednesday, April 24, 2013 3:11:33 PM Subject: Re: [Engine-devel] Proposal to make REST API more webapp-friendly Incidentally, the other day reading hacker news I happened upon a similar discussion and article. It might be an interesting lecture to put in perspective our own discussion: article: http://swaggadocio.com/post/48223179207/why-the-hell-does-your-api-still-use-http-basic-auth discussion: https://news.ycombinator.com/item?id=5569625 - Original Message - > From: "Vojtech Szocs" > To: "Oved Ourfalli" > Cc: "Juan Hernandez" , "engine-devel" > > Sent: Wednesday, April 17, 2013 3:08:31 PM > Subject: Re: [Engine-devel] Proposal to make REST API more webapp-friendly > > Hi Oved, > > >> The only difference would be, when REST API receives the request, it looks > >> for "Prefer:use-jsessionid-header", and if it's present, it uses > >> "JSESSIONID" header value to look up HttpSession in some way (not sure > >> about > >> implementation details, though, but this should be possible to do). > >> > >> So, what do you think? > >> > > As far as I saw, the handling of the cookie is done before the REST code, > > and that's why we need the cookie. > > Perhaps there is a way to make jboss take the JSESSIONID from the HTTP > > header, and not the cookie, but I didn't find a way to do that yet. > > I'm also not sure about this, so far I've only found: > http://stackoverflow.com/questions/5807664/tomcat-how-to-access-session-manager-from-servlet > > It seems that the solution is to either provide custom session manager > implementation in JBoss, or to obtain standard session manager early when > processing request and create session manually there. > > Vojtech > > > - Original Message - > From: "Oved Ourfalli" > To: "Vojtech Szocs" > Cc: "Juan Hernandez" , "engine-devel" > > Sent: Wednesday, April 17, 2013 12:29:09 PM > Subject: Re: [Engine-devel] Proposal to make REST API more webapp-friendly > > > > - Original Message - > > From: "Vojtech Szocs" > > To: "Oved Ourfalli" > > Cc: "Juan Hernandez" , "engine-devel" > > > > Sent: Wednesday, April 17, 2013 1:25:06 PM > > Subject: Re: [Engine-devel] Proposal to make REST API more webapp-friendly > > > > Hi Oved, thanks for your feedback! > > > > > We currently return the JSESSIONID also using HTTP headers. We currently > > > return the jsession id also as part of the response HTTP headers, but the > > > client still needs to pass a cookie with the appropriate value in order > > > for the REST session to work. Isn't that enough to cope with this issue? > > > > Right, currently REST API responds with JSESSIONID cookie + separate > > JSESSIONID response header, both carrying session ID value. > > > > As I wrote in my original email: JavaScript running at > > [http://example.com/webapp] *cannot* get/set cookies from requests at > > [http://example.com/restapi] > > > > So WebAdmin cannot get/set REST API JSESSIONID cookie directly, which is > > why > > it uses separate JSESSIONID response header in order to *read* the session > > ID value. As for sending JSESSIONID cookie, WebAdmin currently relies on > > standard cookie-handling implemented in browsers: all cookies for location > > X > > [http://example.com/restapi] will be part of any request to location X. So > > it's the browser who sets JSESSIONID cookie for REST API request, not > > WebAdmin. > > > > To answer your question, currently it's enough to work around the cookie > > access limitation, but it's not good enough in my opinion (from > > JavaScript/webapp perspective).. > > > > > If not, then we might be able to do option #2: > > > Today, we keep the engine session ID on the HTTP session attributes. > > > So, we can support either passing the cookie with the JSESSIONID (taking > > > the engine session ID from the http session), or passing the engine > > > session ID as HTTP header (assuming we would also return the engine > > > session ID upon first REST request). > > > > Well, the problem I described only relates to the way how JSESSIONID value > > is > > transmitted between client and server: currently using cookies, so REST API > > client has to do cookie handling. > > > > It would be really great if I could tell REST API to use plain (i.
[Engine-devel] UiCommon models in UserPortal - note about optimization logic
Hi, recently we faced an issue [1] where UserPortal UI refresh optimization logic [2] interfered with direct UiCommon model updates. The optimization logic compares freshly received data with existing data and doesn't trigger UI refresh when there's no change. This inherently implies that UiCommon SearchableListModel shouldn't manipulate its item data directly, or it risks the situation when the optimization logic thinks there's no change (data retrieved from server matches updated item data). (Possible improvement: add "dirty" flag to item model type (UserPortalItemModel) that would be called when UiCommon SearchableListModel does direct item manipulation.) Vojtech [1] http://gerrit.ovirt.org/#/c/14148/ [2] AbstractUserPortalListProvider.updateDataProvider method override ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Proposal to make REST API more webapp-friendly
Incidentally, the other day reading hacker news I happened upon a similar discussion and article. It might be an interesting lecture to put in perspective our own discussion: article: http://swaggadocio.com/post/48223179207/why-the-hell-does-your-api-still-use-http-basic-auth discussion: https://news.ycombinator.com/item?id=5569625 - Original Message - > From: "Vojtech Szocs" > To: "Oved Ourfalli" > Cc: "Juan Hernandez" , "engine-devel" > > Sent: Wednesday, April 17, 2013 3:08:31 PM > Subject: Re: [Engine-devel] Proposal to make REST API more webapp-friendly > > Hi Oved, > > >> The only difference would be, when REST API receives the request, it looks > >> for "Prefer:use-jsessionid-header", and if it's present, it uses > >> "JSESSIONID" header value to look up HttpSession in some way (not sure > >> about > >> implementation details, though, but this should be possible to do). > >> > >> So, what do you think? > >> > > As far as I saw, the handling of the cookie is done before the REST code, > > and that's why we need the cookie. > > Perhaps there is a way to make jboss take the JSESSIONID from the HTTP > > header, and not the cookie, but I didn't find a way to do that yet. > > I'm also not sure about this, so far I've only found: > http://stackoverflow.com/questions/5807664/tomcat-how-to-access-session-manager-from-servlet > > It seems that the solution is to either provide custom session manager > implementation in JBoss, or to obtain standard session manager early when > processing request and create session manually there. > > Vojtech > > > - Original Message - > From: "Oved Ourfalli" > To: "Vojtech Szocs" > Cc: "Juan Hernandez" , "engine-devel" > > Sent: Wednesday, April 17, 2013 12:29:09 PM > Subject: Re: [Engine-devel] Proposal to make REST API more webapp-friendly > > > > - Original Message - > > From: "Vojtech Szocs" > > To: "Oved Ourfalli" > > Cc: "Juan Hernandez" , "engine-devel" > > > > Sent: Wednesday, April 17, 2013 1:25:06 PM > > Subject: Re: [Engine-devel] Proposal to make REST API more webapp-friendly > > > > Hi Oved, thanks for your feedback! > > > > > We currently return the JSESSIONID also using HTTP headers. We currently > > > return the jsession id also as part of the response HTTP headers, but the > > > client still needs to pass a cookie with the appropriate value in order > > > for the REST session to work. Isn't that enough to cope with this issue? > > > > Right, currently REST API responds with JSESSIONID cookie + separate > > JSESSIONID response header, both carrying session ID value. > > > > As I wrote in my original email: JavaScript running at > > [http://example.com/webapp] *cannot* get/set cookies from requests at > > [http://example.com/restapi] > > > > So WebAdmin cannot get/set REST API JSESSIONID cookie directly, which is > > why > > it uses separate JSESSIONID response header in order to *read* the session > > ID value. As for sending JSESSIONID cookie, WebAdmin currently relies on > > standard cookie-handling implemented in browsers: all cookies for location > > X > > [http://example.com/restapi] will be part of any request to location X. So > > it's the browser who sets JSESSIONID cookie for REST API request, not > > WebAdmin. > > > > To answer your question, currently it's enough to work around the cookie > > access limitation, but it's not good enough in my opinion (from > > JavaScript/webapp perspective).. > > > > > If not, then we might be able to do option #2: > > > Today, we keep the engine session ID on the HTTP session attributes. > > > So, we can support either passing the cookie with the JSESSIONID (taking > > > the engine session ID from the http session), or passing the engine > > > session ID as HTTP header (assuming we would also return the engine > > > session ID upon first REST request). > > > > Well, the problem I described only relates to the way how JSESSIONID value > > is > > transmitted between client and server: currently using cookies, so REST API > > client has to do cookie handling. > > > > It would be really great if I could tell REST API to use plain (i.e. *not* > > Set-Cookie & Cookie) HTTP header, for example "JSESSIONID", for the purpose > > of transmitting session ID value between client and server. > > > > For example, the request to acquire session would be: > > > > GET /api HTTP/1.1 > > Host: www.example.org > > Prefer: use-jsessionid-header > > JSESSIONID: xxx > > > > [Feel free to replace "use-jsessionid-header" with anything you like. If > > client doesn't specify "use-jsessionid-header", server expects "Cookie" > > header by default to preserve compatibility.] > > > > And the response would be: > > > > HTTP/1.1 200 OK > > JSESSIONID: xxx > > > > [If client didn't specify "use-jsessionid-header", server would use > > "Set-Cookie" header by default to preserve compatibility.] > > > > > This approach is problematic, as it might work well now,
Re: [Engine-devel] find-bugs errors - please investigate/fix
thanks for the fix. Also, finally we see some progress on the 'low' priority bugs, fixing 337, which now stands on ~1600 instead of ~1900... http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/findbugsResult/? Eyal. - Original Message - > From: "Einav Cohen" > To: "Sahina Bose" , "Michal Skrivanek" > , "Tal Nisan" > > Cc: "engine-devel" , "Eyal Edri" > Sent: Wednesday, April 24, 2013 3:48:34 PM > Subject: Re: [Engine-devel] find-bugs errors - please investigate/fix > > it seems that after the fixes and clean-up, find-bugs is now back to normal: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/ > > all - many thanks for your prompt response! > > > Regards, > Einav > > - Original Message - > > From: "Einav Cohen" > > To: "Sahina Bose" , "Michael Kublin" > > , "Michal Skrivanek" > > , "Eyal Edri" > > Cc: "engine-devel" > > Sent: Tuesday, April 23, 2013 10:17:20 PM > > Subject: [Engine-devel] find-bugs errors - please investigate/fix > > > > ovirt find-bugs errors in jenkins - please investigate/fix asap. > > [@Eyal - FYI: some of them seem really strange - see Michal's section > > below] > > > > @Sahina Bose: > > find-bugs error details: > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 > > caused by: http://gerrit.ovirt.org/#/c/13831/ > > > > @Michael Kublin: > > find-bugs error details: > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 > > caused by: > > http://gerrit.ovirt.org/#/c/13740/ > > > > @Michal Skrivanek: > > > > the following seem strange - can you please investigate? could be false > > positives. > > > > - find-bugs error details: > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 > > [not sure when introduced - seems old, hence I suspect it is a false > > positive] > > > > - Two additional errors in the same file as ^^^, you can see them at: > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ > > when clicking on them, there aren't any details, however according to their > > tool-tips, it seems to be an "unreachable > > OnSuccess method within an anonymous class" or something similar. > > > > - another suspicious error is in VmListModel.java: > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 > > [again - not sure when introduced - seems old, hence I suspect it is a > > false > > positive] > > > > > > Thanks, > > Einav > > ___ > > Engine-devel mailing list > > Engine-devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
it seems that after the fixes and clean-up, find-bugs is now back to normal: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/ all - many thanks for your prompt response! Regards, Einav - Original Message - > From: "Einav Cohen" > To: "Sahina Bose" , "Michael Kublin" , > "Michal Skrivanek" > , "Eyal Edri" > Cc: "engine-devel" > Sent: Tuesday, April 23, 2013 10:17:20 PM > Subject: [Engine-devel] find-bugs errors - please investigate/fix > > ovirt find-bugs errors in jenkins - please investigate/fix asap. > [@Eyal - FYI: some of them seem really strange - see Michal's section below] > > @Sahina Bose: > find-bugs error details: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 > caused by: http://gerrit.ovirt.org/#/c/13831/ > > @Michael Kublin: > find-bugs error details: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 > caused by: > http://gerrit.ovirt.org/#/c/13740/ > > @Michal Skrivanek: > > the following seem strange - can you please investigate? could be false > positives. > > - find-bugs error details: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 > [not sure when introduced - seems old, hence I suspect it is a false > positive] > > - Two additional errors in the same file as ^^^, you can see them at: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ > when clicking on them, there aren't any details, however according to their > tool-tips, it seems to be an "unreachable > OnSuccess method within an anonymous class" or something similar. > > - another suspicious error is in VmListModel.java: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 > [again - not sure when introduced - seems old, hence I suspect it is a false > positive] > > > Thanks, > Einav > ___ > Engine-devel mailing list > Engine-devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] find-bugs errors - please investigate/fix
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Database Caching
Hi I've created Change I04d7edea (http://gerrit.ovirt.org/#/c/14188/) that adds automatic database caching capabilities to the engine. To cache a business entity, just add an annotation called TimeToLiveInCache that accepts as a parameter the number of seconds this object can live in the cache until it is refreshed from the database. The next stage is improving the cache update mechanism, using Infinispan, and the ability to capture more query types. Would love input and suggestions. Thanks, Liran ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
I've seen it too, it's after a series of patches I pushed to solve some findbugs issue that we got this false positive, I've asked Eyal to clean the target, it seems that findbugs is referring to old code that doesn't exist anymore. On 04/24/2013 10:11 AM, Michal Skrivanek wrote: On Apr 24, 2013, at 07:49 , Sahina Bose wrote: On 04/24/2013 07:47 AM, Einav Cohen wrote: ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
Seems that the cleanup worked, now the actual results after the frontend cleanup pathces are shown without the false positives http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4069/ On 04/24/2013 10:11 AM, Michal Skrivanek wrote: On Apr 24, 2013, at 07:49 , Sahina Bose wrote: On 04/24/2013 07:47 AM, Einav Cohen wrote: ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
On 04/24/2013 07:47 AM, Einav Cohen wrote: ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
On Apr 24, 2013, at 07:49 , Sahina Bose wrote: > > On 04/24/2013 07:47 AM, Einav Cohen wrote: >> ovirt find-bugs errors in jenkins - please investigate/fix asap. >> [@Eyal - FYI: some of them seem really strange - see Michal's section below] >> >> @Sahina Bose: >> find-bugs error details: >> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 >> caused by: http://gerrit.ovirt.org/#/c/13831/ > Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. > Thanks! >> >> @Michael Kublin: >> find-bugs error details: >> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 >> caused by: >> http://gerrit.ovirt.org/#/c/13740/ >> >> @Michal Skrivanek: >> >> the following seem strange - can you please investigate? could be false >> positives. >> >> - find-bugs error details: >> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 >> [not sure when introduced - seems old, hence I suspect it is a false >> positive] >> >> - Two additional errors in the same file as ^^^, you can see them at: >> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ >> when clicking on them, there aren't any details, however according to their >> tool-tips, it seems to be an "unreachable >> OnSuccess method within an anonymous class" or something similar. >> >> - another suspicious error is in VmListModel.java: >> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 >> [again - not sure when introduced - seems old, hence I suspect it is a false >> positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused >> >> >> Thanks, >> Einav > ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
