Re: [Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-11 Thread Livnat Peer
On 06/10/2013 07:46 PM, Doron Fediuck wrote:
 
 
 - Original Message -
 From: Giuseppe Vallarelli gvall...@redhat.com
 To: Dan Kenigsberg dan...@redhat.com
 Cc: engine-devel@ovirt.org
 Sent: Monday, June 10, 2013 6:04:27 PM
 Subject: Re: [Engine-devel] Add traffic shaping parameters for a network 
 interface.

 - Original Message -
 | From: Dan Kenigsberg dan...@redhat.com
 | To: Giuseppe Vallarelli gvall...@redhat.com
 | Cc: engine-devel@ovirt.org
 | Sent: Monday, June 10, 2013 4:22:54 PM
 | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
 | interface.
 | 
 | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote:
 |  Hi Guys, I've recently submitted a patch to support traffic shaping for a
 |  network interface (http://gerrit.ovirt.org/#/c/15445/).
 |  This work is needed in order to support
 |  http://www.ovirt.org/Features/Network_QoS .
 |  Given:
 |  
 |  'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst':
 |  '1024'},
 | 'outbound': {'average': '128', 'burst': '256'}}}
 |  
 |  Generated xml is the following one:
 |  
 |  
 |  
 |  
 |  
 |  
 |  As you can see I tried to keep the data structure as flat as possible
 |  having the bandwidth element not carrying any useful information.
 |  Feedback is highly appreciated.
 |  
 | 
 | The issue has not been mentioned on the wiki page, but may need a means
 | to report the currently-configured QoS of each vNIC from Vdsm to Engine.
 | For example, when a VM is de-hibernated, we may want to tell whether its
 | QoS needs to be set according to a recently-tweaked policy.
 | 
 | I suggest that we use the getVmList verb of Vdsm, which is intended to
 | report static properties of one Vm (or all of them).
 | 
 | On the other hand, Engine would want to blindly set new values whenever
 | in doubt. In such a case, I think that reporting of QoS can be avoided.
 | 
 | Dan.
 | 

 I'm not sure I've understood completely the issue in discussion, doesn't the
 engine knows already
 which are the QoS profile applied to each vNIC ? The last 'tweaked' profile
 is the one that should
 be applied after de-hibernation. This means that on the engine side we should
 keep track of profile
 change, if a change happens de-hibernating a vm triggers a QoS profile update
 on the host of the
 latest profile. I'm not aware of the implementation details so I might be
 wrong.

 Giuseppe.
 
 The idea is to handle scenarios where something went wrong;
 For example, VDSM crash while starting a new VM, engine crash, etc.
 So the engine should be able to ask for current QoS for reporting,
 and (re-)apply it if out of sync.


In addition, if we change the VNIC profile we do not require the VMs
that are using this profile to be down.
Now we can reach a state were the profile is configured for one thing
and the VMs using this profile are running with another value.

At least we would like the user to be aware of that.
I'm not sure if we'd like to sync it automatically. I would start only
with exposing this information to our administrator.

Livnat




 ___
 Engine-devel mailing list
 Engine-devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 

___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] Ovirt live build failure

2013-06-11 Thread Ohad Basan
Hello everyone.

The jenkins ovirt live job is failing due to libvirt dependency:

Error creating Live CD : Failed to build transaction : 
vdsm-4.11.0-28.git634b9f4.fc18.x86_64 requires libvirt = 1.0.2-1

http://jenkins.ovirt.org/job/ovirt_live_create_iso/151/artifact/ovirt-live-1.0.0-0.1.master.20130611.gitc7da94a.log


Does anyone have an idea how to solve it?
the only thing I thought about is compiling libvirt from source in the job 
itself.

Thanks

Ohad
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Guest Reboot

2013-06-11 Thread Michal Skrivanek

On Jun 10, 2013, at 21:20 , David Jaša dj...@redhat.com wrote:

 Hi Martin,
 
 there may be more kinds of reboot in context of RHEV: warm reboot that
 keeps qemu process intact, or cold that would involve qemu process
 termination and start of new one - and this could be done with keeping
 of current configuration, or with applying settings that take effect
 after reboot that have changed during VM runtime; and all of these can
 be soft - when the guest OS reboots itself and hard when you perform
 the reboot right away.
we plan to have 2 of them which seem to make most sense
warm without applying config changes and keeping qemu process (i.e. also 
keeps Run Once,Stateless, pooled VM config/state)
cold which kills qemu and is completely driven by Engine, and applies config 
changes
and a policy option in VM properties to specify whether you should forcibly 
proceed with reboot/shutdown when graceful methods fail/timeout

is there anything not covered for a typical user? We intentionally don't want 
to provide all possible options, just those making sense. The feature is about 
providing a convenient shortcut.

Thanks,
michal

 
 All of these have their use cases, so it should be documented what will
 you implement, and you may expect somebody asking you to implement the
 rest. ;)
 
 David
 
 
 Martin Betak píše v Pá 07. 06. 2013 v 12:32 -0400:
 Hi, engine-devel
 
 Customers request the ability to reboot a VM with a single click so I 
 started designing the overall architecture and planing out the required 
 changes to the respective components. 
 You can find the wiki page for the initial draft at [1] and I would like to 
 ask you for your input on my general design and potential issues that could 
 arise in some corner cases.
 Please feel free to respond to this thread or add to the Issues section of 
 [1].
 
 Thanks in advance for your opinions :-)
 
 Martin
 
 [1] http://www.ovirt.org/Features/Guest_Reboot
 ___
 Engine-devel mailing list
 Engine-devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 
 -- 
 
 David Jaša, RHCE
 
 SPICE QE based in Brno
 GPG Key: 22C33E24 
 Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24
 
 
 ___
 Engine-devel mailing list
 Engine-devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel

___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Guest Reboot

2013-06-11 Thread David Jaša
Hi,

Michal Skrivanek píše v Út 11. 06. 2013 v 10:19 +0200:
 On Jun 10, 2013, at 21:20 , David Jaša dj...@redhat.com wrote:
 
  Hi Martin,
  
  there may be more kinds of reboot in context of RHEV: warm reboot that
  keeps qemu process intact, or cold that would involve qemu process
  termination and start of new one - and this could be done with keeping
  of current configuration, or with applying settings that take effect
  after reboot that have changed during VM runtime; and all of these can
  be soft - when the guest OS reboots itself and hard when you perform
  the reboot right away.
 we plan to have 2 of them which seem to make most sense
 warm without applying config changes and keeping qemu process (i.e. also 
 keeps Run Once,Stateless, pooled VM config/state)
 cold which kills qemu and is completely driven by Engine, and applies 
 config changes
 and a policy option in VM properties to specify whether you should forcibly 
 proceed with reboot/shutdown when graceful methods fail/timeout
 
 is there anything not covered for a typical user? 

I think you covered it all. Based on the original emails by Martin, I
presumed you only covered warm reboot, having cold reboot available
as well is cool.

David

 We intentionally don't want to provide all possible options, just those 
 making sense. The feature is about providing a convenient shortcut.
 
 Thanks,
 michal
 
  
  All of these have their use cases, so it should be documented what will
  you implement, and you may expect somebody asking you to implement the
  rest. ;)
  
  David
  
  
  Martin Betak píše v Pá 07. 06. 2013 v 12:32 -0400:
  Hi, engine-devel
  
  Customers request the ability to reboot a VM with a single click so I 
  started designing the overall architecture and planing out the required 
  changes to the respective components. 
  You can find the wiki page for the initial draft at [1] and I would like 
  to ask you for your input on my general design and potential issues that 
  could arise in some corner cases.
  Please feel free to respond to this thread or add to the Issues section of 
  [1].
  
  Thanks in advance for your opinions :-)
  
  Martin
  
  [1] http://www.ovirt.org/Features/Guest_Reboot
  ___
  Engine-devel mailing list
  Engine-devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/engine-devel
  
  -- 
  
  David Jaša, RHCE
  
  SPICE QE based in Brno
  GPG Key: 22C33E24 
  Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24
  
  
  ___
  Engine-devel mailing list
  Engine-devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/engine-devel
 
 ___
 Engine-devel mailing list
 Engine-devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel

-- 

David Jaša, RHCE

SPICE QE based in Brno
GPG Key: 22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24




smime.p7s
Description: S/MIME cryptographic signature
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Guest Reboot

2013-06-11 Thread Omer Frenkel


- Original Message -
 From: Martin Betak mbe...@redhat.com
 To: Omer Frenkel ofren...@redhat.com
 Cc: engine-devel@ovirt.org
 Sent: Monday, June 10, 2013 1:29:29 PM
 Subject: Re: [Engine-devel] Guest Reboot
 
 
 
 
 
 - Original Message -
  From: Omer Frenkel ofren...@redhat.com
  To: Martin Betak mbe...@redhat.com
  Cc: engine-devel@ovirt.org
  Sent: Sunday, June 9, 2013 8:51:54 AM
  Subject: Re: [Engine-devel] Guest Reboot
  
  As i understand it, reboot will do shutdown and initiate a run-command in
  order to send any updated parameters,
  if this is correct, why vdsm and GA need to know its a reboot? guest is
  shutting down, no?
 
 Well in some cases where the VM configuration hasn't changed we can do
 graceful reboot using
 libvirt acpi reboot capabilities  via guest agent (by just passing different
 option to the existing shutdown script).
 This preserves the qemu process and can be more efficient than the destroy();
 start() sequence.
 Of course if it were the case that the guest would not respond to graceful
 method of reboot and the
 power-down policy for this VM hard, the engine would fall back to the
 destroy(); start() sequence.
 Otherwise (graceful-only reboot policy) we would leave the guest alone -
 status UP.
 

ok maybe worth adding this info to the wiki,
although currently there is no way to know if configuration has changed or not,
but should be something like this soon (RFE for changing running vm 
configuration)

  
  it would be better to add some info on stateless issue: when stateless vm
  goes down, its state is cleared,
  so need to decide if reboot to stateless means also start with new state or
  no.
 
 I think this issue is similar to the Run-Once question.
 Do we want to give the user another option to choose from or do we pick one
 for him?
 
  
  similar is vm from pool: when vm from automatic pool goes down, it
  returns
  to the pool, and not belong to a specific user anymore,
  also here the state is cleared, so again need to understand the correct
  behaviour
  
 
 In the case of vm from pool the state treatment should be the same as in
 stateless but we also need
 to run the stop(); start() sequence in a transaction to make sure nobody else
 can steal this machine from this user.
 Or possibly since pool-VM configuration cannot change we could perhaps do the
 reboot only using the new vdsm capabilities.
 Do you think this would be possible or the engine would notice that the VM
 went Down for a brief moment?

engine have to identify the vm as down before starting it again..

 Maybe a new VM state Rebooting instead of Down would help in this case?
 

not sure this is the best approach, need to do some thinking about this
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] xml rpc exceptions

2013-06-11 Thread Laszlo Hornyak
hi,

When starting my VM's I get a strange XML RPC error.

org.xml.sax.SAXException: Serializable objects aren't supported, if 
isEnabledForExtensions() == false
org.apache.xmlrpc.common.XmlRpcExtensionException: Serializable objects aren't 
supported, if isEnabledForExtensions() == false

Looks like it is trying to send a Serializable object as parameter to the VDSM, 
but it is not able to do so. Is anyone handling this issue?

Thx,
Laszlo
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] xml rpc exceptions

2013-06-11 Thread Laszlo Hornyak
Got it, after Icada39e3918fb053cb0ad0388178ccf5c6338ca2 watchdog devices are 
attempted to send to vdsm as enum instead of string. Looks like it only happens 
to watchdogs, I will send a fix soon.

Laszlo

- Original Message -
 From: Laszlo Hornyak lhorn...@redhat.com
 To: engine-devel engine-devel@ovirt.org
 Sent: Tuesday, June 11, 2013 1:23:33 PM
 Subject: [Engine-devel] xml rpc exceptions
 
 hi,
 
 When starting my VM's I get a strange XML RPC error.
 
 org.xml.sax.SAXException: Serializable objects aren't supported, if
 isEnabledForExtensions() == false
 org.apache.xmlrpc.common.XmlRpcExtensionException: Serializable objects
 aren't supported, if isEnabledForExtensions() == false
 
 Looks like it is trying to send a Serializable object as parameter to the
 VDSM, but it is not able to do so. Is anyone handling this issue?
 
 Thx,
 Laszlo
 ___
 Engine-devel mailing list
 Engine-devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] Updates in VdsUpdateRuntimeInfo

2013-06-11 Thread Liran Zelkha
Hi all,

I'm checking performance for VdsUpdateRunTimeInfo.
Naturally, much of the performance surrounds database activity 
(getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)

Few questions:
1. I have implemented batch updates for procedure UpdateVmDeviceRuntimeInfo for 
improved performance. 
2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting are 
vm_id,vm_device_id,address and alias. Are those rapidly changing, or will it be 
beneficial to implement caching on those updates (to ensure not-required 
updates do not travel to the database).
3. Any additional known performance problems you know of in regards to this 
class?

Thanks...
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo

2013-06-11 Thread Itamar Heim

On 06/11/2013 03:26 PM, Liran Zelkha wrote:

Hi all,

I'm checking performance for VdsUpdateRunTimeInfo.
Naturally, much of the performance surrounds database activity 
(getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)

Few questions:
1. I have implemented batch updates for procedure UpdateVmDeviceRuntimeInfo for 
improved performance.
2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting are 
vm_id,vm_device_id,address and alias. Are those rapidly changing, or will it be 
beneficial to implement caching on those updates (to ensure not-required 
updates do not travel to the database).


slowly changing, but how will you cover all flows changing these devices 
to invalidate the cache (iiuc, this table is modified by engine when 
adding devices to a VM as well?)



3. Any additional known performance problems you know of in regards to this 
class?

Thanks...
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel



___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Few detailed REST API questions

2013-06-11 Thread Morrissey, Christopher
-Chris


 -Original Message-
 From: Tim Hildred [mailto:thild...@redhat.com]
 Sent: Monday, June 10, 2013 11:46 PM
 To: Morrissey, Christopher
 Cc: engine-devel@ovirt.org
 Subject: Re: [Engine-devel] Few detailed REST API questions
 
 Hey Chris,
 
 The engine uses a host to do pretty much everything. You'll find that you
 can't add a data domain to a data center without an active host, either.
 
 The answer to your question, I think, is that you should specify the SPM host
 in your data center.

Thanks for the response. By SPM host do you mean the host in the data center 
that is tagged as the master?

 
 Tim Hildred, RHCE
 Content Author II - Engineering Content Services, Red Hat, Inc.
 Brisbane, Australia
 Email: thild...@redhat.com
 Internal: 8588287
 Mobile: +61 4 666 25242
 IRC: thildred
 
 - Original Message -
  From: Christopher Morrissey christopher.morris...@netapp.com
  To: engine-devel@ovirt.org
  Sent: Thursday, May 30, 2013 1:38:28 AM
  Subject: [Engine-devel] Few detailed REST API questions
 
  Hi All,
 
  I'm working with the REST API and have a question that I haven't been
  able to figure out. When destroying a storage domain, it appears that
  a host is required in the storage domain. Can this be any host that
  has access to that domain?
 
  The storage domain returned through the REST api does not have the
  host populated so I'm not sure how I would figure out a specific host
  to put in there other than to just make sure it's one that can access the
 domain.
 
  -Chris
 
  Chris Morrissey
  Software Engineer
  NetApp Inc.
  919.476.4428
 
 
  ___
  Engine-devel mailing list
  Engine-devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/engine-devel
 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-11 Thread Giuseppe Vallarelli
Related to QoS parameters reporting to the engine. Looks like they're already
available, I tried to use vdsClient with list verb and I've got the devices
list where a 'specParams' is defined (it's empty because I didn't try it with
my last patch).

devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', 'network': 
'ovirtmgmt', 'alias': 'net0', 'specParams': {},
'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': '0x03', 
'bus': '0x00', 'domain': '0x',
'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'} ...]

Perhaps I'm missing something, any ideas/hints ?
Thanks Giuseppe
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel