[Engine-devel] Problem with development environment
Hi,
I've encountered a problem using development environment. When I run
make clean install-dev PREFIX=$HOME/ovirt-engine
there appears this error message:
make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
# we should avoid make these directories dirty
make copy-recursive SOURCEDIR=packaging/dbscripts
TARGETDIR=/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts \
EXCLUDE_GEN=packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh
packaging/conf/engine.conf.defaults packaging/conf/notifier.conf.defaults
packaging/conf/ovirt-websocket-proxy.conf.defaults
packaging/etc/engine-config/log4j.xml
packaging/etc/engine-manage-domains/log4j.xml
packaging/etc/engine-manage-domains/engine-manage-domains.conf
packaging/etc/notifier/log4j.xml packaging/sys-etc/logrotate.d/ovirt-engine
packaging/services/config.py packaging/services/ovirt-engine.systemd
packaging/services/ovirt-engine.sysv
packaging/services/ovirt-engine-notifier.systemd
packaging/services/ovirt-engine-notifier.sysv
packaging/services/ovirt-websocket-proxy.systemd
packaging/services/ovirt-websocket-proxy.sysv
packaging/setup/ovirt_engine_setup/config.py
packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec \
EXCLUDE=$(find packaging/dbscripts \( -name '*.scripts.md5' -or -name
'*.schema' -or -name '*.log' \))
make[2]: Entering directory `/home/mperina/projects/ovirt/ovirt-engine'
( cd packaging/dbscripts find . -type d -printf '%P\n' ) | while read d;
do \
install -d -m 755
/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts/${d}; \
done
( \
cd packaging/dbscripts find . -type f -printf '%P\n' | \
while read f; do \
exclude=false; \
set -x; \
for x in packaging/bin/engine-prolog.sh
packaging/bin/pki-common.sh packaging/conf/engine.conf.defaults
packaging/conf/notifier.conf.defaults
packaging/conf/ovirt-websocket-proxy.conf.defaults
packaging/etc/engine-config/log4j.xml
packaging/etc/engine-manage-domains/log4j.xml
packaging/etc/engine-manage-domains/engine-manage-domains.conf
packaging/etc/notifier/log4j.xml packaging/sys-etc/logrotate.d/ovirt-engine
packaging/services/config.py packaging/services/ovirt-engine.systemd
packaging/services/ovirt-engine.sysv
packaging/services/ovirt-engine-notifier.systemd
packaging/services/ovirt-engine-notifier.sysv
packaging/services/ovirt-websocket-proxy.systemd
packaging/services/ovirt-websocket-proxy.sysv
packaging/setup/ovirt_engine_setup/config.py
packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec ; do \
if [ packaging/dbscripts/${f} = ${x}.in ]; then \
exclude=true; \
break; \
fi; \
done; \
for x in packaging/dbscripts/upgrade.sh.log
/bin/sh: -c: line 12: syntax error: unexpected end of file
make[2]: *** [copy-recursive] Error 1
make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
make[1]: *** [install-packaging-files] Error 2
make[1]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
make: *** [install-dev] Error 2
I've already upgraded to otopi 1.1 (currently
1.1.0-0.0.master.20130626.git33d9561.fc18).
Martin Perina
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] ovirt-engine-sdk-java 1.0.0.9-1 released
* Fri Jun 28 2013 Michael Pasternak mpast...@redhat.com - 1.0.0.9-1 - configure log4j programmatically More details can be found at [1]. [1] http://www.ovirt.org/Java-sdk-changelog -- Michael Pasternak RedHat, ENG-Virtualization RD ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Sorting in tabs
- Original Message - From: Einav Cohen eco...@redhat.com To: Lior Vernia lver...@redhat.com Cc: Vojtech Szocs vsz...@redhat.com, Eli Mesika emes...@redhat.com, engine-devel@ovirt.org, Alexander Wels aw...@redhat.com, Daniel Erez de...@redhat.com, Gilad Chaplik gchap...@redhat.com, Alona Kaplan alkap...@redhat.com, Tomas Jelinek tjeli...@redhat.com Sent: Thursday, June 27, 2013 6:40:56 PM Subject: Re: [Engine-devel] Sorting in tabs - Original Message - From: Lior Vernia lver...@redhat.com Sent: Thursday, June 27, 2013 12:15:14 PM On 27/06/13 18:15, Einav Cohen wrote: - Original Message - From: Lior Vernia lver...@redhat.com Sent: Thursday, June 27, 2013 10:38:04 AM On 27/06/13 16:42, Einav Cohen wrote: - Original Message - From: Lior Vernia lver...@redhat.com Sent: Thursday, June 27, 2013 8:53:59 AM On 27/06/13 15:37, Einav Cohen wrote: - Original Message - From: Eli Mesika emes...@redhat.com Sent: Thursday, June 27, 2013 6:46:58 AM - Original Message - From: Lior Vernia lver...@redhat.com To: engine-devel@ovirt.org Sent: Thursday, June 27, 2013 10:12:33 AM Subject: [Engine-devel] Sorting in tabs Hello everyone (UI peeps in particular), I've pushed (not yet merged) a patch that would enable us to keep items in tabs (main/sub) sorted at all times by setting a comparator in SearchableListModel: But tabs includes only 100 records and supports paging , how you deal with that ??? if this is in the GUI level, then I assume that the comparator is simply comparing the items within the current page, and not globally. so the sorting doesn't affect the set of items that is displayed in the page (it would be the same as before the sorting) - just their order. Yes, if I understand correctly how the paging works, Einav is correct - only the items passed to the UI are sorted. also: @Lior - what happens when the search query contains a sort by part? there is a chance that the behaivor would be unexpected in this case; Yes, I thought about this case, and it may result in a confusing user experience if developers aren't careful. Together with the issue of paging, this probably makes this sorting mechanism a better candidate for use within subtabs rather than main tabs. note that at some point, I think that we would want to introduce paging also to search- based sub-tabs - it will be useful especially for sub-tabs that potentially display a large number of results (e.g. Disks sub-tab in Storage main tab). In addition, at some point, we would want to get rid of the paging UI as it is now (i.e. next/prev buttons at the top panel) and move to paging triggered by scroll (i.e. have a very long grid, dynamically loaded as you continue to scroll - similar to the behavior of some e-mail web-clients, for example). In this case, sorting on the client side will make no sense at all (i.e. from the user perspective, only a portion of a very large grid will be sorted, the other portions won't be). So for now - yes, I think it makes sense to introduce your mechanism to all sub-tabs, however in the long-term - we would probably want the search-based sub-tabs (which will support paging) to move to search-based sorting, rather than GUI-based-sorting. Sounds good to me. Let me just re-iterate that it is not mandatory to set a comparator, so in technical terms it's not even necessary to introduce it at once to all sub-tabs, if they're already sorting their items some other way. It could happen gradually, and only if developers find it more convenient. In either case, dropping the GUI sorting once search-based sorting is implemented shouldn't be difficult. BTW (maybe the other GUI maintainers can help me with that one) - what about sub-tabs that are not search-based (i.e. display results from a regular query or even from a field within the selected item in the main grid, e.g. Applications in VM) - are these managed via SearchableListModel as well? since the comparator mechanism *is* relevant for them. As far as I've seen, some are managed via SearchableListModel and some aren't. Those that aren't are those that display non-trivial behaviour upon receipt of the items to display (setItems() method) - often this non-trivial behaviour is exactly sorting :) And if it's doing its job, then there's no necessity to change it either. But anyway, I don't know all of them, so I'd also love to hear GUI maintainers. Also: Worth mentioning Bug 893999 - webadmin: please allow column sorting, which requests to enable sorting when clicking on a grid-column header; when implementing column-sorting, probably worth
Re: [Engine-devel] Problem with development environment
Hi,
workaround helped.
Thanks
Martin
- Original Message -
From: Alon Bar-Lev alo...@redhat.com
To: Martin Perina mper...@redhat.com
Cc: engine-devel@ovirt.org
Sent: Friday, June 28, 2013 9:46:36 AM
Subject: Re: [Engine-devel] Problem with development environment
Hello Marina,
Thank you for the report.
I can confirm that.
Workaround:
rm -f packaging/dbscripts/upgrade.sh.log
I will fix that soon.
Thanks,
Alon
- Original Message -
From: Martin Perina mper...@redhat.com
To: engine-devel@ovirt.org
Sent: Friday, June 28, 2013 8:59:53 AM
Subject: [Engine-devel] Problem with development environment
Hi,
I've encountered a problem using development environment. When I run
make clean install-dev PREFIX=$HOME/ovirt-engine
there appears this error message:
make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
# we should avoid make these directories dirty
make copy-recursive SOURCEDIR=packaging/dbscripts
TARGETDIR=/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts \
EXCLUDE_GEN=packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh
packaging/conf/engine.conf.defaults
packaging/conf/notifier.conf.defaults
packaging/conf/ovirt-websocket-proxy.conf.defaults
packaging/etc/engine-config/log4j.xml
packaging/etc/engine-manage-domains/log4j.xml
packaging/etc/engine-manage-domains/engine-manage-domains.conf
packaging/etc/notifier/log4j.xml
packaging/sys-etc/logrotate.d/ovirt-engine
packaging/services/config.py packaging/services/ovirt-engine.systemd
packaging/services/ovirt-engine.sysv
packaging/services/ovirt-engine-notifier.systemd
packaging/services/ovirt-engine-notifier.sysv
packaging/services/ovirt-websocket-proxy.systemd
packaging/services/ovirt-websocket-proxy.sysv
packaging/setup/ovirt_engine_setup/config.py
packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec \
EXCLUDE=$(find packaging/dbscripts \( -name '*.scripts.md5' -or -name
'*.schema' -or -name '*.log' \))
make[2]: Entering directory `/home/mperina/projects/ovirt/ovirt-engine'
( cd packaging/dbscripts find . -type d -printf '%P\n' ) | while read
d;
do \
install -d -m 755
/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts/${d}; \
done
( \
cd packaging/dbscripts find . -type f -printf '%P\n' | \
while read f; do \
exclude=false; \
set -x; \
for x in packaging/bin/engine-prolog.sh
packaging/bin/pki-common.sh
packaging/conf/engine.conf.defaults
packaging/conf/notifier.conf.defaults
packaging/conf/ovirt-websocket-proxy.conf.defaults
packaging/etc/engine-config/log4j.xml
packaging/etc/engine-manage-domains/log4j.xml
packaging/etc/engine-manage-domains/engine-manage-domains.conf
packaging/etc/notifier/log4j.xml
packaging/sys-etc/logrotate.d/ovirt-engine
packaging/services/config.py
packaging/services/ovirt-engine.systemd
packaging/services/ovirt-engine.sysv
packaging/services/ovirt-engine-notifier.systemd
packaging/services/ovirt-engine-notifier.sysv
packaging/services/ovirt-websocket-proxy.systemd
packaging/services/ovirt-websocket-proxy.sysv
packaging/setup/ovirt_engine_setup/config.py
packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec
; do \
if [ packaging/dbscripts/${f} = ${x}.in ]; then \
exclude=true; \
break; \
fi; \
done; \
for x in packaging/dbscripts/upgrade.sh.log
/bin/sh: -c: line 12: syntax error: unexpected end of file
make[2]: *** [copy-recursive] Error 1
make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
make[1]: *** [install-packaging-files] Error 2
make[1]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
make: *** [install-dev] Error 2
I've already upgraded to otopi 1.1 (currently
1.1.0-0.0.master.20130626.git33d9561.fc18).
Martin Perina
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] IE9 Issue with UI Plugin
Hi Ricky,
did you manage to solve the issue related with IE dev tools? If there are still
issues pointing to UI plugin infrastructure, please let me know.
Regards,
Vojtech
- Original Message -
From: Richard Hopper richard.hop...@netapp.com
To: Vojtech Szocs vsz...@redhat.com
Cc: engine-devel@ovirt.org, Christopher Morrissey
christopher.morris...@netapp.com
Sent: Wednesday, June 19, 2013 9:39:50 PM
Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
Hi Vojtech,
I've tested the new patch and for some reason am still running into
problems, though there are different exceptions now. I'll let you know if
we figure out what specifically is going on. It does work if dev tools are
up, but if there are no developer tools available the window will still
not close.
- Ricky
On 6/19/13 9:19 AM, Vojtech Szocs vsz...@redhat.com wrote:
Hi Ricky,
you were right, in IE9, postMessage listener (WebAdmin) didn't work
properly, so I simplified it and verified that it now works in IE9, too:
http://gerrit.ovirt.org/#/c/15888/
After applying above mentioned patch, everything should work as expected
in IE9. I've also attached test-plugin which I used for verification in
IE9.
Regards,
Vojtech
- Original Message -
From: Vojtech Szocs vsz...@redhat.com
To: Richard Hopper richard.hop...@netapp.com
Cc: engine-devel@ovirt.org, Christopher Morrissey
christopher.morris...@netapp.com
Sent: Wednesday, June 19, 2013 11:54:16 AM
Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
Hi Ricky,
code running in the iframe (custom dialog content) can close the dialog
in
the following way:
1, send message to your plugin to indicate the dialog needs to be
closed:
parent.postMessage('CloseMyDialog', '*');
2, your plugin intercepts the message via MessageReceived function and
closes
the dialog:
MessageReceived: function(data, sourceWindow) {
switch (data) {
case 'CloseMyDialog':
window.alert('About to close dialog');
api.closeDialog('my-dialog');
break;
}
}
If the above doesn't work for you, it could mean that:
- MessageReceived function isn't invoked - make sure to have [*] before
api.register() call
- api.closeDialog() function isn't working - in this case I need to fix
it
for IE9
[*] accept message events from iframe (custom dialog content) origin
api.options({
allowedMessageOrigins: 'http://nicedomain:8080'
/* OR */
allowedMessageOrigins: ['http://nicedomain1:123',
'https://nicedomain2:345']
});
I'm going to investigate this issue on IE9 myself to see if the above
code is
really working there.
Vojtech
- Original Message -
From: Richard Hopper richard.hop...@netapp.com
To: Vojtech Szocs vsz...@redhat.com
Cc: engine-devel@ovirt.org, Christopher Morrissey
christopher.morris...@netapp.com
Sent: Monday, June 17, 2013 8:16:03 PM
Subject: IE9 Issue with UI Plugin
Hi Vojtech,
I had previously sent you an email about IE9 compatibility where the
problem
we were having was solved by omitting console logging when a console
was
unavailable (i.e. IE). However, it is looking like IE9 may have a
bigger
issue with regards to the plugin framework.
Now that we have gotten dialogs to open via dynamically inserted
buttons
within RHEV tabs (for example, a NetApp button in the Storage tab),
we can
go through our whole process with the exception of closing the
window. In
all other browsers, our dialog will close as expected, but in IE the
window
remains open. It can be closed by hitting the red x in the corner,
but it
appears the code in the frame itself cannot close the window, with a
console
message in the dev tools of IE9 showing an error of 'Math' is
undefined.
I've read up on this, and it seems like this is a very widespread
error in
Internet Explorer concerning the manner/order in which iframes are
dynamically inserted.
I've copied engine-devel in case anyone has similar issues/solutions,
but
it
seems as though we need some sort of clause in the plugin framework
for IE
when it comes to dynamic insertion of new windows.
- Ricky Hopper
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
Hi Tomas, IIUC the RFE addresses only UIPlugins with their metadata so in order to integrate this with the SPICE we nee to either enrich the RFE or to create a UIPlugin which will start the SPICE. I would vote for the second option. What others? using a ui-plugin that will start SPICE is an interesting approach - it haven't crossed my mind. What I had in mind is to somewhat generalize the RestApiSessionManager to provide REST-API-session-creation services to the entire GUI (e.g. SPICE-console-opening-code), and not only to the ui-plugins in particular. I think that since SPICE is already quite integrated into oVirt (in our business logic, dialogs, ...), it would be somewhat weird to use a UI-Plugin in order to invoke SPICE, just in order to get the REST-API-session-creation capability. So I am actually in favor of enriching the RFE (i.e. generalize the RestApiSessionManager), rather than treating SPICE as a UI-Plugin (in a sense). Why only for SPICE? I can imagine UIPlugins which could make use of this option. the main difference between SPICE and the UIPlugins is that we know in advance how SPICE is going to use REST API. In addition, SPICE is going to do actions (e.g. Stop/Pause/Attach CD) on the VM only when the user chooses to do so (via the SPICE menu), so actions will be done on behalf of the logged-in user, so it makes sense to provide to SPICE the same credentials as the logged-in user. a ui-plugin is a third-party component which we don't know in advance how it is going to act; moreover, the user that is logging into the web-admin doesn't have control on it. Imagine a ui-plugin that shuts-down/deletes all VMs immediately upon login to the web-admin - all VMs will be shutdown/deleted upon the first login into the web-admin (after the ui-plugin installation on the engine server). If the same-credentials-approach will be used, the shutdown/deletion of all VMs will be done on behalf of the user that happened to be the first one logging into the web-admin (post ui-plugin installation), which, obviously, is not good. So to sum-up: I think that - the RestApiSessionManager should be generalized to provide REST-API-session- creation services to the entire GUI (e.g. SPICE-console-opening-code), and not only to the ui-plugins in particular. - RestApiSessionManager should support creation of both same-credentials-session as well as other-credentials-session; the same-credentials-session should be limited to well-known/well-integrated components (e.g. SPICE), whereas the other-credentials-session can be used by third-party components as well (e.g. ui-plugins). [I could be wrong - would love to hear what the others GUI maintainers think] - Original Message - From: Tomas Jelinek tjeli...@redhat.com Sent: Friday, June 28, 2013 1:41:11 AM - Original Message - From: Einav Cohen eco...@redhat.com To: Tomas Jelinek tjeli...@redhat.com, Vojtech Szocs vsz...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Michael Pasternak mpast...@redhat.com Sent: Thursday, June 27, 2013 6:01:13 PM Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST Hi Tomas, Yes, we can provide the sessionId to authenticate with the REST and the vm guid is not a problem. Note that in the web-admin, we already have code that generates REST API session-ID; this code is being utilized in the ui-plugins infrastructure to allow the different ui-plugins to communicate with the rest api. [one related file is this context is RestApiSessionManager.java in the web-admin, not sure if there are others] Yes, I'm aware of that. This is what I had in mind when was talking about passing the SessionId to SPICE. maybe the RestApiSessionManager(?) can somehow be utilized for the SPICE purpose as well (I guess that it will require a couple of code-changes though, and maybe worth moving it to gwt-common, to allow its utilization from the user portal as well?) - @Vojtech would probably know best to advise on this. * Note: Today: (a) a *single* REST API session-ID is generated and used across all ui-plugins in the system (upon user login to the web-admin). (b) this REST-API session-ID is generated based on the *same credentials* with which the user logged into the web-admin. both (a) and (b) will change once [1] will be addressed. Thank you for mentioning this! I was not aware of this RFE. IIUC the RFE addresses only UIPlugins with their metadata so in order to integrate this with the SPICE we nee to either enrich the RFE or to create a UIPlugin which will start the SPICE. I would vote for the second option. What others? Only for the SPICE case in particular - I think that (b) should remain. so Why only for SPICE? I can imagine UIPlugins which could make use of this option. maybe worth allowing both same-credentials-login and
Re: [Engine-devel] IE9 Issue with UI Plugin
Hi Vojtech,
It actually turned out that our particular problem was hidden within our
code, so once we found it, the plugin worked fine with IE9. It was
actually related to the lack of console in the browser as well, I just
didn't realize we called native javascript in multiple places. It seems
that the plugin architecture's compatibility with IE9 is quite solid.
Thank you once again!
- Ricky
On 6/28/13 11:10 AM, Vojtech Szocs vsz...@redhat.com wrote:
Hi Ricky,
did you manage to solve the issue related with IE dev tools? If there are
still issues pointing to UI plugin infrastructure, please let me know.
Regards,
Vojtech
- Original Message -
From: Richard Hopper richard.hop...@netapp.com
To: Vojtech Szocs vsz...@redhat.com
Cc: engine-devel@ovirt.org, Christopher Morrissey
christopher.morris...@netapp.com
Sent: Wednesday, June 19, 2013 9:39:50 PM
Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
Hi Vojtech,
I've tested the new patch and for some reason am still running into
problems, though there are different exceptions now. I'll let you know
if
we figure out what specifically is going on. It does work if dev tools
are
up, but if there are no developer tools available the window will still
not close.
- Ricky
On 6/19/13 9:19 AM, Vojtech Szocs vsz...@redhat.com wrote:
Hi Ricky,
you were right, in IE9, postMessage listener (WebAdmin) didn't work
properly, so I simplified it and verified that it now works in IE9,
too:
http://gerrit.ovirt.org/#/c/15888/
After applying above mentioned patch, everything should work as
expected
in IE9. I've also attached test-plugin which I used for verification
in
IE9.
Regards,
Vojtech
- Original Message -
From: Vojtech Szocs vsz...@redhat.com
To: Richard Hopper richard.hop...@netapp.com
Cc: engine-devel@ovirt.org, Christopher Morrissey
christopher.morris...@netapp.com
Sent: Wednesday, June 19, 2013 11:54:16 AM
Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
Hi Ricky,
code running in the iframe (custom dialog content) can close the
dialog
in
the following way:
1, send message to your plugin to indicate the dialog needs to be
closed:
parent.postMessage('CloseMyDialog', '*');
2, your plugin intercepts the message via MessageReceived function
and
closes
the dialog:
MessageReceived: function(data, sourceWindow) {
switch (data) {
case 'CloseMyDialog':
window.alert('About to close dialog');
api.closeDialog('my-dialog');
break;
}
}
If the above doesn't work for you, it could mean that:
- MessageReceived function isn't invoked - make sure to have [*]
before
api.register() call
- api.closeDialog() function isn't working - in this case I need to
fix
it
for IE9
[*] accept message events from iframe (custom dialog content) origin
api.options({
allowedMessageOrigins: 'http://nicedomain:8080'
/* OR */
allowedMessageOrigins: ['http://nicedomain1:123',
'https://nicedomain2:345']
});
I'm going to investigate this issue on IE9 myself to see if the above
code is
really working there.
Vojtech
- Original Message -
From: Richard Hopper richard.hop...@netapp.com
To: Vojtech Szocs vsz...@redhat.com
Cc: engine-devel@ovirt.org, Christopher Morrissey
christopher.morris...@netapp.com
Sent: Monday, June 17, 2013 8:16:03 PM
Subject: IE9 Issue with UI Plugin
Hi Vojtech,
I had previously sent you an email about IE9 compatibility where
the
problem
we were having was solved by omitting console logging when a
console
was
unavailable (i.e. IE). However, it is looking like IE9 may have a
bigger
issue with regards to the plugin framework.
Now that we have gotten dialogs to open via dynamically inserted
buttons
within RHEV tabs (for example, a NetApp button in the Storage tab),
we can
go through our whole process with the exception of closing the
window. In
all other browsers, our dialog will close as expected, but in IE
the
window
remains open. It can be closed by hitting the red x in the
corner,
but it
appears the code in the frame itself cannot close the window, with
a
console
message in the dev tools of IE9 showing an error of 'Math' is
undefined.
I've read up on this, and it seems like this is a very widespread
error in
Internet Explorer concerning the manner/order in which iframes are
dynamically inserted.
I've copied engine-devel in case anyone has similar
issues/solutions,
but
it
seems as though we need some sort of clause in the plugin framework
for IE
when it comes to dynamic insertion of new windows.
- Ricky Hopper
___
Engine-devel mailing list
Engine-devel@ovirt.org
Re: [Engine-devel] NPE approving node
On 06/27/2013 04:50 AM, Juan Hernandez wrote: Any idea why? Facing the same issue with updated tree. Cannot approve node. $ git log -1 commit b5438e34e0b179ef4f8ee20ce6e0d7b25cd2a36a 2013-06-27 10:37:40,219 INFO [org.ovirt.engine.core.bll.ApproveVdsCommand] (pool-6-thread-5) [3dd1f412] Running command: ApproveVdsCommand internal: false. Entities affected : ID: 0be6cd89-c5f5-4a4e-b498-504bb2c23eb2 Type: VDS 2013-06-27 10:37:40,239 INFO [org.ovirt.engine.core.bll.InstallVdsCommand] (pool-6-thread-5) [3dd1f412] Before Installation host 0be6cd89-c5f5-4a4e-b498-504bb2c23eb2, h0.example.com 2013-06-27 10:37:40,294 ERROR [org.ovirt.engine.core.bll.InstallVdsCommand] (pool-6-thread-5) [3dd1f412] Host installation failed for host 0be6cd89-c5f5-4a4e-b498-504bb2c23eb2, h0.example.com.: java.lang.NullPointerException at org.ovirt.engine.core.utils.ssh.EngineSSHDialog.useDefaultKeyPair(EngineSSHDialog.java:32) [utils.jar:] at org.ovirt.engine.core.bll.VdsDeploy.useDefaultKeyPair(VdsDeploy.java:804) [bll.jar:] at org.ovirt.engine.core.bll.InstallVdsCommand.executeCommand(InstallVdsCommand.java:170) [bll.jar:] at org.ovirt.engine.core.bll.ApproveVdsCommand.executeCommand(ApproveVdsCommand.java:49) [bll.jar:] at org.ovirt.engine.core.bll.CommandBase.executeWithoutTransaction(CommandBase.java:1065) [bll.jar:] at org.ovirt.engine.core.bll.CommandBase.executeActionInTransactionScope(CommandBase.java:1150) [bll.jar:] at org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:1613) [bll.jar:] at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInSuppressed(TransactionSupport.java:174) [utils.jar:] at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInScope(TransactionSupport.java:116) [utils.jar:] at org.ovirt.engine.core.bll.CommandBase.execute(CommandBase.java:1168) [bll.jar:] at org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:316) [bll.jar:] at org.ovirt.engine.core.bll.MultipleActionsRunner.executeValidatedCommand(MultipleActionsRunner.java:174) [bll.jar:] at org.ovirt.engine.core.bll.MultipleActionsRunner.RunCommands(MultipleActionsRunner.java:156) [bll.jar:] at org.ovirt.engine.core.bll.MultipleActionsRunner$1.run(MultipleActionsRunner.java:94) [bll.jar:] at org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:71) [utils.jar:] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) [rt.jar:1.7.0_09-icedtea] at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) [rt.jar:1.7.0_09-icedtea] at java.util.concurrent.FutureTask.run(FutureTask.java:166) [rt.jar:1.7.0_09-icedtea] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_09-icedtea] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_09-icedtea] at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09-icedtea] -- Cheers Douglas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] NPE approving node
- Original Message - From: Douglas Schilling Landgraf dougsl...@redhat.com To: engine-devel@ovirt.org Cc: Alon Bar-Lev alo...@redhat.com, Yaniv Bronheim ybron...@redhat.com Sent: Friday, June 28, 2013 9:55:02 PM Subject: Re: [Engine-devel] NPE approving node On 06/27/2013 04:50 AM, Juan Hernandez wrote: Any idea why? Facing the same issue with updated tree. Cannot approve node. $ git log -1 commit b5438e34e0b179ef4f8ee20ce6e0d7b25cd2a36a This[1] should have fixed that. Can you please send the exception? [1] http://gerrit.ovirt.org/#/c/16184/ ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] NPE approving node
On 06/28/2013 02:22 PM, Alon Bar-Lev wrote: - Original Message - From: Douglas Schilling Landgraf dougsl...@redhat.com To: engine-devel@ovirt.org Cc: Alon Bar-Lev alo...@redhat.com, Yaniv Bronheim ybron...@redhat.com Sent: Friday, June 28, 2013 9:55:02 PM Subject: Re: [Engine-devel] NPE approving node On 06/27/2013 04:50 AM, Juan Hernandez wrote: Any idea why? Facing the same issue with updated tree. Cannot approve node. $ git log -1 commit b5438e34e0b179ef4f8ee20ce6e0d7b25cd2a36a This[1] should have fixed that. Can you please send the exception? [1] http://gerrit.ovirt.org/#/c/16184/ I have cleanup/refresh my working tree, looks like it's gone. Thanks! -- Cheers Douglas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Jenkins failure - findbugs failed: Timeout: killed the sub-process
Hi, Anyone else facing the below jenkins failure when sending patches to gerrit? [ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs (default-cli) on project jboss-modules-maven-plugin: Execution default-cli of goal org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs failed: Timeout: killed the sub-process - [Help 1] http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2650/ Thanks! -- Cheers Douglas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
