Re: [Engine-devel] Proposal for new commit msg design for engine commits
- Original Message - > From: "Eyal Edri" > To: "Alon Bar-Lev" > Cc: "infra" , "engine-devel" , > "Fabian Deutsch" > Sent: Saturday, July 20, 2013 9:41:56 PM > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > commits > > This change to commit template has nothing to do with CI. > it's a change that should reflect updated components relevance to the commit > code. This commit template is mostly invalid, as touching more than one 'subsystem' is possible, and has not enough granularity. For example, database change should trigger what? Infra change should trigger what? A change of both user interface and command should trigger what? So you end up with: userportal: storage: core: db: some message Just to make who happy? And maybe there are 50 tests of network, and you need only 5 of them for the specific change, how do you mark it, so now a developer need to know any test? what if you add one tomorrow which is relevant to a similar change? how do you inform the developer that now he needs 6? Why should it be the developer responsibility and not the quality ensuring engineer responsibility to determine which tests should run and when? As far as this template was not actually used for anything but humans, it was not that important, but once you formalize it as an interface, I step forward and state that the subject line is not the right tool for the task at hand (or any for this matter). The fact that you have in each commit are the sources that are modified, all the other data is just plain noise. From the sources that are modified you should be able to derive a test plan with high chance that this test program will be correct. Human intervention should be possible by ordering special tests that are outside of the standard policy, for cases in which the standard policy of deriving tests from sources is too narrow. Regards, Alon > > Nevertheless, i have no problems with your suggestions for metadata per > directory to map all ovirt code. > any suggestion how to push it forward? > > Eyal. > > - Original Message - > > From: "Alon Bar-Lev" > > To: "Eyal Edri" > > Cc: "infra" , "engine-devel" , > > "Fabian Deutsch" > > Sent: Saturday, July 20, 2013 9:34:13 PM > > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > > commits > > > > > > > > - Original Message - > > > From: "Eyal Edri" > > > To: "infra" > > > Cc: "engine-devel" , "Fabian Deutsch" > > > > > > Sent: Saturday, July 20, 2013 8:34:28 PM > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > > > commits > > > > > > OK, Rome wasn't built in a day. > > > > > > To move things forward, > > > I propose we'll just improve current commit header template to include > > > more > > > relevant code > > > areas [1], and start looking into mapping all code to the relevant > > > components > > > (either via renaming folders, adding a metadata file under each folder > > > mapping the files/classnames/directory names or using automated tools > > > like > > > sonar) > > > > Again, and I am sorry, but I disagree of any relationship between commit > > message and CI. > > > > It will be simple to add metadata to sources, and have CI run tests based > > on > > actual source change thus probable impact, this way we won't be exposed to > > human errors, nor make commit message unusable for actual history. > > > > All we need is someone to take ownership of the task of adding metadata to > > source tree. > > > > As I proposed this can be either within every source using special > > signature, > > or can be in a directory at special file, for example .ovirt-metadata, and > > have the mapping between source component to relevant tests at a simple > > text > > file at source root. > > > > Regards, > > Alon Bar-Lev. > > > > > > > > [1] instead of> > userportal | webadmin> > > > change to something like > > webadmin > > > | network | storage | virt | packaging> > > > > > > Eyal. > > > > > > - Original Message - > > > > From: "Moran Goldboim" > > > > To: "Eyal Edri" > > > > Cc: "Fabian Deutsch" , "engine-devel" > > > > , "infra" > > > > Sent: Sunday, July 14, 2013 6:07:05 PM > > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for > > > > engine > > > > commits > > > > > > > > On 07/11/2013 11:57 AM, Eyal Edri wrote: > > > > > > > > > > - Original Message - > > > > >> From: "Fabian Deutsch" > > > > >> To: "Eyal Edri" > > > > >> Cc: "Alon Bar-Lev" , "engine-devel" > > > > >> , "infra" > > > > >> Sent: Thursday, July 11, 2013 11:41:24 AM > > > > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > > > >> engine > > > > >> commits > > > > >> > > > > >> Am Mittwoch, den 10.07.2013, 15:27 -0400 schrieb Eyal Edri: > > > > >>> - Original Message - > > > > From: "Fabian Deutsch" > > > > To: "Alon Bar-Lev" > > > > Cc: "engine-de
Re: [Engine-devel] Proposal for new commit msg design for engine commits
This change to commit template has nothing to do with CI. it's a change that should reflect updated components relevance to the commit code. Nevertheless, i have no problems with your suggestions for metadata per directory to map all ovirt code. any suggestion how to push it forward? Eyal. - Original Message - > From: "Alon Bar-Lev" > To: "Eyal Edri" > Cc: "infra" , "engine-devel" , > "Fabian Deutsch" > Sent: Saturday, July 20, 2013 9:34:13 PM > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > commits > > > > - Original Message - > > From: "Eyal Edri" > > To: "infra" > > Cc: "engine-devel" , "Fabian Deutsch" > > > > Sent: Saturday, July 20, 2013 8:34:28 PM > > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > > commits > > > > OK, Rome wasn't built in a day. > > > > To move things forward, > > I propose we'll just improve current commit header template to include more > > relevant code > > areas [1], and start looking into mapping all code to the relevant > > components > > (either via renaming folders, adding a metadata file under each folder > > mapping the files/classnames/directory names or using automated tools like > > sonar) > > Again, and I am sorry, but I disagree of any relationship between commit > message and CI. > > It will be simple to add metadata to sources, and have CI run tests based on > actual source change thus probable impact, this way we won't be exposed to > human errors, nor make commit message unusable for actual history. > > All we need is someone to take ownership of the task of adding metadata to > source tree. > > As I proposed this can be either within every source using special signature, > or can be in a directory at special file, for example .ovirt-metadata, and > have the mapping between source component to relevant tests at a simple text > file at source root. > > Regards, > Alon Bar-Lev. > > > > > [1] instead of> userportal | webadmin> > > change to something like > webadmin > > | network | storage | virt | packaging> > > > > Eyal. > > > > - Original Message - > > > From: "Moran Goldboim" > > > To: "Eyal Edri" > > > Cc: "Fabian Deutsch" , "engine-devel" > > > , "infra" > > > Sent: Sunday, July 14, 2013 6:07:05 PM > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > > > commits > > > > > > On 07/11/2013 11:57 AM, Eyal Edri wrote: > > > > > > > > - Original Message - > > > >> From: "Fabian Deutsch" > > > >> To: "Eyal Edri" > > > >> Cc: "Alon Bar-Lev" , "engine-devel" > > > >> , "infra" > > > >> Sent: Thursday, July 11, 2013 11:41:24 AM > > > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > > >> engine > > > >> commits > > > >> > > > >> Am Mittwoch, den 10.07.2013, 15:27 -0400 schrieb Eyal Edri: > > > >>> - Original Message - > > > From: "Fabian Deutsch" > > > To: "Alon Bar-Lev" > > > Cc: "engine-devel" , "infra" > > > > > > Sent: Tuesday, July 9, 2013 3:54:06 PM > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for > > > engine > > > commits > > > > > > Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev: > > > > > > > > - Original Message - > > > >> From: "Yair Zaslavsky" > > > >> To: "Alon Bar-Lev" > > > >> Cc: "Eyal Edri" , "engine-devel" > > > > , "infra" > > > >> Sent: Tuesday, July 9, 2013 3:42:24 PM > > > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > > > engine commits > > > >> > > > >> > > > >> - Original Message - > > > >>> From: "Alon Bar-Lev" > > > >>> To: "Eyal Edri" > > > >>> Cc: "engine-devel" , "infra" > > > > > > > >>> Sent: Tuesday, July 9, 2013 3:33:57 PM > > > >>> Subject: Re: [Engine-devel] Proposal for new commit msg design > > > >>> for > > > > engine > > > >>> commits > > > >>> > > > >>> > > > >>> > > > >>> - Original Message - > > > From: "Eyal Edri" > > > To: "engine-devel" > > > Cc: "infra" > > > Sent: Tuesday, July 9, 2013 12:38:51 PM > > > Subject: Proposal for new commit msg design for engine commits > > > > > > Hi, > > > > > > You all probably know and familiar with 'ovirt-engine' git hook > > > > for > > > commit > > > msg template [1]. > > > this helps understand the general area of the patch in the > > > > project but it > > > lacks additional info that might > > > be valuable for scaling automatic tests in Jenkins CI. > > > > > > Let me explain: > > > > > > Infra team is working hard on expanding oVirt CI infrastructure > > > > and > > > adding > > > more tests in jenkins (per commit/patch). > >
Re: [Engine-devel] Proposal for new commit msg design for engine commits
- Original Message - > From: "Eyal Edri" > To: "infra" > Cc: "engine-devel" , "Fabian Deutsch" > > Sent: Saturday, July 20, 2013 8:34:28 PM > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > commits > > OK, Rome wasn't built in a day. > > To move things forward, > I propose we'll just improve current commit header template to include more > relevant code > areas [1], and start looking into mapping all code to the relevant components > (either via renaming folders, adding a metadata file under each folder > mapping the files/classnames/directory names or using automated tools like > sonar) Again, and I am sorry, but I disagree of any relationship between commit message and CI. It will be simple to add metadata to sources, and have CI run tests based on actual source change thus probable impact, this way we won't be exposed to human errors, nor make commit message unusable for actual history. All we need is someone to take ownership of the task of adding metadata to source tree. As I proposed this can be either within every source using special signature, or can be in a directory at special file, for example .ovirt-metadata, and have the mapping between source component to relevant tests at a simple text file at source root. Regards, Alon Bar-Lev. > > [1] instead ofuserportal | webadmin> > change to something like | network | storage | virt | packaging> > > Eyal. > > - Original Message - > > From: "Moran Goldboim" > > To: "Eyal Edri" > > Cc: "Fabian Deutsch" , "engine-devel" > > , "infra" > > Sent: Sunday, July 14, 2013 6:07:05 PM > > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > > commits > > > > On 07/11/2013 11:57 AM, Eyal Edri wrote: > > > > > > - Original Message - > > >> From: "Fabian Deutsch" > > >> To: "Eyal Edri" > > >> Cc: "Alon Bar-Lev" , "engine-devel" > > >> , "infra" > > >> Sent: Thursday, July 11, 2013 11:41:24 AM > > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > >> engine > > >> commits > > >> > > >> Am Mittwoch, den 10.07.2013, 15:27 -0400 schrieb Eyal Edri: > > >>> - Original Message - > > From: "Fabian Deutsch" > > To: "Alon Bar-Lev" > > Cc: "engine-devel" , "infra" > > Sent: Tuesday, July 9, 2013 3:54:06 PM > > Subject: Re: [Engine-devel] Proposal for new commit msg design for > > engine > > commits > > > > Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev: > > > > > > - Original Message - > > >> From: "Yair Zaslavsky" > > >> To: "Alon Bar-Lev" > > >> Cc: "Eyal Edri" , "engine-devel" > > > , "infra" > > >> Sent: Tuesday, July 9, 2013 3:42:24 PM > > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > > engine commits > > >> > > >> > > >> - Original Message - > > >>> From: "Alon Bar-Lev" > > >>> To: "Eyal Edri" > > >>> Cc: "engine-devel" , "infra" > > > > > >>> Sent: Tuesday, July 9, 2013 3:33:57 PM > > >>> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > > engine > > >>> commits > > >>> > > >>> > > >>> > > >>> - Original Message - > > From: "Eyal Edri" > > To: "engine-devel" > > Cc: "infra" > > Sent: Tuesday, July 9, 2013 12:38:51 PM > > Subject: Proposal for new commit msg design for engine commits > > > > Hi, > > > > You all probably know and familiar with 'ovirt-engine' git hook > > > for > > commit > > msg template [1]. > > this helps understand the general area of the patch in the > > > project but it > > lacks additional info that might > > be valuable for scaling automatic tests in Jenkins CI. > > > > Let me explain: > > > > Infra team is working hard on expanding oVirt CI infrastructure > > > and > > adding > > more tests in jenkins (per commit/patch). > > Adding important meta-data per patch can significatly improve > > > the ability > > to > > run specific tests for each patch/commit, > > and not waste valuable resources on Jenkins jobs that are not > > > relevant to > > the > > code in the patch. > > > > So the idea is to add/expand current metadata per patch, in the > > > form of: > > (either) > > 1. expanding current header template to include more data like > > > 'network' > > , > > 'setup', 'tools', 'virt' > > >>> Please do not expand header, it is too short anyway. > > >>> > > 2. adding a new label with relevant tags for the patch, called > > > e.g > > 'METADATA: network, rest, virt' > > >>> Having: > > >>> >
Re: [Engine-devel] Proposal for new commit msg design for engine commits
OK, Rome wasn't built in a day. To move things forward, I propose we'll just improve current commit header template to include more relevant code areas [1], and start looking into mapping all code to the relevant components (either via renaming folders, adding a metadata file under each folder mapping the files/classnames/directory names or using automated tools like sonar) [1] instead of change to something like Eyal. - Original Message - > From: "Moran Goldboim" > To: "Eyal Edri" > Cc: "Fabian Deutsch" , "engine-devel" > , "infra" > Sent: Sunday, July 14, 2013 6:07:05 PM > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > commits > > On 07/11/2013 11:57 AM, Eyal Edri wrote: > > > > - Original Message - > >> From: "Fabian Deutsch" > >> To: "Eyal Edri" > >> Cc: "Alon Bar-Lev" , "engine-devel" > >> , "infra" > >> Sent: Thursday, July 11, 2013 11:41:24 AM > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine > >> commits > >> > >> Am Mittwoch, den 10.07.2013, 15:27 -0400 schrieb Eyal Edri: > >>> - Original Message - > From: "Fabian Deutsch" > To: "Alon Bar-Lev" > Cc: "engine-devel" , "infra" > Sent: Tuesday, July 9, 2013 3:54:06 PM > Subject: Re: [Engine-devel] Proposal for new commit msg design for > engine > commits > > Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev: > > > > - Original Message - > >> From: "Yair Zaslavsky" > >> To: "Alon Bar-Lev" > >> Cc: "Eyal Edri" , "engine-devel" > > , "infra" > >> Sent: Tuesday, July 9, 2013 3:42:24 PM > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > engine commits > >> > >> > >> - Original Message - > >>> From: "Alon Bar-Lev" > >>> To: "Eyal Edri" > >>> Cc: "engine-devel" , "infra" > > > >>> Sent: Tuesday, July 9, 2013 3:33:57 PM > >>> Subject: Re: [Engine-devel] Proposal for new commit msg design for > > engine > >>> commits > >>> > >>> > >>> > >>> - Original Message - > From: "Eyal Edri" > To: "engine-devel" > Cc: "infra" > Sent: Tuesday, July 9, 2013 12:38:51 PM > Subject: Proposal for new commit msg design for engine commits > > Hi, > > You all probably know and familiar with 'ovirt-engine' git hook > > for > commit > msg template [1]. > this helps understand the general area of the patch in the > > project but it > lacks additional info that might > be valuable for scaling automatic tests in Jenkins CI. > > Let me explain: > > Infra team is working hard on expanding oVirt CI infrastructure > > and > adding > more tests in jenkins (per commit/patch). > Adding important meta-data per patch can significatly improve > > the ability > to > run specific tests for each patch/commit, > and not waste valuable resources on Jenkins jobs that are not > > relevant to > the > code in the patch. > > So the idea is to add/expand current metadata per patch, in the > > form of: > (either) > 1. expanding current header template to include more data like > > 'network' > , > 'setup', 'tools', 'virt' > >>> Please do not expand header, it is too short anyway. > >>> > 2. adding a new label with relevant tags for the patch, called > > e.g > 'METADATA: network, rest, virt' > >>> Having: > >>> > >>> CI-Tests: xxx > >>> CI-Tests: yyy > >>> CI-Tests: zzz > >>> > >>> Is much better. > >> I'm not sure we should have CI-Test - as we might use this for > > something else > >> besides CI. > >> Region_of_Interest as Dan suggests sounds better IMHO. > > I don't care how this is to be called. > > However, I do not think that commit message is the place for > > instructing CI to do anything. > > Commit message stays for good, it should contain information that is > > required a year from now. > > It has nothing to do with tests and such. > I agree with Alon here that the Ci informations don't belong in the > commit msg. > My opinion is that a testcase should know what it covers. This > information from the testcase can then be used by any party to determin > if the testcase should be run on a specific commit (which yields > informations about the changed paths, files, owner, author, etc ... > which might be valuable). > >>> i think you're missing the point here. > >>> can you explain how do you propose a test case will know "what it > >>> covers"? > >>> > >>> let's take an example: > >>> let's say a new commit comes
[Engine-devel] testDisplayPort - VmMapperTest
Hi, Anyone else failing on this unittest? $ make install-dev PREFIX="$HOME/ovirt-engine" BUILD_UT=1 Results : Tests in error: testDisplayPort(org.ovirt.engine.api.restapi.types.VmMapperTest) Tests run: 121, Failures: 0, Errors: 1, Skipped: 0 [INFO] [INFO] Reactor Summary: [INFO] [INFO] ovirt-root SUCCESS [0.443s] [INFO] oVirt Build Tools root SUCCESS [0.010s] [INFO] oVirt checkstyle .. SUCCESS [1.054s] [INFO] oVirt JBoss Modules Maven Plugin .. SUCCESS [3.084s] [INFO] oVirt Checkstyle Checks ... SUCCESS [0.762s] [INFO] oVirt Modules - backend ... SUCCESS [0.004s] [INFO] oVirt Manager . SUCCESS [0.004s] [INFO] oVirt Engine dependencies . SUCCESS [1.428s] [INFO] oVirt Modules - manager ... SUCCESS [0.466s] [INFO] CSharp Compatibility .. SUCCESS [2.694s] [INFO] Common Code ... SUCCESS [10.024s] [INFO] Common utilities .. SUCCESS [19.154s] [INFO] Data Access Layer . SUCCESS [7.966s] [INFO] engine scheduler bean . SUCCESS [1.462s] [INFO] Vds broker SUCCESS [7.028s] [INFO] Search Backend SUCCESS [2.866s] [INFO] Backend Logic @Service bean ... SUCCESS [28.853s] [INFO] oVirt RESTful API Backend Integration . SUCCESS [0.094s] [INFO] oVirt RESTful API interface ... SUCCESS [0.119s] [INFO] oVirt Engine API Definition ... SUCCESS [10.331s] [INFO] oVirt Engine API Commom Parent POM SUCCESS [0.068s] [INFO] oVirt Engine API Common JAX-RS SUCCESS [5.188s] [INFO] oVirt RESTful API Backend Integration Type Mappers FAILURE [1:49.300s] [INFO] oVirt RESTful API Backend Integration JAX-RS Resources SKIPPED [INFO] oVirt RESTful API Backend Integration Webapp .. SKIPPED [INFO] oVirt Engine Web Root . SKIPPED [INFO] oVirt Engine Tools SKIPPED [INFO] oVirt Modules :: Frontend . SKIPPED [INFO] oVirt Modules :: Webadmin . SKIPPED [INFO] oVirt Modules - ui SKIPPED [INFO] Extensions for GWT SKIPPED [INFO] UI Utils Compatibility (for UICommon) . SKIPPED [INFO] Frontend for GWT UI Projects .. SKIPPED [INFO] UICommonWeb ... SKIPPED [INFO] oVirt GWT UI common infrastructure SKIPPED [INFO] WebAdmin .. SKIPPED [INFO] UserPortal SKIPPED [INFO] oVirt Server EAR .. SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 3:33.247s [INFO] Finished at: Sat Jul 20 04:09:04 BRT 2013 [INFO] Final Memory: 165M/881M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.7.2:test (default-test) on project restapi-types: There are test failures. Thanks! -- Cheers Douglas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
