Re: [E-devel] Showing icons on other desks and screens in the window list (or not).....

2006-12-14 Thread Christopher Michael
Ravenlock wrote:
 On 12/13/2006 23:00, Ravenlock wrote:
 Hello,

 I wanted a slightly different behavior than what was available, so I've 
 changed it up a bit on my copy, and wanted others opinions as to whether 
 the change might be suitable for the general population.

I applaud the effort, but can you provide a patch that others can 
use/try ? Sometimes ideas have a better chance if they come with examples :)

 Please excuse me if I am getting my terminology (screens vs desks) mixed 
 up.

 Presently in e17.037...
 when you iconify a window, you can choose whether you want to have them 
 enumerated in the window list or not.  If you choose not to, then they 
 are not present at all.  If you wish to see them, you see *all* 
 iconified windows on the same screen.  Therefore, if you have only one 
 screen like myself, and you switch to one of your other virtual desks... 
 you see them *all* in the list.

 I would prefer them to not be there.  I prefer to use each virtual desk 
 as entirely separate from the others.

Others may also...
 Presently in my patched version...
 I have created options in the Configuration Panel - Advanced - Window 
 List - Window List Settings dialog which read:
   - Show iconified windows (- This was already present)
   - Show iconified windows from other desks
   - Show iconified windows from other screens

 and modified the winlist_border_add function with the following rule:
 if (bd-iconic)
   {
  if (!e_config-winlist_list_show_iconified) ok = 0;
  if ((bd-zone != zone) 
  (!e_config-winlist_list_show_other_screen_iconified)) ok = 0;  
  if ((bd-desk != desk) 
  (!e_config-winlist_list_show_other_desk_iconified)) ok = 0;
   }

 This allows me more flexibility over what I see in the window list.  If 
 I do not want to see those windows which are iconified on desk0 *from* 
 desk1, then I can uncheck the Show iconified windows from other desks.
 
 [Forgot to mention]
 This matches (I think) the functionality of the ibox, in a sense.  The 
 icon boxes can show (!or not!) windows from other screens and desks.
 
 I have given the following default values
  winlist_list_show_iconified = 1
  winlist_list_show_other_desk_iconified = 1
  winlist_list_show_other_screen_iconified = 0
 as I think these represent the original behavior before the changes.

 One thing I am aware of that I *did not* do (which may need 
 addressing)...  I did not modify the IPC_Handlers in any way.  I was 
 hoping for comments on that.  Is it necessary?  Adding something to 
 e_int_config_winlist.h looks, well painful.

It's general practice that when new config properties get created, they 
should be put into enlightenment_remote ipc calls, yes. In the future, 
the ipc code is going to get a much-needed cleaning, but for now your 
option should go in.

 Your thoughts?  Would anyone be interested in this functionality?

 Regards,
 -R

Cheers,
dh

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] exhibit fullscreen patch

2006-12-14 Thread phriedrich
Hi,

as I'm using gqview, I really like the exhibit image viewer.
The attached patch allows you to toggle to fullscreen mode.

A further improvement would be to have a black background in fullscreen
instead of the one colored with the etk's background color.

In fullscreen mode the next image can be selected with SPACE and the
previous with 'b'.

Best regards,
Friedrich
diff -Naur exhibit/src/bin/exhibit.h exhibit_current/src/bin/exhibit.h
--- exhibit/src/bin/exhibit.h	2006-12-14 10:18:12.482892235 +0100
+++ exhibit_current/src/bin/exhibit.h	2006-12-14 10:19:13.703892235 +0100
@@ -186,6 +186,7 @@
 struct _Exhibit
 {
Etk_Widget*vbox;
+   Etk_Widget*vboxf;
Etk_Widget*hbox;
Etk_Widget*menu_bar;
Etk_Widget*statusbar[4];
diff -Naur exhibit/src/bin/exhibit_main.c exhibit_current/src/bin/exhibit_main.c
--- exhibit/src/bin/exhibit_main.c	2006-12-14 10:18:12.487892235 +0100
+++ exhibit_current/src/bin/exhibit_main.c	2006-12-14 11:35:46.812892235 +0100
@@ -121,8 +121,10 @@
etk_statusbar_message_pop(ETK_STATUSBAR(e-statusbar[1]), 0);
etk_statusbar_message_push(ETK_STATUSBAR(e-statusbar[1]), size, 0);

-   hs = etk_scrolled_view_hscrollbar_get(ETK_SCROLLED_VIEW(e-cur_tab-scrolled_view));
-   vs = etk_scrolled_view_vscrollbar_get(ETK_SCROLLED_VIEW(e-cur_tab-scrolled_view));
+   hs = etk_scrolled_view_hscrollbar_get(
+	 ETK_SCROLLED_VIEW(e-cur_tab-scrolled_view));
+   vs = etk_scrolled_view_vscrollbar_get(
+	 ETK_SCROLLED_VIEW(e-cur_tab-scrolled_view));
   
etk_range_value_set(hs, (double)w/2);
etk_range_value_set(vs, (double)h/2);
@@ -494,7 +496,14 @@
 	  }
 	else if(!strcmp(ev-key, q))
 	  {
-	 etk_main_quit();
+/* when in full screen mode actually don't close 
+ * exhibit but leave full screen */
+if (!etk_window_fullscreen_get(e-win)){
+		etk_main_quit();
+}
+else {
+		_ex_main_window_fullscreen_toggle(e);
+}
 	  }
 	else if(!strcmp(ev-key, d))
 	  {
@@ -519,7 +528,24 @@
 	  {
 	 _ex_main_window_slideshow_toggle();
 	  }		   
+	else if(!strcmp(ev-key, f))
+	  {
+	 _ex_main_window_fullscreen_toggle(e);
+	  }		   
  }
+
+	 /* only active when in full screen mode */
+	 if (etk_window_fullscreen_get(e-win)) {
+			 if(!strcmp(ev-key, f)) {
+	 _ex_main_window_fullscreen_toggle(e);
+			 }
+			 if(!strcmp(ev-key, space)) {
+	 _ex_slideshow_next(e);
+			 }
+			 if(!strcmp(ev-key, b)) {
+	 _ex_slideshow_prev(e);
+			 }
+	 }
 }
 
 static void
@@ -538,6 +564,38 @@
  _ex_slideshow_start();
 }
 
+void
+_ex_main_window_fullscreen_toggle(Exhibit *e) {
+		if (etk_window_fullscreen_get(e-win)) {
+etk_container_remove(ETK_CONTAINER(e-win), e-vboxf);
+etk_container_add(ETK_CONTAINER(e-win), e-vbox);
+etk_widget_show_all(e-win);
+etk_container_add(ETK_CONTAINER(e-hpaned_shadow), e-notebook);
+if (evas_list_count(e-tabs)  1)
+		etk_notebook_tabs_visible_set(ETK_NOTEBOOK(e-notebook), ETK_TRUE);
+else
+		etk_notebook_tabs_visible_set(ETK_NOTEBOOK(e-notebook), ETK_FALSE);
+etk_window_fullscreen_set(e-win, ETK_FALSE);
+
+		}
+		else{
+etk_window_fullscreen_set(e-win, ETK_TRUE);
+etk_widget_hide(e-statusbar[0]);
+etk_widget_hide(e-statusbar[1]);
+etk_widget_hide(e-statusbar[2]);
+etk_widget_hide(e-statusbar[3]);
+etk_widget_hide(e-sort_bar);
+etk_container_remove(ETK_CONTAINER(e-win), e-vbox);
+e-vboxf = etk_vbox_new(ETK_FALSE, 0);
+etk_container_add(ETK_CONTAINER(e-win), e-vboxf);
+etk_box_append(ETK_BOX(e-vboxf), e-notebook, 
+ETK_BOX_START, ETK_BOX_EXPAND_FILL, 0);
+etk_widget_show(e-vboxf);
+etk_widget_show(e-notebook);
+etk_notebook_tabs_visible_set(ETK_NOTEBOOK(e-notebook), ETK_FALSE);
+		}
+}
+
 static void 
 _ex_main_window_tab_toggled_cb(Etk_Object *object, void *data)
 { 
diff -Naur exhibit/src/bin/exhibit_main.h exhibit_current/src/bin/exhibit_main.h
--- exhibit/src/bin/exhibit_main.h	2006-12-14 10:18:12.488892235 +0100
+++ exhibit_current/src/bin/exhibit_main.h	2006-12-14 10:19:13.756892235 +0100
@@ -9,6 +9,7 @@
 void _ex_main_itree_add(const char *file, const char *selected_file);
 int  _ex_main_window_slideshow_next(void *data);
 void _ex_main_window_slideshow_toggle();
+void _ex_main_window_fullscreen_toggle();
 void _ex_main_window_tab_append(Ex_Tab *tab);
 void _ex_main_window_tab_remove(Ex_Tab *tab);
 void _ex_main_dialog_show(char *text, Etk_Message_Dialog_Type type);
diff -Naur exhibit/src/bin/exhibit_menus.c exhibit_current/src/bin/exhibit_menus.c
--- exhibit/src/bin/exhibit_menus.c	2006-12-14 10:18:12.489892235 +0100
+++ exhibit_current/src/bin/exhibit_menus.c	2006-12-14 10:25:23.589892235 +0100
@@ -544,6 +544,7 @@
 	 bcontrol-d:/b add to favorites\n
 	 bcontrol-x:/b toggle view\n
 	 bcontrol-q:/b exit program\n
+	 bcontrol-f:/b toggle fullscreen\n
 	 bcontrol-s:/b toggle slideshow\n,
 	 ETK_TRUE);

Re: [E-devel] exhibit fullscreen patch

2006-12-14 Thread Chady Kassouf
On 12/14/06, phriedrich [EMAIL PROTECTED] wrote:

 Hi,

 as I'm using gqview, I really like the exhibit image viewer.
 The attached patch allows you to toggle to fullscreen mode.

 A further improvement would be to have a black background in fullscreen
 instead of the one colored with the etk's background color.

 In fullscreen mode the next image can be selected with SPACE and the
 previous with 'b'.


Thank you

Codewarrior, quick, if this patch is good apply it please. :D

Now all we need is the ability to say from the command line: exhibit -f bleh
and run the fullscreen mode and I can stop using gqview.



-- 
Chady 'Leviathan' Kassouf
http://chady.net/
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] exhibit fullscreen patch

2006-12-14 Thread phriedrich
Am Thu, 14 Dec 2006 12:50:27 +0200
schrieb Chady Kassouf [EMAIL PROTECTED]:

 Now all we need is the ability to say from the command line: exhibit
 -f bleh and run the fullscreen mode and I can stop using gqview.
for me this works with just exhibit foo.png :)


signature.asc
Description: PGP signature
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] exhibit fullscreen patch

2006-12-14 Thread Hisham Mardam Bey
On 12/14/06, phriedrich [EMAIL PROTECTED] wrote:
 Hi,

 as I'm using gqview, I really like the exhibit image viewer.
 The attached patch allows you to toggle to fullscreen mode.

 A further improvement would be to have a black background in fullscreen
 instead of the one colored with the etk's background color.

 In fullscreen mode the next image can be selected with SPACE and the
 previous with 'b'.


Thanks! In cvs (=

-- 
Hisham Mardam Bey
MSc (Computer Science)
http://hisham.cc/
+9613609386
Codito Ergo Sum (I Code Therefore I Am)

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] exhibit fullscreen patch

2006-12-14 Thread Hisham Mardam Bey
On 12/14/06, Chady Kassouf [EMAIL PROTECTED] wrote:
 On 12/14/06, phriedrich [EMAIL PROTECTED] wrote:
 
  Hi,
 
  as I'm using gqview, I really like the exhibit image viewer.
  The attached patch allows you to toggle to fullscreen mode.
 
  A further improvement would be to have a black background in fullscreen
  instead of the one colored with the etk's background color.
 
  In fullscreen mode the next image can be selected with SPACE and the
  previous with 'b'.


 Thank you

 Codewarrior, quick, if this patch is good apply it please. :D

 Now all we need is the ability to say from the command line: exhibit -f bleh
 and run the fullscreen mode and I can stop using gqview.


Done, dump it! (=


-- 
Hisham Mardam Bey
MSc (Computer Science)
http://hisham.cc/
+9613609386
Codito Ergo Sum (I Code Therefore I Am)

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Showing icons on other desks and screens in the window list (or not).....

2006-12-14 Thread Ravenlock

On 12/14/2006 03:43, Christopher Michael wrote:

Ravenlock wrote:

On 12/13/2006 23:00, Ravenlock wrote:

Hello,

I wanted a slightly different behavior than what was available, so 
I've changed it up a bit on my copy, and wanted others opinions as to 
whether the change might be suitable for the general population.


I applaud the effort, but can you provide a patch that others can 
use/try ? Sometimes ideas have a better chance if they come with 
examples :)


K. Try the attached.  Do you (the e-developers) have a preferred diff 
format?  If you have trouble with the diff let me know.




Please excuse me if I am getting my terminology (screens vs desks) 
mixed up.


Presently in e17.037...
when you iconify a window, you can choose whether you want to have 
them enumerated in the window list or not.  If you choose not to, 
then they are not present at all.  If you wish to see them, you see 
*all* iconified windows on the same screen.  Therefore, if you have 
only one screen like myself, and you switch to one of your other 
virtual desks... you see them *all* in the list.


I would prefer them to not be there.  I prefer to use each virtual 
desk as entirely separate from the others.



Others may also...

Presently in my patched version...
I have created options in the Configuration Panel - Advanced - 
Window List - Window List Settings dialog which read:

  - Show iconified windows (- This was already present)
  - Show iconified windows from other desks
  - Show iconified windows from other screens

and modified the winlist_border_add function with the following rule:
if (bd-iconic)
  {
if (!e_config-winlist_list_show_iconified) ok = 0;
if ((bd-zone != zone) 
(!e_config-winlist_list_show_other_screen_iconified)) ok = 
0;   
if ((bd-desk != desk) 

(!e_config-winlist_list_show_other_desk_iconified)) ok = 0;
  }

This allows me more flexibility over what I see in the window list.  
If I do not want to see those windows which are iconified on desk0 
*from* desk1, then I can uncheck the Show iconified windows from 
other desks.


[Forgot to mention]
This matches (I think) the functionality of the ibox, in a sense.  The 
icon boxes can show (!or not!) windows from other screens and desks.



I have given the following default values
winlist_list_show_iconified = 1
winlist_list_show_other_desk_iconified = 1
winlist_list_show_other_screen_iconified = 0
as I think these represent the original behavior before the changes.

One thing I am aware of that I *did not* do (which may need 
addressing)...  I did not modify the IPC_Handlers in any way.  I was 
hoping for comments on that.  Is it necessary?  Adding something to 
e_int_config_winlist.h looks, well painful.


It's general practice that when new config properties get created, they 
should be put into enlightenment_remote ipc calls, yes. In the future, 
the ipc code is going to get a much-needed cleaning, but for now your 
option should go in.


ok.  I started down this road.  May have even completed it, though I 
haven't built it yet.  So I backed it out for the diff attached.  How 
would I go about testing them?  using enlightenment_remote?  I've never 
used that nor do I have any idea what its for (aside from what the name 
implies).  I'll look into it.





Your thoughts?  Would anyone be interested in this functionality?

Regards,
-R


Cheers,
dh



diff -u /home/ravenlock/MyDocs/MyProjects/E/e17.0/apps/e/src/bin/e_config.c 
./e_config.c
--- /home/ravenlock/MyDocs/MyProjects/E/e17.0/apps/e/src/bin/e_config.c Mon Nov 
13 01:26:14 2006
+++ ./e_config.cWed Dec 13 19:48:38 2006
@@ -397,6 +397,8 @@
E_CONFIG_VAL(D, T, winlist_scroll_animate, INT); /**/
E_CONFIG_VAL(D, T, winlist_scroll_speed, DOUBLE); /**/
E_CONFIG_VAL(D, T, winlist_list_show_iconified, INT); /**/
+   E_CONFIG_VAL(D, T, winlist_list_show_other_desk_iconified, INT); /**/
+   E_CONFIG_VAL(D, T, winlist_list_show_other_screen_iconified, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_show_other_desk_windows, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_show_other_screen_windows, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_uncover_while_selecting, INT); /**/
@@ -601,6 +603,8 @@
e_config-winlist_scroll_animate = 1;
e_config-winlist_scroll_speed = 0.1;
e_config-winlist_list_show_iconified = 1;
+   e_config-winlist_list_show_other_desk_iconified = 1;
+   e_config-winlist_list_show_other_screen_iconified = 0;
e_config-winlist_list_show_other_desk_windows = 0;
e_config-winlist_list_show_other_screen_windows = 0;
e_config-winlist_list_uncover_while_selecting = 0;
@@ -1314,6 +1318,8 @@
E_CONFIG_LIMIT(e_config-winlist_scroll_animate, 0, 1);
E_CONFIG_LIMIT(e_config-winlist_scroll_speed, 0.0, 1.0);
E_CONFIG_LIMIT(e_config-winlist_list_show_iconified, 0, 1);
+   E_CONFIG_LIMIT(e_config-winlist_list_show_other_desk_iconified, 0, 1);
+   

Re: [E-devel] Showing icons on other desks and screens in the window list (or not).....

2006-12-14 Thread Aleksej Struk
On Thu, Dec 14, 2006 at 08:36:35AM -0600, Ravenlock wrote:
 On 12/14/2006 03:43, Christopher Michael wrote:
 Ravenlock wrote:
 On 12/13/2006 23:00, Ravenlock wrote:
 Hello,
 
 I wanted a slightly different behavior than what was available, so 
 I've changed it up a bit on my copy, and wanted others opinions as to 
 whether the change might be suitable for the general population.
 
 I applaud the effort, but can you provide a patch that others can 
 use/try ? Sometimes ideas have a better chance if they come with 
 examples :)
 
 K. Try the attached.  Do you (the e-developers) have a preferred diff 
 format?  If you have trouble with the diff let me know.

usually cvs diff -u is preferred.

 
 
 Please excuse me if I am getting my terminology (screens vs desks) 
 mixed up.
 
 Presently in e17.037...
 when you iconify a window, you can choose whether you want to have 
 them enumerated in the window list or not.  If you choose not to, 
 then they are not present at all.  If you wish to see them, you see 
 *all* iconified windows on the same screen.  Therefore, if you have 
 only one screen like myself, and you switch to one of your other 
 virtual desks... you see them *all* in the list.
 
 I would prefer them to not be there.  I prefer to use each virtual 
 desk as entirely separate from the others.
 
 Others may also...
 Presently in my patched version...
 I have created options in the Configuration Panel - Advanced - 
 Window List - Window List Settings dialog which read:
   - Show iconified windows (- This was already present)
   - Show iconified windows from other desks
   - Show iconified windows from other screens
 
 and modified the winlist_border_add function with the following rule:
 if (bd-iconic)
   {
 if (!e_config-winlist_list_show_iconified) ok = 0;
 if ((bd-zone != zone) 
 (!e_config-winlist_list_show_other_screen_iconified)) ok = 
 0;   
 if ((bd-desk != desk) 
 (!e_config-winlist_list_show_other_desk_iconified)) ok = 0;
   }
 
 This allows me more flexibility over what I see in the window list.  
 If I do not want to see those windows which are iconified on desk0 
 *from* desk1, then I can uncheck the Show iconified windows from 
 other desks.
 
 [Forgot to mention]
 This matches (I think) the functionality of the ibox, in a sense.  The 
 icon boxes can show (!or not!) windows from other screens and desks.
 
 I have given the following default values
 winlist_list_show_iconified = 1
 winlist_list_show_other_desk_iconified = 1
 winlist_list_show_other_screen_iconified = 0
 as I think these represent the original behavior before the changes.
 
 One thing I am aware of that I *did not* do (which may need 
 addressing)...  I did not modify the IPC_Handlers in any way.  I was 
 hoping for comments on that.  Is it necessary?  Adding something to 
 e_int_config_winlist.h looks, well painful.
 
 It's general practice that when new config properties get created, they 
 should be put into enlightenment_remote ipc calls, yes. In the future, 
 the ipc code is going to get a much-needed cleaning, but for now your 
 option should go in.
 
 ok.  I started down this road.  May have even completed it, though I 
 haven't built it yet.  So I backed it out for the diff attached.  How 
 would I go about testing them?  using enlightenment_remote?  I've never 
 used that nor do I have any idea what its for (aside from what the name 
 implies).  I'll look into it.
 
 
 Your thoughts?  Would anyone be interested in this functionality?
 
 Regards,
 -R
 
 Cheers,
 dh
 
 

 diff -u /home/ravenlock/MyDocs/MyProjects/E/e17.0/apps/e/src/bin/e_config.c 
 ./e_config.c
 --- /home/ravenlock/MyDocs/MyProjects/E/e17.0/apps/e/src/bin/e_config.c   
 Mon Nov 13 01:26:14 2006
 +++ ./e_config.c  Wed Dec 13 19:48:38 2006
 @@ -397,6 +397,8 @@
 E_CONFIG_VAL(D, T, winlist_scroll_animate, INT); /**/
 E_CONFIG_VAL(D, T, winlist_scroll_speed, DOUBLE); /**/
 E_CONFIG_VAL(D, T, winlist_list_show_iconified, INT); /**/
 +   E_CONFIG_VAL(D, T, winlist_list_show_other_desk_iconified, INT); /**/
 +   E_CONFIG_VAL(D, T, winlist_list_show_other_screen_iconified, INT); /**/
 E_CONFIG_VAL(D, T, winlist_list_show_other_desk_windows, INT); /**/
 E_CONFIG_VAL(D, T, winlist_list_show_other_screen_windows, INT); /**/
 E_CONFIG_VAL(D, T, winlist_list_uncover_while_selecting, INT); /**/
 @@ -601,6 +603,8 @@
 e_config-winlist_scroll_animate = 1;
 e_config-winlist_scroll_speed = 0.1;
 e_config-winlist_list_show_iconified = 1;
 +   e_config-winlist_list_show_other_desk_iconified = 1;
 +   e_config-winlist_list_show_other_screen_iconified = 0;
 e_config-winlist_list_show_other_desk_windows = 0;
 e_config-winlist_list_show_other_screen_windows = 0;
 e_config-winlist_list_uncover_while_selecting = 0;
 @@ -1314,6 +1318,8 @@
 E_CONFIG_LIMIT(e_config-winlist_scroll_animate, 0, 1);
 E_CONFIG_LIMIT(e_config-winlist_scroll_speed, 0.0, 1.0);
 

Re: [E-devel] Showing icons on other desks and screens in the window list (or not).....

2006-12-14 Thread Ravenlock

On 12/14/2006 10:43, Aleksej Struk wrote:

On Thu, Dec 14, 2006 at 08:36:35AM -0600, Ravenlock wrote:

On 12/14/2006 03:43, Christopher Michael wrote:

Ravenlock wrote:

On 12/13/2006 23:00, Ravenlock wrote:

Hello,

I wanted a slightly different behavior than what was available, so 
I've changed it up a bit on my copy, and wanted others opinions as to 
whether the change might be suitable for the general population.


I applaud the effort, but can you provide a patch that others can 
use/try ? Sometimes ideas have a better chance if they come with 
examples :)
K. Try the attached.  Do you (the e-developers) have a preferred diff 
format?  If you have trouble with the diff let me know.


usually cvs diff -u is preferred.


heh.  Sorry.  Here you go (I hope).



Please excuse me if I am getting my terminology (screens vs desks) 
mixed up.


Presently in e17.037...
when you iconify a window, you can choose whether you want to have 
them enumerated in the window list or not.  If you choose not to, 
then they are not present at all.  If you wish to see them, you see 
*all* iconified windows on the same screen.  Therefore, if you have 
only one screen like myself, and you switch to one of your other 
virtual desks... you see them *all* in the list.


I would prefer them to not be there.  I prefer to use each virtual 
desk as entirely separate from the others.



Others may also...

Presently in my patched version...
I have created options in the Configuration Panel - Advanced - 
Window List - Window List Settings dialog which read:

 - Show iconified windows (- This was already present)
 - Show iconified windows from other desks
 - Show iconified windows from other screens

and modified the winlist_border_add function with the following rule:
   if (bd-iconic)
 {
   if (!e_config-winlist_list_show_iconified) ok = 0;
   if ((bd-zone != zone) 
   (!e_config-winlist_list_show_other_screen_iconified)) ok = 
0;   
   if ((bd-desk != desk) 

   (!e_config-winlist_list_show_other_desk_iconified)) ok = 0;
 }

This allows me more flexibility over what I see in the window list.  
If I do not want to see those windows which are iconified on desk0 
*from* desk1, then I can uncheck the Show iconified windows from 
other desks.

[Forgot to mention]
This matches (I think) the functionality of the ibox, in a sense.  The 
icon boxes can show (!or not!) windows from other screens and desks.



I have given the following default values
   winlist_list_show_iconified = 1
   winlist_list_show_other_desk_iconified = 1
   winlist_list_show_other_screen_iconified = 0
as I think these represent the original behavior before the changes.

One thing I am aware of that I *did not* do (which may need 
addressing)...  I did not modify the IPC_Handlers in any way.  I was 
hoping for comments on that.  Is it necessary?  Adding something to 
e_int_config_winlist.h looks, well painful.


It's general practice that when new config properties get created, they 
should be put into enlightenment_remote ipc calls, yes. In the future, 
the ipc code is going to get a much-needed cleaning, but for now your 
option should go in.
ok.  I started down this road.  May have even completed it, though I 
haven't built it yet.  So I backed it out for the diff attached.  How 
would I go about testing them?  using enlightenment_remote?  I've never 
used that nor do I have any idea what its for (aside from what the name 
implies).  I'll look into it.



Your thoughts?  Would anyone be interested in this functionality?

Regards,
-R

Cheers,
dh




diff -u /home/ravenlock/MyDocs/MyProjects/E/e17.0/apps/e/src/bin/e_config.c 
./e_config.c
--- /home/ravenlock/MyDocs/MyProjects/E/e17.0/apps/e/src/bin/e_config.c Mon Nov 
13 01:26:14 2006
+++ ./e_config.cWed Dec 13 19:48:38 2006
@@ -397,6 +397,8 @@
E_CONFIG_VAL(D, T, winlist_scroll_animate, INT); /**/
E_CONFIG_VAL(D, T, winlist_scroll_speed, DOUBLE); /**/
E_CONFIG_VAL(D, T, winlist_list_show_iconified, INT); /**/
+   E_CONFIG_VAL(D, T, winlist_list_show_other_desk_iconified, INT); /**/
+   E_CONFIG_VAL(D, T, winlist_list_show_other_screen_iconified, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_show_other_desk_windows, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_show_other_screen_windows, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_uncover_while_selecting, INT); /**/
@@ -601,6 +603,8 @@
e_config-winlist_scroll_animate = 1;
e_config-winlist_scroll_speed = 0.1;
e_config-winlist_list_show_iconified = 1;
+   e_config-winlist_list_show_other_desk_iconified = 1;
+   e_config-winlist_list_show_other_screen_iconified = 0;
e_config-winlist_list_show_other_desk_windows = 0;
e_config-winlist_list_show_other_screen_windows = 0;
e_config-winlist_list_uncover_while_selecting = 0;
@@ -1314,6 +1318,8 @@
E_CONFIG_LIMIT(e_config-winlist_scroll_animate, 0, 1);
E_CONFIG_LIMIT(e_config-winlist_scroll_speed, 0.0, 1.0);

Re: [E-devel] Showing icons on other desks and screens in the window list (or not).....

2006-12-14 Thread Ravenlock

On 12/14/2006 09:29, Ravenlock wrote:

On 12/14/2006 10:43, Aleksej Struk wrote:

On Thu, Dec 14, 2006 at 08:36:35AM -0600, Ravenlock wrote:

On 12/14/2006 03:43, Christopher Michael wrote:

Ravenlock wrote:

On 12/13/2006 23:00, Ravenlock wrote:

Hello,

I wanted a slightly different behavior than what was available, so 
I've changed it up a bit on my copy, and wanted others opinions as 
to whether the change might be suitable for the general population.


I applaud the effort, but can you provide a patch that others can 
use/try ? Sometimes ideas have a better chance if they come with 
examples :)
K. Try the attached.  Do you (the e-developers) have a preferred diff 
format?  If you have trouble with the diff let me know.


usually cvs diff -u is preferred.


heh.  Sorry.  Here you go (I hope).



Here is a final one with the ipc updates as well.  If this patch does 
not apply cleanly please let me know.


Please take a look at the constants defined in e_ipc_handlers_list.h
, as I took the easy way out... and slipped them in out of numeric 
order.  Would you prefer I update ALL constants that follow my updates?




Please excuse me if I am getting my terminology (screens vs desks) 
mixed up.


Presently in e17.037...
when you iconify a window, you can choose whether you want to have 
them enumerated in the window list or not.  If you choose not to, 
then they are not present at all.  If you wish to see them, you 
see *all* iconified windows on the same screen.  Therefore, if you 
have only one screen like myself, and you switch to one of your 
other virtual desks... you see them *all* in the list.


I would prefer them to not be there.  I prefer to use each virtual 
desk as entirely separate from the others.



Others may also...

Presently in my patched version...
I have created options in the Configuration Panel - Advanced - 
Window List - Window List Settings dialog which read:

 - Show iconified windows (- This was already present)
 - Show iconified windows from other desks
 - Show iconified windows from other screens

and modified the winlist_border_add function with the following rule:
   if (bd-iconic)
 {
   if (!e_config-winlist_list_show_iconified) ok = 0;
   if ((bd-zone != zone) 
   (!e_config-winlist_list_show_other_screen_iconified)) ok = 
0;  if ((bd-desk != desk) 

   (!e_config-winlist_list_show_other_desk_iconified)) ok = 0;
 }

This allows me more flexibility over what I see in the window 
list.  If I do not want to see those windows which are iconified 
on desk0 *from* desk1, then I can uncheck the Show iconified 
windows from other desks.

[Forgot to mention]
This matches (I think) the functionality of the ibox, in a sense.  
The icon boxes can show (!or not!) windows from other screens and 
desks.



I have given the following default values
   winlist_list_show_iconified = 1
   winlist_list_show_other_desk_iconified = 1
   winlist_list_show_other_screen_iconified = 0
as I think these represent the original behavior before the changes.

One thing I am aware of that I *did not* do (which may need 
addressing)...  I did not modify the IPC_Handlers in any way.  I 
was hoping for comments on that.  Is it necessary?  Adding 
something to e_int_config_winlist.h looks, well painful.


It's general practice that when new config properties get created, 
they should be put into enlightenment_remote ipc calls, yes. In the 
future, the ipc code is going to get a much-needed cleaning, but for 
now your option should go in.
ok.  I started down this road.  May have even completed it, though I 
haven't built it yet.  So I backed it out for the diff attached.  How 
would I go about testing them?  using enlightenment_remote?  I've 
never used that nor do I have any idea what its for (aside from what 
the name implies).  I'll look into it.



Your thoughts?  Would anyone be interested in this functionality?

Regards,
-R

Cheers,
dh





Index: e17/apps/e/src/bin/e_config.c
===
RCS file: /var/cvs/e/e17/apps/e/src/bin/e_config.c,v
retrieving revision 1.215
diff -u -r1.215 e_config.c
--- e17/apps/e/src/bin/e_config.c   13 Nov 2006 07:26:14 -  1.215
+++ e17/apps/e/src/bin/e_config.c   14 Dec 2006 17:11:50 -
@@ -397,6 +397,8 @@
E_CONFIG_VAL(D, T, winlist_scroll_animate, INT); /**/
E_CONFIG_VAL(D, T, winlist_scroll_speed, DOUBLE); /**/
E_CONFIG_VAL(D, T, winlist_list_show_iconified, INT); /**/
+   E_CONFIG_VAL(D, T, winlist_list_show_other_desk_iconified, INT); /**/
+   E_CONFIG_VAL(D, T, winlist_list_show_other_screen_iconified, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_show_other_desk_windows, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_show_other_screen_windows, INT); /**/
E_CONFIG_VAL(D, T, winlist_list_uncover_while_selecting, INT); /**/
@@ -601,6 +603,8 @@
e_config-winlist_scroll_animate = 1;
e_config-winlist_scroll_speed = 0.1;

[E-devel] Slideshow patch

2006-12-14 Thread Zachary Goldberg

As per a conversation i've had with devilhorns this provides xinerama
support.  Essentially, if you have xinerama running, there is a new
option in the config dialoge for slideshow.  Possible options are now

-Change BG for all desktops
-Change BG for this desktop
-Change BG for this zone (all desktops on this monitor)



--ZGold
Index: e_mod_config.c
===
RCS file: /var/cvs/e/e_modules/slideshow/e_mod_config.c,v
retrieving revision 1.30
diff -r1.30 e_mod_config.c
113a114,118
if(ecore_x_xinerama_screen_count_get()  1)
  {
ob = e_widget_radio_add(evas, _(Set wallpaper on current monitor (Xinerama support)), 2, rg);
e_widget_framelist_object_append (of, ob);
  }
Index: e_mod_main.c
===
RCS file: /var/cvs/e/e_modules/slideshow/e_mod_main.c,v
retrieving revision 1.39
diff -r1.39 e_mod_main.c
538a539
int i;
564c565,575

---
else if (ci-all_desks == 2)
  {
 	con = e_container_current_get(e_manager_current_get());
 z = e_zone_current_get(con);
 for (i = 0; i  z-desk_x_count*z-desk_y_count; i++)
   {
 e_bg_del(con-num, z-num, z-desks[i]-x, z-desks[i]-y);
 e_bg_add(con-num, z-num, z-desks[i]-x, z-desks[i]-y, buf);
 	  }	
  }   
 
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Slideshow patch

2006-12-14 Thread Christopher Michael
Zachary Goldberg wrote:
 As per a conversation i've had with devilhorns this provides xinerama
 support.  Essentially, if you have xinerama running, there is a new
 option in the config dialoge for slideshow.  Possible options are now
 
 -Change BG for all desktops
 -Change BG for this desktop
 -Change BG for this zone (all desktops on this monitor)
 
 
 
 --ZGold
 
In cvs...Thank You :)

dh

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Showing icons on other desks and screens in the window list (or not).....

2006-12-14 Thread Ravenlock

On 12/14/2006 09:53, Ravenlock wrote:

On 12/14/2006 09:29, Ravenlock wrote:

On 12/14/2006 10:43, Aleksej Struk wrote:

On Thu, Dec 14, 2006 at 08:36:35AM -0600, Ravenlock wrote:

On 12/14/2006 03:43, Christopher Michael wrote:

Ravenlock wrote:

On 12/13/2006 23:00, Ravenlock wrote:

Hello,

I wanted a slightly different behavior than what was available, 
so I've changed it up a bit on my copy, and wanted others 
opinions as to whether the change might be suitable for the 
general population.


I applaud the effort, but can you provide a patch that others can 
use/try ? Sometimes ideas have a better chance if they come with 
examples :)
K. Try the attached.  Do you (the e-developers) have a preferred 
diff format?  If you have trouble with the diff let me know.


usually cvs diff -u is preferred.


heh.  Sorry.  Here you go (I hope).



Here is a final one with the ipc updates as well.  If this patch does 
not apply cleanly please let me know.


Please take a look at the constants defined in e_ipc_handlers_list.h
, as I took the easy way out... and slipped them in out of numeric 
order.  Would you prefer I update ALL constants that follow my updates?




Ok.  One more try.

WRT the constants in e_ipc_handlers_list.h... Given our conversation, 
and after a little more thought, I decided you were right.  They should 
be near the bottom, with the appropriate values.  I think keeping them 
out of order with a note at the top would simply cause bookeeping 
headaches for others.  So I opted for a note in the middle pointing you 
to where the new constants are, since they are not where you might think 
they would be.


Let me know if you have any troubles.



Please excuse me if I am getting my terminology (screens vs 
desks) mixed up.


Presently in e17.037...
when you iconify a window, you can choose whether you want to 
have them enumerated in the window list or not.  If you choose 
not to, then they are not present at all.  If you wish to see 
them, you see *all* iconified windows on the same screen.  
Therefore, if you have only one screen like myself, and you 
switch to one of your other virtual desks... you see them *all* 
in the list.


I would prefer them to not be there.  I prefer to use each 
virtual desk as entirely separate from the others.



Others may also...

Presently in my patched version...
I have created options in the Configuration Panel - Advanced - 
Window List - Window List Settings dialog which read:

 - Show iconified windows (- This was already present)
 - Show iconified windows from other desks
 - Show iconified windows from other screens

and modified the winlist_border_add function with the following 
rule:

   if (bd-iconic)
 {
   if (!e_config-winlist_list_show_iconified) ok = 0;
   if ((bd-zone != zone) 
   (!e_config-winlist_list_show_other_screen_iconified)) ok 
= 0;  if ((bd-desk != desk) 

   (!e_config-winlist_list_show_other_desk_iconified)) ok = 0;
 }

This allows me more flexibility over what I see in the window 
list.  If I do not want to see those windows which are iconified 
on desk0 *from* desk1, then I can uncheck the Show iconified 
windows from other desks.

[Forgot to mention]
This matches (I think) the functionality of the ibox, in a sense.  
The icon boxes can show (!or not!) windows from other screens and 
desks.



I have given the following default values
   winlist_list_show_iconified = 1
   winlist_list_show_other_desk_iconified = 1
   winlist_list_show_other_screen_iconified = 0
as I think these represent the original behavior before the changes.

One thing I am aware of that I *did not* do (which may need 
addressing)...  I did not modify the IPC_Handlers in any way.  I 
was hoping for comments on that.  Is it necessary?  Adding 
something to e_int_config_winlist.h looks, well painful.


It's general practice that when new config properties get created, 
they should be put into enlightenment_remote ipc calls, yes. In the 
future, the ipc code is going to get a much-needed cleaning, but 
for now your option should go in.
ok.  I started down this road.  May have even completed it, though I 
haven't built it yet.  So I backed it out for the diff attached.  
How would I go about testing them?  using enlightenment_remote?  
I've never used that nor do I have any idea what its for (aside from 
what the name implies).  I'll look into it.



Your thoughts?  Would anyone be interested in this functionality?

Regards,
-R

Cheers,
dh








-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV





Re: [E-devel] Showing icons on other desks and screens in the window list (or not).....

2006-12-14 Thread Christopher Michael
Committed in cvs...Thanks :)

dh

Ravenlock wrote:
 On 12/14/2006 09:53, Ravenlock wrote:
 On 12/14/2006 09:29, Ravenlock wrote:
 On 12/14/2006 10:43, Aleksej Struk wrote:
 On Thu, Dec 14, 2006 at 08:36:35AM -0600, Ravenlock wrote:
 On 12/14/2006 03:43, Christopher Michael wrote:
 Ravenlock wrote:
 On 12/13/2006 23:00, Ravenlock wrote:
 Hello,

 I wanted a slightly different behavior than what was available, 
 so I've changed it up a bit on my copy, and wanted others 
 opinions as to whether the change might be suitable for the 
 general population.

 I applaud the effort, but can you provide a patch that others can 
 use/try ? Sometimes ideas have a better chance if they come with 
 examples :)
 K. Try the attached.  Do you (the e-developers) have a preferred 
 diff format?  If you have trouble with the diff let me know.

 usually cvs diff -u is preferred.

 heh.  Sorry.  Here you go (I hope).


 Here is a final one with the ipc updates as well.  If this patch does 
 not apply cleanly please let me know.

 Please take a look at the constants defined in e_ipc_handlers_list.h
 , as I took the easy way out... and slipped them in out of numeric 
 order.  Would you prefer I update ALL constants that follow my updates?

 
 Ok.  One more try.
 
 WRT the constants in e_ipc_handlers_list.h... Given our conversation, 
 and after a little more thought, I decided you were right.  They should 
 be near the bottom, with the appropriate values.  I think keeping them 
 out of order with a note at the top would simply cause bookeeping 
 headaches for others.  So I opted for a note in the middle pointing you 
 to where the new constants are, since they are not where you might think 
 they would be.
 
 Let me know if you have any troubles.
 

 Please excuse me if I am getting my terminology (screens vs 
 desks) mixed up.

 Presently in e17.037...
 when you iconify a window, you can choose whether you want to 
 have them enumerated in the window list or not.  If you choose 
 not to, then they are not present at all.  If you wish to see 
 them, you see *all* iconified windows on the same screen.  
 Therefore, if you have only one screen like myself, and you 
 switch to one of your other virtual desks... you see them *all* 
 in the list.

 I would prefer them to not be there.  I prefer to use each 
 virtual desk as entirely separate from the others.

 Others may also...
 Presently in my patched version...
 I have created options in the Configuration Panel - Advanced - 
 Window List - Window List Settings dialog which read:
  - Show iconified windows (- This was already present)
  - Show iconified windows from other desks
  - Show iconified windows from other screens

 and modified the winlist_border_add function with the following 
 rule:
if (bd-iconic)
  {
if (!e_config-winlist_list_show_iconified) ok = 0;
if ((bd-zone != zone) 
(!e_config-winlist_list_show_other_screen_iconified)) ok 
 = 0;  if ((bd-desk != desk) 
(!e_config-winlist_list_show_other_desk_iconified)) ok = 0;
  }

 This allows me more flexibility over what I see in the window 
 list.  If I do not want to see those windows which are iconified 
 on desk0 *from* desk1, then I can uncheck the Show iconified 
 windows from other desks.
 [Forgot to mention]
 This matches (I think) the functionality of the ibox, in a 
 sense.  The icon boxes can show (!or not!) windows from other 
 screens and desks.

 I have given the following default values
winlist_list_show_iconified = 1
winlist_list_show_other_desk_iconified = 1
winlist_list_show_other_screen_iconified = 0
 as I think these represent the original behavior before the 
 changes.

 One thing I am aware of that I *did not* do (which may need 
 addressing)...  I did not modify the IPC_Handlers in any way.  I 
 was hoping for comments on that.  Is it necessary?  Adding 
 something to e_int_config_winlist.h looks, well painful.

 It's general practice that when new config properties get created, 
 they should be put into enlightenment_remote ipc calls, yes. In 
 the future, the ipc code is going to get a much-needed cleaning, 
 but for now your option should go in.
 ok.  I started down this road.  May have even completed it, though 
 I haven't built it yet.  So I backed it out for the diff attached.  
 How would I go about testing them?  using enlightenment_remote?  
 I've never used that nor do I have any idea what its for (aside 
 from what the name implies).  I'll look into it.

 Your thoughts?  Would anyone be interested in this functionality?

 Regards,
 -R
 Cheers,
 dh


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___