[E-devel] Etk filechooser widget patch
Hi all,
from the #etk discussion this is a patch for
e17/proto/etk/src/lib/etk_filechooser_widget.c
This patch resolve the bug that cause
etk_filechooser_widget_selected_file_get()
to return trash in the case no file is selected. With the patch
applied the function
will return NULL if no file is selected.
ps: this is my first patch for the e17 cvs, I have done it with the command:
diff -u old_file new_file
Is this the right method?
I see that other patch in the list have different syntax, so don't know
if this is good enought.
Thanks Dave
--- src/lib/etk_filechooser_widget_orig.c 2006-10-20 19:51:44.0 +0200
+++ src/lib/etk_filechooser_widget.c 2006-12-19 16:01:10.0 +0100
@@ -238,14 +238,14 @@
*/
const char *etk_filechooser_widget_selected_file_get(Etk_Filechooser_Widget *filechooser_widget)
{
- const char *filename;
+ const char *filename = NULL;
Etk_Tree_Row *row;
if (!filechooser_widget !(filechooser_widget-files_tree))
return NULL;
- row = etk_tree_selected_row_get(ETK_TREE(filechooser_widget-files_tree));
- etk_tree_row_fields_get(row, filechooser_widget-files_name_col, NULL, NULL, filename, NULL);
+ if (row = etk_tree_selected_row_get(ETK_TREE(filechooser_widget-files_tree)))
+ etk_tree_row_fields_get(row, filechooser_widget-files_name_col, NULL, NULL, filename, NULL);
return filename;
}
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Etk filechooser widget patch
DaveMDS wrote: ps: this is my first patch for the e17 cvs, I have done it with the command: diff -u old_file new_file Is this the right method? I see that other patch in the list have different syntax, so don't know if this is good enought. Good enough, but use cvs diff Sebastian - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Etk filechooser widget patch
On 12/19/06, DaveMDS [EMAIL PROTECTED] wrote: Hi all, from the #etk discussion this is a patch for e17/proto/etk/src/lib/etk_filechooser_widget.c This patch resolve the bug that cause etk_filechooser_widget_selected_file_get() to return trash in the case no file is selected. With the patch applied the function will return NULL if no file is selected. Thanks! In cvs. (= -- Hisham Mardam Bey MSc (Computer Science) http://hisham.cc/ +9613609386 Codito Ergo Sum (I Code Therefore I Am) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] WBoD when I try accessing E MenuApplication(sub menu)
White Box of Death when I try accessing E MenuApplication(sub menu) or to execute a command from 'Run Command'. Attach a log from a gdb backtrace, I may add more information but I use a batch file to generate this log so if you have request on some command I may had to the batch file. It will be a pleasure to add them. Marc-André Landry LMA1980 NB: first bt is for menu access and second is for 'Run Command' facility. Using host libthread_db library /lib/libthread_db.so.1. [Thread debugging using libthread_db enabled] [New Thread -1215646032 (LWP 31568)] 0xb7fc2410 in __kernel_vsyscall () #0 0xb7fc2410 in __kernel_vsyscall () #1 0xb796128b in poll () from /lib/libc.so.6 #2 0xb7a26967 in _XWaitForReadable () from /usr/lib/libX11.so.6 #3 0x0001 in ?? () #4 0x in ?? () #5 0xb7ad3b24 in ?? () from /usr/lib/libX11.so.6 #6 0xb7a2f939 in _X11TransSocketRead () from /usr/lib/libX11.so.6 Previous frame inner to this frame (corrupt stack?) [Current thread is 0 (process 31568)] Using host libthread_db library /lib/libthread_db.so.1. [Thread debugging using libthread_db enabled] [New Thread -1215777104 (LWP 31568)] 0xb7fa2410 in __kernel_vsyscall () #0 0xb7fa2410 in __kernel_vsyscall () #1 0xb794128b in poll () from /lib/libc.so.6 #2 0xb7a06967 in _XWaitForReadable () from /usr/lib/libX11.so.6 #3 0x0001 in ?? () #4 0x in ?? () #5 0xb7ab3b24 in ?? () from /usr/lib/libX11.so.6 #6 0xb7a0f939 in _X11TransSocketRead () from /usr/lib/libX11.so.6 Previous frame inner to this frame (corrupt stack?) [Current thread is 0 (process 31568)] - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] export of LD_LIBRARY_PATH in e_start_main.c
On Tuesday 19 December 2006 02:56, Stephan Wezel wrote: hmm in my manpage about ld.so i can't find any references to ORIGIN/LD_ORIGIN ENV-Var read the source code then -mike pgpbL4dzqpWyU.pgp Description: PGP signature - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] bittorrent.ico causes segfault
Updated e from CVS a few hours ago, and now I get a segfault whenever e runs across bittorrent.ico, i.e. in the apps menu (as you try to open it e segv's) and the run box - anything which brings up bittorrent's icon will make e segfault. Attached is the backtrace of the segfault and bittorrent.ico (gzip'ed) I'm happy to help in any way I can, Tom -- Thomas C R Spurden Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1214974288 (LWP 28328)] 0xb7d4ea96 in evas_common_image_free (im=0x8321090) at evas_image_main.c:270 270if (im-cs.data != im-image-data) (gdb) bt #0 0xb7d4ea96 in evas_common_image_free (im=0x8321090) at evas_image_main.c:270 #1 0xb7d4df1d in evas_common_load_image_from_file (file=0x8325348 /usr/share/pixmaps/bittorrent.ico, key=0x0, lo=0xbfedb240) at evas_image_load.c:91 #2 0xb7ef2224 in eng_image_load (data=0x83232a0, file=0x8325348 /usr/share/pixmaps/bittorrent.ico, key=0x0, error=0x88169ac, lo=0xbfedb240) at evas_engine.c:485 #3 0xb7d09499 in evas_object_image_file_set (obj=0x8816848, file=0x8325348 /usr/share/pixmaps/bittorrent.ico, key=0x0) at evas_object_image.c:165 #4 0x0809b902 in e_icon_file_set (obj=0x88264f0, file=0x8325348 /usr/share/pixmaps/bittorrent.ico) at e_icon.c:48 #5 0x08098a03 in _e_menu_realize (m=0x8254f40) at e_menu.c:1256 #6 0x08099217 in e_menu_idler_before () at e_menu.c:879 #7 0x080688dd in _e_main_cb_idler_before (data=0x0) at e_main.c:1337 #8 0xb7f00b47 in _ecore_idle_enterer_call () at ecore_idle_enterer.c:78 #9 0xb7f0317d in _ecore_main_loop_iterate_internal (once_only=0) at ecore_main.c:487 #10 0xb7f034e7 in ecore_main_loop_begin () at ecore_main.c:79 #11 0x080675f5 in main (argc=1, argv=0xbfedee34) at e_main.c:823 bittorrent.ico.gz Description: GNU Zip compressed data signature.asc Description: PGP signature - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] WBoD when I try accessing E MenuApplication(sub menu)
On Tue, 19 Dec 2006 17:24:22 -0500 Landry, Marc-Andre [EMAIL PROTECTED] wrote: White Box of Death when I try accessing E MenuApplication(sub menu) or to execute a command from 'Run Command'. Attach a log from a gdb backtrace, I may add more information but I use a batch file to generate this log so if you have request on some command I may had to the batch file. It will be a pleasure to add them. I could be the librsvg problem. It's looking like version 2.16.0 is buggy. signature.asc Description: PGP signature - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] bittorrent.ico causes segfault
Thomas C R Spurden wrote: Updated e from CVS a few hours ago, and now I get a segfault whenever e runs across bittorrent.ico, i.e. in the apps menu (as you try to open it e segv's) and the run box - anything which brings up bittorrent's icon will make e segfault. Attached is the backtrace of the segfault and bittorrent.ico (gzip'ed) I'm happy to help in any way I can, Tom -- Thomas C R Spurden I have just committed a fix for this issue (have been hunting it all day with people on irc) that should correct the issue. Basically the problem was that evas was trying to make comparisons on image data, without checking that there actually was image data. Update your cvs evas a little later and it should be fixed. Cheers, devilhorns - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
