[E-devel] modules to disable by default in monday release
Hello all, I think that some modules should be disabled, at least at runtime, by default. Things like change colors and fonts, drop shadows and few others. What do you think? If you know of broken modules, then we can easily disable them in configure.ac, just add false instead of true for module line. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Notification escape text patch
Hi,
Thanks, that fixed it
Amey
On Sun, Apr 19, 2009 at 2:15 PM, Gustavo Sverzut Barbieri
barbi...@profusion.mobi wrote:
On Sun, Apr 19, 2009 at 3:32 AM, Amey Parulekar amey@gmail.com
wrote:
Hi,
This patch uses the new edje_object_part_text_unescaped_set function to
escape special characters from notification popup body. Also fixes ticket
#277.
no pathc, make sure your firefox recognizes .diff and .patch as
text/something, otherwise mail list will strip attachments.
add to /etc/mime.types:
text/x-diff diff patch
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
Index: trunk/E-MODULES-EXTRA/notification/src/e_mod_popup.c
===
--- trunk/E-MODULES-EXTRA/notification/src/e_mod_popup.c (revision 40129)
+++ trunk/E-MODULES-EXTRA/notification/src/e_mod_popup.c (working copy)
@@ -382,19 +382,20 @@
char *dest;
int len = 6;
int size = 512;
-
edje_object_part_text_set(popup-theme, notification.text.title,
e_notification_summary_get(n));
msg = calloc(1, 512);
+ orig = e_notification_body_get(n);
+ edje_object_part_text_unescaped_set(popup-theme, notification.textblock.message, orig);
snprintf(msg, 511, body);
- for (orig = e_notification_body_get(n), dest = msg + strlen(msg); orig *orig; orig++)
+ for (dest = msg + strlen(msg); orig *orig; orig++)
{
if (len = size - 4)
{
size = len + 512;
msg = realloc(msg, size);
- msg = memset(msg + len, 0, size - len);
+ //msg = memset(msg + len, 0, size - len);
dest = msg + len;
}
--
Stay on top of everything new and different, both inside and
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today.
Use priority code J9JMT32. http://p.sf.net/sfu/p___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecore_evas_fb.c fix input
Done, thanks for the reminder. :M: -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] New Trac Wiki
Hello, as I found out now there's a new wiki: http://trac.enlightenment.org/e/wiki to replace the old one: http://wiki.enlightenment.org/index.php/Main_Page It doesn't worth to discuss about that change, because it seems the decision has yet took place... The only thing that I now could do is to please all people helping to migrate the useful information from the old wiki to the new wiki. I started with some articles and marked them as old. As you could see I marked them with: '''This page has moved to [new trac wiki URL]. Don't do any more edits here!''' Then I removed the group tag and if available the link from the refering page. There are still some contents on get-e.org that I've linked as reference. Not sure if they're still usable. I think it's a little out dated and could only be used very selective. Now please go on and move your pages from the old to the new wiki. I'll do so from time to time when I like to edit something. regards Andreas -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [e-users] New Trac Wiki
On Sun, Apr 19, 2009 at 3:26 PM, Andreas Volz li...@brachttal.net wrote: Hello, as I found out now there's a new wiki: http://trac.enlightenment.org/e/wiki to replace the old one: http://wiki.enlightenment.org/index.php/Main_Page It doesn't worth to discuss about that change, because it seems the decision has yet took place... AFAIU there is no decision left, we moved to trac already. The only thing that I now could do is to please all people helping to migrate the useful information from the old wiki to the new wiki. I started with some articles and marked them as old. As you could see I marked them with: '''This page has moved to [new trac wiki URL]. Don't do any more edits here!''' Then I removed the group tag and if available the link from the refering page. yeah, we need more people to help moving. There are still some contents on get-e.org that I've linked as reference. Not sure if they're still usable. I think it's a little out dated and could only be used very selective. get-e.org is/should be dead, we should redirect www.get-e.org to www.enlightenment.org, download page. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] modules to disable by default in monday release
On Sun, Apr 19, 2009 at 9:57 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 19 Apr 2009 05:47:38 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: Hello all, I think that some modules should be disabled, at least at runtime, by default. Things like change colors and fonts, drop shadows and few others. What do you think? If you know of broken modules, then we can easily disable them in configure.ac, just add false instead of true for module line. dropshadow is broken? no, but it is lame :-P yes - fonts and colors i had already marked as disabled for e17 (fixed up for e18). n.b. - i'd disable in config profile, not build... ? new users will lose them - old users keep what they have. ok, I'd rather disable their build, but just in profiles is fine. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [e-users] New Trac Wiki
Am Sun, 19 Apr 2009 17:12:33 -0300 schrieb Gustavo Sverzut Barbieri: On Sun, Apr 19, 2009 at 3:26 PM, Andreas Volz li...@brachttal.net wrote: Hello, as I found out now there's a new wiki: http://trac.enlightenment.org/e/wiki to replace the old one: http://wiki.enlightenment.org/index.php/Main_Page It doesn't worth to discuss about that change, because it seems the decision has yet took place... AFAIU there is no decision left, we moved to trac already. The only thing that I now could do is to please all people helping to migrate the useful information from the old wiki to the new wiki. I started with some articles and marked them as old. As you could see I marked them with: '''This page has moved to [new trac wiki URL]. Don't do any more edits here!''' Then I removed the group tag and if available the link from the refering page. yeah, we need more people to help moving. There are still some contents on get-e.org that I've linked as reference. Not sure if they're still usable. I think it's a little out dated and could only be used very selective. get-e.org is/should be dead, we should redirect www.get-e.org to www.enlightenment.org, download page. Do that with the main page if you like. But please don't delete sub-pages as the user guide hasn't yet moved to the wiki. regards Andreas -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] modules to disable by default in monday release
On Sun, Apr 19, 2009 at 06:03:06PM -0300, Gustavo Sverzut Barbieri wrote : n.b. - i'd disable in config profile, not build... ? new users will lose them - old users keep what they have. ok, I'd rather disable their build, but just in profiles is fine. I agree with raster. Unless those modules are broken, there's no point preventing users from trying them out - disabled at runtime is better IMHO. Regards, -- Albin Tonnerre signature.asc Description: Digital signature -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] modules to disable by default in monday release
I hope you don't disable dropshadow... Even if it's lame... ;) On Sun, Apr 19, 2009 at 06:03:06PM -0300, Gustavo Sverzut Barbieri wrote: On Sun, Apr 19, 2009 at 9:57 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 19 Apr 2009 05:47:38 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: Hello all, I think that some modules should be disabled, at least at runtime, by default. Things like change colors and fonts, drop shadows and few others. What do you think? If you know of broken modules, then we can easily disable them in configure.ac, just add false instead of true for module line. dropshadow is broken? no, but it is lame :-P yes - fonts and colors i had already marked as disabled for e17 (fixed up for e18). n.b. - i'd disable in config profile, not build... ? new users will lose them - old users keep what they have. ok, I'd rather disable their build, but just in profiles is fine. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Notification escape text patch
Ok, I don't see what's your point with that, you set the escaped
version than reset with your own escaping!
Attached is a patch I hacked quickly to add rich text as
http://galago-project.org/specs/notification/0.9/x161.html and also
added a lame copy of gnome-osd, with semi-transparent bg that fades on
mouse-in. Please build on this and send a nice good looking version
later :-)
Regards,
On Sun, Apr 19, 2009 at 5:50 AM, Amey Parulekar amey@gmail.com wrote:
Hi,
Thanks, that fixed it
Amey
On Sun, Apr 19, 2009 at 2:15 PM, Gustavo Sverzut Barbieri
barbi...@profusion.mobi wrote:
On Sun, Apr 19, 2009 at 3:32 AM, Amey Parulekar amey@gmail.com
wrote:
Hi,
This patch uses the new edje_object_part_text_unescaped_set function
to
escape special characters from notification popup body. Also fixes
ticket
#277.
no pathc, make sure your firefox recognizes .diff and .patch as
text/something, otherwise mail list will strip attachments.
add to /etc/mime.types:
text/x-diff diff patch
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
Index: e-module-notification.edc
===
--- e-module-notification.edc (revision 40179)
+++ e-module-notification.edc (working copy)
@@ -30,13 +30,29 @@
styles {
style {
name: notification_style;
- base: font=Edje-Vera font_size=11 align=left color=#3c3c3c wrap=word text_class=module_normal;
- tag: subject + text_class=module_large font_size=16;
- tag: /subject - text_class=module_large font_size=16;
- tag: body + text_class=module_normal font_size=13;
- tag: /body - text_class=module_normal;
+ base: font=Sans font_size=11 align=left color=#3c3c3c wrap=word text_class=module_normal;
+ tag: subject + text_class=module_large font_size=16;
+ tag: body + text_class=module_normal font_size=13;
tag: br \n;
+ tag: b + font=Sans:style=Bold text_class=module_bold;
+ tag: i + font=Sans:style=Oblique text_class=module_bold;
+ tag: u + underline=on;
+ tag: img ; /* images not supported */
+ tag: a ; /* links not supported */
}
+
+ style {
+ name: notification_style_alpha;
+ base: font=Sans font_size=11 align=left color=#fcfcfc outline_color=#000 shadow_color=#333 style=outline_soft_shadow wrap=word text_class=module_normal;
+ tag: subject + text_class=module_large font_size=16;
+ tag: body + text_class=module_normal font_size=13;
+ tag: br \n;
+ tag: b + font=Sans:style=Bold text_class=module_bold;
+ tag: i + font=Sans:style=Oblique text_class=module_bold;
+ tag: u + underline=on;
+ tag: img ; /* images not supported */
+ tag: a ; /* links not supported */
+ }
}
collections {
@@ -79,7 +95,7 @@
group {
name: modules/notification/main;
data {
-item: app_icon_max 80 80;
+item: app_icon_max 48 48;
}
parts {
part { name: base;
@@ -219,41 +235,62 @@
description {
state: default 0.0;
align: 0.0 0.5;
- fixed: 1 1;
aspect: 1 1;
aspect_preference: BOTH;
color: 255 0 150 255;
rel1 {
- relative: 0.0 0.0;
- offset: 5 -127;
+ relative: 0.0 1.0;
+ offset: 5 5;
+ to_y: title_back;
}
-
rel2 {
relative: 0.0 1.0;
- offset: 85 -127;
+ offset: 52 52;
+ to_y: title_back;
}
}
description {
state: high 0.0;
inherit: default 0.0;
- rel1.offset: 5 -63;
- rel2.offset: 85 -63;
+ rel1 {
+ relative: 0.0 0.0;
+ offset: 5 -48;
+ to_y: title_back;
+ }
+ rel2 {
+ relative: 0.0 0.0;
+ offset: 52 -1;
+ to_y: title_back;
+ }
}
description {
state: medium 0.0;
inherit: default 0.0;
- rel1.offset: 5 -23;
- rel2.offset: 85 -23;
+ rel1 {
+ relative: 0.0 0.0;
+ offset: 5 -28;
+ to_y: title_back;
+ }
+ rel2 {
+ relative: 0.0 0.0;
+ offset: 52 -21;
+ to_y: title_back;
+ }
Re: [E-devel] NOTICE: svn feature freeze this weekend (April 17-19)
And freeze is over! Packagers should use revision 40244, I documented this in http://trac.enlightenment.org/e/wiki/ReleaseSchedule Thanks you everybody that make this happen. SVN feels a bit better now, lots of commits in the last weeks, guys like raster, Ivan, Dave, Andreas and others helped a lot! Now let's rock on http://trac.enlightenment.org/e/wiki/Release list for next month! On Mon, Apr 13, 2009 at 12:18 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Hello all, As discussed in previous threads we will try to stabilize the SVN so packagers can do their work on a more solid base. So let's try to make the SVN more stable during this week and let's stop doing new feature during this weekend, doing bug fixes and testing instead. DEVELOPERS: If you have a massive change that would change all the repository and is still untested, please wait until next Monday or do it as a compile/runtime time option and leave it disabled until Monday. If possible, take a look at Active Tickets (http://trac.enlightenment.org/e/report/1) and validate (close if now invalid!) or try to fix a couple of them. Running valgrind, gdb and memprof are good things to do this week ;-) Thursday night I'll commit a FEATURE-LOCKED to svn trunk and we expect that after that commit we just do fixes. Sunday night I'll remove that file and that commit will be tagged in SVN. Packagers will build on that tag. USERS: Please update your SVN checkouts and try to update daily and report issues to mail list and also as tickets. We want to know what is broken so we can fix it, bear in mind that developers do not use all existent options and combination of them, so corner cases may show here and there. REPORT! If you want to help with development but have no coding skills, please go toActive Tickets and try to reproduce problems, if not possible ask the reporter to check it again and if not reproducible anymore to close the ticket. Willing to help testing? You can do: - compare expedite benchmarks on the same system, tell us if you see regressions. - check memory usage. - check if dialogs work properly. - create a dummy user and start with a clean profile, try to configure the system the way you want, see if it's possible (good way to test if dialogs work properly). References: - http://trac.enlightenment.org/e/wiki/ReleaseSchedule other freeze dates - http://trac.enlightenment.org/e/wiki/Release tasks to do before alpha release - http://trac.enlightenment.org/e/wiki/TestingPlan how to test (needs contributions!) Regards! -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] modules to disable by default in monday release
2009/4/20 Brian 'morlenxus' Miculcy morlen...@gmx.net: I hope you don't disable dropshadow... Even if it's lame... ;) On Sun, Apr 19, 2009 at 06:03:06PM -0300, Gustavo Sverzut Barbieri wrote: On Sun, Apr 19, 2009 at 9:57 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 19 Apr 2009 05:47:38 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: Hello all, I think that some modules should be disabled, at least at runtime, by default. Things like change colors and fonts, drop shadows and few others. What do you think? If you know of broken modules, then we can easily disable them in configure.ac, just add false instead of true for module line. dropshadow is broken? no, but it is lame :-P No way man! Dropshadow is neat. yes - fonts and colors i had already marked as disabled for e17 (fixed up for e18). n.b. - i'd disable in config profile, not build... ? new users will lose them - old users keep what they have. ok, I'd rather disable their build, but just in profiles is fine. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] modules to disable by default in monday release
On Sun, Apr 19, 2009 at 8:51 PM, Toma tomha...@gmail.com wrote: 2009/4/20 Brian 'morlenxus' Miculcy morlen...@gmx.net: I hope you don't disable dropshadow... Even if it's lame... ;) On Sun, Apr 19, 2009 at 06:03:06PM -0300, Gustavo Sverzut Barbieri wrote: On Sun, Apr 19, 2009 at 9:57 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 19 Apr 2009 05:47:38 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: Hello all, I think that some modules should be disabled, at least at runtime, by default. Things like change colors and fonts, drop shadows and few others. What do you think? If you know of broken modules, then we can easily disable them in configure.ac, just add false instead of true for module line. dropshadow is broken? no, but it is lame :-P No way man! Dropshadow is neat. first time I saw it, before composite managers where born, I said cool, but nowadays it's very lame, even windows do proper shadows! :-/ -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] modules to disable by default in monday release
2009/4/20 Gustavo Sverzut Barbieri barbi...@profusion.mobi: On Sun, Apr 19, 2009 at 8:51 PM, Toma tomha...@gmail.com wrote: 2009/4/20 Brian 'morlenxus' Miculcy morlen...@gmx.net: I hope you don't disable dropshadow... Even if it's lame... ;) On Sun, Apr 19, 2009 at 06:03:06PM -0300, Gustavo Sverzut Barbieri wrote: On Sun, Apr 19, 2009 at 9:57 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 19 Apr 2009 05:47:38 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: Hello all, I think that some modules should be disabled, at least at runtime, by default. Things like change colors and fonts, drop shadows and few others. What do you think? If you know of broken modules, then we can easily disable them in configure.ac, just add false instead of true for module line. dropshadow is broken? no, but it is lame :-P No way man! Dropshadow is neat. first time I saw it, before composite managers where born, I said cool, but nowadays it's very lame, even windows do proper shadows! :-/ Indeed, but its dropshadows without compositing. Its the trendy effect without the graphics card usage. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecore pipe add close functions
was this ever committed? should it be? It was marked as pending in my list.
On Wed, Mar 25, 2009 at 5:37 AM, Lars Munch l...@segv.dk wrote:
On Wed, Mar 25, 2009 at 09:08:53AM +0100, Peter Wehrfritz wrote:
Lars Munch schrieb:
Hi
This patch adds two new functions, ecore_pipe_close_read and
ecore_pipe_close_write, to ecore_pipe. The purpose it to enable
ecore_pipe to be used together with fork (see example below).
The patch also handles if the read or write end of the pipe closes.
I think the names don't fit in to the efl-naming schema, very well. That
means that the verb is at the end of the function name, here this would
be close. So ecore_pipe_write_close, or ecore_pipe_write_end_close
would be better.
Yes, you are right. Updated patch below.
This patch adds two new functions, ecore_pipe_read_close and
ecore_pipe_write_close, to ecore_pipe. The purpose it to enable
ecore_pipe to be used together with fork.
The patch also handles if the read or write end of the pipe closes.
Signed-off-by: Lars Munch l...@segv.dk
---
src/lib/ecore/Ecore.h | 4 +-
src/lib/ecore/ecore_pipe.c | 101
+++-
2 files changed, 93 insertions(+), 12 deletions(-)
diff --git a/src/lib/ecore/Ecore.h b/src/lib/ecore/Ecore.h
index 0a1969d..b001ded 100644
--- a/src/lib/ecore/Ecore.h
+++ b/src/lib/ecore/Ecore.h
@@ -290,10 +290,12 @@ extern C {
EAPI Ecore_Pipe *ecore_pipe_add(void (*handler) (void *data, void
*buffer, unsigned int nbyte), const void *data);
EAPI void *ecore_pipe_del(Ecore_Pipe *p);
EAPI int ecore_pipe_write(Ecore_Pipe *p, const void *buffer,
unsigned int nbytes);
+ EAPI void ecore_pipe_write_close(Ecore_Pipe *p);
+ EAPI void ecore_pipe_read_close(Ecore_Pipe *p);
EAPI double ecore_time_get(void);
EAPI double ecore_loop_time_get(void);
-
+
EAPI Ecore_Timer *ecore_timer_add(double in, int (*func) (void *data),
const void *data);
EAPI Ecore_Timer *ecore_timer_loop_add(double in, int (*func) (void
*data), const void *data);
EAPI void *ecore_timer_del(Ecore_Timer *timer);
diff --git a/src/lib/ecore/ecore_pipe.c b/src/lib/ecore/ecore_pipe.c
index f6e4778..84fded0 100644
--- a/src/lib/ecore/ecore_pipe.c
+++ b/src/lib/ecore/ecore_pipe.c
@@ -332,20 +332,68 @@ ecore_pipe_del(Ecore_Pipe *p)
ecore_pipe_del);
return NULL;
}
- ecore_main_fd_handler_del(p-fd_handler);
- close(p-fd_read);
- close(p-fd_write);
+ if(p-fd_handler != NULL)
+ ecore_main_fd_handler_del(p-fd_handler);
+ if(p-fd_read != -1)
+ close(p-fd_read);
+ if(p-fd_write != -1)
+ close(p-fd_write);
data = (void *)p-data;
free (p);
return data;
}
/**
+ * Close the read end of an Ecore_Pipe object created with ecore_pipe_add().
+ *
+ * @param p The Ecore_Pipe object.
+ * @ingroup Ecore_Pipe_Group
+ */
+EAPI void
+ecore_pipe_read_close(Ecore_Pipe *p)
+{
+ void *data;
+
+ if (!ECORE_MAGIC_CHECK(p, ECORE_MAGIC_PIPE))
+ {
+ ECORE_MAGIC_FAIL(p, ECORE_MAGIC_PIPE,
+ ecore_pipe_close_read);
+ return;
+ }
+ ecore_main_fd_handler_del(p-fd_handler);
+ p-fd_handler = NULL;
+ close(p-fd_read);
+ p-fd_read = -1;
+}
+
+/**
+ * Close the write end of an Ecore_Pipe object created with ecore_pipe_add().
+ *
+ * @param p The Ecore_Pipe object.
+ * @ingroup Ecore_Pipe_Group
+ */
+EAPI void
+ecore_pipe_write_close(Ecore_Pipe *p)
+{
+ void *data;
+
+ if (!ECORE_MAGIC_CHECK(p, ECORE_MAGIC_PIPE))
+ {
+ ECORE_MAGIC_FAIL(p, ECORE_MAGIC_PIPE,
+ ecore_pipe_close_write);
+ return;
+ }
+ close(p-fd_write);
+ p-fd_write = -1;
+}
+
+/**
* Write on the file descriptor the data passed as parameter.
*
* @param p The Ecore_Pipe object.
* @param buffer The data to write into the pipe.
* @param nbytes The size of the @p buffer in bytes
+ * @return Returns TRUE on a successful write, FALSE on an error
* @ingroup Ecore_Pipe_Group
*/
EAPI int
@@ -359,9 +407,13 @@ ecore_pipe_write(Ecore_Pipe *p, const void *buffer,
unsigned int nbytes)
{
ECORE_MAGIC_FAIL(p, ECORE_MAGIC_PIPE,
ecore_pipe_write);
- return 0;
+ return FALSE;
}
- /* first write the len into the pipe */
+
+ if(p-fd_write == -1)
+ return FALSE;
+
+ /* First write the len into the pipe */
do
{
ret = pipe_write(p-fd_write, nbytes, sizeof(nbytes));
@@ -375,7 +427,13 @@ ecore_pipe_write(Ecore_Pipe *p, const void *buffer,
unsigned int nbytes)
/* XXX What should we do here? */
fprintf(stderr, The length of the data was not written complete
to the pipe\n);
- return 0;
+ return FALSE;
+ }
+ else if (ret == -1 errno == EPIPE)
+ {
+ close(p-fd_write);
+
[E-devel] [PATCH] fix etk build fail
After cleaning up, etk wouldn't finish building on r:40244 because it was missing a generated Makefile on data/themes/b_and_w. I don't know if it was removed on purpose or if this is the correct fix, but works for me. It just adds back what was removed on r:40299. -- André Dieb Martins Embedded Systems and Pervasive Computing Lab (Embedded) Electrical Engineering Department (DEE) Center of Electrical Engineering and Informatics (CEEI) Federal University of Campina Grande (UFCG) Blog: http://genuinepulse.blogspot.com/ Mail: dieb at embedded.ufcg.edu.br, andre.dieb at gmail.com Index: configure.ac === --- configure.ac (revision 40244) +++ configure.ac (working copy) @@ -181,6 +181,8 @@ data/themes/default/fonts/Makefile data/themes/default/images/Makefile data/themes/default/macros/Makefile +data/themes/b_and_w/Makefile +data/themes/b_and_w/img/Makefile data/wm/Makefile data/wm/default/Makefile data/wm/default/fonts/Makefile -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
