Re: [E-devel] Invitation to connect on LinkedIn
Grr, isn't there a way to filter messages sent from linkedin? raster: please publicly spank him. On Thu, 2010-12-23 at 07:32 +, fengbin dong via LinkedIn wrote: LinkedIn fengbin dong requested to add you as a connection on LinkedIn: -- João, I'd like to add you to my professional network on LinkedIn. - fengbin Accept invitation from fengbin dong http://www.linkedin.com/e/b5msed-gi1c4lsk-x/v388QXEksSfUNTyuv0ypQu_wsPYH0UzHva8ZQRJLBT5wN7Q2zADobXEtoPrh/blk/I68269652_9/6lColZJrmZznQNdhjRQnOpBtn9QfmhBt71BoSd1p65Lr6lOfPBvczkSejoOe3p9bT9Ne3t9rBENbPsOd3kPe3cRc38LrCBxbOYWrSlI/EML_comm_afe/ View invitation from fengbin dong http://www.linkedin.com/e/b5msed-gi1c4lsk-x/v388QXEksSfUNTyuv0ypQu_wsPYH0UzHva8ZQRJLBT5wN7Q2zADobXEtoPrh/blk/I68269652_9/elYOdjoVdz8UdAALqnpPbOYWrSlI/svi/ -- DID YOU KNOW you can conduct a more credible and powerful reference check using LinkedIn? Enter the company name and years of employment or the prospective employee to find their colleagues that are also in your network. This provides you with a more balanced set of feedback to evaluate that new hire. http://www.linkedin.com/e/b5msed-gi1c4lsk-x/rsr/inv-27/ -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] elm_genlist multi-touch smart callbacks added
Thanks for your advice about patch. I fixed below according to your advice. 1. check device id in multi up/down/move callbacks. 2. I made _multi_touch_motion_eval() function, this function called by both mouse_up and multi_up. If this patch have another issue, please let me know. Thank you. -Original Message- From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] Sent: Tuesday, December 21, 2010 5:54 PM To: Jeonghyun Yun Cc: 'Daniel Juyung Seo'; enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [Patch] elm_genlist multi-touch smart callbacks added On Mon, 20 Dec 2010 15:56:11 +0900 Jeonghyun Yun jh0506@samsung.com said: problem in code for patch... in your multi up/dwon/move callbacks you don't check the device id. as such the core mouse or first touch is device 0 so you don't see multi events for it, but devices 1, 2, 3 etc. are the extra touch points. your patch will get confused if you have 3 fingers on the screen as it will handle both finger #2 and #3 in those events, so you should have a if (ev-device != 1) return; or something like that (to only handle the 2nd touch point). another problem. you trigger this only on the up of the 2nd finger (assuming the above is fixed). what you need to do it handling this on ALL up events - mouse AND multi.. and IF no more fingers are touching on one of those up events (that means its the last finger to release), THEN figure out what to do. so you need to track the down state of main mouse and multi event with some flags/booleans and when both are false/0/off then both fingers are released and you can check what to do. you already do it for multi with wd-multitouched. make this as above for both mouse and multi and then a separate eval call to evaluate what kind of motion the fingers did and you're looking good. can you re-submit the patch with the above fixes? Hello, I modified name and added doxyen. Please refer to below. multi,swipe,left - This is called when the genlist is multi-touch swiped left. multi,swipe,right - This is called when the genlist is multi-touch swiped right. multi,swipe,up - This is called when the genlist is multi-touch swiped up. multi,swpie,down - This is called when the genlist is multi-touch swiped down. multi,pinch,out - This is called when the genlist is multi-touch pinched out. multi,pinch,in - This is called when the genlist is multi-touch pinched in. If this patch have any issue, please let me know. Thank you. -Original Message- From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com] Sent: Monday, December 20, 2010 2:53 PM To: Jeonghyun Yun Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [Patch] elm_genlist multi-touch smart callbacks added Hello, How about using below names for smart callbacks? multi,swipe,left - Genlist has been multi-touch swept left. multi,swipe,right - Genlist has been multi-touch swept right. multi,swipe,up - Genlist has been multi-touch swept top. multi,swpie,down - Genlist has been multi-touch swept bottom. multi,pinch,out - Genlist has been multi-touch pinched out. multi,pinch,in - Genlist has been multi-touch pinched in. Because there is a swipe smart callbacks, I think we can use the name swipe here too. And Mr. Yun, can you add doxygen for those events as well? Please add smart callback doxygen to elm_genlist.c. You can see existing doxygens at the top of elm_genlist.c So you may add multi,** doxygens around line number 78~80. Thank you. Daniel Juyung Seo (SeoZ) On Fri, Dec 17, 2010 at 5:28 PM, Jeonghyun Yun jh0506@samsung.com wrote: Dear SeoZ, Yes. I agree about using up down instead of top bottom. And I'm also not sure but 'sweep' is not bad. Also 'move' is a good name. Then how about 'dragged'? I don't know well. Anybody please suggest a good name. Thanks. -Original Message- From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com] Sent: Friday, December 17, 2010 4:40 PM To: Jeonghyun Yun Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [Patch] elm_genlist multi-touch smart callbacks added Dear Yun, How about renaming some callbacks? multi,sweep,top = multi,sweep,up multi,sweep,bottom = multi,sweep,down Multi touch event cares only for the touch behavior not the callback's behavior. And I'm not sure it is ok to use the word 'sweep'. Anybody please suggest a good name for this. Maybe 'move'? I'm not sure about this. Anyway thanks for your effort. Daniel Juyung Seo. (SeoZ) On Fri, Dec 17, 2010 at 11:48 AM, Jeonghyun Yun jh0506@samsung.com wrote: Dear all, I added 6 multi-touch smart callbacks in elm_genlist, please refer to below. multi,sweep,left - Genlist has been multi-touch swept left. multi,sweep,right - Genlist has been multi-touch swept right. multi,sweep,top - Genlist has been multi-touch swept top. multi,sweep,bottom -
Re: [E-devel] Invitation to connect on LinkedIn
On Thu, 23 Dec 2010 10:09:49 +0200 Tom Hacohen tom.haco...@partner.samsung.com wrote: Grr, isn't there a way to filter messages sent from linkedin? raster: please publicly spank him. On Thu, 2010-12-23 at 07:32 +, fengbin dong via LinkedIn wrote: LinkedIn fengbin dong requested to add you as a connection on LinkedIn: -- João, I'd like to add you to my professional network on LinkedIn. - fengbin Accept invitation from fengbin dong http://www.linkedin.com/e/b5msed-gi1c4lsk-x/v388QXEksSfUNTyuv0ypQu_wsPYH0UzHva8ZQRJLBT5wN7Q2zADobXEtoPrh/blk/I68269652_9/6lColZJrmZznQNdhjRQnOpBtn9QfmhBt71BoSd1p65Lr6lOfPBvczkSejoOe3p9bT9Ne3t9rBENbPsOd3kPe3cRc38LrCBxbOYWrSlI/EML_comm_afe/ View invitation from fengbin dong http://www.linkedin.com/e/b5msed-gi1c4lsk-x/v388QXEksSfUNTyuv0ypQu_wsPYH0UzHva8ZQRJLBT5wN7Q2zADobXEtoPrh/blk/I68269652_9/elYOdjoVdz8UdAALqnpPbOYWrSlI/svi/ -- DID YOU KNOW you can conduct a more credible and powerful reference check using LinkedIn? Enter the company name and years of employment or the prospective employee to find their colleagues that are also in your network. This provides you with a more balanced set of feedback to evaluate that new hire. http://www.linkedin.com/e/b5msed-gi1c4lsk-x/rsr/inv-27/ -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel I say we join. -- Mike Blumenkrantz Zentific: We run the three-legged race individually. -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] question about edje_message_queue
Hello, This is Hermet.
I have one problem because of the message event order.
Let me describe the situation.
I added two clicked callback functions to one elm_button.
Let's call the callback functions A and B
It should be called sequentially definitely.
I'm not sure why user should add separate callbacks but they may use this
case.
Because multiple callback functions for one widget are available.
However, in some cases, the system is so much slow and user clicked the
button continually in a hurry.
So, the clicked message will be queued to the edje message queue (msgq)
Now, it's time to process the signal callbacks.
It will call _edje_message_queue_process to process the queued message
events.
Since user touched the buttons continually and the system could not process
the events yet,
the clicked event messages will be queued in order.
Let's suppose the count of clicked events as 4.
Now It begins to process one.
Because user added two callback functions, A will be called first.
But in this A function, it creates an elementary widget which calls
edje_object_message_signal_process internally.
It means, it will process the queued events(tmp_msgq) again plus additional
new queued events for its own widget.
But next queued event is also button clicked event.
Thus, the A function will be called again even B function does not called
yet.
Users might don't know about this but problem can be occurred.
In this case, the callback function will be called like this order. A - A
- A - A - B - B - B - B actually.
However, it should be called like this A - B - A - B - A - B - A - B.
The real scenario is like this.
In a button callback A, user create a genlist then apply one style by using
elm_object_style_set.
Could someone give me an advice?
Or Must be fixed the edje_message_queue?
Once, I attached the patch file for the edje_message_queue,
please consider and reply me.
Thanks.
Index: src/lib/edje_message_queue.c
===
--- src/lib/edje_message_queue.c(revision 55738)
+++ src/lib/edje_message_queue.c(working copy)
@@ -101,6 +101,17 @@
ed = _edje_fetch(obj);
if (!ed) return;
+ for (l = tmp_msgq; l; )
+ {
+ln = l-next;
+em = l-data;
+if (em-edje == ed)
+ {
+ tmpq = eina_list_append(tmpq, em);
+ tmp_msgq = eina_list_remove_list(tmp_msgq, l);
+ }
+l = ln;
+ }
for (l = msgq; l; )
{
ln = l-next;
@@ -112,30 +123,16 @@
}
l = ln;
}
- /* a temporary message queue */
- if (tmp_msgq)
- {
- while (tmpq)
- {
-tmp_msgq = eina_list_append(tmp_msgq, tmpq-data);
-tmpq = eina_list_remove_list(tmpq, tmpq);
- }
- }
- else
- {
- tmp_msgq = tmpq;
- tmpq = NULL;
- }
- while (tmp_msgq)
+ while (tmpq)
{
- Edje_Message *em;
+Edje_Message *em;
- em = tmp_msgq-data;
- tmp_msgq = eina_list_remove_list(tmp_msgq, tmp_msgq);
- em-edje-message.num--;
- _edje_message_process(em);
- _edje_message_free(em);
+em = tmpq-data;
+tmpq = eina_list_remove_list(tmpq, tmpq);
+em-edje-message.num--;
+_edje_message_process(em);
+_edje_message_free(em);
}
}
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
make this more portable in case the number of states changes in the
future, also outdent and make function params more explicit
Author: discomfitor
Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
New Revision: 55727
Trac: http://trac.enlightenment.org/e/changeset/55727
Modified:
trunk/e/src/bin/e_hints.c
Modified: trunk/e/src/bin/e_hints.c
===
--- trunk/e/src/bin/e_hints.c 2010-12-23 00:28:49 UTC (rev 55726)
+++ trunk/e/src/bin/e_hints.c 2010-12-23 00:36:53 UTC (rev 55727)
@@ -1432,18 +1432,16 @@
{
/* Remember to update the count if we add more states! */
Ecore_X_Atom state[1];
-int num;
+int num, i;
memset(state, 0, sizeof(state));
-num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, 1);
-if (num)
+num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, sizeof(state));
^^^
+if (!num) return;
+
+for (i = 0; (i num) (i sizeof(state)); i++)
^^^
{
- int i;
- for (i = 0; i num; i++)
- {
- if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
-bd-client.e.state.centered = 1;
- }
+ if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
+ bd-client.e.state.centered = 1;
}
}
Just happened to notice...
The use of sizeof(state) is wrong in the marked lines - should probably be
some #define or (sizeof(state)/sizeof(state[0])) or similar.
The use in the second line is futhermore superfluous as
ecore_x_window_prop_card32_get should never return num the len parameter
(fourth argument).
/Kim
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
On Thu, 23 Dec 2010 16:50:19 +0100
Kim Woelders k...@woelders.dk wrote:
On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
make this more portable in case the number of states changes in the
future, also outdent and make function params more explicit
Author: discomfitor
Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
New Revision: 55727
Trac: http://trac.enlightenment.org/e/changeset/55727
Modified:
trunk/e/src/bin/e_hints.c
Modified: trunk/e/src/bin/e_hints.c
===
--- trunk/e/src/bin/e_hints.c 2010-12-23 00:28:49 UTC (rev 55726)
+++ trunk/e/src/bin/e_hints.c 2010-12-23 00:36:53 UTC (rev 55727)
@@ -1432,18 +1432,16 @@
{
/* Remember to update the count if we add more states! */
Ecore_X_Atom state[1];
-int num;
+int num, i;
memset(state, 0, sizeof(state));
-num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, 1);
-if (num)
+num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, sizeof(state));
^^^
+if (!num) return;
+
+for (i = 0; (i num) (i sizeof(state)); i++)
^^^
{
- int i;
- for (i = 0; i num; i++)
- {
- if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
-bd-client.e.state.centered = 1;
- }
+ if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
+ bd-client.e.state.centered = 1;
}
}
Just happened to notice...
The use of sizeof(state) is wrong in the marked lines - should probably be
some #define or (sizeof(state)/sizeof(state[0])) or similar.
hmm since it's just passing the size of the array (1) isn't it fine?
The use in the second line is futhermore superfluous as
ecore_x_window_prop_card32_get should never return num the len parameter
(fourth argument).
yes, it seems obvious, but it caused a warning in clang so I stuck this in to
prevent future runs from picking it up.
/Kim
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Mike Blumenkrantz
Zentific: We run the three-legged race individually.
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
On Thu, 23 Dec 2010 17:15:13 +0100, Mike Blumenkrantz m...@zentific.com
wrote:
On Thu, 23 Dec 2010 16:50:19 +0100
Kim Woelders k...@woelders.dk wrote:
On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
make this more portable in case the number of states changes in the
future, also outdent and make function params more explicit
Author: discomfitor
Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
New Revision: 55727
Trac: http://trac.enlightenment.org/e/changeset/55727
Modified:
trunk/e/src/bin/e_hints.c
Modified: trunk/e/src/bin/e_hints.c
===
--- trunk/e/src/bin/e_hints.c 2010-12-23 00:28:49 UTC (rev 55726)
+++ trunk/e/src/bin/e_hints.c 2010-12-23 00:36:53 UTC (rev 55727)
@@ -1432,18 +1432,16 @@
{
/* Remember to update the count if we add more states! */
Ecore_X_Atom state[1];
-int num;
+int num, i;
memset(state, 0, sizeof(state));
-num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, 1);
-if (num)
+num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, sizeof(state));
^^^
+if (!num) return;
+
+for (i = 0; (i num) (i sizeof(state)); i++)
^^^
{
- int i;
- for (i = 0; i num; i++)
- {
- if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
-bd-client.e.state.centered = 1;
- }
+ if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
+ bd-client.e.state.centered = 1;
}
}
Just happened to notice...
The use of sizeof(state) is wrong in the marked lines - should probably
be
some #define or (sizeof(state)/sizeof(state[0])) or similar.
hmm since it's just passing the size of the array (1) isn't it fine?
sizeof(state) = 4.
The use in the second line is futhermore superfluous as
ecore_x_window_prop_card32_get should never return num the len
parameter
(fourth argument).
yes, it seems obvious, but it caused a warning in clang so I stuck this
in to
prevent future runs from picking it up.
IMO adding code for that reason is wrong. Isn't there some way to shut
clang up when it generates bogus warnings?
/Kim
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
On Thu, 23 Dec 2010 17:31:24 +0100
Kim Woelders k...@woelders.dk wrote:
On Thu, 23 Dec 2010 17:15:13 +0100, Mike Blumenkrantz m...@zentific.com
wrote:
On Thu, 23 Dec 2010 16:50:19 +0100
Kim Woelders k...@woelders.dk wrote:
On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
make this more portable in case the number of states changes in the
future, also outdent and make function params more explicit
Author: discomfitor
Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
New Revision: 55727
Trac: http://trac.enlightenment.org/e/changeset/55727
Modified:
trunk/e/src/bin/e_hints.c
Modified: trunk/e/src/bin/e_hints.c
===
--- trunk/e/src/bin/e_hints.c2010-12-23 00:28:49 UTC (rev 55726)
+++ trunk/e/src/bin/e_hints.c2010-12-23 00:36:53 UTC (rev 55727)
@@ -1432,18 +1432,16 @@
{
/* Remember to update the count if we add more states! */
Ecore_X_Atom state[1];
-int num;
+int num, i;
memset(state, 0, sizeof(state));
-num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, 1);
-if (num)
+num = ecore_x_window_prop_card32_get(bd-client.win,
E_ATOM_WINDOW_STATE, state, sizeof(state));
^^^
+if (!num) return;
+
+for (i = 0; (i num) (i sizeof(state)); i++)
^^^
{
- int i;
- for (i = 0; i num; i++)
- {
- if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
-bd-client.e.state.centered = 1;
- }
+ if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
+ bd-client.e.state.centered = 1;
}
}
Just happened to notice...
The use of sizeof(state) is wrong in the marked lines - should probably
be
some #define or (sizeof(state)/sizeof(state[0])) or similar.
hmm since it's just passing the size of the array (1) isn't it fine?
sizeof(state) = 4.
touche.
The use in the second line is futhermore superfluous as
ecore_x_window_prop_card32_get should never return num the len
parameter
(fourth argument).
yes, it seems obvious, but it caused a warning in clang so I stuck this
in to
prevent future runs from picking it up.
IMO adding code for that reason is wrong. Isn't there some way to shut
clang up when it generates bogus warnings?
sadly no.
/Kim
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Mike Blumenkrantz
Zentific: We run the three-legged race individually.
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
On Thu, 23 Dec 2010 17:47:06 +0100, Enlightenment SVN no-re...@enlightenment.org wrote: Log: fix sizeof use, thanks to kim woelders Author: discomfitor Date: 2010-12-23 08:47:05 -0800 (Thu, 23 Dec 2010) New Revision: 55739 Trac: http://trac.enlightenment.org/e/changeset/55739 Modified: trunk/e/src/bin/e_hints.c Modified: trunk/e/src/bin/e_hints.c === --- trunk/e/src/bin/e_hints.c 2010-12-23 12:47:23 UTC (rev 55738) +++ trunk/e/src/bin/e_hints.c 2010-12-23 16:47:05 UTC (rev 55739) @@ -1435,7 +1435,8 @@ int num, i; memset(state, 0, sizeof(state)); -num = ecore_x_window_prop_card32_get(bd-client.win, E_ATOM_WINDOW_STATE, state, sizeof(state)); +num = ecore_x_window_prop_card32_get(bd-client.win, E_ATOM_WINDOW_STATE, + state, sizeof(state) / sizeof(state[0]); /* ugly, but avoids possible future overflow if more states are added */ if (!num) return; for (i = 0; (i num) (i sizeof(state)); i++) Sorry about going on here, but if the (i sizeof(state)) condition makes clang happy it's just silly. This check ensures that i 4 but clang should be clever enough to see that accessing state[1] is bad. /Kim -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
On Thu, 23 Dec 2010 18:41:24 +0100 Kim Woelders k...@woelders.dk wrote: On Thu, 23 Dec 2010 17:47:06 +0100, Enlightenment SVN no-re...@enlightenment.org wrote: Log: fix sizeof use, thanks to kim woelders Author: discomfitor Date: 2010-12-23 08:47:05 -0800 (Thu, 23 Dec 2010) New Revision: 55739 Trac: http://trac.enlightenment.org/e/changeset/55739 Modified: trunk/e/src/bin/e_hints.c Modified: trunk/e/src/bin/e_hints.c === --- trunk/e/src/bin/e_hints.c 2010-12-23 12:47:23 UTC (rev 55738) +++ trunk/e/src/bin/e_hints.c 2010-12-23 16:47:05 UTC (rev 55739) @@ -1435,7 +1435,8 @@ int num, i; memset(state, 0, sizeof(state)); -num = ecore_x_window_prop_card32_get(bd-client.win, E_ATOM_WINDOW_STATE, state, sizeof(state)); +num = ecore_x_window_prop_card32_get(bd-client.win, E_ATOM_WINDOW_STATE, + state, sizeof(state) / sizeof(state[0]); /* ugly, but avoids possible future overflow if more states are added */ if (!num) return; for (i = 0; (i num) (i sizeof(state)); i++) Sorry about going on here, but if the (i sizeof(state)) condition makes clang happy it's just silly. This check ensures that i 4 but clang should be clever enough to see that accessing state[1] is bad. /Kim Well yes, that's the point. clang sees that it could potentially overflow the buffer there and thus generates a warning. it's super pedantic, but that's the idea. -- Mike Blumenkrantz Zentific: We run the three-legged race individually. -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Docs of Enlil
Hello people In http://www.enlightenment.org/?p=docsl=en we can see the documentation of EPHOTO MANAGER. - Can we remove it ? - Can we add the doc of Enlil ? -- Regards. -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Edje external type?
Hello, I'm working much with Edje externals in my application. Currently Elementary widgets. If I access e.g. a list I've to just to know and trust that an object I got by a name is from the Elementary type I think. But as this may change while development I like to know if there's a function to get the type of a Edje (external) object as string or so? Then I could check if I really have a widget of this type before e.g. adding list items to a button or so. :-) regards Andreas -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] small patch for elm_main.c
Hello ~ all.
I found one small bug in elm_main.c
exe is used just after free(exe). (in elm_quicklaunch_prepare()
function)
Can anybody check about this ?
Thanks.
Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c (revision 55742)
+++ src/lib/elm_main.c (working copy)
@@ -755,7 +755,6 @@ elm_quicklaunch_prepare(int argc __UNUSED__,
return EINA_FALSE;
}
INF(dlopen('%s') = %p, exe, qr_handle);
- free(exe);
qr_main = dlsym(qr_handle, elm_main);
INF(dlsym(%p, 'elm_main') = %p, qr_handle, qr_main);
if (!qr_main)
@@ -763,8 +762,10 @@ elm_quicklaunch_prepare(int argc __UNUSED__,
WRN(not quicklauncher capable: no elm_main in '%s', exe);
dlclose(qr_handle);
qr_handle = NULL;
+ free(exe);
return EINA_FALSE;
}
+ free(exe);
return EINA_TRUE;
#else
return EINA_FALSE;
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
