date:20130524

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

2013-05-24 Thread ChunEon Park


In widget deletion case,

there is no need to set NULL.

unnecessary!  : (
 

-Regards, Hermet- 

-Original Message-
From: Daniel Juyung Seo - Enlightenment Gitno-re...@enlightenment.org 
To: enlightenment-...@lists.sourceforge.net; 
Cc: 
Sent: 2013-05-23 (목) 15:53:17
Subject: [EGIT] [core/elementary] master 01/01: elm: refactoring. use more 
ELM_FREE_FUNC.

seoz pushed a commit to branch master.

commit 0c9bed2265454391f80085a850945191f6fc389f
Author: Daniel Juyung Seo seojuyung2@gmail.com
Date:   Thu May 23 15:54:49 2013 +0900

elm: refactoring. use more ELM_FREE_FUNC.
---
 src/lib/elm_gesture_layer.c  30 +-
 src/lib/elm_image.c  14 --
 src/lib/elm_index.c   6 +++---
 src/lib/elm_list.c   32 +---
 src/lib/elm_map.c32 +++-
 src/lib/elm_notify.c 18 +++---
 src/lib/elm_photo.c  14 --
 src/lib/elm_photocam.c   23 +--
 src/lib/elm_slider.c 11 +--
 src/lib/elm_slideshow.c  22 +++---
 src/lib/elm_spinner.c21 ++---
 src/lib/elm_toolbar.c18 +++---
 src/lib/elm_video.c   8 +++-
 src/lib/elm_web.c29 +++--
 src/lib/elm_win.c 9 +
 src/lib/els_tooltip.c 7 +++
 16 files changed, 91 insertions(+), 203 deletions(-)

diff --git a/src/lib/elm_gesture_layer.c b/src/lib/elm_gesture_layer.c
index acae1d0..f31231e 100644
--- a/src/lib/elm_gesture_layer.c
+++ b/src/lib/elm_gesture_layer.c
@@ -1398,11 +1398,7 @@ _tap_gestures_test_reset(Gesture_Info *gesture)
EINA_SAFETY_ON_NULL_RETURN(gesture);
ELM_GESTURE_LAYER_DATA_GET(gesture-obj, sd);
 
-   if (sd-gest_taps_timeout)
- {
-ecore_timer_del(sd-gest_taps_timeout);
-sd-gest_taps_timeout = NULL;
- }
+   ELM_FREE_FUNC(sd-gest_taps_timeout, ecore_timer_del);
 
if (!gesture-data)
  return;
@@ -1433,11 +1429,7 @@ _n_long_tap_test_reset(Gesture_Info *gesture)
  free(p);
st-touched = NULL;
 
-   if (st-timeout)
- {
-ecore_timer_del(st-timeout);
-st-timeout = NULL;
- }
+   ELM_FREE_FUNC(st-timeout, ecore_timer_del);
memset(gesture-data, 0, sizeof(Long_Tap_Type));
 }
 
@@ -1989,11 +1981,7 @@ _n_long_tap_test(Evas_Object *obj,
ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
 st-info, EINA_FALSE);
 
- if (st-timeout)
-   {
-  ecore_timer_del(st-timeout);
-  st-timeout = NULL;
-   }
+ ELM_FREE_FUNC(st-timeout, ecore_timer_del);
  _event_consume(sd, event_info, event_type, ev_flag);
   }
 
@@ -2013,11 +2001,7 @@ _n_long_tap_test(Evas_Object *obj,
  /* ABORT if user moved fingers out of tap area */
  if (!_inside(x, y, st-center_x, st-center_y))
{
-  if (st-timeout)
-{
-   ecore_timer_del(st-timeout);
-   st-timeout = NULL;
-}
+  ELM_FREE_FUNC(st-timeout, ecore_timer_del);
 
   /* Report MOVE if gesture started */
   ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
@@ -3638,11 +3622,7 @@ _elm_gesture_layer_smart_del(Eo *obj, void *_pd, va_list 
*list EINA_UNUSED)
 
   free(sd-gesture[i]);
}
-   if (sd-gest_taps_timeout)
- {
-ecore_timer_del(sd-gest_taps_timeout);
-sd-gest_taps_timeout = NULL;
- }
+   ELM_FREE_FUNC(sd-gest_taps_timeout, ecore_timer_del);
 
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
 }
diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c
index dc679ba..517485a 100644
--- a/src/lib/elm_image.c
+++ b/src/lib/elm_image.c
@@ -664,11 +664,9 @@ _elm_image_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
 {
Elm_Image_Smart_Data *sd = _pd;
 
-   if (sd-anim_timer)
- ecore_timer_del(sd-anim_timer);
-
-   evas_object_del(sd-img);
-   if (sd-prev_img) evas_object_del(sd-prev_img);
+   ELM_FREE_FUNC(sd-anim_timer, ecore_timer_del);
+   ELM_FREE_FUNC(sd-img, evas_object_del);
+   ELM_FREE_FUNC(sd-prev_img, evas_object_del);
 
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
 }
@@ -1511,11 +1509,7 @@ _elm_image_smart_animated_play_set(Eo *obj, void *_pd, 
va_list *list)
  }
else
  {
-if (sd-anim_timer)
-  {
- ecore_timer_del(sd-anim_timer);
- sd-anim_timer = NULL;
-  }
+ELM_FREE_FUNC(sd-anim_timer, ecore_timer_del);
  }
sd-play = play;
 }
diff --git a/src/lib/elm_index.c b/src/lib/elm_index.c
index 1c3a41f..879f32b 100644
--- a/src/lib/elm_index.c
+++ b/src/lib/elm_index.c
@@ -651,7 +651,7 @@ _sel_eval(Evas_Object *obj,

Re: [E-devel] E18 CFBugs

2013-05-24 Thread Aleksej Struk

Hi,

I have noticed the following strange behaviour with the latest git snapshot
of the EFL and E.
For all Qt applications I tried (i.e. k3b, skype, etc) popup menus and
dialogs are not shown.
However, if I click where the menu item should be, I get that menu item
executed.

sndev


On Tue, May 21, 2013 at 7:21 AM, Michael Blumenkrantz 
michael.blumenkra...@gmail.com wrote:

 Not to be confused with last year's Call For Beards, this is an open call
 for people to submit any outstanding bug reports for E18.

 Known issues:

 * Window shading doesn't shade
 * Keyboard movement of windows between desks/screens may be broken
 * Shaped windows


 Please note that any feature requests masquerading as bug reports will be
 completely ignored.

 --
 Try New Relic Now  We'll Send You this Cool Shirt
 New Relic is the only SaaS-based application performance monitoring service
 that delivers powerful full stack analytics. Optimize and monitor your
 browser, app,  servers with just a few lines of code. Try New Relic
 and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel




-- 
Aleksej Struk
cell phone: +370-612-78908
ast...@gmail.com - http://www.
--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E18 CFBugs

2013-05-24 Thread Michael Blumenkrantz

On Fri, 24 May 2013 06:39:24 +
Aleksej Struk ast...@gmail.com wrote:

 Hi,
 
 I have noticed the following strange behaviour with the latest git snapshot
 of the EFL and E.
 For all Qt applications I tried (i.e. k3b, skype, etc) popup menus and
 dialogs are not shown.
 However, if I click where the menu item should be, I get that menu item
 executed.
 
 sndev

this was already fixed a few days ago

 
 
 On Tue, May 21, 2013 at 7:21 AM, Michael Blumenkrantz 
 michael.blumenkra...@gmail.com wrote:
 
  Not to be confused with last year's Call For Beards, this is an open call
  for people to submit any outstanding bug reports for E18.
 
  Known issues:
 
  * Window shading doesn't shade
  * Keyboard movement of windows between desks/screens may be broken
  * Shaped windows
 
 
  Please note that any feature requests masquerading as bug reports will be
  completely ignored.
 

--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

2013-05-24 Thread Daniel Juyung Seo

Yeah you are right.
I already spent my time on that consideration before I committed that code.

I just wanted to force using ELM_FREE_FUNC at any case instead of
having exceptional case. There are so many human mistakes in
elementary.
But any comments are welcomed :)
ELM_FREE_FUNC is still in experimental state and can be changed any time.

Thanks.

Daniel Juyung Seo (SeoZ)

On Fri, May 24, 2013 at 3:19 PM, ChunEon Park her...@naver.com wrote:

 In widget deletion case,

 there is no need to set NULL.

 unnecessary!  : (

 
 -Regards, Hermet-

 -Original Message-
 From: Daniel Juyung Seo - Enlightenment Gitno-re...@enlightenment.org
 To: enlightenment-...@lists.sourceforge.net;
 Cc:
 Sent: 2013-05-23 (목) 15:53:17
 Subject: [EGIT] [core/elementary] master 01/01: elm: refactoring. use more 
 ELM_FREE_FUNC.

 seoz pushed a commit to branch master.

 commit 0c9bed2265454391f80085a850945191f6fc389f
 Author: Daniel Juyung Seo seojuyung2@gmail.com
 Date:   Thu May 23 15:54:49 2013 +0900

 elm: refactoring. use more ELM_FREE_FUNC.
 ---
  src/lib/elm_gesture_layer.c  30 +-
  src/lib/elm_image.c  14 --
  src/lib/elm_index.c   6 +++---
  src/lib/elm_list.c   32 +---
  src/lib/elm_map.c32 +++-
  src/lib/elm_notify.c 18 +++---
  src/lib/elm_photo.c  14 --
  src/lib/elm_photocam.c   23 +--
  src/lib/elm_slider.c 11 +--
  src/lib/elm_slideshow.c  22 +++---
  src/lib/elm_spinner.c21 ++---
  src/lib/elm_toolbar.c18 +++---
  src/lib/elm_video.c   8 +++-
  src/lib/elm_web.c29 +++--
  src/lib/elm_win.c 9 +
  src/lib/els_tooltip.c 7 +++
  16 files changed, 91 insertions(+), 203 deletions(-)

 diff --git a/src/lib/elm_gesture_layer.c b/src/lib/elm_gesture_layer.c
 index acae1d0..f31231e 100644
 --- a/src/lib/elm_gesture_layer.c
 +++ b/src/lib/elm_gesture_layer.c
 @@ -1398,11 +1398,7 @@ _tap_gestures_test_reset(Gesture_Info *gesture)
 EINA_SAFETY_ON_NULL_RETURN(gesture);
 ELM_GESTURE_LAYER_DATA_GET(gesture-obj, sd);

 -   if (sd-gest_taps_timeout)
 - {
 -ecore_timer_del(sd-gest_taps_timeout);
 -sd-gest_taps_timeout = NULL;
 - }
 +   ELM_FREE_FUNC(sd-gest_taps_timeout, ecore_timer_del);

 if (!gesture-data)
   return;
 @@ -1433,11 +1429,7 @@ _n_long_tap_test_reset(Gesture_Info *gesture)
   free(p);
 st-touched = NULL;

 -   if (st-timeout)
 - {
 -ecore_timer_del(st-timeout);
 -st-timeout = NULL;
 - }
 +   ELM_FREE_FUNC(st-timeout, ecore_timer_del);
 memset(gesture-data, 0, sizeof(Long_Tap_Type));
  }

 @@ -1989,11 +1981,7 @@ _n_long_tap_test(Evas_Object *obj,
 ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
  st-info, EINA_FALSE);

 - if (st-timeout)
 -   {
 -  ecore_timer_del(st-timeout);
 -  st-timeout = NULL;
 -   }
 + ELM_FREE_FUNC(st-timeout, ecore_timer_del);
   _event_consume(sd, event_info, event_type, ev_flag);
}

 @@ -2013,11 +2001,7 @@ _n_long_tap_test(Evas_Object *obj,
   /* ABORT if user moved fingers out of tap area */
   if (!_inside(x, y, st-center_x, st-center_y))
 {
 -  if (st-timeout)
 -{
 -   ecore_timer_del(st-timeout);
 -   st-timeout = NULL;
 -}
 +  ELM_FREE_FUNC(st-timeout, ecore_timer_del);

/* Report MOVE if gesture started */
ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
 @@ -3638,11 +3622,7 @@ _elm_gesture_layer_smart_del(Eo *obj, void *_pd, 
 va_list *list EINA_UNUSED)

free(sd-gesture[i]);
 }
 -   if (sd-gest_taps_timeout)
 - {
 -ecore_timer_del(sd-gest_taps_timeout);
 -sd-gest_taps_timeout = NULL;
 - }
 +   ELM_FREE_FUNC(sd-gest_taps_timeout, ecore_timer_del);

 eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
  }
 diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c
 index dc679ba..517485a 100644
 --- a/src/lib/elm_image.c
 +++ b/src/lib/elm_image.c
 @@ -664,11 +664,9 @@ _elm_image_smart_del(Eo *obj, void *_pd, va_list *list 
 EINA_UNUSED)
  {
 Elm_Image_Smart_Data *sd = _pd;

 -   if (sd-anim_timer)
 - ecore_timer_del(sd-anim_timer);
 -
 -   evas_object_del(sd-img);
 -   if (sd-prev_img) evas_object_del(sd-prev_img);
 +   ELM_FREE_FUNC(sd-anim_timer, ecore_timer_del);
 +   ELM_FREE_FUNC(sd-img, evas_object_del);
 +   ELM_FREE_FUNC(sd-prev_img, evas_object_del);

 eo_do_super(obj, MY_CLASS,

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

2013-05-24 Thread ChunEon Park

use ELM_FREE_FUNC please only when it needs really.
 

-Regards, Hermet- 

-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com 
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net; 
Cc: enlightenment-...@lists.sourceforge.net; 
Sent: 2013-05-24 (금) 16:38:03
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. 
use more ELM_FREE_FUNC.

Yeah you are right.
I already spent my time on that consideration before I committed that code.

I just wanted to force using ELM_FREE_FUNC at any case instead of
having exceptional case. There are so many human mistakes in
elementary.
But any comments are welcomed :)
ELM_FREE_FUNC is still in experimental state and can be changed any time.

Thanks.

Daniel Juyung Seo (SeoZ)

On Fri, May 24, 2013 at 3:19 PM, ChunEon Park hermet@naver.com wrote:

 In widget deletion case,

 there is no need to set NULL.

 unnecessary!  : (

 
 -Regards, Hermet-

 -Original Message-
 From: Daniel Juyung Seo - Enlightenment Gitno-reply@enlightenment.org
 To: enlightenment-git@lists.sourceforge.net;
 Cc:
 Sent: 2013-05-23 (목) 15:53:17
 Subject: [EGIT] [core/elementary] master 01/01: elm: refactoring. use more 
 ELM_FREE_FUNC.

 seoz pushed a commit to branch master.

 commit 0c9bed2265454391f80085a850945191f6fc389f
 Author: Daniel Juyung Seo seojuyung2@gmail.com
 Date:   Thu May 23 15:54:49 2013 +0900

 elm: refactoring. use more ELM_FREE_FUNC.
 ---
  src/lib/elm_gesture_layer.c  30 +-
  src/lib/elm_image.c  14 --
  src/lib/elm_index.c   6 +++---
  src/lib/elm_list.c   32 +---
  src/lib/elm_map.c32 +++-
  src/lib/elm_notify.c 18 +++---
  src/lib/elm_photo.c  14 --
  src/lib/elm_photocam.c   23 +--
  src/lib/elm_slider.c 11 +--
  src/lib/elm_slideshow.c  22 +++---
  src/lib/elm_spinner.c21 ++---
  src/lib/elm_toolbar.c18 +++---
  src/lib/elm_video.c   8 +++-
  src/lib/elm_web.c29 +++--
  src/lib/elm_win.c 9 +
  src/lib/els_tooltip.c 7 +++
  16 files changed, 91 insertions(+), 203 deletions(-)

 diff --git a/src/lib/elm_gesture_layer.c b/src/lib/elm_gesture_layer.c
 index acae1d0..f31231e 100644
 --- a/src/lib/elm_gesture_layer.c
 +++ b/src/lib/elm_gesture_layer.c
 @@ -1398,11 +1398,7 @@ _tap_gestures_test_reset(Gesture_Info *gesture)
 EINA_SAFETY_ON_NULL_RETURN(gesture);
 ELM_GESTURE_LAYER_DATA_GET(gesture-obj, sd);

 -   if (sd-gest_taps_timeout)
 - {
 -ecore_timer_del(sd-gest_taps_timeout);
 -sd-gest_taps_timeout = NULL;
 - }
 +   ELM_FREE_FUNC(sd-gest_taps_timeout, ecore_timer_del);

 if (!gesture-data)
   return;
 @@ -1433,11 +1429,7 @@ _n_long_tap_test_reset(Gesture_Info *gesture)
   free(p);
 st-touched = NULL;

 -   if (st-timeout)
 - {
 -ecore_timer_del(st-timeout);
 -st-timeout = NULL;
 - }
 +   ELM_FREE_FUNC(st-timeout, ecore_timer_del);
 memset(gesture-data, 0, sizeof(Long_Tap_Type));
  }

 @@ -1989,11 +1981,7 @@ _n_long_tap_test(Evas_Object *obj,
 ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
  st-info, EINA_FALSE);

 - if (st-timeout)
 -   {
 -  ecore_timer_del(st-timeout);
 -  st-timeout = NULL;
 -   }
 + ELM_FREE_FUNC(st-timeout, ecore_timer_del);
   _event_consume(sd, event_info, event_type, ev_flag);
}

 @@ -2013,11 +2001,7 @@ _n_long_tap_test(Evas_Object *obj,
   /* ABORT if user moved fingers out of tap area */
   if (!_inside(x, y, st-center_x, st-center_y))
 {
 -  if (st-timeout)
 -{
 -   ecore_timer_del(st-timeout);
 -   st-timeout = NULL;
 -}
 +  ELM_FREE_FUNC(st-timeout, ecore_timer_del);

/* Report MOVE if gesture started */
ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
 @@ -3638,11 +3622,7 @@ _elm_gesture_layer_smart_del(Eo *obj, void *_pd, 
 va_list *list EINA_UNUSED)

free(sd-gesture[i]);
 }
 -   if (sd-gest_taps_timeout)
 - {
 -ecore_timer_del(sd-gest_taps_timeout);
 -sd-gest_taps_timeout = NULL;
 - }
 +   ELM_FREE_FUNC(sd-gest_taps_timeout, ecore_timer_del);

 eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
  }
 diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c
 index dc679ba..517485a 100644
 --- a/src/lib/elm_image.c
 +++ b/src/lib/elm_image.c
 @@ -664,11 +664,9 @@

[E-devel] Fix in ecore_con

2013-05-24 Thread Guillaume Friloux


Hello dear devs,
I have committed a fix for ecore_con, in the legacy branch.
This fix should also be applied to efl/ (1.8), but i am not going to do 
it as i dont use 1.8, and so wont test it.

I need someone to take care of this.
attachment: guillaume_friloux.vcf--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Fix in ecore_con

2013-05-24 Thread Guillaume Friloux

I sent another patch in ecore_con : 
http://git.enlightenment.org/legacy/ecore.git/commit/?id=d3d82c6f490e5ba1b4c9a7c72c9ff42c3a7e70f6

Please, add it to 1.8 and test it.

On 24/05/2013 11:01, Guillaume Friloux wrote:

Hello dear devs,
I have committed a fix for ecore_con, in the legacy branch.
This fix should also be applied to efl/ (1.8), but i am not going to 
do it as i dont use 1.8, and so wont test it.

I need someone to take care of this.


attachment: guillaume_friloux.vcf--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

2013-05-24 Thread Daniel Juyung Seo

Ok I will do. However I still doubt people will not make mistakes. I
was trying to avoid those mistakes by forcing ELM_FREE_FUNC at all
cases.

Any other opinions?

Thanks.

Daniel Juyung Seo (SeoZ)


On Fri, May 24, 2013 at 5:08 PM, ChunEon Park her...@naver.com wrote:
 use ELM_FREE_FUNC please only when it needs really.

 
 -Regards, Hermet-

 -Original Message-
 From: Daniel Juyung Seoseojuyu...@gmail.com
 To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
 Cc: enlightenment-...@lists.sourceforge.net;
 Sent: 2013-05-24 (금) 16:38:03
 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: 
 refactoring. use more ELM_FREE_FUNC.

 Yeah you are right.
 I already spent my time on that consideration before I committed that code.

 I just wanted to force using ELM_FREE_FUNC at any case instead of
 having exceptional case. There are so many human mistakes in
 elementary.
 But any comments are welcomed :)
 ELM_FREE_FUNC is still in experimental state and can be changed any time.

 Thanks.

 Daniel Juyung Seo (SeoZ)

 On Fri, May 24, 2013 at 3:19 PM, ChunEon Park hermet@naver.com wrote:

 In widget deletion case,

 there is no need to set NULL.

 unnecessary!  : (

 
 -Regards, Hermet-

 -Original Message-
 From: Daniel Juyung Seo - Enlightenment Gitno-reply@enlightenment.org
 To: enlightenment-git@lists.sourceforge.net;
 Cc:
 Sent: 2013-05-23 (목) 15:53:17
 Subject: [EGIT] [core/elementary] master 01/01: elm: refactoring. use more 
 ELM_FREE_FUNC.

 seoz pushed a commit to branch master.

 commit 0c9bed2265454391f80085a850945191f6fc389f
 Author: Daniel Juyung Seo seojuyung2@gmail.com
 Date:   Thu May 23 15:54:49 2013 +0900

 elm: refactoring. use more ELM_FREE_FUNC.
 ---
  src/lib/elm_gesture_layer.c  30 +-
  src/lib/elm_image.c  14 --
  src/lib/elm_index.c   6 +++---
  src/lib/elm_list.c   32 +---
  src/lib/elm_map.c32 +++-
  src/lib/elm_notify.c 18 +++---
  src/lib/elm_photo.c  14 --
  src/lib/elm_photocam.c   23 +--
  src/lib/elm_slider.c 11 +--
  src/lib/elm_slideshow.c  22 +++---
  src/lib/elm_spinner.c21 ++---
  src/lib/elm_toolbar.c18 +++---
  src/lib/elm_video.c   8 +++-
  src/lib/elm_web.c29 +++--
  src/lib/elm_win.c 9 +
  src/lib/els_tooltip.c 7 +++
  16 files changed, 91 insertions(+), 203 deletions(-)

 diff --git a/src/lib/elm_gesture_layer.c b/src/lib/elm_gesture_layer.c
 index acae1d0..f31231e 100644
 --- a/src/lib/elm_gesture_layer.c
 +++ b/src/lib/elm_gesture_layer.c
 @@ -1398,11 +1398,7 @@ _tap_gestures_test_reset(Gesture_Info *gesture)
 EINA_SAFETY_ON_NULL_RETURN(gesture);
 ELM_GESTURE_LAYER_DATA_GET(gesture-obj, sd);

 -   if (sd-gest_taps_timeout)
 - {
 -ecore_timer_del(sd-gest_taps_timeout);
 -sd-gest_taps_timeout = NULL;
 - }
 +   ELM_FREE_FUNC(sd-gest_taps_timeout, ecore_timer_del);

 if (!gesture-data)
   return;
 @@ -1433,11 +1429,7 @@ _n_long_tap_test_reset(Gesture_Info *gesture)
   free(p);
 st-touched = NULL;

 -   if (st-timeout)
 - {
 -ecore_timer_del(st-timeout);
 -st-timeout = NULL;
 - }
 +   ELM_FREE_FUNC(st-timeout, ecore_timer_del);
 memset(gesture-data, 0, sizeof(Long_Tap_Type));
  }

 @@ -1989,11 +1981,7 @@ _n_long_tap_test(Evas_Object *obj,
 ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
  st-info, EINA_FALSE);

 - if (st-timeout)
 -   {
 -  ecore_timer_del(st-timeout);
 -  st-timeout = NULL;
 -   }
 + ELM_FREE_FUNC(st-timeout, ecore_timer_del);
   _event_consume(sd, event_info, event_type, ev_flag);
}

 @@ -2013,11 +2001,7 @@ _n_long_tap_test(Evas_Object *obj,
   /* ABORT if user moved fingers out of tap area */
   if (!_inside(x, y, st-center_x, st-center_y))
 {
 -  if (st-timeout)
 -{
 -   ecore_timer_del(st-timeout);
 -   st-timeout = NULL;
 -}
 +  ELM_FREE_FUNC(st-timeout, ecore_timer_del);

/* Report MOVE if gesture started */
ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT,
 @@ -3638,11 +3622,7 @@ _elm_gesture_layer_smart_del(Eo *obj, void *_pd, 
 va_list *list EINA_UNUSED)

free(sd-gesture[i]);
 }
 -   if (sd-gest_taps_timeout)
 - {
 -ecore_timer_del(sd-gest_taps_timeout);
 -sd-gest_taps_timeout = NULL;
 - }
 +

Re: [E-devel] Fix in ecore_con

2013-05-24 Thread Daniel Willmann

On 24/05/13 11:00, Guillaume Friloux wrote:
 I sent another patch in ecore_con : 
 http://git.enlightenment.org/legacy/ecore.git/commit/?id=d3d82c6f490e5ba1b
 4c9a7c72c9ff42c3a7e70f6
 Please, add it to 1.8 and test it.
 
 On 24/05/2013 11:01, Guillaume Friloux wrote:
 Hello dear devs,
 I have committed a fix for ecore_con, in the legacy branch.
 This fix should also be applied to efl/ (1.8), but i am not going to 
 do it as i dont use 1.8, and so wont test it.
 I need someone to take care of this.

Done for both. Thanks for the fix!


Regards,
Daniel


--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Fix in ecore_con

2013-05-24 Thread Guillaume Friloux

i forgot one timer_reset in the case we only setted a timeout on server.
http://git.enlightenment.org/legacy/ecore.git/commit/?id=940d63c4178f68d606f3d28fdba312ed05a2374f

On 24/05/2013 12:35, Daniel Willmann wrote:

On 24/05/13 11:00, Guillaume Friloux wrote:

I sent another patch in ecore_con :
http://git.enlightenment.org/legacy/ecore.git/commit/?id=d3d82c6f490e5ba1b
4c9a7c72c9ff42c3a7e70f6
Please, add it to 1.8 and test it.

On 24/05/2013 11:01, Guillaume Friloux wrote:

Hello dear devs,
I have committed a fix for ecore_con, in the legacy branch.
This fix should also be applied to efl/ (1.8), but i am not going to
do it as i dont use 1.8, and so wont test it.
I need someone to take care of this.

Done for both. Thanks for the fix!

Regards,
Daniel

--
Try New Relic Now We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

attachment: guillaume_friloux.vcf--
Try New Relic Now We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Fix in ecore_con

2013-05-24 Thread Guillaume Friloux


I also fixed ecore_con_client_uptime_get() as reported in IRC.


On 24/05/2013 12:35, Daniel Willmann wrote:

On 24/05/13 11:00, Guillaume Friloux wrote:

I sent another patch in ecore_con :
http://git.enlightenment.org/legacy/ecore.git/commit/?id=d3d82c6f490e5ba1b
4c9a7c72c9ff42c3a7e70f6
Please, add it to 1.8 and test it.

On 24/05/2013 11:01, Guillaume Friloux wrote:

Hello dear devs,
I have committed a fix for ecore_con, in the legacy branch.
This fix should also be applied to efl/ (1.8), but i am not going to
do it as i dont use 1.8, and so wont test it.
I need someone to take care of this.

Done for both. Thanks for the fix!


Regards,
Daniel



attachment: guillaume_friloux.vcf--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [legacy/ecore] ecore-1.7 01/01: Update NEWS and ChangeLog according to last fixes in ecore_con

2013-05-24 Thread Daniel Willmann

On 24/05/13 16:25, Guillaume Friloux - Enlightenment Git wrote:
 asdfuser pushed a commit to branch ecore-1.7.
 
 commit 910f77328e67f67e3425858ef6c1e3bb814c36e7
 Author: Guillaume Friloux guillaume.fril...@asp64.com
 Date:   Fri May 24 14:12:41 2013 +0200
 
 Update NEWS and ChangeLog according to last fixes in ecore_con
 
 Backport commit 16cbbb
 
 Signed-off-by: Daniel Willmann d.willm...@samsung.com

Sorry, this was a PEBKAC issue... commit message does not match the
commit. The backport commit reference is correct, though.

Regards,
Daniel

 ---
  ChangeLog | 4 
  NEWS  | 2 ++
  src/lib/ecore_con/ecore_con.c | 1 +
  3 files changed, 7 insertions(+)
[...]
 diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c
 index 309b24a..158e1b9 100644
 --- a/src/lib/ecore_con/ecore_con.c
 +++ b/src/lib/ecore_con/ecore_con.c
 @@ -371,6 +371,7 @@ ecore_con_server_add(Ecore_Con_Type compl_type,
 if (!svr-name)
   goto error;
  
 +   svr-start_time = ecore_time_get();
 svr-type = compl_type;


--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

Re: [E-devel] E18 CFBugs

Re: [E-devel] E18 CFBugs

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

[E-devel] Fix in ecore_con

Re: [E-devel] Fix in ecore_con

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm: refactoring. use more ELM_FREE_FUNC.

Re: [E-devel] Fix in ecore_con

Re: [E-devel] Fix in ecore_con

Re: [E-devel] Fix in ecore_con

Re: [E-devel] [EGIT] [legacy/ecore] ecore-1.7 01/01: Update NEWS and ChangeLog according to last fixes in ecore_con

12 matches

Site Navigation

Mail list logo

Footer information