Re: [E-devel] [EGIT] [tools/enventor] annotated tag v0.1 deleted
Try as much as you like, but locally. Don't push anything as I now restricted tag deletion. You can't delete tags anymore. :) No harm done. On 6 Nov 2013 04:57, ChunEon Park her...@naver.com wrote: ok. trial and error before first release. -Regards, Hermet- -Original Message- From: Tom Hacohentom.haco...@samsung.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-11-05 (화) 22:39:21 Subject: Re: [E-devel] [EGIT] [tools/enventor] annotated tag v0.1 deleted On 05/11/13 13:32, Enlightenment Git wrote: hermet pushed a change to annotated tag v0.1 in repository tools/enventor. *** WARNING: tag v0.1 was deleted! *** tag was 31b9f906b4 The revisions that were on this annotated tag are still contained in other references; therefore, this change does not discard any commits from the repository. Just wanted to stretch it again (employed technical restrictions now to prevent it). DO NOT CHANGE HISTORY! If you create a tag, it's there to stay. YOU CAN NOT DELETE TAGS AFTER THEY ARE CREATED. Because of an oversight it was not the case, but it is the case now. DO NOT CREATE TAGS IF THEY ARE NOT FINAL. I think there are enough caps in this email to convey my point. Have a good day. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] New contributor
Hi Carsten, Thanks for your quick reply. It would be nice to have a front end to connman. Also what about porting any missing features from an already established network manager like the one kde uses or wicd to connman? On Wednesday 06 November 2013 16:22:42 Carsten Haitzler wrote: On Wed, 06 Nov 2013 07:28:31 +0100 Jonathan Aquilina jaquil...@eagleeyet.net said: From the moment I first tried out E i have fallen in love with it. I do notice that there are certain features which are lacking. The network manager conman needs some major work, as well as native apps for E. My in what way? connman is a back-end daemon. it has quite a lot of features not actually exposed in the ui - the ui only exposes the most basic things needed to get wifi selected, enter password, select a bt, usb/ethernet connection etc. the only things i personally really miss are: 1. being able to forget a network 2. static ip setup. to a large extent we will rely on connman having a feature at all to be able to use it. question becomes would the project like in terms of conman, for example, the code of the kde network management source ported to E or would it be better if something were written from scratch using the E api's. Also what languages in terms of programming does one need to know? Regards Jonathan -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clkt rk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: wsod: Fixed gdb hangs when generating backtraces.
Damn, OK. Will change that back, but the fix doesn't depend on that anyway. :) On 5 Nov 2013 23:49, Bertrand Jacquin be...@meleeweb.net wrote: On 2013-11-05 16:58, Tom Hacohen wrote: tasn pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=18cbd6f59a9c004dc1fe15d17331b3e23e8a6582 commit 18cbd6f59a9c004dc1fe15d17331b3e23e8a6582 Author: Tom Hacohen t...@stosb.com Date: Tue Nov 5 15:50:23 2013 + wsod: Fixed gdb hangs when generating backtraces. @@ -168,10 +168,11 @@ main(int argc, snprintf(buffer, 4096, %s --pid=%i + -batch -ex 'set logging file %s' -ex 'set logging on' -ex 'thread apply all backtrace full' - -ex detach -ex quit /dev/null 2 /dev/null, + -ex detach /dev/null /dev/zero, The '' is a bashism (stable since bash 4 only), therefore will not work for people not using bash as the main shell. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] New contributor
Hi, Connman has all the required features one would need, and as Cedric said connman exposes everyhting in Dbus. You can find all the connman documentation here: https://connman.net/documentation As for the connman e module, it uses the dbus api to interact with the connman daemon. For now it only implements a few connman thing, and lacks all the manual configuration part. This can be implemented by using the dbus api. Porting some kde thing are of no use, because it uses the kde libs and are just doing the same that is displaying a UI that talk to the network daemon through dbus. The only good way of doing something to enhance the network module in e is to write a new E module that talks either to NetworkManager or Connman through dbus. Porting that from another desktop is of no help because it uses completely different technologies (E uses EFL). If you want to do some work on that, a starting point would be to learn efl first, then play with the dbus api (we also have edbus, an efl library for talking with dbus apps/daemon). The bricks are there, the only thing is to put everything together and write a nice and cool UI for it, that would support either NetworkManager or Connman. -- Raoul Hecky 2013/11/6 Jonathan Aquilina jaquil...@eagleeyet.net: Hi Carsten, Thanks for your quick reply. It would be nice to have a front end to connman. Also what about porting any missing features from an already established network manager like the one kde uses or wicd to connman? On Wednesday 06 November 2013 16:22:42 Carsten Haitzler wrote: On Wed, 06 Nov 2013 07:28:31 +0100 Jonathan Aquilina jaquil...@eagleeyet.net said: From the moment I first tried out E i have fallen in love with it. I do notice that there are certain features which are lacking. The network manager conman needs some major work, as well as native apps for E. My in what way? connman is a back-end daemon. it has quite a lot of features not actually exposed in the ui - the ui only exposes the most basic things needed to get wifi selected, enter password, select a bt, usb/ethernet connection etc. the only things i personally really miss are: 1. being able to forget a network 2. static ip setup. to a large extent we will rely on connman having a feature at all to be able to use it. question becomes would the project like in terms of conman, for example, the code of the kde network management source ported to E or would it be better if something were written from scratch using the E api's. Also what languages in terms of programming does one need to know? Regards Jonathan -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clkt rk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Eolian meta-data parsing
On 11/06/2013 03:31 AM, Cedric BAIL wrote:
On Tue, Nov 5, 2013 at 6:51 PM, Yakov Goldberg yako...@samsung.com wrote:
On 11/05/2013 08:20 AM, Cedric BAIL wrote:
On Tue, Nov 5, 2013 at 12:42 AM, Yakov Goldberg yako...@samsung.com wrote:
Here is autogenerated (a little prettyfied and shortened) example of eo
file.
http://pastebin.com/ERQphzNk
I'm using my own python code from eo_bindings, where I was parsing c/h
files to get all eo information.
Some explanations:
name - class name from Eo class description. We check that it is unique.
inherits - names of parent classes
constructors - (actually it is a method, just put it into separate
section). Here you will meet only custom cunstructors.
here win_constructor is a name
comment - comment
parameters:2d array
[in,const,char*,name,],
direction, modifier, type, name, comment
maybe modifier is not needed, (but I already parsed it)
I must say that I don't like the parameters syntax at all. I think
something along the following line would have been better :
in : [ { name : const char * } ]. Also I am starting thinking that
we should have comment in doxygen form inside the JSON itself that
could then be put along the generated code.
For example item_insert_before would become :
item_insert_before: {
/* This inserts an item before another in the list. It will be in the
* same tree level or group as the item it is inserted before.
*
* @see elm_genlist_item_append()
* @see elm_genlist_item_prepend()
* @see elm_genlist_item_insert_after()
* @see elm_object_item_del()
*
* @ingroup Genlist
*/
brief: Insert an item before another in a genlist widget,
parameters: [
in : [
{ itc : const Elm_Genlist_Item_Class* }, /* @param
itc The item class for the item */
{ data : const void* }, /* @param data The item data */
{ parent : Elm_Object_Item* }, /* @param parent The
parent item, or NULL if none */
{ before_it : Elm_Object_Item* }, /* @param before
The item to place this new one before. */
{ type : Elm_Genlist_Item_Type }, /* @param type Item
type */
{ func : Evas_Smart_Cb }, /* @param func
Convenience function called when the item is selected */
{ func_data : const void * } /* @param func_data
Data passed to @p func above. */
],
out : [
{ ret : Elm_Object_Item* } /* @return A handle to
the item added or @c NULL if not possible */
]
]
]
},
What's if I want to put in/out/inout parameters all mixed, wouldn't it
be nicier to put them like this.
Also comments outside will ruin JSON structure. So I will try to keep
giving proper json examples a while.
parameters : [
{par1 : [in, int, Comment1]},
{par2 : [out, Eina_Bool*, Comment2]},
{par3 : [inout, char **, Comment3]},
{par4 : [in, Typedefed_Enum, Comment4]},
]
I must say that I am against mixing in and out. I may be wrong, but I
think that our current API does follow this pattern of in, out ?
I think, yes. They follow this pattern, but what's for future classes
and API?
Maybe we simply should start with explanations. Which way is prefered?
- making everything as generic as possible.
or
- limit syntax with conventions, so we can say in EFL in - params in
the beginning, out - in the end
Also some nicier implements
implements: [
{elm_interface_scrollable: [ policy, set_get ]},
{Evas_Pbject_Smart: [ move, method ]},
]
I must say that I don't understand the previous two lines :-) Why do
we need to say if it is a method ? It should be able to find it easily
with only the name, no ?
In most cases - yes. And probably the only example I can give is:
elm_widget_theme/_set/_get .
So in eo file for Elm Widget we will have:
methods: {
theme: {
comment: 'Virtual' function on the widget being re-themed.,
parameters: [
[out, , Eina_Bool, ret, ]
]
}
}
properties :
{
theme: {
comment_set: No description supplied by the EAPI.,
comment_get: No description supplied by the EAPI.,
parameters: [
[ , Elm_Theme*, th, ]
]
}
}
So when overriding theme i need to tell which one of them I want to
override.
implements: [
{elm_widget: [ theme, method ]},
{elm_widget: [ theme, set ]}
]
Example: 2.
Also we can put implemets section into method and property sections.
But for properties still need to be marked, which of them should be overriden.
Example
methods : {
some_additional_section_to_separate_methods_from_implements :
{
/* methods description */
},
implements: [
{elm_widget: theme}
]
}
properties : {
Re: [E-devel] EFL 1.8 Alpha 1 + Enlightenment 0.18 Alpha1 Terminology 0.4 Alpha1
Great job! So.. when do we have a string freeze? This is important to translators, or they will waste their time. Thanks. Daniel Juyung Seo (SeoZ) On Tue, Nov 5, 2013 at 6:00 PM, Carsten Haitzler ras...@rasterman.comwrote: We are pleased to announce that our very first Alpha release (Alpha 1) of EFL 1.8 is now available for download at: http://download.enlightenment.org/releases/ The relevant components are: **GZ** http://download.enlightenment.org/releases/efl-1.8.0-alpha1.tar.gz http://download.enlightenment.org/releases/elementary-1.8.0-alpha1.tar.gz http://download.enlightenment.org/releases/emotion_generic_players-1.8.0-alpha1.tar.gz http://download.enlightenment.org/releases/evas_generic_loaders-1.8.0-alpha1.tar.gz **BZ2** http://download.enlightenment.org/releases/efl-1.8.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/elementary-1.8.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/emotion_generic_players-1.8.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/evas_generic_loaders-1.8.0-alpha1.tar.bz2 If you are compiling the above, please compile them in the following order: efl elementary emotion_generic_players evas_generic_players If you have an existing EFL or Elementary install, you may wish to delete its header files and libraries before building the above. In addition we have also put up early stage Alphas of Enlightenment 0.18 and Terminology 0.4 available here: **GZ** http://download.enlightenment.org/releases/enlightenment-0.18.0-alpha1.tar.gz http://download.enlightenment.org/releases/terminology-0.4.0-alpha1.tar.gz **BZ2** http://download.enlightenment.org/releases/enlightenment-0.18.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/terminology-0.4.0-alpha1.tar.bz2 We ask people to test builds and functionality at this stage in preparation for full release. Of course there will be bugs, and this is the point at which to weed them out. Please file bug tasks on http://phab.enlightenment.org and we will address them as best as possible for release. Future Alpha and Betas will come. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Eolian meta-data parsing
On 11/06/2013 11:45 AM, Yakov Goldberg wrote:
On 11/06/2013 03:31 AM, Cedric BAIL wrote:
On Tue, Nov 5, 2013 at 6:51 PM, Yakov Goldberg yako...@samsung.com wrote:
On 11/05/2013 08:20 AM, Cedric BAIL wrote:
On Tue, Nov 5, 2013 at 12:42 AM, Yakov Goldberg yako...@samsung.com
wrote:
Here is autogenerated (a little prettyfied and shortened) example of eo
file.
http://pastebin.com/ERQphzNk
I'm using my own python code from eo_bindings, where I was parsing c/h
files to get all eo information.
Some explanations:
name - class name from Eo class description. We check that it is unique.
inherits - names of parent classes
constructors - (actually it is a method, just put it into separate
section). Here you will meet only custom cunstructors.
here win_constructor is a name
comment - comment
parameters:2d array
[in,const,char*,name,],
direction, modifier, type, name, comment
maybe modifier is not needed, (but I already parsed it)
I must say that I don't like the parameters syntax at all. I think
something along the following line would have been better :
in : [ { name : const char * } ]. Also I am starting thinking that
we should have comment in doxygen form inside the JSON itself that
could then be put along the generated code.
For example item_insert_before would become :
item_insert_before: {
/* This inserts an item before another in the list. It will be in the
* same tree level or group as the item it is inserted before.
*
* @see elm_genlist_item_append()
* @see elm_genlist_item_prepend()
* @see elm_genlist_item_insert_after()
* @see elm_object_item_del()
*
* @ingroup Genlist
*/
brief: Insert an item before another in a genlist widget,
parameters: [
in : [
{ itc : const Elm_Genlist_Item_Class* }, /* @param
itc The item class for the item */
{ data : const void* }, /* @param data The item data
*/
{ parent : Elm_Object_Item* }, /* @param parent The
parent item, or NULL if none */
{ before_it : Elm_Object_Item* }, /* @param before
The item to place this new one before. */
{ type : Elm_Genlist_Item_Type }, /* @param type
Item type */
{ func : Evas_Smart_Cb }, /* @param func
Convenience function called when the item is selected */
{ func_data : const void * } /* @param func_data
Data passed to @p func above. */
],
out : [
{ ret : Elm_Object_Item* } /* @return A handle to
the item added or @c NULL if not possible */
]
]
]
},
What's if I want to put in/out/inout parameters all mixed, wouldn't it
be nicier to put them like this.
Also comments outside will ruin JSON structure. So I will try to keep
giving proper json examples a while.
parameters : [
{par1 : [in, int, Comment1]},
{par2 : [out, Eina_Bool*, Comment2]},
{par3 : [inout, char **, Comment3]},
{par4 : [in, Typedefed_Enum, Comment4]},
]
I must say that I am against mixing in and out. I may be wrong, but I
think that our current API does follow this pattern of in, out ?
I think, yes. They follow this pattern, but what's for future classes
and API?
Maybe we simply should start with explanations. Which way is prefered?
- making everything as generic as possible.
or
- limit syntax with conventions, so we can say in EFL in - params in
the beginning, out - in the end
Also some nicier implements
implements: [
{elm_interface_scrollable: [ policy, set_get ]},
{Evas_Pbject_Smart: [ move, method ]},
]
I must say that I don't understand the previous two lines :-) Why do
we need to say if it is a method ? It should be able to find it easily
with only the name, no ?
In most cases - yes. And probably the only example I can give is:
elm_widget_theme/_set/_get .
So in eo file for Elm Widget we will have:
methods: {
theme: {
comment: 'Virtual' function on the widget being re-themed.,
parameters: [
[out, , Eina_Bool, ret, ]
]
}
}
properties :
{
theme: {
comment_set: No description supplied by the EAPI.,
comment_get: No description supplied by the EAPI.,
parameters: [
[ , Elm_Theme*, th, ]
]
}
}
So when overriding theme i need to tell which one of them I want to
override.
implements: [
{elm_widget: [ theme, method ]},
{elm_widget: [ theme, set ]}
]
Just a little precision here. We plan to set this type as optional. So
only if the generator has conflicts, it will fail and the developer will
have to be explicit.
Example: 2.
Also we can put implemets section into method and property sections.
Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: wsod: Fixed gdb hangs when generating backtraces.
On 05/11/13 23:48, Bertrand Jacquin wrote: On 2013-11-05 16:58, Tom Hacohen wrote: tasn pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=18cbd6f59a9c004dc1fe15d17331b3e23e8a6582 commit 18cbd6f59a9c004dc1fe15d17331b3e23e8a6582 Author: Tom Hacohen t...@stosb.com Date: Tue Nov 5 15:50:23 2013 + wsod: Fixed gdb hangs when generating backtraces. @@ -168,10 +168,11 @@ main(int argc, snprintf(buffer, 4096, %s --pid=%i + -batch -ex 'set logging file %s' -ex 'set logging on' -ex 'thread apply all backtrace full' - -ex detach -ex quit /dev/null 2 /dev/null, + -ex detach /dev/null /dev/zero, The '' is a bashism (stable since bash 4 only), therefore will not work for people not using bash as the main shell. Saw your fix, thanks. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [eina] Eina_List and Eina_Inlist eina_inlist_prepend_relative and eina_list_prepend_relative_list
On 06/11/13 00:35, Felipe Magno de Almeida wrote:
n On Tue, Nov 5, 2013 at 7:02 PM, Tom Hacohen t...@stosb.com wrote:
That is not going to change.
The first and most important reason is that we are *NOT* going to break API
no matter how right you are.
OK. Can't really argue with that. Though I don't really see how an application
that depends on this behavior for *prepend_relative functions to be correct
since it just doesn't prepend relative to NULL at all.
If you really want to nit-pick, our lists and double-linked lists, so
the NULL is on both sides which means this is actually doing exactly
that (well, except for the fact that it replaces the NULL).
Well, applications were allowed to depend on that because it is
explicitly written in our docs. Even if you think it's wrong. Even if it
wasn't in the docs, it's relied upon in many places, so again, changing
it is a no go.
The second reason is that we also have append_relative and having two
functions that do the same would be redundant.
I don't see how that is related to what I said. I only want to prepend, but
I want the relative argument to treat NULL as a valid position in the list
(being that the post-the-end position), instead of treating that as an
optional argument with a fallback for list prepend algorithm. We already
treat NULL as an empty list and the list ends when next points to
NULL, so it already is true that NULL *is* the post-the-end node.
It's related because then what would you do with the append_relative
functions? Will they behave the same way as the prepend_relative (when
null is past as the relative)?
Also, using post-the-end positions is idiomatic in C and C++.
int = 0;
for(i = 0; i != size; ++i)
{
// loops on all elements
}
I disagree with this example, I don't see how this has anything to do
with null and double-linked lists.
The third reason is quite subjective, and maybe I'm too used to the efl
way, but I would expect the default behaviour of prepend relative to be
prepend. That's why I'm prepending.
If NULL becomes a valid domain for the positional argument, then
there isn't a default to talk about. Only prepend to relative argument
where NULL means the position after the last element. The list
argument already includes NULL in its value domain for eina list
functions.
Also, not append, nor prepend can be used to insert
elements in all possible positions of a list. Prepend can't insert
the element after the last element and append can't add it as
a first element. There's no current algorithm that can be used
as a
Again, double-linked list, NULL is in the list twice. Sure prepend and
append can't both be used to insert everywhere in the list, that's
annoying. As I said, the last point is subjective, maybe I was wrong
(still not convinced I am). However that doesn't change the fact that
it's not going to change. :)
Anyhow, talking about it is moot as this is not going to change.
Ok. I won't bring it up again if there's no controversy on this.
Even if there was, it's not going to change (recurring theme).
I understand developing libraries can be annoying, especially if you are
a perfectionist (I'm one as well). However that doesn't change the fact
that we've made a promise to our developers, and that promise is our
API. We are not going to break that promise no matter how big the
controversy is.
--
Tom.
--
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/elementary] master 01/01: fileselector: Remove invalid or unnecessary comment
ryuan pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=1b4b3fa86683b0ed1fc9ab47c07a94f783df4e13 commit 1b4b3fa86683b0ed1fc9ab47c07a94f783df4e13 Author: Ryuan Choi ryuan.c...@gmail.com Date: Wed Nov 6 19:26:57 2013 +0900 fileselector: Remove invalid or unnecessary comment --- src/lib/elc_fileselector.c | 4 1 file changed, 4 deletions(-) diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c index 5d8dc37..64f1157 100644 --- a/src/lib/elc_fileselector.c +++ b/src/lib/elc_fileselector.c @@ -3,12 +3,8 @@ * - child elements focusing support * - user defined icon/label cb * - show/hide/add buttons ??? - * - make variable/function names that are sensible * - Pattern Filter support * - Custom Filter support - * - is 'is_save' flag and API needed? If it is not is_save mode, - *entry is disabled and anchor can't be clicked. - *Also user should be able to type custom name in this mode. */ #ifdef HAVE_CONFIG_H # include elementary_config.h --
[E-devel] Weekly news from the automated build and QA front
Hello. The stabilization phase should give us all some time to look at issues in phab, defects in coverity or add some more regression or unit tests. No more rush on features for a while. Pick some easy things to keep you busy and have the good feeling on helping to get our code in a releasable state. This should give everyone an overview over what has happened in the last week on the QA front. The numbers in parentheses reflect the values from last week to give you a trend. CI: o Overall build statistic: 10.65% (5.1%) failed and 89.35% (94.9%) succeeded. https://build.enlightenment.org/ clang scan-build: o EFL scan-build reports 507 (505) issues. https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/ Exactness: o The edje exactness builds are working now. Elm exactness still failing. o Problems with icons and paths (file selector widget) o Still waiting for the first successful run on jenkins Unit tests: o 276 (277) unit tests for efl and none failing Coverage: o EFL total coverage is at 25.5% (25.9%) lines and 28.2% (28.7%) functions https://build.enlightenment.org/view/Test%20Coverage/ Coverity: o EFL: Outstanding defects 425 (439) with a density of 0.79 (0.83). 17 defects fixed since last build and 6 added. o Elm: Outstanding defects 35 (21) with a density of 0.16 (0.10). 0 defects fixed since last build and 17 added. o E: Outstanding defects 197 (198) with a density of 0.70 (0.71). 1 defects fixed since last build and 0 added. o Terminology: Outstanding defects 21 (19) with a density of 0.33 (0.30). 0 defects fixed since last build and 2 added. If anybody wants to see something added here let me know and be my guest. regards Stefan Schmidt -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.8 Alpha 1 + Enlightenment 0.18 Alpha1 Terminology 0.4 Alpha1
On Wed, 6 Nov 2013 18:47:42 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: Great job! So.. when do we have a string freeze? This is important to translators, or they will waste their time. not now. :) Thanks. Daniel Juyung Seo (SeoZ) On Tue, Nov 5, 2013 at 6:00 PM, Carsten Haitzler ras...@rasterman.comwrote: We are pleased to announce that our very first Alpha release (Alpha 1) of EFL 1.8 is now available for download at: http://download.enlightenment.org/releases/ The relevant components are: **GZ** http://download.enlightenment.org/releases/efl-1.8.0-alpha1.tar.gz http://download.enlightenment.org/releases/elementary-1.8.0-alpha1.tar.gz http://download.enlightenment.org/releases/emotion_generic_players-1.8.0-alpha1.tar.gz http://download.enlightenment.org/releases/evas_generic_loaders-1.8.0-alpha1.tar.gz **BZ2** http://download.enlightenment.org/releases/efl-1.8.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/elementary-1.8.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/emotion_generic_players-1.8.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/evas_generic_loaders-1.8.0-alpha1.tar.bz2 If you are compiling the above, please compile them in the following order: efl elementary emotion_generic_players evas_generic_players If you have an existing EFL or Elementary install, you may wish to delete its header files and libraries before building the above. In addition we have also put up early stage Alphas of Enlightenment 0.18 and Terminology 0.4 available here: **GZ** http://download.enlightenment.org/releases/enlightenment-0.18.0-alpha1.tar.gz http://download.enlightenment.org/releases/terminology-0.4.0-alpha1.tar.gz **BZ2** http://download.enlightenment.org/releases/enlightenment-0.18.0-alpha1.tar.bz2 http://download.enlightenment.org/releases/terminology-0.4.0-alpha1.tar.bz2 We ask people to test builds and functionality at this stage in preparation for full release. Of course there will be bugs, and this is the point at which to weed them out. Please file bug tasks on http://phab.enlightenment.org and we will address them as best as possible for release. Future Alpha and Betas will come. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Weekly news from the automated build and QA front
Hello. On Fri, 2013-11-01 at 12:39, Bertrand Jacquin wrote: Switch have been done, new build are now run with gcc 4.8.1 Thanks. No fallout so far which is good. :) regards Stefan Schmidt -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Elementary QuickLaunch and PIE executables
Hello. On Mon, 2013-11-04 at 17:37, Jean-Philippe André wrote: I have submitted some changes to Elementary, reviewed by Cedric, so blame him if everything is broken now :) The following commits remove elementary_testql, simplify the build logic based on PIE and even simplify execution of quicklaunch programs (by extending the searched paths): https://git.enlightenment.org/core/elementary.git/commit/?id=876f8bccc7fed2f8511c9bdbe1c0e21be30290ca https://git.enlightenment.org/core/elementary.git/commit/?id=97264f434d88af38aead65426d67236c7f89ffc0 I'll remove the now useless #ifdef ELM_LIB_QUICKLAUNCH in elementary. Btw, I forgot to add that the linker needs -rdynamic -pie and not just -pie :) The speed up for the build is really nice. Thanks for doing it. regards Stefan Schmidt -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] New contributor
06.11.2013 08:28, Jonathan Aquilina kirjoitti: From the moment I first tried out E i have fallen in love with it. I do notice that there are certain features which are lacking. The network manager conman needs some major work, as well as native apps for E. My question becomes would the project like in terms of conman, for example, the code of the kde network management source ported to E or would it be better if something were written from scratch using the E api's. Also what languages in terms of programming does one need to know? Hello! The current implementation for connman has very basic controls written in C as a loadable Enlightenment module; and a more advanced configuration UI written in Python-EFL, launched as an application. This advanced interface is almost complete but still lacking a couple of important features (like proxy configuration) which could be added with a fairly small amount of effort. Several useful applications have been written using EFL, some of these you can find in our git repository, under /apps: https://git.enlightenment.org/apps Some of the more unfinished applications live under developer spaces, which will hopefully grow into polished apps one day. Apps also exist in external repos, like EpyMC: https://code.google.com/p/e17mods/wiki/EpyMC Most (all?) of them have been written in C or Python. New ideas and development effort would be welcome! Regards Jonathan -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Blog on e planet
Hi all, for those who don't know me i am Simon a co maintainer of Enlightenment on openSUSE, I have a rss feed for the parts of my blog that are related to enlightenment, and occasionally openSUSE, i was wondering if it was possible to get it added to the e planet? the URL is http://simotek.net/category/opensuse-e/feed/ thanks for your time. Simon / Simotek --- Co maintainer of Enlightenment on openSUSE -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/02: Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the application to k
kuri pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=838c3bed85535559713e57f6e523da1f73c0ca31 commit 838c3bed85535559713e57f6e523da1f73c0ca31 Author: Guillaume Friloux guillaume.fril...@gmail.com Date: Wed Nov 6 14:13:40 2013 +0100 Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the application to know. This is not a complete fix has you need to fix a timeout value for it to happen, but still, it makes it possible to work around it. More work is needed on this. --- src/lib/ecore_con/ecore_con.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c index 7067d8d..fece5f3 100644 --- a/src/lib/ecore_con/ecore_con.c +++ b/src/lib/ecore_con/ecore_con.c @@ -1751,7 +1751,8 @@ _ecore_con_cb_tcp_connect(void *data, return; error: - if (errno || memerr) ecore_con_event_server_error(svr, memerr ?: strerror(errno)); + ecore_con_event_server_error(svr, +memerr ?: errno? strerror(errno) : DNS error); ecore_con_ssl_server_shutdown(svr); _ecore_con_server_kill(svr); } --
[EGIT] [core/efl] master 02/02: This adds the test case for the DNS error patch. Do not set the timeout value to something too low or you walk over another bug i discovered and that needs a lil talk.
kuri pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=329c64621891f855955eab1794d2d0255c377fcc
commit 329c64621891f855955eab1794d2d0255c377fcc
Author: Guillaume Friloux guillaume.fril...@gmail.com
Date: Wed Nov 6 14:30:54 2013 +0100
This adds the test case for the DNS error patch.
Do not set the timeout value to something too low or you walk over
another bug i discovered and that needs a lil talk.
---
src/tests/ecore/ecore_test_ecore_con.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/src/tests/ecore/ecore_test_ecore_con.c
b/src/tests/ecore/ecore_test_ecore_con.c
index 19cd447..7e5c593 100644
--- a/src/tests/ecore/ecore_test_ecore_con.c
+++ b/src/tests/ecore/ecore_test_ecore_con.c
@@ -146,6 +146,24 @@ _data(void *data, int type EINA_UNUSED, void *ev)
return ECORE_CALLBACK_RENEW;
}
+Eina_Bool
+_dns_add(void *data, int type EINA_UNUSED, void *ev EINA_UNUSED)
+{
+ Eina_Bool *err_check = data;
+ *err_check = EINA_FALSE;
+ ecore_main_loop_quit();
+ return ECORE_CALLBACK_RENEW;
+}
+
+Eina_Bool
+_dns_err(void *data, int type EINA_UNUSED, void *ev EINA_UNUSED)
+{
+ Eina_Bool *err_check = data;
+ *err_check = EINA_TRUE;
+ ecore_main_loop_quit();
+ return ECORE_CALLBACK_RENEW;
+}
+
START_TEST(ecore_test_ecore_con_server)
{
Ecore_Con_Server *server;
@@ -251,8 +269,46 @@ START_TEST(ecore_test_ecore_con_init)
}
END_TEST
+START_TEST(ecore_test_ecore_con_dns)
+{
+ Ecore_Con_Server *client;
+ Ecore_Event_Handler *e_err;
+ Ecore_Event_Handler *e_add;
+ Eina_Bool err_check = EINA_FALSE;
+ int ret;
+
+ ret = eina_init();
+ fail_if(ret != 1);
+ ret = ecore_init();
+ fail_if(ret != 1);
+ ret = ecore_con_init();
+ fail_if(ret != 1);
+
+ e_add = ecore_event_handler_add(ECORE_CON_EVENT_SERVER_ADD, _dns_add, (void
*) err_check);
+ e_err = ecore_event_handler_add(ECORE_CON_EVENT_SERVER_ERROR, _dns_err,
(void *) err_check);
+
+ client = ecore_con_server_connect(ECORE_CON_REMOTE_TCP,
+ wongsub.wrongdns.lan, 1234, NULL);
+ fail_if (client == NULL);
+ ecore_con_server_timeout_set(client, 5.0);
+
+ ecore_main_loop_begin();
+ fail_if (err_check == EINA_FALSE);
+ fail_if (ecore_event_handler_del(e_err) != (void *) err_check);
+ fail_if (ecore_event_handler_del(e_add) != (void *) err_check);
+
+ ret = ecore_con_shutdown();
+ fail_if(ret != 0);
+ ret = ecore_shutdown();
+ fail_if(ret != 0);
+ ret = eina_shutdown();
+ fail_if(ret != 0);
+}
+END_TEST
+
void ecore_test_ecore_con(TCase *tc)
{
tcase_add_test(tc, ecore_test_ecore_con_init);
tcase_add_test(tc, ecore_test_ecore_con_server);
+ tcase_add_test(tc, ecore_test_ecore_con_dns);
}
--
[EGIT] [website/www] master 01/01: update.php doesnt handle NEWER e versions well
raster pushed a commit to branch master.
http://git.enlightenment.org/website/www.git/commit/?id=f48782560b98870ddf6357f61a60032fc1267ab7
commit f48782560b98870ddf6357f61a60032fc1267ab7
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date: Wed Nov 6 22:34:12 2013 +0900
update.php doesnt handle NEWER e versions well
---
public_html/update.php | 4
1 file changed, 4 insertions(+)
diff --git a/public_html/update.php b/public_html/update.php
index 13d51d5..957113b 100644
--- a/public_html/update.php
+++ b/public_html/update.php
@@ -72,6 +72,10 @@ for ($l = 0; $l $linecount; $l++)
$res = OLD . $apps[$app];
break;
}
+ if (intval($vsv[$i]) intval($vcl[$i]))
+ {
+ break;
+ }
}
$fh = fopen($_SERVER[DOCUMENT_ROOT] . /../logs/e17-updates, a);
--
Re: [E-devel] [EGIT] [core/efl] master 01/02: Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the ap
SPANK + reminder. Hey guys, don't forget, the commit message format is: *** summary line EMPTY LINE rest of the commit message *** Please follow that, when you don't, it's really annoying. On 06/11/13 13:32, Guillaume Friloux wrote: kuri pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=838c3bed85535559713e57f6e523da1f73c0ca31 commit 838c3bed85535559713e57f6e523da1f73c0ca31 Author: Guillaume Friloux guillaume.fril...@gmail.com Date: Wed Nov 6 14:13:40 2013 +0100 Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the application to know. This is not a complete fix has you need to fix a timeout value for it to happen, but still, it makes it possible to work around it. More work is needed on this. --- src/lib/ecore_con/ecore_con.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c index 7067d8d..fece5f3 100644 --- a/src/lib/ecore_con/ecore_con.c +++ b/src/lib/ecore_con/ecore_con.c @@ -1751,7 +1751,8 @@ _ecore_con_cb_tcp_connect(void *data, return; error: - if (errno || memerr) ecore_con_event_server_error(svr, memerr ?: strerror(errno)); + ecore_con_event_server_error(svr, +memerr ?: errno? strerror(errno) : DNS error); ecore_con_ssl_server_shutdown(svr); _ecore_con_server_kill(svr); } -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Ecore_con state and error management.
Hello e devs. When fixing an issue (http://git.enlightenment.org/core/efl.git/commit/?id=838c3bed85535559713e57f6e523da1f73c0ca31), i saw that the error isnt held correctly in ecore. When everything is working, things are quite simple : - You call ecore_con_server_connect(), that will allocate you an Ecore_Con_Server object. - You go in the mainloop, do the stuff you want. - You leave mainloop. - You call ecore_con_server_del() to free your object. But when an error happens, the Ecore_Con_Server object always gets delete_me set to EINA_TRUE, and so, in the application using ecore_con, you have to handle this by not trying to free the object in case of an error (while the error can be totally separated from an allocation problem, in my case, non existent domain name). My opinion is that the error event should be raised, without deleting the Ecore_Con_Server object. Also, in the test case i added (http://git.enlightenment.org/core/efl.git/commit/?id=329c64621891f855955eab1794d2d0255c377fcc), you change the timeout set (5 seconds) to something low (1 second or lower), the test case will just segfault. I dont have time to spend on this, but maybe this is related to the strange behavior i have describe above. What do you guys think about it ? attachment: guillaume_friloux.vcf-- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [legacy/ecore] ecore-1.7 01/02: Ecore_con send error event when dns error.
kuri pushed a commit to branch ecore-1.7. http://git.enlightenment.org/legacy/ecore.git/commit/?id=1b216cc108169c08633fd43f74fa0f4cc77f2e86 commit 1b216cc108169c08633fd43f74fa0f4cc77f2e86 Author: Guillaume Friloux guillaume.fril...@gmail.com Date: Wed Nov 6 15:05:49 2013 +0100 Ecore_con send error event when dns error. This patch is a backport of http://git.enlightenment.org/core/efl.git/commit/?id=838c3bed85535559713e57f6e523da1f73c0ca31 : Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the application to know. This is not a complete fix has you need to fix a timeout value for it to happen, but still, it makes it possible to work around it. More work is needed on this. /hug tasn. --- src/lib/ecore_con/ecore_con.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c index 01c9767..7a8232d 100644 --- a/src/lib/ecore_con/ecore_con.c +++ b/src/lib/ecore_con/ecore_con.c @@ -1753,7 +1753,8 @@ _ecore_con_cb_udp_connect(void *data, return; error: - if (errno || memerr) ecore_con_event_server_error(svr, memerr ?: strerror(errno)); + ecore_con_event_server_error(svr, +memerr ?: errno? strerror(errno) : DNS error); ecore_con_ssl_server_shutdown(svr); _ecore_con_server_kill(svr); } --
[EGIT] [legacy/ecore] ecore-1.7 02/02: Adds a test case for the DNS error patch.
kuri pushed a commit to branch ecore-1.7.
http://git.enlightenment.org/legacy/ecore.git/commit/?id=4e425d92bd49ad0aed7691ac88aadc96672c0de6
commit 4e425d92bd49ad0aed7691ac88aadc96672c0de6
Author: Guillaume Friloux guillaume.fril...@gmail.com
Date: Wed Nov 6 15:10:28 2013 +0100
Adds a test case for the DNS error patch.
Do not set the timeout value to something too low or you walk over
another bug i discovered and that needs a lil talk.
---
src/tests/ecore_test_ecore_con.c | 56
1 file changed, 56 insertions(+)
diff --git a/src/tests/ecore_test_ecore_con.c b/src/tests/ecore_test_ecore_con.c
index 45c1f69..4b53866 100644
--- a/src/tests/ecore_test_ecore_con.c
+++ b/src/tests/ecore_test_ecore_con.c
@@ -146,6 +146,24 @@ _data(void *data, int type __UNUSED__, void *ev)
return ECORE_CALLBACK_RENEW;
}
+Eina_Bool
+_dns_add(void *data, int type EINA_UNUSED, void *ev EINA_UNUSED)
+{
+ Eina_Bool *err_check = data;
+ *err_check = EINA_FALSE;
+ ecore_main_loop_quit();
+ return ECORE_CALLBACK_RENEW;
+}
+
+Eina_Bool
+_dns_err(void *data, int type EINA_UNUSED, void *ev EINA_UNUSED)
+{
+ Eina_Bool *err_check = data;
+ *err_check = EINA_TRUE;
+ ecore_main_loop_quit();
+ return ECORE_CALLBACK_RENEW;
+}
+
START_TEST(ecore_test_ecore_con_server)
{
Ecore_Con_Server *server;
@@ -251,8 +269,46 @@ START_TEST(ecore_test_ecore_con_init)
}
END_TEST
+START_TEST(ecore_test_ecore_con_dns)
+{
+ Ecore_Con_Server *client;
+ Ecore_Event_Handler *e_err;
+ Ecore_Event_Handler *e_add;
+ Eina_Bool err_check = EINA_FALSE;
+ int ret;
+
+ ret = eina_init();
+ fail_if(ret != 1);
+ ret = ecore_init();
+ fail_if(ret != 1);
+ ret = ecore_con_init();
+ fail_if(ret != 1);
+
+ e_add = ecore_event_handler_add(ECORE_CON_EVENT_SERVER_ADD, _dns_add, (void
*) err_check);
+ e_err = ecore_event_handler_add(ECORE_CON_EVENT_SERVER_ERROR, _dns_err,
(void *) err_check);
+
+ client = ecore_con_server_connect(ECORE_CON_REMOTE_TCP,
+ wongsub.wrongdns.lan, 1234, NULL);
+ fail_if (client == NULL);
+ ecore_con_server_timeout_set(client, 5.0);
+
+ ecore_main_loop_begin();
+ fail_if (err_check == EINA_FALSE);
+ fail_if (ecore_event_handler_del(e_err) != (void *) err_check);
+ fail_if (ecore_event_handler_del(e_add) != (void *) err_check);
+
+ ret = ecore_con_shutdown();
+ fail_if(ret != 0);
+ ret = ecore_shutdown();
+ fail_if(ret != 0);
+ ret = eina_shutdown();
+ fail_if(ret != 0);
+}
+END_TEST
+
void ecore_test_ecore_con(TCase *tc)
{
tcase_add_test(tc, ecore_test_ecore_con_init);
tcase_add_test(tc, ecore_test_ecore_con_server);
+ tcase_add_test(tc, ecore_test_ecore_con_dns);
}
--
Re: [E-devel] Blog on e planet
On 2013-11-06 13:51, Simon wrote: Hi all, for those who don't know me i am Simon a co maintainer of Enlightenment on openSUSE, I have a rss feed for the parts of my blog that are related to enlightenment, and occasionally openSUSE, i was wondering if it was possible to get it added to the e planet? the URL is http://simotek.net/category/opensuse-e/feed/ thanks for your time. Will be done tonight if other fool agreed ! Thanks for this. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/02: Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the ap
Hello. On Wed, 2013-11-06 at 13:35, Tom Hacohen wrote: SPANK + reminder. Hey guys, don't forget, the commit message format is: *** summary line EMPTY LINE rest of the commit message *** Please follow that, when you don't, it's really annoying. On the other hand we have to praise him as he delivered a regression test with theis as well. Which is something I would encourage more people to do. regards Stefan Schmidt -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/02: Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the ap
On 06/11/13 14:17, Stefan Schmidt wrote: Hello. On Wed, 2013-11-06 at 13:35, Tom Hacohen wrote: SPANK + reminder. Hey guys, don't forget, the commit message format is: *** summary line EMPTY LINE rest of the commit message *** Please follow that, when you don't, it's really annoying. On the other hand we have to praise him as he delivered a regression test with theis as well. Which is something I would encourage more people to do. regards Stefan Schmidt OK, you also get praises. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/02: Fixes a bug where when you try to connect to a server using an inexistant DNS, or having a DNS resolution error, there isnt any event generated for the ap
On 06/11/2013 15:18, Tom Hacohen wrote: On 06/11/13 14:17, Stefan Schmidt wrote: Hello. On Wed, 2013-11-06 at 13:35, Tom Hacohen wrote: SPANK + reminder. Hey guys, don't forget, the commit message format is: *** summary line EMPTY LINE rest of the commit message *** Please follow that, when you don't, it's really annoying. On the other hand we have to praise him as he delivered a regression test with theis as well. Which is something I would encourage more people to do. regards Stefan Schmidt OK, you also get praises. -- Tom. Oh yeah slap me bad and kiss me, naugthy boy! attachment: guillaume_friloux.vcf-- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] New contributor
On Wed, 6 Nov 2013 15:57:59 +0900 Cedric BAIL cedric.b...@free.fr wrote: On Wed, Nov 6, 2013 at 3:28 PM, Jonathan Aquilina jaquil...@eagleeyet.net wrote: Also what languages in terms of programming does one need to know? All core developers and applications tend to happen in C. Connman module does start a python application when you click on the configuration button, that did create us trouble with distribution that didn't provide it correctly and user did complain. So I would argue that for anything that is going to be integrated with E, it should be C only. That's not entirely true. Theming, and some parts of UI that are in the themes, is written in Edje, with the option of Embryo and Lua parts. Knowing at least two of those three is likely to be useful when developing UI stuff. Edje is our own invention, and Embryo is based an Pawn/Small. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] gerrit code review
Hey guys I am seeing alot of things about commiting code to the code base etc, Has gerrit code review been considered? As well as build bots -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gerrit code review
On 06/11/13 14:59, Jonathan Aquilina wrote: Hey guys I am seeing alot of things about commiting code to the code base etc, Has gerrit code review been considered? As well as build bots It has been considered and rejected. Build bots: we have jenkins, build.enlightenment.org -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: Eo: remove ; after while (0) in Eo.h.
tasn pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=087f94569083db23786fb09d3b8bff3a3190dd80
commit 087f94569083db23786fb09d3b8bff3a3190dd80
Author: Tom Hacohen t...@stosb.com
Date: Wed Nov 6 14:33:06 2013 +
Eo: remove ; after while (0) in Eo.h.
The whole point of having do {} while (0); is to force people to add a
; after the call to the macro. Therefore there should be no semicolon.
---
src/lib/eo/Eo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/eo/Eo.h b/src/lib/eo/Eo.h
index 8ec503f..228872f 100644
--- a/src/lib/eo/Eo.h
+++ b/src/lib/eo/Eo.h
@@ -1173,7 +1173,7 @@ enum {
#define eo_weak_ref(wref) \
do { \
if (*wref) eo_do(*wref, eo_wref_add(wref));\
- } while (0);
+ } while (0)
/**
* @def eo_weak_unref
@@ -1191,7 +1191,7 @@ enum {
#define eo_weak_unref(wref)\
do { \
if (*wref) eo_do(*wref, eo_wref_del(wref));\
- } while (0);
+ } while (0)
/**
* @def eo_wref_del_safe
--
Re: [E-devel] gerrit code review
Why was gerrit rejected? On Wednesday 06 November 2013 15:01:56 Tom Hacohen wrote: On 06/11/13 14:59, Jonathan Aquilina wrote: Hey guys I am seeing alot of things about commiting code to the code base etc, Has gerrit code review been considered? As well as build bots It has been considered and rejected. Build bots: we have jenkins, build.enlightenment.org -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Class names/object types: one last thing for 1.8
Hey guys, At the moment we have a lot of ugly and inconsistent class names and object types used all over the place, for example: elm windows: elm_win evas rectangle: rectangle evas box: Evas_Object_Box I would like to change those to something consistent before 1.8. I know for a fact that there is code out there that compares to that string, and that will have to be fix as well. Otherwise it should be fine. It's really ugly and confusing (especially with clouseau) and I would love seeing it fixed. I suggest we do something like: Elm_Win Evas_Rectangle Evas_Box What do you think? -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gerrit code review
On 06/11/13 15:15, Jonathan Aquilina wrote: Why was gerrit rejected? Mainly because people didn't want to go through a review system and because we don't have the man-power to review commits. Also, many of us have their own area of expertise so approving commits will mostly be a waste of time. We already review commits post-push through the ML and we find that sufficient. For random contributors we have Phabricator (for better or worse) and a review system there. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Class names/object types: one last thing for 1.8
On 11/06/2013 05:11 PM, Tom Hacohen wrote: Hey guys, At the moment we have a lot of ugly and inconsistent class names and object types used all over the place, for example: elm windows: elm_win evas rectangle: rectangle evas box: Evas_Object_Box I would like to change those to something consistent before 1.8. I know for a fact that there is code out there that compares to that string, and that will have to be fix as well. Otherwise it should be fine. It's really ugly and confusing (especially with clouseau) and I would love seeing it fixed. I suggest we do something like: Elm_Win Evas_Rectangle Evas_Box What do you think? -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel +100 Since I'm working on auto-generating eo classes, having a template like name is a must. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gerrit code review
Dont you run the risk of patches falling through the cracks in terms of patches recieved on the mailing list? On Wednesday 06 November 2013 15:26:57 Tom Hacohen wrote: On 06/11/13 15:15, Jonathan Aquilina wrote: Why was gerrit rejected? Mainly because people didn't want to go through a review system and because we don't have the man-power to review commits. Also, many of us have their own area of expertise so approving commits will mostly be a waste of time. We already review commits post-push through the ML and we find that sufficient. For random contributors we have Phabricator (for better or worse) and a review system there. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Class names/object types: one last thing for 1.8
On 06/11/13 15:33, Yossi Kantor wrote: On 11/06/2013 05:11 PM, Tom Hacohen wrote: Hey guys, At the moment we have a lot of ugly and inconsistent class names and object types used all over the place, for example: elm windows: elm_win evas rectangle: rectangle evas box: Evas_Object_Box I would like to change those to something consistent before 1.8. I know for a fact that there is code out there that compares to that string, and that will have to be fix as well. Otherwise it should be fine. It's really ugly and confusing (especially with clouseau) and I would love seeing it fixed. I suggest we do something like: Elm_Win Evas_Rectangle Evas_Box What do you think? -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel +100 Since I'm working on auto-generating eo classes, having a template like name is a must. Haha, I expected some love from you guys. :P -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gerrit code review
On 06/11/13 15:35, Jonathan Aquilina wrote: Dont you run the risk of patches falling through the cracks in terms of patches recieved on the mailing list? We should at some point use patchwork or whatever. But no, there's no risk in that, because the official method of sending patches is phabricator. Which doesn't lose patches. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gerrit code review
When i say lose i mean more along the lines of ending up being missed or overlooked. On Wednesday 06 November 2013 15:41:07 Tom Hacohen wrote: On 06/11/13 15:35, Jonathan Aquilina wrote: Dont you run the risk of patches falling through the cracks in terms of patches recieved on the mailing list? We should at some point use patchwork or whatever. But no, there's no risk in that, because the official method of sending patches is phabricator. Which doesn't lose patches. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] gerrit code review
On 06/11/13 15:55, Jonathan Aquilina wrote: When i say lose i mean more along the lines of ending up being missed or overlooked. Yes, I understand that's what you meant by lose. Have you even looked at phabricator? Our wiki? Our contribute page? If you send patches to phabricator they won't be lost. In that regard it's the same as gerrit. -- TOm. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/elementary] master 01/03: test_progressbar.c: Fixed formatting before working on it.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=dc20d7843f64373b3fa61e0f3d006d3a3a8f6a75
commit dc20d7843f64373b3fa61e0f3d006d3a3a8f6a75
Author: Daniel Juyung Seo seojuyu...@gmail.com
Date: Wed Nov 6 23:59:45 2013 +0900
test_progressbar.c: Fixed formatting before working on it.
---
src/bin/test_progressbar.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/bin/test_progressbar.c b/src/bin/test_progressbar.c
index 1b38223..d5256d7 100644
--- a/src/bin/test_progressbar.c
+++ b/src/bin/test_progressbar.c
@@ -121,8 +121,8 @@ test_progressbar(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *eve
evas_object_size_hint_weight_set(pb, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(pb, EVAS_HINT_FILL, 0.5);
elm_box_pack_end(bx, pb);
-// elm_progressbar_horizontal_set(pb, EINA_TRUE);
-// elm_object_text_set(pb, Progression %);
+ //elm_progressbar_horizontal_set(pb, EINA_TRUE);
+ //elm_object_text_set(pb, Progression %);
elm_progressbar_unit_format_function_set(pb, my_progressbar_format_cb,
(void (*)(char *)) free);
evas_object_show(pb);
@@ -244,9 +244,9 @@ _set_progress_val(Evas_Object *pb, double inc_value, char
*part_name)
progress = elm_progressbar_part_value_get(pb, part_name);
if (progress 1.0)
- progress += inc_value;
+ progress += inc_value;
else
- return EINA_TRUE;
+ return EINA_TRUE;
elm_progressbar_part_value_set(pb, part_name, progress);
@@ -259,22 +259,22 @@ _progressbar2_timer_cb(void *data)
Progressbar_Data *pd = data;
double progress;
- if (!pd)
- {
- pd-timer = NULL;
- return ECORE_CALLBACK_CANCEL;
- }
+ if (!pd)
+ {
+pd-timer = NULL;
+return ECORE_CALLBACK_CANCEL;
+ }
progress = elm_progressbar_value_get (pd-pb1);
if (progress 1.0)
- {
- progress += 0.0123;
- elm_progressbar_part_value_set(pd-pb1, elm.cur.progressbar,
progress);
- elm_progressbar_part_value_set(pd-pb2, elm.cur.progressbar1,
progress);
- elm_progressbar_part_value_set(pd-pb3, elm.cur.progressbar1,
progress);
- elm_progressbar_part_value_set(pd-pb4, elm.cur.progressbar1,
progress);
- }
+ {
+progress += 0.0123;
+elm_progressbar_part_value_set(pd-pb1, elm.cur.progressbar,
progress);
+elm_progressbar_part_value_set(pd-pb2, elm.cur.progressbar1,
progress);
+elm_progressbar_part_value_set(pd-pb3, elm.cur.progressbar1,
progress);
+elm_progressbar_part_value_set(pd-pb4, elm.cur.progressbar1,
progress);
+ }
_set_progress_val(pd-pb2, 0.00723, elm.cur.progressbar);
_set_progress_val(pd-pb3, 0.00523, elm.cur.progressbar);
--
[EGIT] [core/elementary] master 03/03: test_genlist.c: Fixed wrong item class name.
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=385004135fde929133e39c10925656c960a62220 commit 385004135fde929133e39c10925656c960a62220 Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Thu Nov 7 01:24:12 2013 +0900 test_genlist.c: Fixed wrong item class name. This fixes coverity CID 1126089. --- src/bin/test_genlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/test_genlist.c b/src/bin/test_genlist.c index b62bfb6..dd56103 100644 --- a/src/bin/test_genlist.c +++ b/src/bin/test_genlist.c @@ -3628,5 +3628,5 @@ test_genlist_multi_select(void *data EINA_UNUSED, gl_sel/* func */, (void *)(uintptr_t)(i * 10)/* func data */); } - elm_genlist_item_class_free(itc1); + elm_genlist_item_class_free(itc); } --
[EGIT] [core/elementary] master 02/03: test_progressbar.c: Fixed wrong null set of timer.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=825d357baa20f3c36b5f4c51b42bd507ca21ba5a
commit 825d357baa20f3c36b5f4c51b42bd507ca21ba5a
Author: Daniel Juyung Seo seojuyu...@gmail.com
Date: Thu Nov 7 00:00:38 2013 +0900
test_progressbar.c: Fixed wrong null set of timer.
If pd is null, pd-timer will crash and cannot set it to null.
This fixes coverity CID 1126081.
---
src/bin/test_progressbar.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/bin/test_progressbar.c b/src/bin/test_progressbar.c
index d5256d7..997a9f4 100644
--- a/src/bin/test_progressbar.c
+++ b/src/bin/test_progressbar.c
@@ -259,11 +259,7 @@ _progressbar2_timer_cb(void *data)
Progressbar_Data *pd = data;
double progress;
- if (!pd)
- {
-pd-timer = NULL;
-return ECORE_CALLBACK_CANCEL;
- }
+ if (!pd) return ECORE_CALLBACK_CANCEL;
progress = elm_progressbar_value_get (pd-pb1);
--
Re: [E-devel] gerrit code review
Yet, not everyone does that, there have been a few patches that landed on the ML... either due to ignorance about phab or because people couldn't set it up correctly and decided to drop them here instead. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [apps/ecrire] master 01/01: Correctly init and shutdown eet and efreet.
tasn pushed a commit to branch master.
http://git.enlightenment.org/apps/ecrire.git/commit/?id=4b31848b6fbfab96b6e1ea5289c4dd87408c19ac
commit 4b31848b6fbfab96b6e1ea5289c4dd87408c19ac
Author: Tom Hacohen t...@stosb.com
Date: Wed Nov 6 16:56:12 2013 +
Correctly init and shutdown eet and efreet.
---
src/bin/cfg.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/bin/cfg.c b/src/bin/cfg.c
index 24afcaf..a4c6dd1 100644
--- a/src/bin/cfg.c
+++ b/src/bin/cfg.c
@@ -43,15 +43,23 @@ ecrire_cfg_shutdown(void)
free(config_file);
_ent_cfg_descriptor_shutdown();
+
+ eet_shutdown();
+ efreet_shutdown();
}
void
ecrire_cfg_init(const char *file)
{
const char *ext = .cfg;
- const char *path = efreet_config_home_get();
+ const char *path;
size_t len;
+ efreet_init();
+ eet_init();
+
+ path = efreet_config_home_get();
+
if (!path || !file)
return;
@@ -63,8 +71,6 @@ ecrire_cfg_init(const char *file)
config_file = malloc(len + 1);
snprintf(config_file, len + 1, %s/%s%s, path, file, ext);
- eet_init();
-
_ent_cfg_descriptor_init();
}
--
[EGIT] [tools/clouseau] master 01/01: Get rid of the bottom backtrace panel for the meanwhile.
tasn pushed a commit to branch master. http://git.enlightenment.org/tools/clouseau.git/commit/?id=d95fc3e02b97ca483101a4ed533a3a8015d0d0df commit d95fc3e02b97ca483101a4ed533a3a8015d0d0df Author: Tom Hacohen t...@stosb.com Date: Wed Nov 6 16:12:21 2013 + Get rid of the bottom backtrace panel for the meanwhile. --- src/bin/clouseau_client.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c index 04b3d53..78b4ffe 100644 --- a/src/bin/clouseau_client.c +++ b/src/bin/clouseau_client.c @@ -69,7 +69,6 @@ struct _Gui_Elementns Evas_Object *win; Evas_Object *bx; /* The main box */ Evas_Object *hbx;/* The top menu box */ - Evas_Object *panel; /* Button panel */ Evas_Object *bt_load; Evas_Object *bt_save; Evas_Object *dd_list; @@ -1726,7 +1725,6 @@ _show_gui(Gui_Elements *g, Eina_Bool work_offline) } evas_object_show(g-bx); - evas_object_show(g-panel); } static void @@ -2095,23 +2093,6 @@ main(int argc, char **argv) _main_list_create(panes); _property_list_create(panes); - /* START Add buttom panel */ - gui-panel = elm_panel_add(win); - elm_panel_orient_set(gui-panel, ELM_PANEL_ORIENT_BOTTOM); - evas_object_size_hint_weight_set(gui-panel, - EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - evas_object_size_hint_align_set(gui-panel, EVAS_HINT_FILL, EVAS_HINT_FILL); - elm_panel_hidden_set(gui-panel, EINA_TRUE); - elm_win_resize_object_add(win, gui-panel); - - gui-lb = elm_label_add(win); - evas_object_size_hint_weight_set(gui-lb, EVAS_HINT_EXPAND, 0); - evas_object_size_hint_align_set(gui-lb, EVAS_HINT_FILL, 0); - evas_object_show(gui-lb); - - elm_object_content_set(gui-panel, gui-lb); - /* END Add buttom panel */ - /* Add progress wheel */ gui-pb = elm_progressbar_add(win); elm_object_style_set(gui-pb, wheel); --
Re: [E-devel] gerrit code review
On 06/11/13 16:50, Alex-P. Natsios wrote: Yet, not everyone does that, there have been a few patches that landed on the ML... either due to ignorance about phab or because people couldn't set it up correctly and decided to drop them here instead. Yeah, but the same would happen with gerrit... There are no magic solutions to that (except for patchwork, but it's not really needed atm). At the moment, we just encourage people to use phab. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [apps/terminology] master 02/02: missing EINA_UNUSED
billiob pushed a commit to branch master.
http://git.enlightenment.org/apps/terminology.git/commit/?id=e724c8d0db68276bf4da15964087b223a49531b1
commit e724c8d0db68276bf4da15964087b223a49531b1
Author: Boris Faure bill...@gmail.com
Date: Wed Nov 6 21:45:32 2013 +0100
missing EINA_UNUSED
---
src/bin/termio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/bin/termio.c b/src/bin/termio.c
index 6dfaf74..5286bc0 100644
--- a/src/bin/termio.c
+++ b/src/bin/termio.c
@@ -304,7 +304,8 @@ _activate_link(Evas_Object *obj, Eina_Bool may_inline)
}
static void
-_cb_ctxp_del(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_UNUSED,
void *event EINA_UNUSED)
+_cb_ctxp_del(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_UNUSED,
+ void *event EINA_UNUSED)
{
Termio *sd = data;
sd-link.ctxpopup = NULL;
@@ -312,7 +313,8 @@ _cb_ctxp_del(void *data, Evas *e EINA_UNUSED, Evas_Object
*obj EINA_UNUSED, void
}
static void
-_cb_ctxp_dismissed(void *data, Evas_Object *obj, void *event EINA_UNUSED)
+_cb_ctxp_dismissed(void *data EINA_UNUSED, Evas_Object *obj,
+ void *event EINA_UNUSED)
{
evas_object_del(obj);
}
--
[EGIT] [apps/terminology] master 01/02: fix typo. CID 1126105, 1126106
billiob pushed a commit to branch master.
http://git.enlightenment.org/apps/terminology.git/commit/?id=432587bc79704e360aa95d9f42bd2fe7c45334d1
commit 432587bc79704e360aa95d9f42bd2fe7c45334d1
Author: Boris Faure bill...@gmail.com
Date: Wed Nov 6 21:43:46 2013 +0100
fix typo. CID 1126105, 1126106
---
src/bin/termio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/termio.c b/src/bin/termio.c
index eca40bc..6dfaf74 100644
--- a/src/bin/termio.c
+++ b/src/bin/termio.c
@@ -3167,7 +3167,7 @@ _smart_cb_mouse_up(void *data, Evas *e EINA_UNUSED,
Evas_Object *obj EINA_UNUSED
sd-cur.makesel = 0;
if ((sd-cur.sel1.x == sd-cur.sel2.x)
-(sd-cur.sel2.y == sd-cur.sel2.y))
+(sd-cur.sel1.y == sd-cur.sel2.y))
{
_sel_set(data, EINA_FALSE);
sd-didclick = EINA_FALSE;
--
Re: [E-devel] gerrit code review
On Wed, 06 Nov 2013 16:55:04 +0100 Jonathan Aquilina jaquil...@eagleeyet.net said: When i say lose i mean more along the lines of ending up being missed or overlooked. https://phab.enlightenment.org/w/arcanist/ linked from: http://www.enlightenment.org/p.php?p=contribute and when they have been submitted they end up on: https://phab.enlightenment.org/differential/query/c.8PlsTrzNjQ if you look at them you will notice there are things like inline commenting on the patch (just like gerrit) etc. etc. just like gerrit - if people don't use the mechanisms we have in place, then patches may get lost on the mailing list. even here with phab patches may go unreviewed for a long time. they end up eternally on the list. unless someone gets assigned to review them explicitly then they are often not noticed. i cleaned out some old ones recently and need to go through more of them soon for release (those that are bug fixes. those that are new features will just wait until efl 1.8 is out). running EVERYTHING through gerrit will just waste our time. realistically what will happen is it will force everyone to ask someone else to review and 99.9% of that will be the rubber-stamp variety. that is what i have seen gerrit devolve into. unless you have a seriously large amount of manpower and time and are willing to slow down your dev process a lot, it becomes nothing more than a rubber-stamping exercise, which in and of itself just adds delay and STILL wastes peoples time in doing the bureaucratic stamping process. there is no point having a pre-review if that is the case (and only makes things worse as if the rubber-stamp comes a little too late, there may be a conflict and the commit has to go back to be re-edited just to get a stamp when it would have been fine if committed directly). if you have a commit - eg on a branch of your own, BEFORE you merge it and WANT people to review before your merge (voluntariily because you're not sure and want more eyeballs) then phab has all of this already. https://phab.enlightenment.org/diffusion/ just go to any commit and click. you can comment on the commit inline like gerrit. just ask people to do this and based on the feedback push in more commits and when ready - merge. that is if you have commit access already. commit access is what you get when your submissions are more trouble to review before merge than catching them ad-hoc afterwards. ie they are almost all good quality and not bad/malicious etc. and where the value in review before commit is minimal vs the effort to do so. so it means we trust you. until you have commit access changes can be submitted via phab's review process as above. oh and one other thing. gerrit is a NEW git server written in java. no one here was fond of the idea of having that running at all. not in the slightest. :) On Wednesday 06 November 2013 15:41:07 Tom Hacohen wrote: On 06/11/13 15:35, Jonathan Aquilina wrote: Dont you run the risk of patches falling through the cracks in terms of patches recieved on the mailing list? We should at some point use patchwork or whatever. But no, there's no risk in that, because the official method of sending patches is phabricator. Which doesn't lose patches. -- Tom. -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel
Re: [E-devel] Blog on e planet
On Wed, Nov 6, 2013 at 11:16 PM, Bertrand Jacquin be...@meleeweb.net wrote: On 2013-11-06 13:51, Simon wrote: Hi all, for those who don't know me i am Simon a co maintainer of Enlightenment on openSUSE, I have a rss feed for the parts of my blog that are related to enlightenment, and occasionally openSUSE, i was wondering if it was possible to get it added to the e planet? the URL is http://simotek.net/category/opensuse-e/feed/ thanks for your time. Will be done tonight if other fool agreed ! Thanks for this. I am a crazy fool and I agree ! Need more ? -- Cedric BAIL -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] efl packaging files
Hi, Instead of having: efl/pkgbuild efl/spec (and maybe more later) It would be cleaner to have one single packaging folder: efl/packaging/pkgbuild efl/packaging/spec etc. -- Jérôme Pinot http://ngc891.blogdns.net/ signature.asc Description: Digital signature -- November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
