Re: [E-devel] [EGIT] [core/elementary] master 01/01: slider: slider should be focused, when slider is handled with mouse or touch event.

2015-09-16 Thread Daniel Juyung Seo 
Yo,

This is not always true.
We need to consider ELM_FOCUS_MOVE_POLICY_KEY_ONLY. In that case, the
slide should not be focused by dragging.

Thanks,
Daniel

On Wed, Sep 16, 2015 at 10:16 AM, Hosang Kim  wrote:
> hermet pushed a commit to branch master.
>
> http://git.enlightenment.org/core/elementary.git/commit/?id=1262c24a72a314bc3dd1de014283068cd390e88c
>
> commit 1262c24a72a314bc3dd1de014283068cd390e88c
> Author: Hosang Kim 
> Date:   Wed Sep 16 10:10:32 2015 +0900
>
> slider: slider should be focused, when slider is handled with mouse or 
> touch event.
>
> Summary: slider is not focused after slider is dragged.
>
> Test Plan: elementary_test -> slider
>
> Reviewers: woohyun, seoz, smohanty, cedric, raster
>
> Differential Revision: https://phab.enlightenment.org/D3057
> ---
>  src/lib/elm_slider.c | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/lib/elm_slider.c b/src/lib/elm_slider.c
> index bffab0a..25cd4a7 100644
> --- a/src/lib/elm_slider.c
> +++ b/src/lib/elm_slider.c
> @@ -240,6 +240,8 @@ _drag_start(void *data,
>  const char *emission EINA_UNUSED,
>  const char *source EINA_UNUSED)
>  {
> +   if (!elm_widget_focus_get(data))
> + elm_object_focus_set(data, EINA_TRUE);
> _slider_update(data, EINA_TRUE);
> eo_do(data, eo_event_callback_call(ELM_SLIDER_EVENT_SLIDER_DRAG_START, 
> NULL));
> elm_widget_scroll_freeze_push(data);
> @@ -644,6 +646,8 @@ _spacer_down_cb(void *data,
> edje_object_part_drag_value_set
>   (wd->resize_obj, "elm.dragable.slider",
>   button_x, button_y);
> +   if (!elm_widget_focus_get(data))
> + elm_object_focus_set(data, EINA_TRUE);
> _slider_update(data, EINA_TRUE);
> eo_do(data, eo_event_callback_call(ELM_SLIDER_EVENT_SLIDER_DRAG_START, 
> NULL));
> elm_layout_signal_emit(data, "elm,state,indicator,show", "elm");
>
> --
>
>



-- 
Daniel Juyung Seo (SeoZ)

--
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Weekly news from the automated build and QA front

2015-09-16 Thread Stefan Schmidt 
Hello.

Summary:
o Bug reports increasing again
o Jenkins crash

This should give everyone an overview over what has happened in the last
week on the QA front. The numbers in parentheses reflect the values from
last week to give you a trend.

CI:
o Overall build statistic: 10.28% (7.08%) failed.
https://build.enlightenment.org/

Unique Jenkins build failures:
o Open:

o Resolved:
Various borken builds due to Jenkins crash

o Random:


Clang scan-build:
o EFL scan-build reports N/A (N/A) issues.
https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfu
lBuild/artifact/scan-build/build/
o Elementary scan-build reports 87 (87) issues.
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build

Unit tests:
o 541 (541) unit tests for efl and none failing

Coverage:
o EFL total coverage is at 36.4% (36.4%) lines and 39.6% (39.6%) functions
https://build.enlightenment.org/view/Test%20Coverage/

Coverity:
o EFL: Outstanding defects 90 (92) with a density of 0.12 (0.12)
o Elm: Outstanding defects 8 (8) with a density of 0.03 (0.03)
o Evas Generic Loaders: Outstanding defects 2 (2) with a density of 0.02
(0.02)
o Emotion Generic Players: Outstanding defects 0 (0) with a density of
0 (0)
o Enlightenment: Outstanding defects 49 (50) with a density of 0.18 (0.18)
o Terminology: Outstanding defects 0 (0) with a density of 0 (0)
o Rage: Outstanding defects 0 (0) with a density of 0 (0)

Phab:
o Total bug count: 649 (639)
https://phab.enlightenment.org/maniphest/report/burn/
o Pending patch reviews: 100 (99)

regards
Stefan Schmidt

--
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991=/4140
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel