Re: [E-devel] edevelop.slack.com experiment

[Naruto TAKAHASHI]

> So if you want to join, let me know your email and I'll send the
invitation.

Would you send a invite to tnaruto at gmail.com ?

B.R.

2017年3月21日(火) 23:54 Gustavo Sverzut Barbieri :

> Hi all,
>
> I'm doing an experiment with slack.com as IRC alternative. I'm no
> expert in slack, first time I ever used, if you have more experience
> let me know so I can add you as admin.
>
> The biggest annoyance at the time is sign up that requires an
> invitation, I sent to some in this list, others can do based on
> domains such as @samsung.com, @osg.samsung.com and so on... but they
> do not allow comcast.net or gmail.com to auto-join.
>
> So if you want to join, let me know your email and I'll send the
> invitation.
>
> I've added some interesting plugins as people were demanding
> voice/video calls at some point, these 2 can be better than simply
> keeping a google Hangouts open all the time (and night!):
>
>  /appear edevelop
>
> creates an appear.in video/voice chat https://appear.in/edevelop
> just click to join, no app or registration is required. Seems to have
> a 8 person limit.
>
>  /hangout
>
>  creates a hangout invitation link and post to channel, people can
> click to join. Marcel told it also has a limit on video users.
>
> Since we often need to remember people of stuff:
>
>  /remind [@person or #channel] [what] [when]
>  /remind me to drink water at 3pm every day
>  /remind me on June 1st to wish Linda happy birthday
>  /remind #team-alpha to update the project status every Monday at 9am
>  /remind @jessica about the interview in 3 hours
>  /remind @peter tomorrow "Please review the office seating plan"
>
> or:
>
>   /todo @okra fix ephoto!
>   /mytodo help vtorri with ecore-con on win32
>
>
> It can integrate with jenkins as well, but I don't have the permission
> to do that in our jenkins.
>
> So far, the web-browser version is as usable as the app, at least on
> Linux/Chrome, so no install is required. It looks quite nice and also
> provides phone applications (iOS version is very good). I also liked
> that it have built-in "pastebin", just click the "[+]" at the left
> side of the message box to send one.
>
>
> --
> Gustavo Sverzut Barbieri
> --
> Mobile: +55 (16) 99354-9890 <+55%2016%2099354-9890>
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
-- 

Naruto TAKAHASHI
tnar...@gmail.com
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Work items towards 1.19

[Vincent Torri]

there are some errors in the pipe names in ecore_con on Windows, so I think
that they must be fixed first

Vincent

On Mon, Mar 27, 2017 at 9:44 PM, Gustavo Sverzut Barbieri <
barbi...@gmail.com> wrote:

> Hi all,
>
> Please check my branch: devs/barbieri/efl_net_socket_windows2
> https://git.enlightenment.org/core/efl.git/log/?h=devs/
> barbieri/efl_net_socket_windows2
>
> This is what I plan to merge, I did tests using wine
> (src/examples/ecore) and it seems to work, please test on real windows
> machine and report problems please.
>
> PS: some tests useecore_main_fd_handler_add(STDIN_FILENO,
> ECORE_FD_READ, _on_stdin, NULL, NULL, NULL); to read from stdin, at
> least on wine this is not working as expected, in these tests I'm
> simulating by calling _on_stdin() from an ecore_job...
>
> BR,
>
> On Fri, Mar 24, 2017 at 10:20 AM, Gustavo Sverzut Barbieri
>  wrote:
> > On Fri, Mar 24, 2017 at 6:09 AM, Vincent Torri 
> wrote:
> > [...]
>  TL;DR: we'll never benefit from the thread pool benefits.
> >>>
> >>> it will if we have a lot of use of connections using ecore_con_local
> >>> or ecore_ipc
> >>
> >> also, it does not consume HANDLE's,
> >
> > what you mean?
> >
> >
> >> contrary to what you will use with
> >> the design you want to choose (which is btw my first implementation of
> >> ecore_con_local, you're re-writing it...)
> >
> > Yes, I checked the old win32 local file when I did some grep... but
> > it's slightly different as it uses the hEvent instead of notifying on
> > our own with SetEvent().
> >
> >
> >> and will be faster. The
> >> Windows port is already largely slower than the linux one. I've chosen
> >> I/O completion port for that very reason
> >
> > here is the part that I think I couldn't explain, it doesn't matter
> > the port speed if the user is not sending stuff to it.
> >
> > it's like having a 1Gbps network but the card is only capable of 10bmps.
> >
> > this is because we must go back to main thread to get more data to
> > send. Same for read, we only read up to BUFSIZE (I'm using 16kb), then
> > we call the user... until that is done, the kernel will idle...
> >
> > --
> > Gustavo Sverzut Barbieri
> > --
> > Mobile: +55 (16) 99354-9890
>
>
>
> --
> Gustavo Sverzut Barbieri
> --
> Mobile: +55 (16) 99354-9890
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Ephoto 1.0-beta3 Released

[Stephen Houston]

Hello all!

It is my pleasure to announce that Ephoto 1.0 Beta3 has been released.
This addresses many of the fixes and feature requests that you provided,
including the removal of overlapping/autohiding panels to regular side by
side panels.  Without your feedback, this would not be possible.  This will
be the last beta release before an official 1.0 release.  The 1.0 release
will come out in tandem with the EFL 1.19 release, so please provide
feedback, phab tickets, and feature requests to help get the final out! You
can find the release announcement with links to the tarballs here:
*https://www.enlightenment.org/news/ephoto-1-beta3-released
*
as well as here:
http://smhouston.us/ephoto-1-0-beta3-released

Ephoto's home on the interwebs is:
http://smhouston.us/ephoto/

Please test this beta via tarball or git and start making bug reports on
phab so I can clean everything up.  Thanks for all of your support over the
years! this beta via tarball or git and start making bug reports on phab so
I can clean everything up.  Thanks for all of your support over the years!

Stephen Houston
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [apps/ephoto] master 01/01: Ephoto: Fix use of stat/lstat, use eina_environment to get HOME and tmp dirs.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/apps/ephoto.git/commit/?id=ef805cefa9c6378d75e23c22b437d098114945b7

commit ef805cefa9c6378d75e23c22b437d098114945b7
Author: Stephen 'Okra' Houston 
Date:   Wed Mar 29 16:12:50 2017 -0500

Ephoto: Fix use of stat/lstat, use eina_environment to get HOME and tmp 
dirs.
---
 src/bin/ephoto_config.c|  4 ++--
 src/bin/ephoto_directory_browser.c |  4 ++--
 src/bin/ephoto_file.c  | 11 +-
 src/bin/ephoto_ipc.c   | 42 +-
 src/bin/ephoto_main.c  |  2 +-
 src/bin/ephoto_scale.c |  2 +-
 src/bin/ephoto_single_browser.c|  2 +-
 src/bin/ephoto_thumb_browser.c |  4 ++--
 8 files changed, 24 insertions(+), 47 deletions(-)

diff --git a/src/bin/ephoto_config.c b/src/bin/ephoto_config.c
index 3ebcb3a..5edb491 100644
--- a/src/bin/ephoto_config.c
+++ b/src/bin/ephoto_config.c
@@ -19,7 +19,7 @@ _config_save_cb(void *data, Evas_Object *obj EINA_UNUSED,
if (!strcmp(text, _("Root Directory")))
   path = "/";
else if (!strcmp(text, _("Home Directory")))
-  path = getenv("HOME");
+  path = eina_environment_home_get();
else if (!strcmp(text, _("Last Open Directory")))
   path = "Last";
else
@@ -778,7 +778,7 @@ ephoto_config_init(Ephoto *ephoto)
  ephoto->config->window_height = 500*elm_config_scale_get();
  ephoto->config->fsel_hide = 0;
   ephoto->config->lpane_size = .15;
- ephoto->config->open = eina_stringshare_add(getenv("HOME"));
+ ephoto->config->open = 
eina_stringshare_add(eina_environment_home_get());
  ephoto->config->prompts = 1;
  ephoto->config->drop = 0;
   ephoto->config->movess = 1;
diff --git a/src/bin/ephoto_directory_browser.c 
b/src/bin/ephoto_directory_browser.c
index 39898ed..cecdceb 100644
--- a/src/bin/ephoto_directory_browser.c
+++ b/src/bin/ephoto_directory_browser.c
@@ -473,7 +473,7 @@ _dir_go_trash(void *data, Evas_Object *obj EINA_UNUSED,
 
eina_stringshare_replace(>back_directory,
db->ephoto->config->directory);
-   snprintf(path, PATH_MAX, "%s/.config/ephoto/trash", getenv("HOME"));
+   snprintf(path, PATH_MAX, "%s/.config/ephoto/trash", 
eina_environment_home_get());
if (!ecore_file_exists(path))
   ecore_file_mkpath(path);
db->thumbs_only = 0;
@@ -607,7 +607,7 @@ _fsel_mouse_up_cb(void *data, Evas *e EINA_UNUSED,
if (info->button != 3)
   return;
 
-   snprintf(trash, PATH_MAX, "%s/.config/ephoto/trash", getenv("HOME"));
+   snprintf(trash, PATH_MAX, "%s/.config/ephoto/trash", 
eina_environment_home_get());
 
if (item)
  elm_genlist_item_selected_set(item, EINA_TRUE);
diff --git a/src/bin/ephoto_file.c b/src/bin/ephoto_file.c
index a9938a3..7e2b13e 100644
--- a/src/bin/ephoto_file.c
+++ b/src/bin/ephoto_file.c
@@ -728,7 +728,7 @@ _delete_thread_cb(void *data, Ecore_Thread *et EINA_UNUSED)
const char *file;
char destination[PATH_MAX];
 
-   snprintf(destination, PATH_MAX, "%s/.config/ephoto/trash", getenv("HOME"));
+   snprintf(destination, PATH_MAX, "%s/.config/ephoto/trash", 
eina_environment_home_get());
if (!ecore_file_exists(destination))
   ecore_file_mkpath(destination);
 
@@ -743,11 +743,10 @@ _delete_thread_cb(void *data, Ecore_Thread *et 
EINA_UNUSED)
 char dest[PATH_MAX], fp[PATH_MAX], extra[PATH_MAX];
 int ret;
  struct stat s;
-
 #ifdef _WIN32
- if (stat(file, ))
+ if (stat(file, ) == 0)
 #else
- if (lstat(file, ))
+ if (lstat(file, ) == 0)
 #endif
{
   if (S_ISLNK(s.st_mode))
@@ -808,7 +807,7 @@ _delete_dir_thread_cb(void *data, Ecore_Thread *et 
EINA_UNUSED)
const char *dir = eina_list_data_get(ephoto->file_pos);
char destination[PATH_MAX];
 
-   snprintf(destination, PATH_MAX, "%s/.config/ephoto/trash", getenv("HOME"));
+   snprintf(destination, PATH_MAX, "%s/.config/ephoto/trash", 
eina_environment_home_get());
 
if (!ecore_file_exists(destination))
   ecore_file_mkpath(destination);
@@ -868,7 +867,7 @@ _empty_trash_thread_cb(void *data, Ecore_Thread *th 
EINA_UNUSED)
const char *file;
char trash[PATH_MAX];
 
-   snprintf(trash, PATH_MAX, "%s/.config/ephoto/trash", getenv("HOME"));
+   snprintf(trash, PATH_MAX, "%s/.config/ephoto/trash", 
eina_environment_home_get());
 
if (!ephoto->file_pos)
   ephoto->file_pos = eina_list_nth(ephoto->file_pos, 0);
diff --git a/src/bin/ephoto_ipc.c b/src/bin/ephoto_ipc.c
index a171b60..be1084f 100644
--- a/src/bin/ephoto_ipc.c
+++ b/src/bin/ephoto_ipc.c
@@ -18,42 +18,20 @@ int
 e_ipc_init(void)
 {
char buf[4096], buf3[4096];
-   const char *tmp, *user, *base;
+   const char *tmp, *user, *base = NULL;
int pid, trynum = 0, id1 = 0;
 
tmp = eina_environment_tmp_get();
-   if (!tmp) tmp = "/tmp";
-   base = tmp;
-
-   tmp = 

Re: [E-devel] edevelop.slack.com experiment

[Thanatermesis]

>
> Since we often need to remember people of stuff:
>  /remind [@person or #channel] [what] [when]
>  /remind me to drink water at 3pm every day
>  /remind me on June 1st to wish Linda happy birthday


If you want, I have a customized (with -just- the basic stuff) a bot that I
personally use based in cinch, I used it since more than one year now and
is perfectly stable and light, there's the list of these few features, you
can include more or disable any of them  https://github.com/Elive/keyra-bot



2017-03-29 2:59 GMT-06:00 Conrad Um :

> What about this one?
> https://about.mattermost.com/
>
> Mattermost is an open source project for slack-alternative and it's MIT
> licensed. Samsung adopted its enterprise edition.
>
> I don't know well about what features are supported compared to slack, but
> its first impression is similar.
>
> On Mar 23, 2017 3:05 PM, "Vincent Torri"  wrote:
>
> > On Thu, Mar 23, 2017 at 1:14 AM, Carsten Haitzler 
> > wrote:
> > > On Wed, 22 Mar 2017 15:18:27 + Tom Hacohen  said:
> > >
> > >> Heya,
> > >>
> > >> I personally think it's a bad idea to rely on a proprietary tool for
> > >> open source development, and from what I remember, I'm not the only
> > >> one.
> > >> This is partially why we self host git and not use Github et al.
> > >>
> > >> Long live IRC.
> > >>
> > >> https://xkcd.com/1782/
> > >
> > > there are things slack does that irc doesn't - like work well with
> > mobiles...
> > > but it does have downsides. like invite-only, closed, ...
> > >
> > > ultimately we should solve this ourselves:
> > >
> > > let's consider building a great IRC client (like express - work on it),
> > and
> > > EXTEND irc.
> >
> > I agree on this. Extend Express like Terminology extends what a
> > terminal usually does.
> >
> > Vincent
> >
> > > yes. let's do what MIRC did. but let's do it a little less
> > > annoyingly. we'd need to build some server infra to be able to upload
> > data to
> > > (images, videos, audio, text etc.) and much like imgur./pastebin (our
> own
> > > screenshot thing for e  and visible on http://www.enlightenment.org/ss
> > ) ...
> > > allow a client to upload some displayable/sharable media and then just
> > stuff a
> > > link into the channel. if you look at slack's irc gateway when you use
> a
> > giphy
> > > image all it does is spew out:
> > >
> > >  giphy: http://gipy.com/8267fv78s6238dx
> > >
> > > all you need is for an irc client to handle such things implicitly and
> > convert
> > > such lines into an image box (and then download the image in the
> > background and
> > > inline it once done)...
> > >
> > > this would be a major start to modernizing irc. whatever - we can argue
> > about
> > > what should be done by default (download blurred out thumbnail and only
> > > download full sized image when clicked on - or just replace with a
> > "download
> > > me" button... let's not get into that). the point is that using other
> > > messengers (slack, telegram, hangouts, whatsapp) people can do this and
> > it
> > > looks nice and is convenient. yes people can abuse it yet such apps
> grow
> > in
> > > popularity. so use an ancient irc client where you dont see this if you
> > hate
> > > it (just a text url), or we can have options... but don't let this be a
> > reason
> > > to NOT extend and improve.
> > >
> > > given a good irc client with such extensions we can get all of the
> > benefits of
> > > something like slack BUT stick to open IRC servers and channels without
> > > fragmenting community.
> > >
> > > then there is the other problem. mobile. ultimately someone will need a
> > mobile
> > > friendly server with proper remote (delayed) wakeups that don't require
> > the
> > > phone to maintain wake locks... and then mobile clients. technically
> > express
> > > could be recycled for tizen... and perhaps android if efl got good
> > android
> > > support. similar story for ios... :)
> > >
> > >> --
> > >> Tom
> > >>
> > >> On Tue, Mar 21, 2017 at 2:52 PM, Gustavo Sverzut Barbieri
> > >>  wrote:
> > >> > Hi all,
> > >> >
> > >> > I'm doing an experiment with slack.com as IRC alternative. I'm no
> > >> > expert in slack, first time I ever used, if you have more experience
> > >> > let me know so I can add you as admin.
> > >> >
> > >> > The biggest annoyance at the time is sign up that requires an
> > >> > invitation, I sent to some in this list, others can do based on
> > >> > domains such as @samsung.com, @osg.samsung.com and so on... but
> they
> > >> > do not allow comcast.net or gmail.com to auto-join.
> > >> >
> > >> > So if you want to join, let me know your email and I'll send the
> > invitation.
> > >> >
> > >> > I've added some interesting plugins as people were demanding
> > >> > voice/video calls at some point, these 2 can be better than simply
> > >> > keeping a google Hangouts open all the time (and night!):
> > >> >
> > >> >  /appear 

[EGIT] [website/www-content] master 01/01: Wiki page about-ephoto changed with summary [] by Stephen M Houston

[Stephen M Houston]

WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=08744ffa58c3662e91846535037011001ba03530

commit 08744ffa58c3662e91846535037011001ba03530
Author: Stephen M Houston 
Date:   Wed Mar 29 12:28:18 2017 -0700

Wiki page about-ephoto changed with summary [] by Stephen M Houston
---
 pages/about-ephoto.txt | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/pages/about-ephoto.txt b/pages/about-ephoto.txt
index 432555c..9251515 100644
--- a/pages/about-ephoto.txt
+++ b/pages/about-ephoto.txt
@@ -10,10 +10,11 @@ Ephoto is an image viewer and editor written using the 
Enlightenment Foundation
 
 
 === Screenshots ===
+{{:ephoto_thumb_view.jpg?400|}}
 
-{{:shot-ephoto.jpg?320}}
-{{:ephoto2.jpg?320}}
-{{:ephoto3.jpg?320}}
+{{:ephoto_single_view.jpg?400|}}
+
+{{:ephoto_slideshow.jpg?400|}}
 
 
 

-- 

[EGIT] [website/www-content] master 01/01: Wiki media ephoto_single_view.jpg uploaded by Stephen M Houston

[Stephen M Houston]

WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=0c2313a24219a8b4de3769359ec384c00a56b23e

commit 0c2313a24219a8b4de3769359ec384c00a56b23e
Author: Stephen M Houston 
Date:   Wed Mar 29 12:25:53 2017 -0700

Wiki media ephoto_single_view.jpg uploaded by Stephen M Houston
---
 media/ephoto_single_view.jpg | Bin 0 -> 242233 bytes
 media/ephoto_thumb_view.jpg  | Bin 0 -> 176220 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/media/ephoto_single_view.jpg b/media/ephoto_single_view.jpg
new file mode 100644
index 000..de39d74
Binary files /dev/null and b/media/ephoto_single_view.jpg differ
diff --git a/media/ephoto_thumb_view.jpg b/media/ephoto_thumb_view.jpg
new file mode 100644
index 000..8bd2c02
Binary files /dev/null and b/media/ephoto_thumb_view.jpg differ

-- 

[EGIT] [website/www-content] master 01/01: Wiki page ephoto-1-beta3-released changed with summary [created] by Stephen M Houston

[Stephen M Houston]

WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=ad28d7bf05ca8cc19958176954d652af24b7a2f4

commit ad28d7bf05ca8cc19958176954d652af24b7a2f4
Author: Stephen M Houston 
Date:   Wed Mar 29 12:03:37 2017 -0700

Wiki page ephoto-1-beta3-released changed with summary [created] by Stephen 
M Houston
---
 pages/news/ephoto-1-beta3-released.txt | 279 +
 1 file changed, 279 insertions(+)

diff --git a/pages/news/ephoto-1-beta3-released.txt 
b/pages/news/ephoto-1-beta3-released.txt
new file mode 100644
index 000..247b311
--- /dev/null
+++ b/pages/news/ephoto-1-beta3-released.txt
@@ -0,0 +1,279 @@
+=== Ephoto 1.0 Beta3 ===
+  * //2017-03-29 - by Stephen M Houston//
+
+Ephoto 1.0 Beta3 is now available for download. This comes several months 
after beta2.  There was overwhelming support and requests following the second 
beta.  The largest part of this feedback was that the transparent overlapping 
panels that auto-hid would be better served as normal style panels that didn’t 
overlap.  This was a fairly large change and thus with the pending release of 
EFL 1.19, a third and final beta was ultimately the best way to proceed.  This 
will be the final beta an [...]
+
+Please test this release and reporting any bugs or feedback to 
http://phab.enlightenment.org.
+
+You can find the tarballs here:
+
+http://www.smhouston.us/stuff/ephoto-1.0-beta3.tar.gz
+
+http://www.smhouston.us/stuff/ephoto-1.0-beta3.tar.xz
+
+Ephoto is a comprehensive image/photo viewer written in C and using the 
Enlightened Foundation Libraries.  The application supports file system 
browsing for photos and images, enhancement and editing features, and moving 
slideshows.
+
+Interested in learning more about Ephoto?
+Please visit the Ephoto page at http://www.smhouston.us/ephoto/ as well as
+http://phab.enlightenment.org/w/projects/ephoto/
+
+Thank you for your support over the years and happy testing!!
+
+**Stephen Houston**
+
+Ephoto 1.0 Beta 3:
+Highlights:
+   * Removed overlapping/autohiding panels
+   * Improved Settings Panel
+   * Windows Support
+   * Improved stability
+   * Many More Fixes
+Fixes:
+   * commit 751e08acc77eb6708454228dedc634cafe887df5
+Author: Vincent 'vtorri' Torri 
+Date:   Wed Mar 29 13:31:58 2017 -0500
+ 
+Ephoto: Make Ephoto compile/work on Windows.
+ 
+   * commit afa1529be3e5cfd2acdd8167b96acb3c235edca7
+Author: Stephen 'Okra' Houston 
+Date:   Wed Mar 29 13:21:43 2017 -0500
+ 
+Ephoto: Make sure the search box expands so its visible.
+ 
+   * commit f9b35bfd45c611ef0af59638c92c5f7987a281ce
+Author: Stephen 'Okra' Houston 
+Date:   Wed Mar 29 13:18:22 2017 -0500
+ 
+Ephoto: Hide controls on edit, fix a bug with undo+redo, improve settings 
popup.
+ 
+   * commit f207845f103f887f93ce97663f4dcc4002889494
+Author: Stephen 'Okra' Houston 
+Date:   Wed Mar 29 09:56:00 2017 -0500
+ 
+Ephoto: Use a table+show/hide commands rather than naviframe to avoid 
event conflicts.
+ 
+   * commit 0effa4ea023f55db2c2925ab060b5b7ff595d414
+Author: Stephen 'Okra' Houston 
+Date:   Tue Mar 28 16:14:14 2017 -0500
+ 
+Ephoto: Close the edit panel if going back to thumb view.
+ 
+   * commit 2639e5b1ad2078d22d60f94cd2c1b140502fc800
+Author: Stephen 'Okra' Houston 
+Date:   Tue Mar 28 12:09:18 2017 -0500
+ 
+Ephoto: In preparation for release, remove the overlapping autohide panels 
per overwhelming user requests.
+ 
+   * commit 5cbf023d1db850b9a28410e886ba1ba1403d3553
+Author: Stephen 'Okra' Houston 
+Date:   Fri Feb 10 14:12:43 2017 -0600
+ 
+Ephoto - Cleanup ecore_file_realpath usage.
+ 
+   * commit 5129f92d3adfe665948626826671cf9c9b174f43
+Author: Stephen 'Okra' Houston 
+Date:   Mon Dec 12 12:26:02 2016 -0600
+ 
+Ephoto: Add quick access rotate buttons.
+ 
+   * commit 1aa4e97d4d2e47bdab1c094e4a59c09f06e71da4
+Author: Stephen okra Houston 
+Date:   Fri Dec 9 10:16:40 2016 -0600
+ 
+Ephoto: Only show the exit button when the window is fullscreen.
+ 
+   * commit bce27ed4d42b227aacac4aa7d0e4783dbadb4f83
+Author: Bruno Dilly 
+Date:   Mon Dec 5 20:56:51 2016 -0200
+ 
+Update gitignore
+ 
+   * commit a0e367be4f7268d8a97107d4371d35d1350a9c72
+Author: Boris Faure 
+Date:   Mon Nov 28 21:32:09 2016 +0100
+ 
+ephoto_file: fix string not null-terminated. CID151522
+ 
+   * commit a0a389abb01d7faad78398eaeff9d7064e9b4e86
+Author: Boris Faure 
+Date:   Mon Nov 28 21:28:33 2016 +0100
+ 
+ephoto_file: fix resource leak. CID156953
+ 
+   * commit 38c246b000641b690712fcb8b8341e5488ad86d0
+Author: Stephen okra Houston 
+Date:   Mon Nov 28 12:03:35 2016 -0600
+ 
+Ephoto: Fix 

[EGIT] [website/www-content] master 01/01: Wiki page about-ephoto changed with summary [] by Stephen M Houston

[Stephen M Houston]

WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=880c2ac06fe441173f147d17af4a4c9fd71a1d4e

commit 880c2ac06fe441173f147d17af4a4c9fd71a1d4e
Author: Stephen M Houston 
Date:   Wed Mar 29 11:51:47 2017 -0700

Wiki page about-ephoto changed with summary [] by Stephen M Houston
---
 pages/about-ephoto.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pages/about-ephoto.txt b/pages/about-ephoto.txt
index 41b1d17..432555c 100644
--- a/pages/about-ephoto.txt
+++ b/pages/about-ephoto.txt
@@ -1,7 +1,7 @@
 ~~Title: About Ephoto~~
  Ephoto - A Comprehensive Image Viewer Using the EFL 
 
-[[http://www.smhouston.us/ephoto/|Download Ephoto 1.0 Beta 2]]
+[[http://www.smhouston.us/ephoto/|Download Ephoto 1.0 Beta 3]]
 
 {{:ephoto.png?nolink |}}
 

-- 

[EGIT] [apps/ephoto] master 01/01: Ephoto: Make Ephoto compile/work on Windows.

[Vincent 'vtorri' Torri]

okra pushed a commit to branch master.

http://git.enlightenment.org/apps/ephoto.git/commit/?id=751e08acc77eb6708454228dedc634cafe887df5

commit 751e08acc77eb6708454228dedc634cafe887df5
Author: Vincent 'vtorri' Torri 
Date:   Wed Mar 29 13:31:58 2017 -0500

Ephoto: Make Ephoto compile/work on Windows.
---
 configure.ac  | 23 ++-
 src/bin/ephoto_file.c |  4 
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/configure.ac b/configure.ac
index 13c3707..cd786f3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@ dnl Process this file with autoconf to produce a configure 
script.
 # get rid of that stupid cache mechanism
 rm -f config.cache
 
-AC_INIT([ephoto], [1.0-beta2], [enlightenment-devel@lists.sourceforge.net])
+AC_INIT([ephoto], [1.0-beta3], [enlightenment-devel@lists.sourceforge.net])
 
 AC_PREREQ([2.60])
 AC_CONFIG_SRCDIR([configure.ac])
@@ -53,18 +53,15 @@ fi
 
 AM_CONDITIONAL([HAVE_PO], [test "x${have_po}" = "xyes"])
 
-PKG_CHECK_MODULES([EFL], [
- eina >= 1.18.0
- evas >= 1.18.0
- ecore >= 1.18.0
- ecore-file >= 1.18.0
- ecore-ipc >= 1.18.0
- edje >= 1.18.0
- eo >= 1.18.0
- eio >= 1.18.0
- elementary >= 1.18.0
- efreet-mime >= 1.18.0
-])
+requirements="eina >= 1.18.0 evas >= 1.18.0 ecore >= 1.18.0 ecore-file >=
+1.18.0 ecore-ipc >= 1.18.0 edje >= 1.18.0 eo >= 1.18.0 eio >= 1.18.0
+elementary >= 1.18.0 efreet-mime >= 1.18.0"
+
+if test "x${have_win32}" = "xyes" ; then
+ requirements="${requirements} evil"
+fi
+
+PKG_CHECK_MODULES([EFL], [${requirements}])
 
 AC_CHECK_FUNCS([nice])
 
diff --git a/src/bin/ephoto_file.c b/src/bin/ephoto_file.c
index c273ce2..a9938a3 100644
--- a/src/bin/ephoto_file.c
+++ b/src/bin/ephoto_file.c
@@ -744,7 +744,11 @@ _delete_thread_cb(void *data, Ecore_Thread *et EINA_UNUSED)
 int ret;
  struct stat s;
 
+#ifdef _WIN32
+ if (stat(file, ))
+#else
  if (lstat(file, ))
+#endif
{
   if (S_ISLNK(s.st_mode))
 {

-- 

[EGIT] [apps/ephoto] master 01/01: Ephoto: Make sure the search box expands so its visible.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/apps/ephoto.git/commit/?id=afa1529be3e5cfd2acdd8167b96acb3c235edca7

commit afa1529be3e5cfd2acdd8167b96acb3c235edca7
Author: Stephen 'Okra' Houston 
Date:   Wed Mar 29 13:21:43 2017 -0500

Ephoto: Make sure the search box expands so its visible.
---
 src/bin/ephoto_thumb_browser.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/bin/ephoto_thumb_browser.c b/src/bin/ephoto_thumb_browser.c
index f5e58a3..9128763 100644
--- a/src/bin/ephoto_thumb_browser.c
+++ b/src/bin/ephoto_thumb_browser.c
@@ -1349,8 +1349,8 @@ _ephoto_thumb_search_start(void *data, Evas_Object *obj 
EINA_UNUSED,
elm_object_part_text_set(search, "guide", _("Search"));
elm_scroller_policy_set(search, ELM_SCROLLER_POLICY_OFF,
ELM_SCROLLER_POLICY_OFF);
-   EPHOTO_WEIGHT(hbox, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
-   EPHOTO_FILL(hbox);
+   EPHOTO_WEIGHT(search, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
+   EPHOTO_FILL(search);
evas_object_data_set(search, "thumb_browser", tb);
evas_object_data_set(search, "parent", hbox);
evas_object_smart_callback_add(search, "activated",

-- 

[EGIT] [apps/ephoto] master 01/01: Ephoto: Hide controls on edit, fix a bug with undo+redo, improve settings popup.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/apps/ephoto.git/commit/?id=f9b35bfd45c611ef0af59638c92c5f7987a281ce

commit f9b35bfd45c611ef0af59638c92c5f7987a281ce
Author: Stephen 'Okra' Houston 
Date:   Wed Mar 29 13:18:22 2017 -0500

Ephoto: Hide controls on edit, fix a bug with undo+redo, improve settings 
popup.
---
 src/bin/ephoto_bcg.c   |  6 +++---
 src/bin/ephoto_color.c |  6 +++---
 src/bin/ephoto_config.c| 21 ++---
 src/bin/ephoto_cropper.c   |  4 ++--
 src/bin/ephoto_directory_browser.c |  2 +-
 src/bin/ephoto_editor.c|  6 +++---
 src/bin/ephoto_file.c  | 16 
 src/bin/ephoto_filters.c   |  6 +++---
 src/bin/ephoto_hsv.c   |  6 +++---
 src/bin/ephoto_main.c  | 12 +++-
 src/bin/ephoto_red_eye.c   |  4 ++--
 src/bin/ephoto_scale.c |  6 +++---
 src/bin/ephoto_single_browser.c| 26 ++
 src/bin/ephoto_slideshow.c | 10 +++---
 src/bin/ephoto_thumb_browser.c |  8 
 15 files changed, 81 insertions(+), 58 deletions(-)

diff --git a/src/bin/ephoto_bcg.c b/src/bin/ephoto_bcg.c
index 7d8cee4..77714bd 100644
--- a/src/bin/ephoto_bcg.c
+++ b/src/bin/ephoto_bcg.c
@@ -363,7 +363,7 @@ ephoto_bcg_add(Ephoto *ephoto, Evas_Object *main, 
Evas_Object *parent, Evas_Obje
elm_slider_value_set(slider, 1);
elm_slider_unit_format_set(slider, "%1.2f");
elm_slider_indicator_format_set(slider, "%1.2f");
-   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, 0.0);
+   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
EPHOTO_ALIGN(slider, EVAS_HINT_FILL, 0.5);
evas_object_smart_callback_add(slider, "delay,changed",
_gamma_slider_changed, ebcg);
@@ -378,7 +378,7 @@ ephoto_bcg_add(Ephoto *ephoto, Evas_Object *main, 
Evas_Object *parent, Evas_Obje
elm_slider_value_set(slider, 0);
elm_slider_unit_format_set(slider, "%1.0f");
elm_slider_indicator_format_set(slider, "%1.0f");
-   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, 0.0);
+   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
EPHOTO_ALIGN(slider, EVAS_HINT_FILL, 0.5);
evas_object_smart_callback_add(slider, "delay,changed",
_contrast_slider_changed, ebcg);
@@ -393,7 +393,7 @@ ephoto_bcg_add(Ephoto *ephoto, Evas_Object *main, 
Evas_Object *parent, Evas_Obje
elm_slider_value_set(slider, 0);
elm_slider_unit_format_set(slider, "%1.0f");
elm_slider_indicator_format_set(slider, "%1.0f");
-   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, 0.0);
+   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
EPHOTO_ALIGN(slider, EVAS_HINT_FILL, 0.5);
evas_object_smart_callback_add(slider, "delay,changed",
_brightness_slider_changed, ebcg);
diff --git a/src/bin/ephoto_color.c b/src/bin/ephoto_color.c
index fa0c748..5d81f52 100644
--- a/src/bin/ephoto_color.c
+++ b/src/bin/ephoto_color.c
@@ -348,7 +348,7 @@ ephoto_color_add(Ephoto *ephoto, Evas_Object *main, 
Evas_Object *parent, Evas_Ob
elm_slider_value_set(slider, 0);
elm_slider_unit_format_set(slider, "%1.0f");
elm_slider_indicator_format_set(slider, "%1.0f");
-   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, 0.0);
+   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
EPHOTO_ALIGN(slider, EVAS_HINT_FILL, 0.5);
evas_object_smart_callback_add(slider, "delay,changed",
_blue_slider_changed, eco);
@@ -363,7 +363,7 @@ ephoto_color_add(Ephoto *ephoto, Evas_Object *main, 
Evas_Object *parent, Evas_Ob
elm_slider_value_set(slider, 0);
elm_slider_unit_format_set(slider, "%1.0f");
elm_slider_indicator_format_set(slider, "%1.0f");
-   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, 0.0);
+   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
EPHOTO_ALIGN(slider, EVAS_HINT_FILL, 0.5);
evas_object_smart_callback_add(slider, "delay,changed",
_green_slider_changed, eco);
@@ -378,7 +378,7 @@ ephoto_color_add(Ephoto *ephoto, Evas_Object *main, 
Evas_Object *parent, Evas_Ob
elm_slider_value_set(slider, 0);
elm_slider_unit_format_set(slider, "%1.0f");
elm_slider_indicator_format_set(slider, "%1.0f");
-   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, 0.0);
+   EPHOTO_WEIGHT(slider, EVAS_HINT_EXPAND, EVAS_HINT_FILL);
EPHOTO_ALIGN(slider, EVAS_HINT_FILL, 0.5);
evas_object_smart_callback_add(slider, "delay,changed",
_red_slider_changed, eco);
diff --git a/src/bin/ephoto_config.c b/src/bin/ephoto_config.c
index 58ad9e1..3ebcb3a 100644
--- a/src/bin/ephoto_config.c
+++ b/src/bin/ephoto_config.c
@@ -80,7 +80,7 @@ _config_general(Ephoto *ephoto, Evas_Object *parent)
 
check = elm_check_add(table);
elm_object_text_set(check, _("Show Folders On Start"));
-   EPHOTO_ALIGN(check, 0.0, 0.5); 
+   EPHOTO_ALIGN(check, EVAS_HINT_FILL, 0.5); 
elm_check_state_set(check, ephoto->config->folders);
elm_table_pack(table, check, 0, 0, 1, 1);

[EGIT] [core/efl] master 10/10: evil_string: fix strndup() for non-NULL terminated strings.

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=13cd93f729bd2be8b5ab84d4a1706c365acc7cb3

commit 13cd93f729bd2be8b5ab84d4a1706c365acc7cb3
Author: Gustavo Sverzut Barbieri 
Date:   Wed Mar 29 10:11:01 2017 -0300

evil_string: fix strndup() for non-NULL terminated strings.

If the given string is not null-terminated, then strlen() will go out
of boundaries, we must limit the lookup to given 'n' parameter.

To do so use strnlen(), that is a strlen() bounded by a maximum size.
---
 src/lib/evil/evil_string.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lib/evil/evil_string.c b/src/lib/evil/evil_string.c
index 634565b..4534b72 100644
--- a/src/lib/evil/evil_string.c
+++ b/src/lib/evil/evil_string.c
@@ -18,10 +18,9 @@
 char *
 strndup(const char *str, size_t n)
 {
-   size_t slen = strlen(str);
+   size_t slen = strnlen(str, n);
char *ret;
 
-   if (slen > n) slen = n;
ret = malloc (slen + 1);
if (!ret) return NULL;
 

-- 

Re: [E-devel] ecore_con branch : simple tests on Windows

[Gustavo Sverzut Barbieri]

On Wed, Mar 29, 2017 at 11:21 AM, Gustavo Sverzut Barbieri
 wrote:
> Hi Vincent,
>
> thanks for your testing, it sems everything is right

ok, then merged as agreed on IRC.


> except TCP:
>
>> 2) ecore_con_server|client_simple_example : error message(s) as soon as
>> the programs are launched :
>>
>> $ ./ecore_con_server_simple_example.exe
>> ERR:ecore_con lib/ecore_con/ecore_con.c:593 efl_net_socket4() fcntl(344,
>> F_SETFD, FD_CLOEXEC): Bad file descriptor
>> ERR:ecore_con lib/ecore_con/efl_net_server_tcp.c:74
>> _efl_net_server_tcp_resolved_bind() socket(2, 1, 6): (null)
>>
>> $ ./ecore_con_client_simple_example.exe 127.0.0.1 8080
>> ERR:ecore_con lib/ecore_con/ecore_con.c:593 efl_net_socket4()
>> fcntl(388, F_SETFD, FD_CLOEXEC): Bad file descriptor
>
> as talked in IRC, efl-net is checking for FD_CLOEXEC being defined, if
> so, then use it in fcntl. Both fcntl() and FD_CLOEXEC are being
> defined by evil_fcntl.h, so we have 2 options:
>
>  - change evil_fcntl.h to not define the symbol
>  - change evil_fcntl.c to implement it so it's usable with sockets
>
> In my branch I added commits to handle the FD_CLOEXEC not being
> defined (it was triggering some compile warnings).

we still need to decide what to do here, the easiest solution is to
not #define FD_CLOEXEC... Windows defaults to children not inheriting
its handles, so it won't be an issue except when we want to leak
stuff to children, as some FD to be processed by a worker/slave
process, not that common except stdin/out/err, which is manually
handled by ecore_exe.


-- 
Gustavo Sverzut Barbieri
--
Mobile: +55 (16) 99354-9890

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 07/10: others: support efl_net_dialer_windows.

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a93c2740f21c956ca24c393cb0585d9b59355cab

commit a93c2740f21c956ca24c393cb0585d9b59355cab
Author: Gustavo Sverzut Barbieri 
Date:   Mon Mar 27 16:11:29 2017 -0300

others: support efl_net_dialer_windows.

these are not working on windows yet due other factors, anyway add the
proper ifdefs
---
 src/bin/eeze/eeze_scanner_monitor/eeze_scanner_monitor.c | 5 -
 src/bin/efl/efl_debug.c  | 5 -
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/bin/eeze/eeze_scanner_monitor/eeze_scanner_monitor.c 
b/src/bin/eeze/eeze_scanner_monitor/eeze_scanner_monitor.c
index b6b8e14..c5a6a05 100644
--- a/src/bin/eeze/eeze_scanner_monitor/eeze_scanner_monitor.c
+++ b/src/bin/eeze/eeze_scanner_monitor/eeze_scanner_monitor.c
@@ -156,8 +156,11 @@ main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
 #ifdef EFL_NET_DIALER_UNIX_CLASS
dialer = efl_add(EFL_NET_DIALER_SIMPLE_CLASS, loop,
 efl_net_dialer_simple_inner_class_set(efl_added, 
EFL_NET_DIALER_UNIX_CLASS));
+#elif defined(EFL_NET_DIALER_WINDOWS_CLASS)
+   dialer = efl_add(EFL_NET_DIALER_SIMPLE_CLASS, loop,
+efl_net_dialer_simple_inner_class_set(efl_added, 
EFL_NET_DIALER_WINDOWS_CLASS));
 #else
-   fprintf(stderr, "ERROR: your platform doesn't support 
Efl.Net.Dialer.Unix\n");
+   fprintf(stderr, "ERROR: your platform doesn't support Efl.Net.Dialer.*\n");
 #endif
if (!dialer)
  {
diff --git a/src/bin/efl/efl_debug.c b/src/bin/efl/efl_debug.c
index 428180e..28cdb39 100644
--- a/src/bin/efl/efl_debug.c
+++ b/src/bin/efl/efl_debug.c
@@ -155,11 +155,14 @@ main(int argc, char **argv)
 #ifdef EFL_NET_DIALER_UNIX_CLASS
dialer = efl_add(EFL_NET_DIALER_SIMPLE_CLASS, loop,
 efl_net_dialer_simple_inner_class_set(efl_added, 
EFL_NET_DIALER_UNIX_CLASS));
+#elif defined(EFL_NET_DIALER_WINDOWS_CLASS)
+   dialer = efl_add(EFL_NET_DIALER_SIMPLE_CLASS, loop,
+efl_net_dialer_simple_inner_class_set(efl_added, 
EFL_NET_DIALER_WINDOWS_CLASS));
 #else
/* TODO: maybe start a TCP using locahost:12345?
 * Right now eina_debug_monitor is only for AF_UNIX, so not an issue.
 */
-   fprintf(stderr, "ERROR: your platform doesn't support 
Efl.Net.Dialer.Unix\n");
+   fprintf(stderr, "ERROR: your platform doesn't support Efl.Net.Dialer.*\n");
 #endif
if (!dialer)
  {

-- 

[EGIT] [core/efl] master 04/10: implement efl_net_{socket, dialer, server}_windows

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=fa0e2865a1a53cd05298b8368fa9abdb7c83bff8

commit fa0e2865a1a53cd05298b8368fa9abdb7c83bff8
Author: Gustavo Sverzut Barbieri 
Date:   Wed Mar 22 04:29:16 2017 -0300

implement efl_net_{socket,dialer,server}_windows

This is the local socket for windows, analogous to AF_UNIX.

`Efl_Net_Socket_Windows` is the base class doing `ReadFile()` and
`WriteFile()` using overlapped I/O, as well as the close procedure
(`FlushFileBuffers()`, `DisconnectNamedPipe()` and
`CloseHandle()`). These are done on top of an existing HANDLE that is
set by `Efl_Net_Dialer_Windows` (from `CreateFile()`) or
`Efl_Net_Server_Windows` (from `CreateNamedPipe()`).

The overlapped I/O will return immediately, either with operation
completed or `ERROR_IO_PENDING`, which means the kernel will execute
that asynchronously and will later `SetEvent(overlapped.hEvent)` which
is an event we wait on our main loop. That `overlapped` handle must
exist during the call lifetime, thus cannot be bound to `pd`, as we
may call `CancelIo()` but there is no guarantee the memory won't be
touched, in that case we keep the overlapped around, but without an
associated object.

Windows provides no notification "can read without blocking" or
non-blocking calls that returns partial data. The way to go is to use
these overlapped I/O, with an initial `ReadFile()` to an internal
buffer, once that operation finishes, we callback the user to says
there is something to read (`efl_io_reader_can_read_set()`) and wait
until `efl_io_reader_read()` is called to consume the available data,
then `ReadFile()` is called again to read more data to the same
internal buffer.

Likewise, there is no "can write without blocking" or non-blocking
calls that sends only partial data. The way to go is to get user bytes
in `efl_io_writer_write()` and copy them in an internal buffer, then
call `WriteFile()` on that and inform the user nothing else can be
written until that operation completes
(`efl_io_writer_can_write_set()`).

This is cumbersome since we say we "sent" stuff when we actually
didn't, it's still in our internal buffer (`pd->send.bytes`), but
nonetheless the kernel and the other peer may be adding even more
buffers, in this case we need to do a best effort to get it
delivery. A particular case is troublesome: `write() -> close()`, this
may result in `WriteFile()` pending, in this case we wait using
`GetOverlappedResult()`, *this is nasty and may block*, but it's the
only way I see to cope with such common use case.

Other operations, like ongoing `ReadFile()` or `ConnectNamedPipe()`
will be canceled using `CancelIo()`.

Q: Why no I/O Completion Port (IOCP) was used? Why no
   CreateThreadpoolIo()? These perform much better!

A: These will call back from secondary threads, but in EFL we must
   report back to the user in order to process incoming data or get
   more data to send. That is, we serialize everything to the main
   thread, making it impossible to use the benefits of IOCP and
   similar such as CreateThreadpoolIo(). Since we'd need to wakeup the
   main thread anyways, using `OVERLAPPED.hEvent` with
   `ecore_main_win32_handler_add()` does the job as we expect.

Thanks to Vincent Torri (vtorri) for his help getting this code done
with an example on how to do the NamedPipe handling on Windows.
---
 src/Makefile_Ecore_Con.am  |   9 +-
 src/examples/ecore/Makefile.am |   6 +-
 src/examples/ecore/efl_io_copier_example.c |  72 +-
 src/examples/ecore/efl_net_dialer_simple_example.c |   5 +-
 .../ecore/efl_net_dialer_windows_example.c | 218 +
 src/examples/ecore/efl_net_server_example.c|  12 +-
 src/examples/ecore/efl_net_server_simple_example.c |  12 +-
 src/lib/ecore_con/Ecore_Con_Eo.h   |   3 +
 src/lib/ecore_con/ecore_con_legacy.c   |   8 +
 src/lib/ecore_con/ecore_con_private.h  |  24 +-
 src/lib/ecore_con/efl_net_dialer_windows.c | 164 
 src/lib/ecore_con/efl_net_dialer_windows.eo|  20 +
 src/lib/ecore_con/efl_net_server_windows.c | 508 +++
 src/lib/ecore_con/efl_net_server_windows.eo|  36 +
 src/lib/ecore_con/efl_net_socket_windows.c | 929 +
 src/lib/ecore_con/efl_net_socket_windows.eo|  26 +
 16 files changed, 2038 insertions(+), 14 deletions(-)

diff --git a/src/Makefile_Ecore_Con.am b/src/Makefile_Ecore_Con.am
index b22c3f6..cfae980 100644
--- a/src/Makefile_Ecore_Con.am
+++ b/src/Makefile_Ecore_Con.am
@@ -33,6 +33,10 @@ ecore_con_eolian_files = \
lib/ecore_con/ecore_con_eet_client_obj.eo
 
 if HAVE_WINDOWS

[EGIT] [core/efl] master 06/10: ecore_ipc: use new efl_net_*_windows classes.

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6877ee8ad42bd4510101926a3b1e21fb3096425a

commit 6877ee8ad42bd4510101926a3b1e21fb3096425a
Author: Gustavo Sverzut Barbieri 
Date:   Mon Mar 27 15:54:38 2017 -0300

ecore_ipc: use new efl_net_*_windows classes.
---
 src/lib/ecore_ipc/ecore_ipc.c | 393 --
 src/lib/ecore_ipc/ecore_ipc_private.h |   9 -
 2 files changed, 42 insertions(+), 360 deletions(-)

diff --git a/src/lib/ecore_ipc/ecore_ipc.c b/src/lib/ecore_ipc/ecore_ipc.c
index 8f72ff9..0c08bfc 100644
--- a/src/lib/ecore_ipc/ecore_ipc.c
+++ b/src/lib/ecore_ipc/ecore_ipc.c
@@ -205,14 +205,6 @@ _ecore_ipc_ddlt_int(int in, int prev, int mode)
 }
 
 /* EFL_NET_SERVER_UNIX_CLASS and EFL_NET_DIALER_UNIX_CLASS should be defined 
at the same time, we're only checking for EFL_NET_SERVER_UNIX_CLASS in shared 
blocks */
-#ifndef EFL_NET_SERVER_UNIX_CLASS
-static Eina_Bool _ecore_ipc_event_client_add(void *data, int ev_type, void 
*ev);
-static Eina_Bool _ecore_ipc_event_client_del(void *data, int ev_type, void 
*ev);
-static Eina_Bool _ecore_ipc_event_server_add(void *data, int ev_type, void 
*ev);
-static Eina_Bool _ecore_ipc_event_server_del(void *data, int ev_type, void 
*ev);
-static Eina_Bool _ecore_ipc_event_client_data(void *data, int ev_type, void 
*ev);
-static Eina_Bool _ecore_ipc_event_server_data(void *data, int ev_type, void 
*ev);
-#endif
 
 static void _ecore_ipc_event_client_add_free(void *data, void *ev);
 static void _ecore_ipc_event_client_del_free(void *data, void *ev);
@@ -231,10 +223,6 @@ EAPI int ECORE_IPC_EVENT_SERVER_DATA = 0;
 static int  _ecore_ipc_init_count = 0;
 static Eina_List   *servers = NULL;
 
-#ifndef EFL_NET_SERVER_UNIX_CLASS
-static Ecore_Event_Handler *handler[6];
-#endif
-
 static void
 ecore_ipc_post_event_server_add(Ecore_Ipc_Server *svr)
 {
@@ -318,10 +306,6 @@ ecore_ipc_client_add(Ecore_Ipc_Server *svr)
 EAPI int
 ecore_ipc_init(void)
 {
-#ifndef EFL_NET_SERVER_UNIX_CLASS
-   int i = 0;
-#endif
-
if (++_ecore_ipc_init_count != 1)
  return _ecore_ipc_init_count;
 
@@ -346,30 +330,12 @@ ecore_ipc_init(void)
ECORE_IPC_EVENT_CLIENT_DATA = ecore_event_type_new();
ECORE_IPC_EVENT_SERVER_DATA = ecore_event_type_new();
 
-#ifndef EFL_NET_SERVER_UNIX_CLASS
-   handler[i++] = ecore_event_handler_add(ECORE_CON_EVENT_CLIENT_ADD,
-  _ecore_ipc_event_client_add, NULL);
-   handler[i++] = ecore_event_handler_add(ECORE_CON_EVENT_CLIENT_DEL,
-  _ecore_ipc_event_client_del, NULL);
-   handler[i++] = ecore_event_handler_add(ECORE_CON_EVENT_SERVER_ADD,
-  _ecore_ipc_event_server_add, NULL);
-   handler[i++] = ecore_event_handler_add(ECORE_CON_EVENT_SERVER_DEL,
-  _ecore_ipc_event_server_del, NULL);
-   handler[i++] = ecore_event_handler_add(ECORE_CON_EVENT_CLIENT_DATA,
-  _ecore_ipc_event_client_data, NULL);
-   handler[i] = ecore_event_handler_add(ECORE_CON_EVENT_SERVER_DATA,
-  _ecore_ipc_event_server_data, NULL);
-#endif
return _ecore_ipc_init_count;
 }
 
 EAPI int
 ecore_ipc_shutdown(void)
 {
-#ifndef EFL_NET_SERVER_UNIX_CLASS
-   int i;
-#endif
-
if (--_ecore_ipc_init_count != 0)
  return _ecore_ipc_init_count;
 
@@ -385,11 +351,6 @@ ecore_ipc_shutdown(void)
   ECORE_IPC_EVENT_CLIENT_DATA,
   ECORE_IPC_EVENT_SERVER_DATA);
 
-#ifndef EFL_NET_SERVER_UNIX_CLASS
-   for (i = 0; i < 6; i++)
- ecore_event_handler_del(handler[i]);
-#endif
-
ecore_con_shutdown();
 
/* do not unregister log domain as ecore_ipc_servers may be pending deletion
@@ -416,50 +377,6 @@ static void _ecore_ipc_server_client_add(void *data, const 
Efl_Event *event);
 EFL_CALLBACKS_ARRAY_DEFINE(_ecore_ipc_server_cbs,
{ EFL_NET_SERVER_EVENT_CLIENT_ADD, 
_ecore_ipc_server_client_add });
 
-
-#ifndef EFL_NET_SERVER_UNIX_CLASS
-static Ecore_Ipc_Server *
-ecore_ipc_server_add_legacy(Ecore_Ipc_Type compl_type, const char *name, int 
port, const void *data)
-{
-   Ecore_Ipc_Server *svr;
-   Ecore_Ipc_Type type;
-   Ecore_Con_Type extra = 0;
-
-   if (!name) return NULL;
-
-   svr = calloc(1, sizeof(Ecore_Ipc_Server));
-   if (!svr) return NULL;
-   type = compl_type;
-   type &= ~ECORE_IPC_USE_SSL;
-   if (compl_type & ECORE_IPC_USE_SSL) extra = ECORE_CON_USE_SSL;
-   switch (type)
- {
-  case ECORE_IPC_LOCAL_USER:
-svr->legacy_server = ecore_con_server_add(ECORE_CON_LOCAL_USER | 
extra, name, port, svr);
-break;
-  case ECORE_IPC_LOCAL_SYSTEM:
-svr->legacy_server = ecore_con_server_add(ECORE_CON_LOCAL_SYSTEM | 
extra, name, port, svr);
-break;
-  case ECORE_IPC_REMOTE_SYSTEM:
-

[EGIT] [core/efl] master 08/10: eina: fix compilation warning on _WIN32 due missing strndup()

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=13a8842614a50706d5d6a2bf172e98bd9a032024

commit 13a8842614a50706d5d6a2bf172e98bd9a032024
Author: Gustavo Sverzut Barbieri 
Date:   Tue Mar 28 15:22:14 2017 -0300

eina: fix compilation warning on _WIN32 due missing strndup()

Eina.h will include Evil.h, but those using direct include of internal
headers must include it as well.
---
 src/lib/eina/eina_main.c| 4 
 src/lib/eina/eina_ustrbuf.c | 4 
 src/lib/eina/eina_xattr.c   | 4 
 3 files changed, 12 insertions(+)

diff --git a/src/lib/eina/eina_main.c b/src/lib/eina/eina_main.c
index 9a7237f..3617715 100644
--- a/src/lib/eina/eina_main.c
+++ b/src/lib/eina/eina_main.c
@@ -46,6 +46,10 @@
 #include 
 #endif
 
+#ifdef _WIN32
+#include "Evil.h"
+#endif
+
 #include "eina_lock.h"
 #include "eina_config.h"
 #include "eina_private.h"
diff --git a/src/lib/eina/eina_ustrbuf.c b/src/lib/eina/eina_ustrbuf.c
index 7c1c2db..7a2a5a0 100644
--- a/src/lib/eina/eina_ustrbuf.c
+++ b/src/lib/eina/eina_ustrbuf.c
@@ -2,6 +2,10 @@
 # include "config.h"
 #endif
 
+#ifdef _WIN32
+#include "Evil.h"
+#endif
+
 #include "eina_strbuf_common.h"
 #include "eina_unicode.h"
 #include "eina_ustrbuf.h"
diff --git a/src/lib/eina/eina_xattr.c b/src/lib/eina/eina_xattr.c
index a32ff53..a0170ca 100644
--- a/src/lib/eina/eina_xattr.c
+++ b/src/lib/eina/eina_xattr.c
@@ -32,6 +32,10 @@
 
 #include 
 
+#ifdef _WIN32
+#include "Evil.h"
+#endif
+
 #include "eina_config.h"
 #include "eina_private.h"
 

-- 

[EGIT] [core/efl] master 03/10: ecore_con_*_example: compile on win32.

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=17444557deab4f1ecb62e0fd03a7090a3a4bcbfd

commit 17444557deab4f1ecb62e0fd03a7090a3a4bcbfd
Author: Gustavo Sverzut Barbieri 
Date:   Mon Mar 27 16:08:39 2017 -0300

ecore_con_*_example: compile on win32.

 - win32 doesn't provide getline().
 - _write() exists, use _write_() instead
---
 src/examples/ecore/ecore_con_client_example.c | 18 +++---
 src/examples/ecore/ecore_con_server_example.c |  4 ++--
 2 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/src/examples/ecore/ecore_con_client_example.c 
b/src/examples/ecore/ecore_con_client_example.c
index 879e220..35371ca 100644
--- a/src/examples/ecore/ecore_con_client_example.c
+++ b/src/examples/ecore/ecore_con_client_example.c
@@ -58,8 +58,20 @@ static Eina_Bool
 _on_stdin(void *data EINA_UNUSED, Ecore_Fd_Handler *fdh EINA_UNUSED)
 {
char *line = NULL;
+#ifdef _WIN32
+   char lbuf[4096] = "";
+   ssize_t r;
+   if (fgets(lbuf, sizeof(lbuf), stdin) == NULL)
+ r = -1;
+   else
+ {
+line = strdup(lbuf);
+r = strlen(line);
+ }
+#else
size_t len = 0;
ssize_t r = getline(, , stdin);
+#endif
 
if (r < 0)
  {
@@ -151,13 +163,13 @@ _data(void *data EINA_UNUSED, int type EINA_UNUSED, 
Ecore_Con_Event_Server_Data
   "%.*s\n"
   ">\n",
   ev->size,
-  ev->size, ev->data);
+  ev->size, (const char *)ev->data);
 
return ECORE_CALLBACK_RENEW;
 }
 
 Eina_Bool
-_write(void *data EINA_UNUSED, int type EINA_UNUSED, 
Ecore_Con_Event_Server_Write *ev)
+_write_(void *data EINA_UNUSED, int type EINA_UNUSED, 
Ecore_Con_Event_Server_Write *ev)
 {
printf("Sent %d bytes to server\n", ev->size);
return ECORE_CALLBACK_RENEW;
@@ -323,7 +335,7 @@ main(int argc, char *argv[])
 /* set event handler for receiving server data */
ecore_event_handler_add(ECORE_CON_EVENT_SERVER_DATA, 
(Ecore_Event_Handler_Cb)_data, NULL);
 /* set event handler that notifies of sent data */
-   ecore_event_handler_add(ECORE_CON_EVENT_SERVER_WRITE, 
(Ecore_Event_Handler_Cb)_write, NULL);
+   ecore_event_handler_add(ECORE_CON_EVENT_SERVER_WRITE, 
(Ecore_Event_Handler_Cb)_write_, NULL);
 /* set event handler that notifies of errors */
ecore_event_handler_add(ECORE_CON_EVENT_SERVER_ERROR, 
(Ecore_Event_Handler_Cb)_error, NULL);
 /* set event handler that notifies of upgrades */
diff --git a/src/examples/ecore/ecore_con_server_example.c 
b/src/examples/ecore/ecore_con_server_example.c
index 08aee96..4ccb1a4 100644
--- a/src/examples/ecore/ecore_con_server_example.c
+++ b/src/examples/ecore/ecore_con_server_example.c
@@ -94,7 +94,7 @@ _data(void *data EINA_UNUSED, int type EINA_UNUSED, void 
*event)
 
 
 Eina_Bool
-_write(void *data EINA_UNUSED, int type EINA_UNUSED, void *event)
+_write_(void *data EINA_UNUSED, int type EINA_UNUSED, void *event)
 {
Ecore_Con_Event_Client_Write *ev = event;
printf("Sent %d bytes to client %s\n", ev->size, 
ecore_con_client_ip_get(ev->client));
@@ -290,7 +290,7 @@ main(int argc, char **argv)
 /* set event handler for receiving client data */
ecore_event_handler_add(ECORE_CON_EVENT_CLIENT_DATA, 
(Ecore_Event_Handler_Cb)_data, NULL);
 /* set event handler that notifies of sent data */
-   ecore_event_handler_add(ECORE_CON_EVENT_CLIENT_WRITE, 
(Ecore_Event_Handler_Cb)_write, NULL);
+   ecore_event_handler_add(ECORE_CON_EVENT_CLIENT_WRITE, 
(Ecore_Event_Handler_Cb)_write_, NULL);
 /* set event handler that notifies of errors */
ecore_event_handler_add(ECORE_CON_EVENT_CLIENT_ERROR, 
(Ecore_Event_Handler_Cb)_error, NULL);
 /* set event handler that notifies of upgrades */

-- 

[EGIT] [core/efl] master 02/10: ecore_ipc_client_example: win32 doesn't provide getline().

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=8f6e3265b6c2d66309fec5fe27f1e91ad9568302

commit 8f6e3265b6c2d66309fec5fe27f1e91ad9568302
Author: Gustavo Sverzut Barbieri 
Date:   Mon Mar 27 12:45:30 2017 -0300

ecore_ipc_client_example: win32 doesn't provide getline().
---
 src/examples/ecore/ecore_ipc_client_example.c | 12 
 1 file changed, 12 insertions(+)

diff --git a/src/examples/ecore/ecore_ipc_client_example.c 
b/src/examples/ecore/ecore_ipc_client_example.c
index c3f3708..8951264 100644
--- a/src/examples/ecore/ecore_ipc_client_example.c
+++ b/src/examples/ecore/ecore_ipc_client_example.c
@@ -57,8 +57,20 @@ static Eina_Bool
 _on_stdin(void *data EINA_UNUSED, Ecore_Fd_Handler *fdh EINA_UNUSED)
 {
char *line = NULL;
+#ifdef _WIN32
+   char lbuf[4096] = "";
+   ssize_t r;
+   if (fgets(lbuf, sizeof(lbuf), stdin) == NULL)
+ r = -1;
+   else
+ {
+line = strdup(lbuf);
+r = strlen(line);
+ }
+#else
size_t len = 0;
ssize_t r = getline(, , stdin);
+#endif
 
if (r < 0)
  {

-- 

[EGIT] [core/efl] master 01/10: efl_net_dialer_unix_example: read in loop while "can_read".

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=bfe2988f4d5c9ed5b94022a6003fbc12fe47291a

commit bfe2988f4d5c9ed5b94022a6003fbc12fe47291a
Author: Gustavo Sverzut Barbieri 
Date:   Mon Mar 27 10:53:43 2017 -0300

efl_net_dialer_unix_example: read in loop while "can_read".

While in UNIX we use 'select()/poll()' to query for read fds and this
will eventually callback with "can_read" event, use the loop to match
other implementations where can_read keeps true if not all data was
read.
---
 src/examples/ecore/efl_net_dialer_unix_example.c | 24 +++-
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/src/examples/ecore/efl_net_dialer_unix_example.c 
b/src/examples/ecore/efl_net_dialer_unix_example.c
index 57110ef..e890a3a 100644
--- a/src/examples/ecore/efl_net_dialer_unix_example.c
+++ b/src/examples/ecore/efl_net_dialer_unix_example.c
@@ -33,7 +33,6 @@ static void
 _can_read(void *data EINA_UNUSED, const Efl_Event *event)
 {
char buf[4];
-   Eina_Rw_Slice rw_slice = EINA_SLICE_ARRAY(buf);
Eina_Error err;
Eina_Bool can_read = efl_io_reader_can_read_get(event->object);
 
@@ -45,16 +44,23 @@ _can_read(void *data EINA_UNUSED, const Efl_Event *event)
if (!can_read) return;
if (!do_read) return;
 
-   err = efl_io_reader_read(event->object, _slice);
-   if (err)
+   do
  {
-fprintf(stderr, "ERROR: could not read: %s\n", 
eina_error_msg_get(err));
-retval = EXIT_FAILURE;
-ecore_main_loop_quit();
-return;
+Eina_Rw_Slice rw_slice = EINA_SLICE_ARRAY(buf);
+
+err = efl_io_reader_read(event->object, _slice);
+if (err)
+  {
+ if (err == EAGAIN) return;
+ fprintf(stderr, "ERROR: could not read: %s\n", 
eina_error_msg_get(err));
+ retval = EXIT_FAILURE;
+ ecore_main_loop_quit();
+ return;
+  }
+
+fprintf(stderr, "INFO: read '" EINA_SLICE_STR_FMT "'\n", 
EINA_SLICE_STR_PRINT(rw_slice));
  }
-
-   fprintf(stderr, "INFO: read '" EINA_SLICE_STR_FMT "'\n", 
EINA_SLICE_STR_PRINT(rw_slice));
+   while (efl_io_reader_can_read_get(event->object));
 }
 
 static void

-- 

[EGIT] [core/efl] master 05/10: ecore_con_local_path_new(): implemented for Windows

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a4be1e479c2c329e99d693d4921e1e39c66bc1a5

commit a4be1e479c2c329e99d693d4921e1e39c66bc1a5
Author: Gustavo Sverzut Barbieri 
Date:   Mon Mar 27 15:42:11 2017 -0300

ecore_con_local_path_new(): implemented for Windows
---
 src/lib/ecore_con/ecore_con_local.c | 34 ++
 1 file changed, 34 insertions(+)

diff --git a/src/lib/ecore_con/ecore_con_local.c 
b/src/lib/ecore_con/ecore_con_local.c
index fa909c8..2e83774 100644
--- a/src/lib/ecore_con/ecore_con_local.c
+++ b/src/lib/ecore_con/ecore_con_local.c
@@ -26,6 +26,7 @@
 #include "Ecore_Con.h"
 #include "ecore_con_private.h"
 
+#ifndef _WIN32
 static const char *
 _ecore_con_local_path_get(void)
 {
@@ -39,10 +40,42 @@ _ecore_con_local_path_get(void)
if (!homedir) homedir = (char *)eina_environment_tmp_get();
return homedir;
 }
+#endif
 
 EAPI char *
 ecore_con_local_path_new(Eina_Bool is_system, const char *name, int port)
 {
+#if _WIN32
+   char buf[256 - sizeof(PIPE_NS)] = "";
+
+   /* note: using '!' instead of '|' since at least on wine '|' causes
+* ERROR_INVALID_NAME
+*/
+
+   if (!is_system)
+ {
+TCHAR user[sizeof(buf) - sizeof("ecore!u!n!1")] = "unknown";
+DWORD userlen = sizeof(user);
+if (!GetUserName(user, ))
+  {
+ char *msg = _efl_net_windows_error_msg_get(GetLastError());
+ ERR("GetUserName(%p, %lu): %s", user, userlen, msg);
+ free(msg);
+  }
+if (port < 0)
+  snprintf(buf, sizeof(buf), "ecore!%s!%s", user, name);
+else
+  snprintf(buf, sizeof(buf), "ecore!%s!%s!%d", user, name, port);
+ }
+   else
+ {
+if (port < 0)
+  snprintf(buf, sizeof(buf), "ecore_service!%s", name);
+else
+  snprintf(buf, sizeof(buf), "ecore_service!%s!%d", name, port);
+ }
+   return strdup(buf);
+#else
char buf[4096];
const char *homedir;
 
@@ -99,6 +132,7 @@ ecore_con_local_path_new(Eina_Bool is_system, const char 
*name, int port)
  return strdup(buf);
   }
  }
+#endif
 }
 
 void

-- 

[EGIT] [core/efl] master 09/10: ecore_con: remove warnings if FD_CLOEXEC is undefined.

[Gustavo Sverzut Barbieri]

barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9486225744efdc9a68813f0d34f4e38e04387567

commit 9486225744efdc9a68813f0d34f4e38e04387567
Author: Gustavo Sverzut Barbieri 
Date:   Tue Mar 28 15:25:39 2017 -0300

ecore_con: remove warnings if FD_CLOEXEC is undefined.

currently it's being defined in evil_fcntl.h, but the actual
implementation of fcntl() in evil_fcntl.c is causing problems with
sockets. So one possibility is to remove the ifdef, another is to
change the implementation.
---
 src/lib/ecore_con/ecore_con.c | 3 +++
 src/lib/ecore_con/efl_net_server_fd.c | 8 
 2 files changed, 11 insertions(+)

diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c
index 6ab3276..64ac60f 100644
--- a/src/lib/ecore_con/ecore_con.c
+++ b/src/lib/ecore_con/ecore_con.c
@@ -598,6 +598,9 @@ efl_net_socket4(int domain, int type, int protocol, 
Eina_Bool close_on_exec)
   }
  }
EINA_THREAD_CLEANUP_POP(EINA_FALSE); /* we need fd on success */
+#else
+   DBG("close on exec is not supported on your platform");
+   (void)close_on_exec;
 #endif
 
return fd;
diff --git a/src/lib/ecore_con/efl_net_server_fd.c 
b/src/lib/ecore_con/efl_net_server_fd.c
index deb1962..0c76af2 100644
--- a/src/lib/ecore_con/efl_net_server_fd.c
+++ b/src/lib/ecore_con/efl_net_server_fd.c
@@ -60,6 +60,8 @@ efl_net_accept4(SOCKET fd, struct sockaddr *addr, socklen_t 
*addrlen, Eina_Bool
  return INVALID_SOCKET;
   }
  }
+#else
+   (void)close_on_exec;
 #endif
 
return client;
@@ -295,6 +297,10 @@ _efl_net_server_fd_close_on_exec_set(Eo *o, 
Efl_Net_Server_Fd_Data *pd, Eina_Boo
 pd->close_on_exec = old;
 return EINA_FALSE;
  }
+#else
+   DBG("close on exec is not supported on your platform");
+   (void)close_on_exec;
+   (void)o;
 #endif
 
return EINA_TRUE;
@@ -321,6 +327,8 @@ _efl_net_server_fd_close_on_exec_get(Eo *o, 
Efl_Net_Server_Fd_Data *pd)
  }
 
pd->close_on_exec = !!(flags & FD_CLOEXEC); /* sync */
+#else
+   (void)o;
 #endif
return pd->close_on_exec;
 }

-- 

[EGIT] [apps/ephoto] master 01/01: Ephoto: Use a table+show/hide commands rather than naviframe to avoid event conflicts.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/apps/ephoto.git/commit/?id=f207845f103f887f93ce97663f4dcc4002889494

commit f207845f103f887f93ce97663f4dcc4002889494
Author: Stephen 'Okra' Houston 
Date:   Wed Mar 29 09:56:00 2017 -0500

Ephoto: Use a table+show/hide commands rather than naviframe to avoid event 
conflicts.
---
 src/bin/ephoto.h|  3 ---
 src/bin/ephoto_main.c   | 35 ---
 src/bin/ephoto_single_browser.c |  3 +++
 src/bin/ephoto_slideshow.c  |  3 +++
 src/bin/ephoto_thumb_browser.c  |  3 +++
 5 files changed, 25 insertions(+), 22 deletions(-)

diff --git a/src/bin/ephoto.h b/src/bin/ephoto.h
index 85570b0..37d2aaa 100644
--- a/src/bin/ephoto.h
+++ b/src/bin/ephoto.h
@@ -258,9 +258,6 @@ struct _Ephoto
Evas_Object *dir_browser;
Evas_Object *right_menu;
Evas_Object *file_popup;
-   Elm_Object_Item *tb;
-   Elm_Object_Item *sb;
-   Elm_Object_Item *sl;
 
Eina_Bool folders_toggle;
Eina_List *entries;
diff --git a/src/bin/ephoto_main.c b/src/bin/ephoto_main.c
index 4e924f0..416a732 100644
--- a/src/bin/ephoto_main.c
+++ b/src/bin/ephoto_main.c
@@ -35,7 +35,9 @@ _ephoto_state_set(Ephoto *ephoto, Ephoto_State state)
 static void
 _ephoto_thumb_browser_show(Ephoto *ephoto, Ephoto_Entry *entry)
 {
-   elm_naviframe_item_promote(ephoto->tb);
+   evas_object_hide(ephoto->slideshow);
+   evas_object_hide(ephoto->single_browser);
+   evas_object_show(ephoto->thumb_browser);
elm_object_focus_set(ephoto->thumb_browser, EINA_TRUE);
_ephoto_state_set(ephoto, EPHOTO_STATE_THUMB);
ephoto_title_set(ephoto, ephoto->config->directory);
@@ -79,7 +81,9 @@ _ephoto_single_browser_show(Ephoto *ephoto, Ephoto_Entry 
*entry)
  ephoto->entries);
 
ephoto_single_browser_entry_set(ephoto->single_browser, entry);
-   elm_naviframe_item_simple_promote(ephoto->pager, ephoto->single_browser);
+   evas_object_hide(ephoto->slideshow);
+   evas_object_show(ephoto->single_browser);
+   evas_object_hide(ephoto->thumb_browser);
elm_object_focus_set(ephoto->single_browser, EINA_TRUE);
_ephoto_state_set(ephoto, EPHOTO_STATE_SINGLE);
evas_object_show(ephoto->statusbar);
@@ -103,7 +107,9 @@ _ephoto_slideshow_show(Ephoto *ephoto, Ephoto_Entry *entry)
else
  ephoto_slideshow_entries_set(ephoto->slideshow, ephoto->entries);
ephoto_slideshow_entry_set(ephoto->slideshow, entry);
-   elm_naviframe_item_simple_promote(ephoto->pager, ephoto->slideshow);
+   evas_object_show(ephoto->slideshow);
+   evas_object_hide(ephoto->single_browser);
+   evas_object_hide(ephoto->thumb_browser);
elm_object_focus_set(ephoto->slideshow, EINA_TRUE);
_ephoto_state_set(ephoto, EPHOTO_STATE_SLIDESHOW);
elm_layout_signal_emit(ephoto->layout, "ephoto,folders,hide", "ephoto");
@@ -389,8 +395,7 @@ ephoto_window_add(const char *path)
elm_table_pack(ephoto->main, ephoto->layout, 0, 1, 1, 2);
evas_object_show(ephoto->layout);
 
-   ephoto->pager = elm_naviframe_add(ephoto->layout);
-   elm_naviframe_prev_btn_auto_pushed_set(ephoto->pager, EINA_FALSE);
+   ephoto->pager = elm_table_add(ephoto->layout);
EPHOTO_EXPAND(ephoto->pager);
EPHOTO_FILL(ephoto->pager);
elm_layout_content_set(ephoto->layout, "ephoto.swallow.main", 
ephoto->pager);
@@ -402,10 +407,7 @@ ephoto_window_add(const char *path)
evas_object_del(ephoto->win);
return NULL;
  }
-   ephoto->tb =
-   elm_naviframe_item_push(ephoto->pager, NULL, NULL, NULL,
-   ephoto->thumb_browser, "overlap");
-   elm_naviframe_item_title_enabled_set(ephoto->tb, EINA_FALSE, EINA_FALSE);
+   elm_table_pack(ephoto->pager, ephoto->thumb_browser, 0, 0, 1, 1);
evas_object_smart_callback_add(ephoto->thumb_browser, "view",
_ephoto_thumb_browser_view, ephoto);
evas_object_smart_callback_add(ephoto->thumb_browser, "changed,directory",
@@ -419,10 +421,7 @@ ephoto_window_add(const char *path)
evas_object_del(ephoto->win);
return NULL;
  }
-   ephoto->sb =
-   elm_naviframe_item_insert_after(ephoto->pager, ephoto->tb, NULL, NULL,
-   NULL, ephoto->single_browser, "overlap");
-   elm_naviframe_item_title_enabled_set(ephoto->sb, EINA_FALSE, EINA_FALSE);
+   elm_table_pack(ephoto->pager, ephoto->single_browser, 0, 0, 1, 1);
evas_object_smart_callback_add(ephoto->single_browser, "back",
_ephoto_single_browser_back, ephoto);
evas_object_smart_callback_add(ephoto->single_browser, "slideshow",
@@ -433,10 +432,7 @@ ephoto_window_add(const char *path)
evas_object_del(ephoto->win);
return NULL;
  }
-   ephoto->sl =
-   elm_naviframe_item_insert_after(ephoto->pager, ephoto->sb, NULL, NULL,
-   NULL, ephoto->slideshow, "overlap");
-   elm_naviframe_item_title_enabled_set(ephoto->sl, EINA_FALSE, EINA_FALSE);
+   elm_table_pack(ephoto->pager, ephoto->slideshow, 0, 0, 1, 1);
evas_object_smart_callback_add(ephoto->slideshow, "back",
  

Re: [E-devel] ecore_con branch : simple tests on Windows

[Gustavo Sverzut Barbieri]

Hi Vincent,

thanks for your testing, it sems everything is right except TCP:

> 2) ecore_con_server|client_simple_example : error message(s) as soon as
> the programs are launched :
>
> $ ./ecore_con_server_simple_example.exe
> ERR:ecore_con lib/ecore_con/ecore_con.c:593 efl_net_socket4() fcntl(344,
> F_SETFD, FD_CLOEXEC): Bad file descriptor
> ERR:ecore_con lib/ecore_con/efl_net_server_tcp.c:74
> _efl_net_server_tcp_resolved_bind() socket(2, 1, 6): (null)
>
> $ ./ecore_con_client_simple_example.exe 127.0.0.1 8080
> ERR:ecore_con lib/ecore_con/ecore_con.c:593 efl_net_socket4()
> fcntl(388, F_SETFD, FD_CLOEXEC): Bad file descriptor

as talked in IRC, efl-net is checking for FD_CLOEXEC being defined, if
so, then use it in fcntl. Both fcntl() and FD_CLOEXEC are being
defined by evil_fcntl.h, so we have 2 options:

 - change evil_fcntl.h to not define the symbol
 - change evil_fcntl.c to implement it so it's usable with sockets

In my branch I added commits to handle the FD_CLOEXEC not being
defined (it was triggering some compile warnings).

-- 
Gustavo Sverzut Barbieri
--
Mobile: +55 (16) 99354-9890

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Help me get Ephoto released!

[Vincent Torri]

About ephoto on Windows, once the ecore_con branch is pushed, and some
modifications in build and code, see attached screenshot

diff:

1) Evl must be linked
2) lstat() does not exist on windows, switch to stat() on Windows

Here is the diff, modify it as you like

diff --git a/configure.ac b/configure.ac
index 13c3707..35cb7ac 100644
--- a/configure.ac
+++ b/configure.ac
@@ -53,18 +53,13 @@ fi

 AM_CONDITIONAL([HAVE_PO], [test "x${have_po}" = "xyes"])

-PKG_CHECK_MODULES([EFL], [
- eina >= 1.18.0
- evas >= 1.18.0
- ecore >= 1.18.0
- ecore-file >= 1.18.0
- ecore-ipc >= 1.18.0
- edje >= 1.18.0
- eo >= 1.18.0
- eio >= 1.18.0
- elementary >= 1.18.0
- efreet-mime >= 1.18.0
-])
+requirements="eina >= 1.18.0 evas >= 1.18.0 ecore >= 1.18.0 ecore-file >=
1.18.0 ecore-ipc >= 1.18.0 edje >= 1.18.0 eo >= 1.18.0 eio >= 1.18.0
elementary >= 1.18.0 efreet-mime >= 1.18.0"
+
+if test "x${have_win32}" = "xyes" ; then
+ requirements="${requirements} evil"
+fi
+
+PKG_CHECK_MODULES([EFL], [${requirements}])

 AC_CHECK_FUNCS([nice])

diff --git a/src/bin/ephoto_file.c b/src/bin/ephoto_file.c
index 708ef46..453f262 100644
--- a/src/bin/ephoto_file.c
+++ b/src/bin/ephoto_file.c
@@ -744,7 +744,11 @@ _delete_thread_cb(void *data, Ecore_Thread *et
EINA_UNUSED)
 int ret;
  struct stat s;

+#ifdef _WIN32
+ if (stat(file, ))
+#else
  if (lstat(file, ))
+#endif
{
   if (S_ISLNK(s.st_mode))
 {



Vincent


On Mon, Jan 9, 2017 at 4:57 PM, Stephen Houston 
wrote:

> Following in the footsteps of Boris with Terminology, I would also like to
> get Ephoto final released.  We have been on beta 2 for a while now.  Please
> respond to this mail or file tickets on phab with any questions, comments,
> queries, or ponders you have with Ephoto right now.  Suggestions,
> compliments, and harsh criticism welcome.  Assuming it fits the timeline, I
> would like to release this week.
>
> Thanks,
> Stephen
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] ecore_con branch : simple tests on Windows

[Vincent Torri]

Hey

Here are some tests on Windows of the ecore_con k-s' branch using the
examples:


1) ecore_con_server|client_example, local-user: seems to work :

$ ./ecore_con_server_example.exe -t=local-user test 2
INFO: client added 030b55c8: 0.0.0.0
Sent 12 bytes to client 0.0.0.0
INFO: client data 030b55c8: 0.0.0.0
INFO:  - size: 6
-- BEGIN DATA --
hello!-- END DATA --

$ ./ecore_con_client_example.exe -t=local-user test 2
Server with ip (null) connected!
Sent 6 bytes to server
Received 12 bytes from server:
>
Hello World!
>


2) ecore_con_server|client_simple_example : error message(s) as soon as
the programs are launched :

$ ./ecore_con_server_simple_example.exe
ERR:ecore_con lib/ecore_con/ecore_con.c:593 efl_net_socket4() fcntl(344,
F_SETFD, FD_CLOEXEC): Bad file descriptor
ERR:ecore_con lib/ecore_con/efl_net_server_tcp.c:74
_efl_net_server_tcp_resolved_bind() socket(2, 1, 6): (null)

$ ./ecore_con_client_simple_example.exe 127.0.0.1 8080
ERR:ecore_con lib/ecore_con/ecore_con.c:593 efl_net_socket4()
fcntl(388, F_SETFD, FD_CLOEXEC): Bad file descriptor


3) ecore_ipc_server|client_example :

$ ./ecore_ipc_server_example.exe -t=user test 2
INFO: client added 00832de0: 0.0.0.0

$ ./ecore_ipc_client_example.exe -t=user test 2
INFO: server added 031be7b0: (null)
INFO: start typing some lines of text to send to server...
INFO: server data 031be7b0: (null)
INFO:  - major: 1, minor: 2, ref: 3 (to: 0)
INFO:  - response?: 1
INFO:  - size: 12
-- BEGIN DATA --
Hello World!-- END DATA --

and when I Ctrl-C the client :

$ ./ecore_ipc_server_example.exe -t=user test 2
INFO: client added 00832de0: 0.0.0.0
INFO: client deleted 00832de0: (null)

tell me if you want other tests

Vincent
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] edevelop.slack.com experiment

[Conrad Um]

What about this one?
https://about.mattermost.com/

Mattermost is an open source project for slack-alternative and it's MIT
licensed. Samsung adopted its enterprise edition.

I don't know well about what features are supported compared to slack, but
its first impression is similar.

On Mar 23, 2017 3:05 PM, "Vincent Torri"  wrote:

> On Thu, Mar 23, 2017 at 1:14 AM, Carsten Haitzler 
> wrote:
> > On Wed, 22 Mar 2017 15:18:27 + Tom Hacohen  said:
> >
> >> Heya,
> >>
> >> I personally think it's a bad idea to rely on a proprietary tool for
> >> open source development, and from what I remember, I'm not the only
> >> one.
> >> This is partially why we self host git and not use Github et al.
> >>
> >> Long live IRC.
> >>
> >> https://xkcd.com/1782/
> >
> > there are things slack does that irc doesn't - like work well with
> mobiles...
> > but it does have downsides. like invite-only, closed, ...
> >
> > ultimately we should solve this ourselves:
> >
> > let's consider building a great IRC client (like express - work on it),
> and
> > EXTEND irc.
>
> I agree on this. Extend Express like Terminology extends what a
> terminal usually does.
>
> Vincent
>
> > yes. let's do what MIRC did. but let's do it a little less
> > annoyingly. we'd need to build some server infra to be able to upload
> data to
> > (images, videos, audio, text etc.) and much like imgur./pastebin (our own
> > screenshot thing for e  and visible on http://www.enlightenment.org/ss
> ) ...
> > allow a client to upload some displayable/sharable media and then just
> stuff a
> > link into the channel. if you look at slack's irc gateway when you use a
> giphy
> > image all it does is spew out:
> >
> >  giphy: http://gipy.com/8267fv78s6238dx
> >
> > all you need is for an irc client to handle such things implicitly and
> convert
> > such lines into an image box (and then download the image in the
> background and
> > inline it once done)...
> >
> > this would be a major start to modernizing irc. whatever - we can argue
> about
> > what should be done by default (download blurred out thumbnail and only
> > download full sized image when clicked on - or just replace with a
> "download
> > me" button... let's not get into that). the point is that using other
> > messengers (slack, telegram, hangouts, whatsapp) people can do this and
> it
> > looks nice and is convenient. yes people can abuse it yet such apps grow
> in
> > popularity. so use an ancient irc client where you dont see this if you
> hate
> > it (just a text url), or we can have options... but don't let this be a
> reason
> > to NOT extend and improve.
> >
> > given a good irc client with such extensions we can get all of the
> benefits of
> > something like slack BUT stick to open IRC servers and channels without
> > fragmenting community.
> >
> > then there is the other problem. mobile. ultimately someone will need a
> mobile
> > friendly server with proper remote (delayed) wakeups that don't require
> the
> > phone to maintain wake locks... and then mobile clients. technically
> express
> > could be recycled for tizen... and perhaps android if efl got good
> android
> > support. similar story for ios... :)
> >
> >> --
> >> Tom
> >>
> >> On Tue, Mar 21, 2017 at 2:52 PM, Gustavo Sverzut Barbieri
> >>  wrote:
> >> > Hi all,
> >> >
> >> > I'm doing an experiment with slack.com as IRC alternative. I'm no
> >> > expert in slack, first time I ever used, if you have more experience
> >> > let me know so I can add you as admin.
> >> >
> >> > The biggest annoyance at the time is sign up that requires an
> >> > invitation, I sent to some in this list, others can do based on
> >> > domains such as @samsung.com, @osg.samsung.com and so on... but they
> >> > do not allow comcast.net or gmail.com to auto-join.
> >> >
> >> > So if you want to join, let me know your email and I'll send the
> invitation.
> >> >
> >> > I've added some interesting plugins as people were demanding
> >> > voice/video calls at some point, these 2 can be better than simply
> >> > keeping a google Hangouts open all the time (and night!):
> >> >
> >> >  /appear edevelop
> >> >
> >> > creates an appear.in video/voice chat https://appear.in/edevelop
> >> > just click to join, no app or registration is required. Seems to have
> >> > a 8 person limit.
> >> >
> >> >  /hangout
> >> >
> >> >  creates a hangout invitation link and post to channel, people can
> >> > click to join. Marcel told it also has a limit on video users.
> >> >
> >> > Since we often need to remember people of stuff:
> >> >
> >> >  /remind [@person or #channel] [what] [when]
> >> >  /remind me to drink water at 3pm every day
> >> >  /remind me on June 1st to wish Linda happy birthday
> >> >  /remind #team-alpha to update the project status every Monday at 9am
> >> >  /remind @jessica about the interview in 3 hours
> >> >  /remind @peter tomorrow "Please review the office 

[EGIT] [website/www-content] master 01/01: Wiki page ubuntu-start changed with summary [] by Philippe Jean Guillaumie

[Philippe Jean Guillaumie]

WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=da810e9e0224b4e5ed3d9593cd7f85c56fc2ed81

commit da810e9e0224b4e5ed3d9593cd7f85c56fc2ed81
Author: Philippe Jean Guillaumie 
Date:   Wed Mar 29 01:25:33 2017 -0700

Wiki page ubuntu-start changed with summary [] by Philippe Jean Guillaumie
---
 pages/distros/ubuntu-start.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pages/distros/ubuntu-start.txt b/pages/distros/ubuntu-start.txt
index 4e64018..afec1a3 100644
--- a/pages/distros/ubuntu-start.txt
+++ b/pages/distros/ubuntu-start.txt
@@ -18,8 +18,8 @@ libsndfile1-dev libspectre-dev libssl-dev libsystemd-dev \
 libtiff5-dev libtool libudev-dev libudisks2-dev libunibreak-dev \
 libvlc-dev libwebp-dev libxcb-keysyms1-dev libxcursor-dev \
 libxine2-dev libxinerama-dev libxkbfile-dev libxrandr-dev libxss-dev \
-libxtst-dev linux-tools-common texlive-base \
-unity-greeter-badges valgrind xserver-xephyr
+libxtst-dev linux-tools-common texlive-base unity-greeter-badges \
+valgrind xserver-xephyr
 
 
 

-- 

[EGIT] [website/www-content] master 01/01: Wiki page ubuntu-start changed with summary [] by Philippe Jean Guillaumie

[Philippe Jean Guillaumie]

WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=c6411d05751df8e97c5c261b01fb7fdef841544d

commit c6411d05751df8e97c5c261b01fb7fdef841544d
Author: Philippe Jean Guillaumie 
Date:   Wed Mar 29 01:23:28 2017 -0700

Wiki page ubuntu-start changed with summary [] by Philippe Jean Guillaumie
---
 pages/distros/ubuntu-start.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pages/distros/ubuntu-start.txt b/pages/distros/ubuntu-start.txt
index 2a5ba64..4e64018 100644
--- a/pages/distros/ubuntu-start.txt
+++ b/pages/distros/ubuntu-start.txt
@@ -15,9 +15,9 @@ liblz4-dev libmount-dev libopenjpeg-dev libpam0g-dev \
 libpoppler-cpp-dev libpoppler-dev libpoppler-private-dev \
 libproxy-dev libpulse-dev libraw-dev librsvg2-dev libscim-dev \
 libsndfile1-dev libspectre-dev libssl-dev libsystemd-dev \
-libtiff5-dev libtool libudisks2-dev libunibreak-dev libvlc-dev \
-libwebp-dev libxcb-keysyms1-dev libxcursor-dev libxine2-dev \
-libxinerama-dev libxkbfile-dev libxrandr-dev libxss-dev \
+libtiff5-dev libtool libudev-dev libudisks2-dev libunibreak-dev \
+libvlc-dev libwebp-dev libxcb-keysyms1-dev libxcursor-dev \
+libxine2-dev libxinerama-dev libxkbfile-dev libxrandr-dev libxss-dev \
 libxtst-dev linux-tools-common texlive-base \
 unity-greeter-badges valgrind xserver-xephyr
 

-- 

[EGIT] [core/efl] master 01/01: fix ecore con client exmaple to match cmdline help output for options

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=eac53691f9429fc23462abba92cbd77b514e12bb

commit eac53691f9429fc23462abba92cbd77b514e12bb
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Mar 29 16:49:03 2017 +0900

fix ecore con client exmaple to match cmdline help output for options
---
 src/examples/ecore/ecore_con_client_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/examples/ecore/ecore_con_client_example.c 
b/src/examples/ecore/ecore_con_client_example.c
index 781dff6..879e220 100644
--- a/src/examples/ecore/ecore_con_client_example.c
+++ b/src/examples/ecore/ecore_con_client_example.c
@@ -293,7 +293,7 @@ main(int argc, char *argv[])
  }
else if (strcmp(type_choice, "local-user") == 0)
  type = ECORE_CON_LOCAL_USER;
-   else if (strcmp(type_choice, "system") == 0)
+   else if (strcmp(type_choice, "local-system") == 0)
  type = ECORE_CON_LOCAL_SYSTEM;
else
  {

-- 

[EGIT] [core/efl] master 01/01: fix ecore con server exmaple to match cmdline help output for options

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=feeff68401c29fc9ad46e2cc2b42b4688eda8450

commit feeff68401c29fc9ad46e2cc2b42b4688eda8450
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Mar 29 16:28:21 2017 +0900

fix ecore con server exmaple to match cmdline help output for options
---
 src/examples/ecore/ecore_con_server_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/examples/ecore/ecore_con_server_example.c 
b/src/examples/ecore/ecore_con_server_example.c
index fed7c9c..08aee96 100644
--- a/src/examples/ecore/ecore_con_server_example.c
+++ b/src/examples/ecore/ecore_con_server_example.c
@@ -238,7 +238,7 @@ main(int argc, char **argv)
  }
else if (strcmp(type_choice, "local-user") == 0)
  type = ECORE_CON_LOCAL_USER;
-   else if (strcmp(type_choice, "system") == 0)
+   else if (strcmp(type_choice, "local-system") == 0)
  type = ECORE_CON_LOCAL_SYSTEM;
else if (strcmp(type_choice, "mcast") == 0)
  type = ECORE_CON_REMOTE_MCAST;

--