Re: [E-devel] implementation of ntohl and al.
On Thu, Jan 3, 2019 at 2:32 AM Cedric Bail wrote: > > On Wednesday, January 2, 2019 1:24 PM, Vincent Torri > wrote: > > just for some ideas, here is a patch for this code : > > https://pastebin.com/bHdMVjLZ > > It would be really nice to start pushing this through phab for > review as this would allow for a better tracking of it for sure. I > really recommend switching to git phab as described: > https://phab.enlightenment.org/w/arcanist/ (I know the page title > is "slightly" misleading). i will use these functions in efl code too, then > > I have to add a macro (EINA_BIGENDIAN) with configure as the code is inlined > > > > ideas, remarks ? > > I think you should use the macro WORDS_BIGENDIAN which is already > available in both meson and the autotools. no, they are **inlined** functions that is, if a library or program **uses** these functions, WORDS_BIGENDIAN may be not correctly defined. I can use WORDS BIGENDIAN if the functions are not inlined > I think I kind of understand why you wouldn't want to use them even > on Linux and I am fine the way it looks and seems to generate the > proper asm at the end. thank you Vincent ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] implementation of ntohl and al.
On Wednesday, January 2, 2019 1:24 PM, Vincent Torri wrote: > just for some ideas, here is a patch for this code : > https://pastebin.com/bHdMVjLZ It would be really nice to start pushing this through phab for review as this would allow for a better tracking of it for sure. I really recommend switching to git phab as described: https://phab.enlightenment.org/w/arcanist/ (I know the page title is "slightly" misleading). > I have to add a macro (EINA_BIGENDIAN) with configure as the code is inlined > > ideas, remarks ? I think you should use the macro WORDS_BIGENDIAN which is already available in both meson and the autotools. I think I kind of understand why you wouldn't want to use them even on Linux and I am fine the way it looks and seems to generate the proper asm at the end. Cedric ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] implementation of ntohl and al.
Hello just for some ideas, here is a patch for this code : https://pastebin.com/bHdMVjLZ I have to add a macro (EINA_BIGENDIAN) with configure as the code is inlined ideas, remarks ? thank you and happy new year Vincent On Wed, Dec 19, 2018 at 10:35 AM Vincent Torri wrote: > > hey > > On Tue, Dec 18, 2018 at 9:00 PM Cedric Bail wrote: > > > > Hi, > > > > I also agree completely with Xavi. Especially on naming it ntoh() for > > discoverability as it is the well known expected name for it. > > > > As for the implementation, maybe move it into an inline .x file, but no > > strong opinion there. > > i also wanted to make these functions inlined > > Vincent ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Next Release
Hi All, I have a quick question who is taking care of the next release since Stefan has stepped down? I am willing to setup if necessary. Do we have a time line for the next release? Regards, Jonathan ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
