Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: fix pointer offset fpor older themes
On Wed, 1 Apr 2020 15:16:37 -0400 Christopher Michael
said:
i didn't. good catch. :)
> Did you mean to leave the 2 printf's in here (at the bottom) ??
>
>
> dh
>
>
> On 4/1/20 3:13 PM, Carsten Haitzler wrote:
> > raster pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/enlightenment.git/commit/?id=64f87877a6294ab46684f0da36ef7bc6f1dabe59
> >
> > commit 64f87877a6294ab46684f0da36ef7bc6f1dabe59
> > Author: Carsten Haitzler (Rasterman)
> > Date: Wed Apr 1 20:12:15 2020 +0100
> >
> > fix pointer offset fpor older themes
> >
> > fixes T8622
> >
> > so due rto optimizations in edje it no longer moves/resizes invsible
> > parts, so swallow a rect and it wont have moved if it is not visible
> > thus tracking its geometry by getting the geometry of the swallowed
> > part only works if its visible, so get the part geom from edje instead
> > which has to give the calculated geom.
> > ---
> > src/bin/e_pointer.c | 14 --
> > 1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/src/bin/e_pointer.c b/src/bin/e_pointer.c
> > index 61743a2cf..eca3afb7d 100644
> > --- a/src/bin/e_pointer.c
> > +++ b/src/bin/e_pointer.c
> > @@ -225,8 +225,8 @@ _e_pointer_cb_hot_move(void *data, Evas *evas
> > EINA_UNUSED, Evas_Object *obj EINA
> > if (!ptr->e_cursor) return;
> > if (!evas_object_visible_get(ptr->o_ptr)) return;
> > - evas_object_geometry_get(ptr->buffer_o_hot,
> > -, , NULL, NULL);
> > + edje_object_part_geometry_get(ptr->o_ptr, "e.swallow.hotspot",
> > + , , NULL, NULL);
> > _e_pointer_hot_update(ptr, x, y);
> > }
> >
> > @@ -237,8 +237,8 @@ _e_pointer_cb_hot_show(void *data, Evas *evas
> > EINA_UNUSED, Evas_Object *obj EINA int x = 0, y = 0;
> >
> > if (!ptr->e_cursor) return;
> > - evas_object_geometry_get(ptr->buffer_o_hot,
> > -, , NULL, NULL);
> > + edje_object_part_geometry_get(ptr->o_ptr, "e.swallow.hotspot",
> > + , , NULL, NULL);
> > _e_pointer_hot_update(ptr, x, y);
> > }
> >
> > @@ -477,8 +477,8 @@ _e_pointer_type_set(E_Pointer *ptr, const char *type)
> > _e_pointer_x11_setup(ptr, cursor);
> > if (!cursor[0]) return;
> >
> > -evas_object_geometry_get(ptr->buffer_o_hot,
> > - , , NULL, NULL);
> > +edje_object_part_geometry_get(ptr->o_ptr, "e.swallow.hotspot",
> > + , , NULL, NULL);
> > _e_pointer_hot_update(ptr, x, y);
> >
> > if (ptr->canvas)
> > @@ -783,6 +783,7 @@ e_pointer_idler_before(void)
> > #ifndef HAVE_WAYLAND_ONLY
> > Ecore_X_Cursor cur;
> >
> > + printf("update cursor hot %i %i\n", ptr->hot.x,
> > ptr->hot.y); cur = ecore_x_cursor_new(ptr->win, ptr->pixels, ptr->w,
> > ptr->h, ptr->hot.x,
> > ptr->hot.y); ecore_x_window_cursor_set(ptr->win, cur);
> > @@ -830,6 +831,7 @@ e_pointer_object_set(E_Pointer *ptr, Evas_Object *obj,
> > int x, int y) else if ((o != ptr->o_ptr) || (x != px) || (y != py))
> >{
> > ecore_evas_cursor_unset(ptr->ee);
> > +printf("ecore_evas_obj ptr hot %i %i\n", ptr->hot.x, ptr->hot.y);
> > ecore_evas_object_cursor_set(ptr->ee, ptr->o_ptr, E_LAYER_MAX -
> > 1, ptr->hot.x, ptr->hot.y); evas_object_show(ptr->o_ptr);
> >}
> >
>
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
- Codito, ergo sum - "I code, therefore I am" --
Carsten Haitzler - ras...@rasterman.com
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: fix pointer offset fpor older themes
Did you mean to leave the 2 printf's in here (at the bottom) ??
dh
On 4/1/20 3:13 PM, Carsten Haitzler wrote:
raster pushed a commit to branch master.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=64f87877a6294ab46684f0da36ef7bc6f1dabe59
commit 64f87877a6294ab46684f0da36ef7bc6f1dabe59
Author: Carsten Haitzler (Rasterman)
Date: Wed Apr 1 20:12:15 2020 +0100
fix pointer offset fpor older themes
fixes T8622
so due rto optimizations in edje it no longer moves/resizes invsible
parts, so swallow a rect and it wont have moved if it is not visible
thus tracking its geometry by getting the geometry of the swallowed
part only works if its visible, so get the part geom from edje instead
which has to give the calculated geom.
---
src/bin/e_pointer.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/bin/e_pointer.c b/src/bin/e_pointer.c
index 61743a2cf..eca3afb7d 100644
--- a/src/bin/e_pointer.c
+++ b/src/bin/e_pointer.c
@@ -225,8 +225,8 @@ _e_pointer_cb_hot_move(void *data, Evas *evas EINA_UNUSED,
Evas_Object *obj EINA
if (!ptr->e_cursor) return;
if (!evas_object_visible_get(ptr->o_ptr)) return;
- evas_object_geometry_get(ptr->buffer_o_hot,
-, , NULL, NULL);
+ edje_object_part_geometry_get(ptr->o_ptr, "e.swallow.hotspot",
+ , , NULL, NULL);
_e_pointer_hot_update(ptr, x, y);
}
@@ -237,8 +237,8 @@ _e_pointer_cb_hot_show(void *data, Evas *evas EINA_UNUSED, Evas_Object *obj EINA
int x = 0, y = 0;
if (!ptr->e_cursor) return;
- evas_object_geometry_get(ptr->buffer_o_hot,
-, , NULL, NULL);
+ edje_object_part_geometry_get(ptr->o_ptr, "e.swallow.hotspot",
+ , , NULL, NULL);
_e_pointer_hot_update(ptr, x, y);
}
@@ -477,8 +477,8 @@ _e_pointer_type_set(E_Pointer *ptr, const char *type)
_e_pointer_x11_setup(ptr, cursor);
if (!cursor[0]) return;
-evas_object_geometry_get(ptr->buffer_o_hot,
- , , NULL, NULL);
+edje_object_part_geometry_get(ptr->o_ptr, "e.swallow.hotspot",
+ , , NULL, NULL);
_e_pointer_hot_update(ptr, x, y);
if (ptr->canvas)
@@ -783,6 +783,7 @@ e_pointer_idler_before(void)
#ifndef HAVE_WAYLAND_ONLY
Ecore_X_Cursor cur;
+ printf("update cursor hot %i %i\n", ptr->hot.x, ptr->hot.y);
cur = ecore_x_cursor_new(ptr->win, ptr->pixels, ptr->w,
ptr->h, ptr->hot.x, ptr->hot.y);
ecore_x_window_cursor_set(ptr->win, cur);
@@ -830,6 +831,7 @@ e_pointer_object_set(E_Pointer *ptr, Evas_Object *obj, int
x, int y)
else if ((o != ptr->o_ptr) || (x != px) || (y != py))
{
ecore_evas_cursor_unset(ptr->ee);
+printf("ecore_evas_obj ptr hot %i %i\n", ptr->hot.x, ptr->hot.y);
ecore_evas_object_cursor_set(ptr->ee, ptr->o_ptr, E_LAYER_MAX - 1,
ptr->hot.x, ptr->hot.y);
evas_object_show(ptr->o_ptr);
}
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] EFL 1.24.0 alpha 1
With this alpha release we are marking the freeze and start of the stabilization phase for the efl 1.24 release cycle. Please give it some testing and report problems to us so we can work towards a well working release. **Features:** * eina: add comparison macros for Eina_Size2D and Eina_Position2D * ecore-wl2: Add API to find a window by surface * ecore-wl2: Add API to find a connected display given a name * ecore-wl2: Add API to return the compositor object from a given display * ecore-wl2: Add API to return window type * ecore-wl2: Add API to find a window by given surface * edje: Add text change signal * edje: add json file support feature **Fixes:** * efl_ui/bg: unset finger_size multiplier during construction (T8304) * elementary: always use a font that matches our expectation for our test instead of the system one. (T8277) * doc: improve colorselector preview (T8304) * eldbus: properly call parent finalize during creation of Eldbus.Model_Method. * efl_ui/win: fix max size hint eval (T8304) * eet - fix loading eet files that do not have dicts (T8368) * evas/callbacks: emit hardcoded legacy smart callbacks always * elm/layout: add some workarounds to try handling legacy min sizes * ecore_evas/wl2 0 fux xdg close cb for window when it's closed remotely * wl egl - use platform get display * ecore-evas-wayland: Add handler to array * ecore_evas_wayland: Fix array step size * efl/timer: correctly handle recursion for timer processing * elm/genlist: trigger filter,done callback immediately if no filter queue exists * elm/genlist: fix "drag" smart callback * elm/genlist: set pan need recalc during item move on item position change * elm/genlist: fix item focus unregister on item move * ecore/timer: correctly handle recursive deletion of legacy timers * ecore-drm2: Fix issue of shifting 1 by more than 32bits * efreet - consider ctime changes as changes too * edje - box - calc min size correctly at start ... * vector svg: apply fill-opacity to graidents fill objects. * evas vector: initialize data member properly. * fix jpeg loading which freed the wrong ptr (T8497) * fix the wrong method signature for evas_textgrid * efl_ui/layout: fix multiple emissions of theme,changed during construction * ui image: fix scale_method expand behavior. * ecore-x - fix fallbacks to use capital X in lib name (T8543) * elm - widget - actually check object smart data return for no data * canvas vector: fix to refresh svg file of vector object. * evas - fix access-after-free where during destroy hash item not cleared * elm - fix filesel deferred unref to not crash * ecore_con - freebsd bind blocking workaround * elm win + ecore evas - fix csd stuff like base size and min sizing * evas - fix access-after-free number 2 (T8534) * elm win - fix client side move/resize req handling csd in x * edje - store original size in edje struct and dont exceed max size * evas - loaders - jp2k - re-enable in the build after it was lost * edje_entry: Add matching tag. * evas/events: fix multi-touch object targeting on touch down events * eo - fix - fix alignment of eo object class structs - it was wrong * canvas font: correct wrong masking length. * Efl.Gfx.Path: Fix condition of for loop in current search * canvas mask: fix incorrect render surface size. * canvas proxy: fix broken proxy source clipping function. * evas gl: clip rect with proper size. * canvas proxy: fix a missing case that proxy not updated properly. * evas_object_box: respect static clipper. * ecore evas x - on argb dont create unused 1 bit pixmap masks * emotion - webcam - fix segv on webcam plug/unplug and clean **Removals:** * emotion & evas: remove gstreamer 0.10 support * escape: remove library from tree * ecore_x: remove support XGesture extension * elocation: remove beta library * eeze: remove tizen module support from eeze sensor * evas3d: remove support for evas 3D which was a beta all along **Download** http://download.enlightenment.org/rel/libs/efl/efl-1.24.0-alpha1.tar.xz a1d56848be9ebbac47d542df1f0075b927776c0402bdb192ecba4dd25a6c5656 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
