kwo pushed a commit to branch master.
http://git.enlightenment.org/legacy/imlib2.git/commit/?id=ac1d4b0520faa627b75c3465ac5b71f71a2281f6
commit ac1d4b0520faa627b75c3465ac5b71f71a2281f6
Author: Kim Woelders
Date: Thu Mar 3 06:04:45 2022 +0100
Deal consistently with including Imlib2.h
- Always include config.h before Imlib2.h
Needed for X_DISPLAY_MISSING.
- Always include config.h and Imlib2.h first
Should make it more likely to spot stuff missing but required
in Imlib2.h, like stddef.h.
gtest.h apparently must be included before X headers though.
- Make sure we use the Imlib2.h here and not the one in /usr/include
Also ensure that the tests build when building without X.
---
src/bin/imlib2_bumpmap.c | 3 +--
src/bin/imlib2_colorspace.c | 3 +--
src/bin/imlib2_conv.c | 16
src/bin/imlib2_grab.c | 3 +--
src/bin/imlib2_load.c | 10 +-
src/bin/imlib2_poly.c | 3 +--
src/bin/imlib2_show.c | 3 +--
src/bin/imlib2_test.c | 3 +--
src/bin/imlib2_view.c | 2 +-
src/lib/Imlib2.h.in | 1 +
src/lib/api.c | 2 +-
src/lib/api_obsolete.c| 3 +--
src/lib/image.c | 5 +++--
src/lib/script.c | 5 +++--
src/modules/filters/Makefile.am | 2 +-
src/modules/filters/filter_bumpmap.c | 7 +--
src/modules/filters/filter_colormod.c | 7 +--
src/modules/filters/filter_test.c | 7 +--
test/Makefile.am | 4 +++-
test/test_context.cpp | 4 +++-
test/test_grab.cpp| 5 +++--
test/test_load.cpp| 3 ++-
test/test_load_2.cpp | 3 ++-
test/test_rotate.cpp | 3 ++-
test/test_save.cpp| 2 +-
test/test_scale.cpp | 3 ++-
26 files changed, 63 insertions(+), 49 deletions(-)
diff --git a/src/bin/imlib2_bumpmap.c b/src/bin/imlib2_bumpmap.c
index c373a91..690ace0 100644
--- a/src/bin/imlib2_bumpmap.c
+++ b/src/bin/imlib2_bumpmap.c
@@ -1,12 +1,11 @@
#include "config.h"
+#include
#include
#include
#include
#include
-#include
-
Display*disp;
Window win;
diff --git a/src/bin/imlib2_colorspace.c b/src/bin/imlib2_colorspace.c
index 7a0a4ba..4f5d583 100644
--- a/src/bin/imlib2_colorspace.c
+++ b/src/bin/imlib2_colorspace.c
@@ -1,12 +1,11 @@
#include "config.h"
+#include
#include
#include
#include
#include
-#include
-
Display*disp;
Window win;
diff --git a/src/bin/imlib2_conv.c b/src/bin/imlib2_conv.c
index 6a88f94..d204e02 100644
--- a/src/bin/imlib2_conv.c
+++ b/src/bin/imlib2_conv.c
@@ -1,18 +1,18 @@
-#include "config.h"
-/* Convert images between formats, using Imlib2's API. Smart enough to know
- * about edb files; defaults to jpg's.
+/*
+ * Convert images between formats, using Imlib2's API.
+ * Defaults to jpg's.
*/
+#include "config.h"
+#ifndef X_DISPLAY_MISSING
+#define X_DISPLAY_MISSING
+#endif
+#include
#include
#include
#include
#include
-#ifndef X_DISPLAY_MISSING
-#define X_DISPLAY_MISSING
-#endif
-#include
-
#define PROG_NAME "imlib2_conv"
static void usage(int exit_status);
diff --git a/src/bin/imlib2_grab.c b/src/bin/imlib2_grab.c
index e7db343..3004048 100644
--- a/src/bin/imlib2_grab.c
+++ b/src/bin/imlib2_grab.c
@@ -1,12 +1,11 @@
#include "config.h"
+#include
#include
#include
#include
#include
-#include
-
Display*disp;
int image_width = 0, image_height = 0;
diff --git a/src/bin/imlib2_load.c b/src/bin/imlib2_load.c
index d4345d5..9e46baa 100644
--- a/src/bin/imlib2_load.c
+++ b/src/bin/imlib2_load.c
@@ -1,4 +1,9 @@
#include "config.h"
+#ifndef X_DISPLAY_MISSING
+#define X_DISPLAY_MISSING
+#endif
+#include
+
#include
#include
#include
@@ -11,11 +16,6 @@
#include
#endif
-#ifndef X_DISPLAY_MISSING
-#define X_DISPLAY_MISSING
-#endif
-#include
-
#define PROG_NAME "imlib2_load"
static char progress_called;
diff --git a/src/bin/imlib2_poly.c b/src/bin/imlib2_poly.c
index 3e7ab62..f3153e6 100644
--- a/src/bin/imlib2_poly.c
+++ b/src/bin/imlib2_poly.c
@@ -1,12 +1,11 @@
#include "config.h"
+#include
#include
#include
#include
#include
-#include
-
Display*disp;
Window win;
diff --git a/src/bin/imlib2_show.c b/src/bin/imlib2_show.c
index a8d75c2..7025def 100644
--- a/src/bin/imlib2_show.c
+++ b/src/bin/imlib2_show.c
@@ -1,4 +1,5 @@
#include "config.h"
+#include
#include
#include
@@ -10,8 +11,6 @@
#include
#include
-#include
-
Display*disp;
Window win;
diff --git a/src/bin/imlib2_test.c b/src/bin/imlib2_test.c
index 42dab64..4762723 100644
--- a/src/bin/imlib2_test.c