Re: [E-devel] bug in imlib2
On Wed, 6 Dec 2006, [EMAIL PROTECTED] wrote: On Sun, 3 Dec 2006, [EMAIL PROTECTED] wrote: Clearly whoever wrote that stuff seems to have left things in imlib2 languish since no improvements or fixes have ever been sent on anything. :( I don't think it's a question of lack of interest, it's lack of *time*, and lack of more people who can actively work on things. Rather than 'give up on supporting this project' I'd say that what's needed is further support and involvement. :) If someone makes a contribution to your project, and the response is, Yeah, we know that sucks, but we're not going to do anything about it at this time, is it any surprise that you lack people who are actively working on things? It seems to me that you are asking for support on one hand and rejecting the support offered on the other hand. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] bug in imlib2
On Sun, 3 Dec 2006, [EMAIL PROTECTED] wrote: I have attached a test case for the bug, and a patch to fix it. Clearly whoever wrote that stuff seems to have left things in imlib2 languish since no improvements or fixes have ever been sent on anything. :( Is there a bugtracker where I should put the bug report and patch, so someone can find it if they ever get around to fixing bugs in imlib2? If there is as little interest in fixing bugs as you say, I will just give up on supporting this project. ~ John Williams - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] bug in imlib2
imlib_image_draw_line has a bug in which it fails to draw a line correctly
when dx0, dy0, and dydx. It mistakenly uses the shallow line code
path, and the resulting line is always drawn as if dy=dx.
I have attached a test case for the bug, and a patch to fix it.
~ John Williams
#include X11/Xlib.h
#include stdio.h
#include string.h
#include Imlib2.h
int main(int argc, char **argv)
{
Imlib_Image image;
image = imlib_create_image(100,100);
imlib_context_set_image(image);
imlib_context_set_color(255,255,255,255);
imlib_image_fill_rectangle(0,0,100,100);
imlib_context_set_color(0,0,0,255);
/* show the destination point */
imlib_image_draw_line(74,16,74,16,0);
/* try to draw a line to there */
imlib_image_draw_line(50,50,74,16,0);
imlib_save_image(bug.png);
}
Index: line.c
===
RCS file: /var/cvs/e/e17/libs/imlib2/src/lib/line.c,v
retrieving revision 1.1
diff -u -r1.1 line.c
--- line.c 1 Nov 2004 09:45:31 - 1.1
+++ line.c 3 Dec 2006 00:56:37 -
@@ -404,7 +404,7 @@
y1 -= cly;
/* shallow: x-parametric */
- if ((dy dx) || (dy -dx))
+ if (abs(dy) abs(dx))
{
SETUP_LINE_SHALLOW
@@ -513,7 +513,7 @@
y1 -= cly;
/* shallow: x-parametric */
- if ((dy dx) || (dy -dx))
+ if (abs(dy) abs(dx))
{
SETUP_LINE_SHALLOW
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
