[E-devel] eina : use lstat instead of d_type
hi
eina only build on linux/BSD OS because it's use d_type . I try to
create a patch to use lstat instead d_type but i have big problem with
C :)
Does someone can tell me if this patch is ok or not ?
thanks
$ gdiff -Naur e17_src/eina/src/lib/eina_file.c eina_file.c
--- e17_src/eina/src/lib/eina_file.c2008-10-17 10:54:13.008637731 +0200
+++ eina_file.c 2008-10-17 22:40:00.648011565 +0200
@@ -117,6 +117,7 @@
#ifndef _WIN32
struct dirent *de;
DIR *d;
+ struct stat statbuf;
if (!cb) return EINA_FALSE;
@@ -139,7 +140,7 @@
strcat(path, "/");
strcat(path, de->d_name);
- if (de->d_type == DT_UNKNOWN) {
+ if (lstat(de->d_name, &statbuf) == -1) {
struct stat st;
if (stat(path, &st))
@@ -147,8 +148,10 @@
if (!S_ISDIR(st.st_mode))
continue ;
- } else if (de->d_type != DT_DIR) {
- continue ;
+ } else {
+ if (!S_ISDIR(statbuf.st_mode)) {
+ continue ;
+ }
}
eina_file_dir_list(path, recursive, cb, data);
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] enlightenment_fm segfault (s->icon.drive and s->icon.volume are NULL)
when i said solaris , i mean opensolaris which have dbus/hal. Now the default WM is JDS with gnome, and sun is working with kde to port kde 4.1 on opensolaris. I know, i must be the only guy who use opensolaris :) I use e17 since 0.16.999.041 on opensolaris and i dont have big problem. Only some segault : last week, 2 segfault have been resolved in module weather and forecast stay : 1 segfault in enlightenment_fm and another in wallpaper menu On Wed, Aug 20, 2008 at 01:36, Michael Jennings <[EMAIL PROTECTED]> wrote: > On Wednesday, 20 August 2008, at 09:30:30 (+1000), > Carsten Haitzler wrote: > >> i do know this... (solaris vs linux (null) output). the thing is... it's >> debugging output - and solaris traditionally has never had hald/dbus and thus >> this hasn't mattered. :) > > I didn't know you wrote that code; I *know* you know that. You ran > Solaris at UNSW, didn't you? > > I didn't realize Solaris had dbus support now either. Yikes. > > Once upon a time, I caught all our Solaris (and HP-UX) bugs. Then it > was het, then benr. I guess we need a new Solaris tester. Want the > job, doof? ;-) > > Michael > > -- > Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> > Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) > --- > "The first lesson reading teaches is how to be alone." > -- Jonathan Franzen > > - > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] enlightenment_fm segfault (s->icon.drive and s->icon.volume are NULL)
yes i 'm on solaris :)
i find a bad workaround which is to disable the device in hal .
On Tue, Aug 19, 2008 at 23:47, Michael Jennings <[EMAIL PROTECTED]> wrote:
> On Tuesday, 19 August 2008, at 22:04:43 (+0200),
> _doof wrote:
>
>> i find why enlightenment_fm segfault but i dont have the answer
>>
>> in e_fm_main.c, line 586
>>
>> 586printf("++STO:\n udi: %s\n bus: %s\n drive_type: %s\n
>> model: %s\n vendor: %s\n serial: %s\n icon.drive: %s\n
>> icon.volume: %s\n\n", s->udi, s->bus, s->drive_type, "s->model",
>> s->vendor, s->serial, s->icon.drive, s->icon.volume);
>> 587s->validated = 1;
>>
>> s->udi 0x809adb0
>> "/org/freedesktop/Hal/devices/pci_0_0/pci1043_8239_2_1/hub_4/hub_1/storage_1_if0_0/scsi_host0/disk6/sd6"
>> s->bus0x8091780 "usb"
>> s->drive_type 0x8091750 "disk"
>> s->model0x808fae8 "Flash HS-COMBO"
>> s->vendor 0x8091730 "Generic"
>> s->serial 0x8091710 ""
>> s->icon.drive 0x0
>> s->icon.volume 0x0
>>
>> when s->icon.drive and s->icon.volume have no value,
>> enlightenment_fm segfault , and i cant browse file when i want change
>> theme or wallpaper
>>
>> if i change value of s->icon.drive and s->icon.volume to 0x8091710
>> like s->serial, it work
>> ++STO:
>> udi:
>> /org/freedesktop/Hal/devices/pci_0_0/pci1043_8239_2_1/hub_4/hub_1/storage_1_if0_0/scsi_host0/disk6/sd6
>> bus: usb
>> drive_type: disk
>> model: Flash HS-COMBO
>> vendor: Generic
>> serial:
>> icon.drive:
>> icon.volume:
>>
>> i dont know if it can help you
>
> On Linux, using printf("%s"...) with a NULL pointer is safe. On
> Solaris, it is not. Are you by any chance running on Solaris?
>
> The programmer who wrote this code probably doesn't know any better.
> But this is why the NONULL() macro exists in LibAST:
>
> #define NONULL(x) (((char *) (x)) ? ((char *) (x)) : ((char *) ("<" #x "
> null>")))
>
> HTH,
> Michael
>
> --
> Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]>
> Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org)
> ---
> "Perhaps someday we will discover that space and time are simpler
> than the human equation." -- Jean-Luc Picard, ST:TNG
>
> -
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] enlightenment_fm segfault (s->icon.drive and s->icon.volume are NULL)
hi
i find why enlightenment_fm segfault but i dont have the answer
in e_fm_main.c, line 586
586printf("++STO:\n udi: %s\n bus: %s\n drive_type: %s\n
model: %s\n vendor: %s\n serial: %s\n icon.drive: %s\n
icon.volume: %s\n\n", s->udi, s->bus, s->drive_type, "s->model",
s->vendor, s->serial, s->icon.drive, s->icon.volume);
587s->validated = 1;
s->udi 0x809adb0
"/org/freedesktop/Hal/devices/pci_0_0/pci1043_8239_2_1/hub_4/hub_1/storage_1_if0_0/scsi_host0/disk6/sd6"
s->bus0x8091780 "usb"
s->drive_type 0x8091750 "disk"
s->model0x808fae8 "Flash HS-COMBO"
s->vendor 0x8091730 "Generic"
s->serial 0x8091710 ""
s->icon.drive 0x0
s->icon.volume 0x0
when s->icon.drive and s->icon.volume have no value,
enlightenment_fm segfault , and i cant browse file when i want change
theme or wallpaper
if i change value of s->icon.drive and s->icon.volume to 0x8091710
like s->serial, it work
++STO:
udi:
/org/freedesktop/Hal/devices/pci_0_0/pci1043_8239_2_1/hub_4/hub_1/storage_1_if0_0/scsi_host0/disk6/sd6
bus: usb
drive_type: disk
model: Flash HS-COMBO
vendor: Generic
serial:
icon.drive:
icon.volume:
i dont know if it can help you
thanks
++
fred
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] always e17 on opensolaris
hi
little problem exist to compil e17 on opensolaris
1/ ETK
e17/libs/etk/src/bin/etk_combobox_test.c file use strcasestr which
doesnt exist on opensolaris. i need to add this line to compil etk
char *strcasestr(register char *s, register char *find)
{
register char c, sc;
register size_t len;
if ((c = *find++) != 0) {
len = strlen(find);
do {
do {
if ((sc = *s++) == 0)
return (NULL);
} while (sc != c);
} while (strncasecmp(s, find, len) != 0);
s--;
}
return ((char *) s);
}
2/ E
to compil e_slider.c file, i need to add --std=c99
gcc -m64 -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../src/bin
-I../../src/lib -DUSE_E_CONFIG_H -DHAVE_EDBUS -I/opt/e17/include
-I/opt/e17/include/efreet -I/usr/sfw/include -I/usr/include/curl
-I/opt/e17/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include
-I/opt/e17/include -I/usr/openwin/include -DLOWRES_PDA=1
-DMEDIUMRES_PDA=2 -DHIRES_PDA=3 -DSLOW_PC=4 -DMEDIUM_PC=5 -DFAST_PC=6
-DE17_PROFILE=SLOW_PC -DPACKAGE_BIN_DIR=\"/opt/e17//bin\"
-DPACKAGE_LIB_DIR=\"/opt/e17//lib\"
-DPACKAGE_DATA_DIR=\"/opt/e17//share/enlightenment\"
-DLOCALE_DIR=\"/opt/e17//share/locale\"
-DPACKAGE_SYSCONF_DIR=\"/opt/e17//etc\"-g -O2 -fomit-frame-pointer
-pipe -msse -msse2 -msse3 -m3dnow -mmmx -I/opt/e17/include
-I/usr/local/include -I/usr/sfw/include -I/opt/csw/include
-I/usr/include -MT e_slider.o -MD -MP -MF .deps/e_slider.Tpo -c -o
e_slider.o e_slider.c
In file included from
/usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/include/stdio.h:54,
from e.h:28,
from e_slider.c:5:
/usr/include/sys/feature_tests.h:357:2: #error "Compiler or options
invalid; UNIX 03 and POSIX.1-2001 applications require the use of
c99"
i hope this comment can help you :)
++
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e17 segfault with forecast/weather module (opensolaris)
thanks,
for weather, it's no longer segfault but in log, i have lot of message
ERROR: Couldn't parse info from rssweather.com
and it doesnt show information on my city
forecast is for me, it's work well
++
On Wed, Aug 13, 2008 at 7:34 AM, Sebastian Dransfeld
<[EMAIL PROTECTED]> wrote:
> _doof wrote:
>>
>> hi
>>
>> sorry i'm not a developer then i dont have patch
>>
>> each time i load this module (forecast and weather), e17 segfault on this
>> line :
>>
>> e_mod_main.c :
>>snprintf(env, sizeof(env), "%s", getenv("http_proxy"));
>>
>> it's because getenv('http_proxy') return NULL value
>>
>> than i add 3 lines :
>>
>> char *p;
>> int port = 0;
>> + if ( getenv("http_proxy") == NULL ) {
>> + return;
>> + }
>> snprintf(env, sizeof(env), "%s", getenv("http_proxy"));
>> if (!env[0])
>>
>>
>> In forecast module, a second add is needed because the module doesnt
>> like when "location" is NULL
>>
>> In same file, i add
>>
>>
>> inst->popup = e_gadcon_popup_new(inst->gcc, _forecasts_popup_resize);
>>
>> evas = inst->popup->win->evas;
>> o = e_widget_list_add(evas, 0, 0);
>> +if ( inst->location == NULL ) {
>> + return;
>> +}
>> snprintf(buf, sizeof(buf), "%s", inst->location);
>> of = e_widget_frametable_add(evas, buf, 0);
>>
>>
>> and now, all is work :)))
>
> I've submitted a fix for these problems, please try with latest cvs.
>
> Sebastian
>
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] e17 segfault with forecast/weather module (opensolaris)
hi
sorry i'm not a developer then i dont have patch
each time i load this module (forecast and weather), e17 segfault on this line :
e_mod_main.c :
snprintf(env, sizeof(env), "%s", getenv("http_proxy"));
it's because getenv('http_proxy') return NULL value
than i add 3 lines :
char *p;
int port = 0;
+ if ( getenv("http_proxy") == NULL ) {
+ return;
+ }
snprintf(env, sizeof(env), "%s", getenv("http_proxy"));
if (!env[0])
In forecast module, a second add is needed because the module doesnt
like when "location" is NULL
In same file, i add
inst->popup = e_gadcon_popup_new(inst->gcc, _forecasts_popup_resize);
evas = inst->popup->win->evas;
o = e_widget_list_add(evas, 0, 0);
+if ( inst->location == NULL ) {
+ return;
+}
snprintf(buf, sizeof(buf), "%s", inst->location);
of = e_widget_frametable_add(evas, buf, 0);
and now, all is work :)))
++
Fred
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] e17 : segmentation fault when forecast or weather module are loading
hi
i run e17 on nevada 91 and it's work very well
I have only one problem. When i try to loa forecast module or weather
module, e17 segfault
does someone have same problem ?
thanks
578:stat("/home/doof/.e/e/modules/forecasts/solaris2.11-i386/module.so",
0xFD7FFFDB9C60) Err#2 ENOENT
578:
stat("/opt/e17/lib/enlightenment/modules/forecasts/solaris2.11-i386/module.so",
0xFD7FFFDB9C60) = 0
578:
stat("/opt/e17/lib/enlightenment/modules/forecasts/solaris2.11-i386/module.so",
0xFD7FFFDB96D0) = 0
578:
resolvepath("/opt/e17/lib/enlightenment/modules/forecasts/solaris2.11-i386/module.so",
"/opt/e17/lib/enlightenment/modules/forecasts/solaris2.11-i386/module.so",
1023) = 71
578:
open("/opt/e17/lib/enlightenment/modules/forecasts/solaris2.11-i386/module.so",
O_RDONLY) = 93
578:mmap(0x0001, 32768, PROT_READ|PROT_EXEC,
MAP_PRIVATE|MAP_ALIGN, 93, 0) = 0xFD7FFC18
578:mmap(0x0001, 98304, PROT_NONE,
MAP_PRIVATE|MAP_NORESERVE|MAP_ANON|MAP_ALIGN, 4294967295, 0) =
0xFD7FFC16
578:mmap(0xFD7FFC16, 29288, PROT_READ|PROT_EXEC,
MAP_PRIVATE|MAP_FIXED|MAP_TEXT, 93, 0) = 0xFD7FFC16
578:mmap(0xFD7FFC177000, 2352, PROT_READ|PROT_WRITE,
MAP_PRIVATE|MAP_FIXED|MAP_INITDATA, 93, 28672) = 0xFD7FFC177000
578:munmap(0xFD7FFC168000, 61440) = 0
578:mmap(0x, 4096, PROT_READ|PROT_WRITE|PROT_EXEC,
MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFD7FFD4C
578:memcntl(0xFD7FFC16, 13344, MC_ADVISE, MADV_WILLNEED, 0, 0) = 0
578:close(93) = 0
578:munmap(0xFD7FFC18, 32768) = 0
578:open("/home/doof/.e/e/config/default/module.forecasts.cfg",
O_RDONLY) = 93
578:fstat(93, 0xFD7FFFDBA330) = 0
578:fcntl(93, F_SETFD, 0x0001) = 0
578:mmap(0x, 202, PROT_READ, MAP_SHARED, 93, 0) = 0xFD7FFC18
578:fstat(2, 0xFD7FFFDB8FA0)= 0
578:write(2, 0xFD7FFEEBF248, 20)= 20
578: E E T f i l e f o r m a t o f '
578:write(2, 0x010D2EC0, 51)= 51
578: / h o m e / d o o f / . e / e / c o n f i g / d e f a u l t / m
578: o d u l e . f o r e c a s t s . c f g
578:write(2, 0xFD7FFEEBF25E, 109) = 109
578: ' i s d e p r e c a t e d . Y o u s h o u l d j u s t
578: o p e n i t o n e t i m e w i t h m o d e = = E
578: E T _ F I L E _ M O D E _ R E A D _ W R I T E t o s o l v e
578: t h i s i s s u e .\n
578:Incurred fault #6, FLTBOUNDS %pc = 0xFD7FFEAE2AE0
578: siginfo: SIGSEGV SEGV_MAPERR addr=0x
578:Received signal #11, SIGSEGV [caught]
578: siginfo: SIGSEGV SEGV_MAPERR addr=0x
578:lwp_sigmask(SIG_SETMASK, 0x, 0x) = 0xFFBFFEFF
[0x]
578:write(2, 0x0050FCB2, 29)= 29
578: * * * * S E G M E N T A T I O N F A U L T * * * *\n
578:write(3, 0x005338B0, 24)= 24
578: 1B0302\0\0\0\0\0 \b02\0\0\0\0\0 %\001\0 +\001\0
578:read(3, 0xFD7FFFDB9BA0, 32) = 32
578: 0101AA Z\0\0\0\0E5\bA0\0\0\0\0\0808E82\0\0\0\0\0\0\0\0\0\0\0\0\0
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
