Re: [E-devel] [EGIT] [core/efl] master 01/01: Ok, This actually fixes maximized state properly now :) Basically, we still need to account for frame height, but not frame width when we are maximizing.
On 10/31/2013 11:27 PM, Rafael Antognolli wrote:
On Thu, Oct 31, 2013 at 3:22 PM, Chris Michael cp.mich...@samsung.com wrote:
devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=20f6676eb6ed0020c07272c9f59a20faf6ff651c
commit 20f6676eb6ed0020c07272c9f59a20faf6ff651c
Author: Chris Michael cp.mich...@samsung.com
Date: Thu Oct 31 17:21:33 2013 +
Ok, This actually fixes maximized state properly now :) Basically, we
still need to account for frame height, but not frame width when we
are maximizing.
Wait, this is not true! It only makes sense with the current
elementary theme, but it shouldn't work with a theme where we do have
borders on left and right, not only top and bottom.
BTW, what are you trying to fix here? Yesterday I pushed commits to
both efl and elementary that are fixing maximize/unmaximize already.
Is there still any problem that I didn't notice? Without your commits
to efl and elementary, everything was working fine already for me...
Ok. If you say it's fixed. I reverted these commits. Now to look into
why it does not work properly here then...
Cheers,
dh
Signed-off-by: Chris Michael cp.mich...@samsung.com
---
src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c | 7
---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
index 7d3d444..4b99563 100644
--- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
+++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
@@ -224,19 +224,20 @@ _ecore_evas_wl_common_cb_window_configure(void *data
EINA_UNUSED, int type EINA_
nw = ev-w;
nh = ev-h;
- if ((!ee-prop.maximized) (!ee-prop.fullscreen))
+
+ if (!ee-prop.fullscreen)
{
int fw = 0, fh = 0;
evas_output_framespace_get(ee-evas, NULL, NULL, fw, fh);
if ((ee-rotation == 90) || (ee-rotation == 270))
{
- nw = ev-w - fh;
+ if (!ee-prop.maximized) nw = ev-w - fh;
nh = ev-h - fw;
}
else
{
- nw = ev-w - fw;
+ if (!ee-prop.maximized) nw = ev-w - fw;
nh = ev-h - fh;
}
}
--
--
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: Ok, This actually fixes maximized state properly now :) Basically, we still need to account for frame height, but not frame width when we are maximizing.
On Thu, Oct 31, 2013 at 3:22 PM, Chris Michael cp.mich...@samsung.com wrote:
devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=20f6676eb6ed0020c07272c9f59a20faf6ff651c
commit 20f6676eb6ed0020c07272c9f59a20faf6ff651c
Author: Chris Michael cp.mich...@samsung.com
Date: Thu Oct 31 17:21:33 2013 +
Ok, This actually fixes maximized state properly now :) Basically, we
still need to account for frame height, but not frame width when we
are maximizing.
Wait, this is not true! It only makes sense with the current
elementary theme, but it shouldn't work with a theme where we do have
borders on left and right, not only top and bottom.
BTW, what are you trying to fix here? Yesterday I pushed commits to
both efl and elementary that are fixing maximize/unmaximize already.
Is there still any problem that I didn't notice? Without your commits
to efl and elementary, everything was working fine already for me...
Signed-off-by: Chris Michael cp.mich...@samsung.com
---
src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c | 7
---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
index 7d3d444..4b99563 100644
--- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
+++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
@@ -224,19 +224,20 @@ _ecore_evas_wl_common_cb_window_configure(void *data
EINA_UNUSED, int type EINA_
nw = ev-w;
nh = ev-h;
- if ((!ee-prop.maximized) (!ee-prop.fullscreen))
+
+ if (!ee-prop.fullscreen)
{
int fw = 0, fh = 0;
evas_output_framespace_get(ee-evas, NULL, NULL, fw, fh);
if ((ee-rotation == 90) || (ee-rotation == 270))
{
- nw = ev-w - fh;
+ if (!ee-prop.maximized) nw = ev-w - fh;
nh = ev-h - fw;
}
else
{
- nw = ev-w - fw;
+ if (!ee-prop.maximized) nw = ev-w - fw;
nh = ev-h - fh;
}
}
--
--
Rafael Antognolli
--
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
